{"id":2230537,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230537/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-5-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-5-be96757428d0@redhat.com>","date":"2026-04-29T21:02:38","name":"[v3,05/26] ui/dbus: expose vc encoding via D-Bus Chardev.VCEncoding interface","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b76acd7807d7dfe7899f42b6a7fc6dd33d70c314","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-5-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230537/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230537/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hmXOw+3I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VCm62J3z1yGq\n\tfor ; Thu, 30 Apr 2026 07:04:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC4S-0003Wq-Jj; Wed, 29 Apr 2026 17:03:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4R-0003Wg-DJ\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:47 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4P-0003FE-R0\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:47 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-RZi9exQ6OrSDEYfSLEEtnw-1; Wed,\n 29 Apr 2026 17:03:43 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B113A180049F\n for ; Wed, 29 Apr 2026 21:03:42 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4E2B019560AB; Wed, 29 Apr 2026 21:03:40 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496625;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=14U39x3hKFcnEg9txnoTC7C763WGgzRgszbuzkY7lcQ=;\n b=hmXOw+3I0xGo8syRB+WjBI1qwTFQgYIQ4JlOm27NkGR2ZPLgyEXo080ooBVKPKzkWBTILX\n 2JuVGT5QiwLJ1AWpyRGnBNNTQsNziv5eVSVZKZ6dLtY9UIGqmyGZ3PgtiPdHLnDlVV7Wtr\n wUnfTk3xSHaEck5rh+/amENCy23r+/8=","X-MC-Unique":"RZi9exQ6OrSDEYfSLEEtnw-1","X-Mimecast-MFC-AGG-ID":"RZi9exQ6OrSDEYfSLEEtnw_1777496622","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:38 +0400","Subject":"[PATCH v3 05/26] ui/dbus: expose vc encoding via D-Bus\n Chardev.VCEncoding interface","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-5-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3680;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=4EvqtYupk8nS0o0eXyT42yY2zQZ9lVjuqZl5ryTPKwI=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nILijNBE/833XnKNw7MvHsLUq0h7LpZJLgqK\n YrSrO/KUX6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyCwAKCRDa6OEJdZac\n 5dMXEAC36VxpStOMXAtCIhW2AWL3KO4CNfOx1GQYAfVvXvTgsPX7KDQL8EKglUznZW4Z4A2ykjw\n i4Vt8ajHAnhwtNu4JHhg8AHdHV/51OXgiQGawCmy+I4mvxe+E2rSy0t2VtwtZpyqyka3o5MVgLS\n kuitP6hskqeo3N99pD+k9J3HotONnWdut2xORLKGCelDvsjzi+tokJDlpO3ku1S5c+6mXu4vFWt\n /60aDF1+Edv/hGSOSYs/+w+Mwxaq10gq4PhrA/CoqlVpuevkskcCQoW6JLPHomhLCitSs5xY7Lc\n f8HY1uqmsBNF+Yf6QoHcvpyXoe79aiMV+sjPcOlmL1jIyoUTduZSAXXdcfAbJyq43qwoGa6gAhQ\n pyyCF0uBim9cw/r5IY1kSiBaMqvxZKPQIB659uovbaZ0cGco/UiNvRkDRDDA1XlEZekTJJT1kh+\n SMTsZ2f9XOdAwubqNpnrU5/QUhDPiZz4IDmEnDaEMua8suViMxav89CdG5MNZxRbDhjZmrr+u9X\n q9y9ufOt3KB6I5kUi2XlA12aMuOwqt5USQYUsA5Z1u3dc6s3VyzOoPpSccmwq8sQia0EdFVK90O\n KivZ6I2SCUIfedq5PSYZyFhezCZwBiZoKr7NJPV5XZLKIYftmNURpYg75e3ds34xnkEn/AZb2qe\n oJtDNinP0p44DnA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When a D-Bus VC chardev is instantiated, export an extra\norg.qemu.Display1.Chardev.VCEncoding interface on the chardev\nobject. This lets D-Bus display clients discover the encoding\n(cp437 or utf8) in use by the virtual console.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/dbus.h | 1 +\n ui/dbus-chardev.c | 10 ++++++++++\n ui/dbus.c | 6 ++++++\n ui/dbus-display1.xml | 18 ++++++++++++++++++\n 4 files changed, 35 insertions(+)","diff":"diff --git a/ui/dbus.h b/ui/dbus.h\nindex 986d7774601..e4e78590b49 100644\n--- a/ui/dbus.h\n+++ b/ui/dbus.h\n@@ -126,6 +126,7 @@ typedef struct DBusChardev {\n \n bool exported;\n QemuDBusDisplay1Chardev *iface;\n+ QemuDBusDisplay1ChardevVCEncoding *iface_vc_encoding;\n } DBusChardev;\n \n DECLARE_INSTANCE_CHECKER(DBusChardev, DBUS_CHARDEV, TYPE_CHARDEV_DBUS)\ndiff --git a/ui/dbus-chardev.c b/ui/dbus-chardev.c\nindex 9442b475517..55117029acc 100644\n--- a/ui/dbus-chardev.c\n+++ b/ui/dbus-chardev.c\n@@ -53,6 +53,15 @@ dbus_display_chardev_export(DBusDisplay *dpy, DBusChardev *chr)\n sk = g_dbus_object_skeleton_new(path);\n g_dbus_object_skeleton_add_interface(\n sk, G_DBUS_INTERFACE_SKELETON(chr->iface));\n+ if (chr->iface_vc_encoding) {\n+ const char *interfaces[] = {\n+ \"org.qemu.Display1.Chardev.VCEncoding\",\n+ NULL\n+ };\n+ g_dbus_object_skeleton_add_interface(\n+ sk, G_DBUS_INTERFACE_SKELETON(chr->iface_vc_encoding));\n+ g_object_set(chr->iface, \"interfaces\", interfaces, NULL);\n+ }\n g_dbus_object_manager_server_export(dpy->server, sk);\n chr->exported = true;\n }\n@@ -290,6 +299,7 @@ char_dbus_finalize(Object *obj)\n };\n \n dbus_display_notify(&event);\n+ g_clear_object(&dc->iface_vc_encoding);\n g_clear_object(&dc->iface);\n }\n \ndiff --git a/ui/dbus.c b/ui/dbus.c\nindex 59b73e0aa94..e02a94df2f3 100644\n--- a/ui/dbus.c\n+++ b/ui/dbus.c\n@@ -514,6 +514,7 @@ CHARDEV_VC_ENCODING_PROPERTY_DEFINE(DBUS_VC_CHARDEV)\n static bool\n dbus_vc_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n {\n+ DBusChardev *dc = DBUS_CHARDEV(chr);\n DBusVCChardev *vc = DBUS_VC_CHARDEV(chr);\n ChardevClass *parent =\n CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_DBUS));\n@@ -522,6 +523,11 @@ dbus_vc_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n if (be->has_encoding) {\n vc->encoding = be->encoding;\n }\n+ dc->iface_vc_encoding =\n+ qemu_dbus_display1_chardev_vcencoding_skeleton_new();\n+ qemu_dbus_display1_chardev_vcencoding_set_encoding(\n+ dc->iface_vc_encoding,\n+ qapi_enum_lookup(&ChardevVCEncoding_lookup, vc->encoding));\n \n return parent->chr_open(chr, backend, errp);\n }\ndiff --git a/ui/dbus-display1.xml b/ui/dbus-display1.xml\nindex 4a41a7e0f34..d96bae2ed64 100644\n--- a/ui/dbus-display1.xml\n+++ b/ui/dbus-display1.xml\n@@ -1141,4 +1141,22 @@\n -->\n \n \n+\n+ \n+ \n+ \n+ \n+ \n \n","prefixes":["v3","05/26"]}