{"id":2230531,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230531/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429204128.2865817-1-boolli@google.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429204128.2865817-1-boolli@google.com>","date":"2026-04-29T20:41:28","name":"[iwl-next,v3] libie: log more info when virtchnl fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f6312b75efedfaacb3e2510bec58c5fb7410cc9d","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/1.1/people/92373/?format=json","name":"Li Li","email":"boolli@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429204128.2865817-1-boolli@google.com/mbox/","series":[{"id":502148,"url":"http://patchwork.ozlabs.org/api/1.1/series/502148/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502148","date":"2026-04-29T20:41:28","name":"[iwl-next,v3] libie: log more info when virtchnl fails","version":3,"mbox":"http://patchwork.ozlabs.org/series/502148/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230531/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230531/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Bf5uxq1u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Tjs1nKwz1yKJ\n\tfor ; Thu, 30 Apr 2026 06:41:37 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9E68484577;\n\tWed, 29 Apr 2026 20:41:35 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lGNcc7Okrr2O; Wed, 29 Apr 2026 20:41:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id CED9B84436;\n\tWed, 29 Apr 2026 20:41:34 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id B4C9018E\n for ; Wed, 29 Apr 2026 20:41:33 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 9A8E242622\n for ; Wed, 29 Apr 2026 20:41:33 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ftjwbvQTFe-1 for ;\n Wed, 29 Apr 2026 20:41:33 +0000 (UTC)","from mail-dy1-x1349.google.com (mail-dy1-x1349.google.com\n [IPv6:2607:f8b0:4864:20::1349])\n by smtp4.osuosl.org (Postfix) with ESMTPS id ED7BD42615\n for ; Wed, 29 Apr 2026 20:41:32 +0000 (UTC)","by mail-dy1-x1349.google.com with SMTP id\n 5a478bee46e88-2d93379001eso974335eec.1\n for ; Wed, 29 Apr 2026 13:41:32 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org CED9B84436","OpenDKIM Filter v2.11.0 smtp4.osuosl.org ED7BD42615"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777495294;\n\tbh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=Bf5uxq1udLQzjWoqZyb0BIAxQBxcfvAjhdBbJzRd6ffeiWsZFr3Z8MJH64DDEMXwL\n\t OMa2KUEaQlHhqCcY9hAcRiX4X6oxgV5slqF+nCXevaUHq7wDzbQCxcJyLHRszREeNt\n\t DZ5NzxnXfV+ytjebIuSwozwUeqed/qwuXfVv8t4ty3t6n8A0L5v3x/Z06e1luuYCSf\n\t VX0FaEwamgoQTL+tSQUrsDvfaAzp96bC1dpSRX31cGeSGQtzQYeMRiCiFEScT+w6M4\n\t mnMSG5B/81wOBIhITrhmVFPMGbBJBYYZnuXDro19Q+wzr4T9m39btlEeE4krP0z5xK\n\t nHbK3I4xfYorA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com;\n envelope-from=3-2zyaqykd_qxkkhheckkcha.ykiejpah-senaz-hwjheopo.koqkoh.knc@flex--boolli.bounces.google.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org ED7BD42615","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777495292; x=1778100092;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=;\n b=NnQdsqjVw43t8hCkLTW37gav+giLGULJgrda1z80x8atp0m3F3FxbTob8aLvkS5W4U\n tdB+g+LbA4nhwZsxBK8kN8ZiI403gHj450h/ySn6vuWWXIPyVF4cKbtPAxxS8/ooQoKy\n qJUdCfwnROdei61l8YqV2SFpvdLbQES06rBywgNewUNYnEcgv6Wq38baOJ/koTnk7hEK\n jh9rvojPwK2UjYde7N7Uef5gYpTqJeffKU6LvA5wtsItXsyQnibBJmwKe3EmUhyhQuRM\n i6ihKTqkx/4pNyNCGQQPPZXSMe+AwRPs90/vyyFzeFQzdGqC+yMN2Pl+5lwIwTVpMs75\n pkBQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8/ypRD/vNDZ+Q7KMkg7JjlX4LTcfPYb/sSv5lrORoylYiXW7MUHZvUNF0v0DWTpMa5ahoWvfSawkZ0uTkio/U=@lists.osuosl.org","X-Gm-Message-State":"AOJu0Yxli4eXtoVWc5ikBs+3h2OhXHL/ZrDQdq8gZ75U6GOoc+JfQB3t\n S+DT03C9I4csF+QdByfWjUrjZm3jryDpRSg2DVE6yYYhgmpzU1dOEMxNHuTtyrV7h/KbIoFccpv\n Zi6EeKw==","X-Received":"from dycmd10.prod.google.com\n ([2002:a05:693c:23ca:b0:2dd:7012:2d3b])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7300:dc93:b0:2cb:8d2f:e247\n with SMTP id 5a478bee46e88-2ed0a099154mr4072247eec.13.1777495291613; Wed, 29\n Apr 2026 13:41:31 -0700 (PDT)","Date":"Wed, 29 Apr 2026 20:41:28 +0000","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.545.g6539524ca2-goog","Message-ID":"<20260429204128.2865817-1-boolli@google.com>","To":"Tony Nguyen ,\n Przemek Kitszel ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny ,\n Anjali Singhai ,\n Sridhar Samudrala ,\n Brian Vazquez ,\n Li Li , emil.s.tantilov@intel.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777495292; x=1778100092; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=Dombmj9ny0RyT7dLXRXjIRy7HfDUGhjx5FcWbglB77o=;\n b=aUjB3wq9C3B5olyvGeuL99eQsSG67vwQ9Onop5JXwXoCRlQ2TL1ZvUEDvOzaQ7+9fN\n CCYv9t49Je1qYOiTP6TUUUmWuLEZRqynXrEbMDv3zJtrmKG5fGaTizPtPM/f4UZGJAT7\n cxLIt3PjQjVdiE5jvcgaC8cCeF4aq094xw6WiY8OmEwiiTSRwcc6V4/b1RRf+j174Xts\n YVJjT/iNzQq761CniEyQyADtFvajlDUkNkziYhabcMC2OFDZTuGP2DFOYLchW7rUikPj\n 6a0r0p4MCzsjFKekPzJcEABbBUKs668X6AdDHnQogVvfGJGFPjYA1kWC3diHCGnLGfEq\n eZXA==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=aUjB3wq9"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Virtchnl failures can be hard to debug without logs. Logging the details\nof virtchnl transactions can be useful for debugging virtchnl-related\nissues.\n\nTested: Built & booted on a test machine and synthetically produced a\nvirtual failure to produce the following log:\n\nidpf 0000:01:00.0: Non-zero virtchnl ret val (msg op: 1, ret val: 6,\ndata_len: 8); xn id: 0, cookie: 0\nidpf 0000:01:00.0: Transaction failed (op 1, xn state:\n3, id: 0, cookie: 0, size: 8)\n\nSigned-off-by: Li Li \n---\nv3:\n - Use dev_err_ratelimited in both logs.\n - Move log placement to after virtchnl field validation.\n - Remove redundant op/cookie fields since they were validated.\nv2:\n - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on\n reviewer feedback.\n\n drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c\nindex ebc05355e39d..ceca8a076d79 100644\n--- a/drivers/net/ethernet/intel/libie/controlq.c\n+++ b/drivers/net/ethernet/intel/libie/controlq.c\n@@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params,\n \t msg_cookie != xn->cookie)\n \t\treturn false;\n \n+\tif (ctlq_msg->chnl_retval) {\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Non-zero virtchnl ret val (msg op: %u, ret val: %u, data_len: %u); xn id: %u, cookie: %u\\n\",\n+\t\t\tctlq_msg->chnl_opcode, ctlq_msg->chnl_retval,\n+\t\t\tctlq_msg->data_len, xn->index, xn->cookie);\n+\t}\n+\n \tspin_lock(&xn->xn_lock);\n \tif (xn->state != LIBIE_CTLQ_XN_ASYNC &&\n \t xn->state != LIBIE_CTLQ_XN_WAITING) {\n@@ -1011,6 +1019,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n \t\tparams->recv_mem = xn->recv_mem;\n \t\tbreak;\n \tdefault:\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\\n\",\n+\t\t\tparams->chnl_opcode, xn->state, xn->index, xn->cookie,\n+\t\t\txn->recv_mem.iov_len);\n \t\tret = -EBADMSG;\n \t\tbreak;\n \t}\n","prefixes":["iwl-next","v3"]}