{"id":2230482,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230482/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429190550.20122-4-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429190550.20122-4-farosas@suse.de>","date":"2026-04-29T19:05:48","name":"[v1,3/5] tests/qtest/dbus-vmstate: Honor QTEST_LOG env variable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1f428fc3a8899cf4bf0188e44f57378c3f0dcf1e","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.1/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429190550.20122-4-farosas@suse.de/mbox/","series":[{"id":502137,"url":"http://patchwork.ozlabs.org/api/1.1/series/502137/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502137","date":"2026-04-29T19:05:45","name":"tests/qtest: Re-enable dbus-vmstate","version":1,"mbox":"http://patchwork.ozlabs.org/series/502137/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230482/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230482/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wXD1NvKK;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=rpjVOoXp;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=wXD1NvKK;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=rpjVOoXp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5RdG3lPrz1xqf\n\tfor ; Thu, 30 Apr 2026 05:07:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIAEf-0001wc-Tb; Wed, 29 Apr 2026 15:06:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wIAEf-0001uN-23\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:13 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wIAEc-0000Rs-Ru\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:12 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id D65926A81C;\n Wed, 29 Apr 2026 19:05:58 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7D44B593B0;\n Wed, 29 Apr 2026 19:05:57 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 8NEgE5VW8mm/eQAAD6G6ig\n (envelope-from ); Wed, 29 Apr 2026 19:05:57 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777489558;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=;\n b=wXD1NvKKOa6nwk1FEdsR9VXb4sxy95k2w4iBSh4ox6N5vaOVvOZfusKXe8dzon42pmTCeJ\n QTPTonDhclVFyKJNUHXAqWMQzXqNUAzp2dZDsRJu9Kp0w45zjDSkRnTguICavHHRImGpno\n ncY0MgVXr99jaS6+to0sGa+a6oWNGsw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777489558;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=;\n b=rpjVOoXpYhgqDWOru3XggElXVsaR3Kn+FpIGjy1XQDZPHECKi60i8sr+jn+hhKHFvzTD/L\n QBvQNVpJUQhASeBg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777489558;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=;\n b=wXD1NvKKOa6nwk1FEdsR9VXb4sxy95k2w4iBSh4ox6N5vaOVvOZfusKXe8dzon42pmTCeJ\n QTPTonDhclVFyKJNUHXAqWMQzXqNUAzp2dZDsRJu9Kp0w45zjDSkRnTguICavHHRImGpno\n ncY0MgVXr99jaS6+to0sGa+a6oWNGsw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777489558;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=;\n b=rpjVOoXpYhgqDWOru3XggElXVsaR3Kn+FpIGjy1XQDZPHECKi60i8sr+jn+hhKHFvzTD/L\n QBvQNVpJUQhASeBg=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , marcandre.lureau@redhat.com,\n Laurent Vivier , Paolo Bonzini ","Subject":"[PATCH v1 3/5] tests/qtest/dbus-vmstate: Honor QTEST_LOG env variable","Date":"Wed, 29 Apr 2026 16:05:48 -0300","Message-ID":"<20260429190550.20122-4-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260429190550.20122-1-farosas@suse.de>","References":"<20260429190550.20122-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]","X-Spam-Score":"-2.80","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Don't hide QEMU error messages unconditionally, make the tests that\nexpect to fail honor QTEST_LOG and show every output if the variable\nis set.\n\nSigned-off-by: Fabiano Rosas \n---\n tests/qtest/dbus-vmstate-test.c | 28 +++++++++++++++-------------\n 1 file changed, 15 insertions(+), 13 deletions(-)","diff":"diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-test.c\nindex 51c5fdb995..05e598a3e3 100644\n--- a/tests/qtest/dbus-vmstate-test.c\n+++ b/tests/qtest/dbus-vmstate-test.c\n@@ -324,17 +324,18 @@ test_dbus_vmstate_missing_src(char *name, MigrateCommon *args)\n {\n Test test = { .id_list = \"idA,idC\",\n .result = MIG_TEST_FAIL };\n+ bool silent = !getenv(\"QTEST_LOG\");\n \n /* run in subprocess to silence QEMU error reporting */\n- if (g_test_subprocess()) {\n- test_dbus_vmstate(&test);\n- check_not_migrated(&test.srcA, &test.dstA);\n- check_not_migrated(&test.srcB, &test.dstB);\n+ if (silent && !g_test_subprocess()) {\n+ g_test_trap_subprocess(NULL, 0, 0);\n+ g_test_trap_assert_passed();\n return;\n }\n \n- g_test_trap_subprocess(NULL, 0, 0);\n- g_test_trap_assert_passed();\n+ test_dbus_vmstate(&test);\n+ check_not_migrated(&test.srcA, &test.dstA);\n+ check_not_migrated(&test.srcB, &test.dstB);\n }\n \n static void\n@@ -343,18 +344,19 @@ test_dbus_vmstate_missing_dst(char *name, MigrateCommon *args)\n Test test = { .id_list = \"idA,idB\",\n .without_dst_b = true,\n .result = MIG_TEST_FAIL };\n+ bool silent = !getenv(\"QTEST_LOG\");\n \n /* run in subprocess to silence QEMU error reporting */\n- if (g_test_subprocess()) {\n- test_dbus_vmstate(&test);\n- assert(test.srcA.save_called);\n- assert(test.srcB.save_called);\n- assert(!test.dstB.save_called);\n+ if (silent && !g_test_subprocess()) {\n+ g_test_trap_subprocess(NULL, 0, 0);\n+ g_test_trap_assert_passed();\n return;\n }\n \n- g_test_trap_subprocess(NULL, 0, 0);\n- g_test_trap_assert_passed();\n+ test_dbus_vmstate(&test);\n+ assert(test.srcA.save_called);\n+ assert(test.srcB.save_called);\n+ assert(!test.dstB.save_called);\n }\n \n static void log_func(const gchar *log_domain, GLogLevelFlags log_level,\n","prefixes":["v1","3/5"]}