{"id":2230465,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230465/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429183310.12455-12-harshpb@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429183310.12455-12-harshpb@linux.ibm.com>","date":"2026-04-29T18:33:01","name":"[PULL,11/13] hw/ssi/pnv_spi: Fix fifo8 memory leak on unrealize","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"950b6883aaf14b07a33b311070a5691256c1e9f9","submitter":{"id":85411,"url":"http://patchwork.ozlabs.org/api/1.1/people/85411/?format=json","name":"Harsh Prateek Bora","email":"harshpb@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429183310.12455-12-harshpb@linux.ibm.com/mbox/","series":[{"id":502132,"url":"http://patchwork.ozlabs.org/api/1.1/series/502132/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502132","date":"2026-04-29T18:32:53","name":"[PULL,01/13] ppc/pnv: Move SBE host doorbell function to top of file","version":1,"mbox":"http://patchwork.ozlabs.org/series/502132/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230465/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230465/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=IUw37U7H;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Qvb2LG2z1yHX\n\tfor ; Thu, 30 Apr 2026 04:34:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI9jh-0007v3-0F; Wed, 29 Apr 2026 14:34:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI9jc-0007nV-OX\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 14:34:09 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI9jX-0007DA-Vc\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 14:34:05 -0400","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63TIEAbb1973593\n for ; Wed, 29 Apr 2026 18:34:02 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn44v6bu-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 29 Apr 2026 18:34:02 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63TINoNr014447;\n Wed, 29 Apr 2026 18:34:01 GMT","from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ds7xqfqhw-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 29 Apr 2026 18:34:01 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63TIXvnM9044252\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 29 Apr 2026 18:33:57 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id BCB122004E;\n Wed, 29 Apr 2026 18:33:57 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 5462F20049;\n Wed, 29 Apr 2026 18:33:55 +0000 (GMT)","from localhost.localdomain (unknown [9.39.31.77])\n by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Wed, 29 Apr 2026 18:33:55 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=u7PmL0DPcJ17q5P43\n x3UH4AeWo6hO13Jc83RjVZt+nw=; b=IUw37U7HrRoEiRGd2usAjA6B8/p7pcK4u\n pjWAU0TdoP6+Qgc1k350HfnDpCRhfebj1xOkQGU5lqjPH50ALKrsZ8KeBCDn0ogu\n XO/SNEP0ArapeE7lNW4eJeRxJ97Qag0kH8tiM8iJkP1BcOAy4HEpSra+61LvOxI+\n F+hYpHz0Tj4E+/DFwMn6lgafGYAsvrvsKrkCUEJSvos9BI4FipjE+75sCKS5qTm0\n /9B8TFexy2qNMhFKLmaIuZAJ+98ytsu3D9uoVvI1s+FulDGYYOrdU+ZUuNGZILX0\n cBYuqUbkXn/BGGwpP3t46onb52gkgM0LBRA4muCiGw/6po3BWJGaw==","From":"Harsh Prateek Bora ","To":"qemu-devel@nongnu.org","Cc":"Caleb Schlossin ,\n Glenn Miles ,\n Chalapathi V ,\n Nicholas Piggin , Aditya Gupta ","Subject":"[PULL 11/13] hw/ssi/pnv_spi: Fix fifo8 memory leak on unrealize","Date":"Thu, 30 Apr 2026 00:03:01 +0530","Message-ID":"<20260429183310.12455-12-harshpb@linux.ibm.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260429183310.12455-1-harshpb@linux.ibm.com>","References":"<20260429183310.12455-1-harshpb@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"8Q9JkKSUSbrqcTLN2mOpMN4fl0vDN_yX","X-Authority-Analysis":"v=2.4 cv=Ft81OWrq c=1 sm=1 tr=0 ts=69f24f1a cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=A5OVakUREuEA:10 a=f7IdgyKtn90A:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=Q8LBFeAF4jmk_nWGM1UA:9","X-Proofpoint-GUID":"d5FiGD7l7op7p0b5R2XAmyJ5zz5ttHLN","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDE4NCBTYWx0ZWRfX/MZCVJciYxTe\n 0TSliaqY/lkfIsYEBgFRLf8CbNhA+pAmAdTSIkCMoJWz/HBBNatoflyXXr6WYgWo1i1BEeNn5eZ\n ezmPK2oP3Tl2RrT9NSMzw81I0wR5GnPUF5wq87mISb7kDuH1KPn2HSy7aOqt3H1NYrMffBZBkrZ\n stfUqopXaMWgk2KXA65eV37p3Og+TUjS7OB9NYC5cfpBp79tQKGianXTVpmvUk4Guqcq525MxCi\n bWuX+vDi5k2W24hu2RhlZc5RAJGK8QueJmHU/B64clqR4lTjNCxhtIhmKXzLmol2u47bLHU8bvd\n WEi8JA3SDLDfFG7t/MItPko9mLQQ8M4Y+jo8PpdwQMxq7WoFmGlcclWK5Y1C7kuu+OQtlM17CK7\n GlhSyBVMQJM78kUJffNKwXu/EkIYCVtQ/HOd9rDOGgynx8q+uQVdma8FPonCuVsMpK7NVfkrR7c\n gV7O0X5Njp+y7qKWHNw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-29_01,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0\n clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290184","Received-SPF":"pass client-ip=148.163.156.1;\n envelope-from=harshpb@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Caleb Schlossin \n\nunrealize should free the fifo8 memory that was allocated by realize.\n\nFixes: 17befecda85 (\"hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure\")\n\nReviewed-by: Glenn Miles \nReviewed-by: Chalapathi V \nSigned-off-by: Nicholas Piggin \nSigned-off-by: Caleb Schlossin \nReviewed-by: Aditya Gupta \nLink: https://lore.kernel.org/qemu-devel/20260120145117.602960-1-calebs@linux.ibm.com\nSigned-off-by: Harsh Prateek Bora \n---\n hw/ssi/pnv_spi.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c\nindex 76304d26fc..f3add8cab9 100644\n--- a/hw/ssi/pnv_spi.c\n+++ b/hw/ssi/pnv_spi.c\n@@ -1177,6 +1177,13 @@ static void pnv_spi_realize(DeviceState *dev, Error **errp)\n s, \"xscom-spi\", PNV10_XSCOM_PIB_SPIC_SIZE);\n }\n \n+static void pnv_spi_unrealize(DeviceState *dev)\n+{\n+ PnvSpi *s = PNV_SPI(dev);\n+ fifo8_destroy(&s->tx_fifo);\n+ fifo8_destroy(&s->rx_fifo);\n+}\n+\n static int pnv_spi_dt_xscom(PnvXScomInterface *dev, void *fdt,\n int offset)\n {\n@@ -1234,6 +1241,7 @@ static void pnv_spi_class_init(ObjectClass *klass, const void *data)\n \n dc->desc = \"PowerNV SPI\";\n dc->realize = pnv_spi_realize;\n+ dc->unrealize = pnv_spi_unrealize;\n device_class_set_legacy_reset(dc, do_reset);\n dc->vmsd = &pnv_spi_vmstate;\n device_class_set_props(dc, pnv_spi_properties);\n","prefixes":["PULL","11/13"]}