{"id":2230384,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230384/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260429-winbond-v6-18-rc1-cont-read-v3-3-0f38b3c229ad@bootlin.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.1/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260429-winbond-v6-18-rc1-cont-read-v3-3-0f38b3c229ad@bootlin.com>","date":"2026-04-29T17:56:40","name":"[v3,03/11] mtd: spinand: Drop ECC dirmaps","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec11c91b6c80593451864b470500c9b5cdba227c","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.1/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20260429-winbond-v6-18-rc1-cont-read-v3-3-0f38b3c229ad@bootlin.com/mbox/","series":[{"id":502120,"url":"http://patchwork.ozlabs.org/api/1.1/series/502120/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=502120","date":"2026-04-29T17:56:40","name":"mtd: spinand: Winbond continuous read support","version":3,"mbox":"http://patchwork.ozlabs.org/series/502120/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230384/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230384/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ADFFiKhZ;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=uDsKwvQO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Q544TJmz1yK5\n\tfor ; Thu, 30 Apr 2026 03:57:57 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wI9AV-000000040Qt-23SI;\n\tWed, 29 Apr 2026 17:57:51 +0000","from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wI9AT-000000040NV-1RLS\n\tfor linux-mtd@lists.infradead.org;\n\tWed, 29 Apr 2026 17:57:50 +0000","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id E77054E42B6A;\n\tWed, 29 Apr 2026 17:57:47 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id BABB15FD43;\n\tWed, 29 Apr 2026 17:57:47 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id C966E1072B171;\n\tWed, 29 Apr 2026 19:57:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=wB2QUWUI+IXc3+b6/NFTNamI5VJQzvoXIBzMtFr9fQk=; b=ADFFiKhZfE3+2y\n\t3GU5LG3IvekSvQpCMZuGI9TzS3EStJL2W2M+fkUQdGxoB0BtO+cSWJDULTAoaLavxn+H4TcW7DHXd\n\tsJa3dDDfGYfNOsFBDnEETEA6Pmq29+yCJCh9IigabUB1hCqFMe+qx75N4jfK6KEKiB2rt+EuS58oA\n\tf3xqmbojxTU/ALE3FiOKFnccZ0kmpMQGuOouAGsfmXwAmLy9MDRJ1MmfsZWfiOAHPE7/GB5qExnO6\n\tydBMiA+RPX8Wb6p8PjG9qscO3OyScW9STKCPU/HPAQ/znopML7t8TjfzjYewiQauLfjTfvQ5SCAV/\n\tOOGJfEbg3nTvUawLtbQw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777485465; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=QdHHmy5KibUj7IOUfvRAtvrskjTvNN+KNx7nY11cePM=;\n\tb=uDsKwvQOEhv6WrNXDMP9ss0SW/69JMJHgvqRB8tshJUyUYKiLRCiM6vONo8b0Y8rcmqBd2\n\tBEABK7qva7LRm2ch44uFcuvG8mx9hdH2X0tMsCNHyRze3nTQMetp+I0I/QJ1rfejdggIGn\n\tX7Xzyl0AgBsSQxWeM+jW9LzsFGHgo6auF20jWVlet49Oi87WBUUHrFYCqb5wVjUTTO6+yA\n\t+bQzEtHGMLjcg6DzVm6/oVnNpjZlHFj0tm5qYGe1o5kqgg46w9Ku3um13/qpvofCq3I6Fj\n\t5YbuqF48vQSXbuDiBZE7f2ssG/IeOKERTDFuPuNGrlmT8oGKR7YlaxyAhJQT3Q=="],"From":"Miquel Raynal ","Date":"Wed, 29 Apr 2026 19:56:40 +0200","Subject":"[PATCH v3 03/11] mtd: spinand: Drop ECC dirmaps","MIME-Version":"1.0","Message-Id":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-3-0f38b3c229ad@bootlin.com>","References":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","In-Reply-To":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Michael Walle ,\n Miquel Raynal ,\n Takahiro Kuwano ,\n Lorenzo Bianconi , Ray Liu ,\n Chin-Ting Kuo , =?utf-8?q?C=C3=A9dric_Le_Goa?=\n\t=?utf-8?q?ter?= , Joel Stanley ,\n Andrew Jeffery ,\n Avi Fishman , Tomer Maimon ,\n Tali Perry , Patrick Venture ,\n Nancy Yuen , Benjamin Fair ,\n Maxime Coquelin ,\n Alexandre Torgue , =?utf-8?q?Jonathan_Neusch?=\n\t=?utf-8?q?=C3=A4fer?= ","Cc":"Pratyush Yadav ,\n Thomas Petazzoni ,\n Steam Lin , Santhosh Kumar K ,\n linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org,\n linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,\n linux-stm32@st-md-mailman.stormreply.com","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260429_105749_540566_A9A70D51 ","X-CRM114-Status":"GOOD ( 17.55 )","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Direct mappings are very static concepts, which allow us to\n reuse a template to perform reads or writes in a very efficient manner\n after\n a single initialization. With the introduction of pipelined ECC [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Direct mappings are very static concepts, which allow us to reuse a\ntemplate to perform reads or writes in a very efficient manner after a\nsingle initialization. With the introduction of pipelined ECC engines\nfor SPI controllers, the need to differentiate between an operation with\nand without correction has arised. The chosen solution at that time has\nbeen to create new direct mappings for these operations, jumping from 2\nto 4 dirmaps per target. Enabling ECC was done by choosing the correct\ndirmap.\n\nToday, we need to further parametrize dirmaps. With the goal to enable\ncontinuous reads on a wider range of devices, we will need more\nflexibility regarding the read from cache operation template to pick at\nrun time, for instance to use shorter \"continuous read from cache\"\nvariants.\n\nWe could create other direct mappings, but it would increase the matrix\nby a power of two, bringing the theoretical number of dirmaps to\n8 (read/write, ecc, shorter read variants) per target. This grow is not\nsustainable, so let's change how dirmaps work - a little bit.\n\nOperations already carry an ECC parameter, use it to indicate whether\nerror correction is required or not. In practice this change happens\nonly at the core level, SPI controller drivers do not care about the\ndirect mapping structure in this case, they just pick whatever is in the\ntemplate as a base. As a result, we allow the core to dynamically change\nthe content of the templates.\n\nHe who can do more can do less, so during the checking steps, make sure\nto enable the ECC requirement just for the time of the checks.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/core.c | 52 +++++++++++++++++----------------------------\n include/linux/mtd/spinand.h | 2 --\n 2 files changed, 20 insertions(+), 34 deletions(-)","diff":"diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c\nindex 1c3ac9ad650e..663f5d6a6bd7 100644\n--- a/drivers/mtd/nand/spi/core.c\n+++ b/drivers/mtd/nand/spi/core.c\n@@ -487,10 +487,13 @@ static int spinand_read_from_cache_op(struct spinand_device *spinand,\n \t\t}\n \t}\n \n-\tif (req->mode == MTD_OPS_RAW)\n-\t\trdesc = spinand->dirmaps[req->pos.plane].rdesc;\n+\trdesc = spinand->dirmaps[req->pos.plane].rdesc;\n+\n+\tif (nand->ecc.engine->integration == NAND_ECC_ENGINE_INTEGRATION_PIPELINED &&\n+\t req->mode != MTD_OPS_RAW)\n+\t\trdesc->info.op_tmpl.data.ecc = true;\n \telse\n-\t\trdesc = spinand->dirmaps[req->pos.plane].rdesc_ecc;\n+\t\trdesc->info.op_tmpl.data.ecc = false;\n \n \tif (spinand->flags & SPINAND_HAS_READ_PLANE_SELECT_BIT)\n \t\tcolumn |= req->pos.plane << fls(nanddev_page_size(nand));\n@@ -579,10 +582,13 @@ static int spinand_write_to_cache_op(struct spinand_device *spinand,\n \t\t\t req->ooblen);\n \t}\n \n-\tif (req->mode == MTD_OPS_RAW)\n-\t\twdesc = spinand->dirmaps[req->pos.plane].wdesc;\n+\twdesc = spinand->dirmaps[req->pos.plane].wdesc;\n+\n+\tif (nand->ecc.engine->integration == NAND_ECC_ENGINE_INTEGRATION_PIPELINED &&\n+\t req->mode != MTD_OPS_RAW)\n+\t\twdesc->info.op_tmpl.data.ecc = true;\n \telse\n-\t\twdesc = spinand->dirmaps[req->pos.plane].wdesc_ecc;\n+\t\twdesc->info.op_tmpl.data.ecc = false;\n \n \tif (spinand->flags & SPINAND_HAS_PROG_PLANE_SELECT_BIT)\n \t\tcolumn |= req->pos.plane << fls(nanddev_page_size(nand));\n@@ -1231,12 +1237,17 @@ static int spinand_create_dirmap(struct spinand_device *spinand,\n \tstruct nand_device *nand = spinand_to_nand(spinand);\n \tstruct spi_mem_dirmap_info info = { 0 };\n \tstruct spi_mem_dirmap_desc *desc;\n+\tbool enable_ecc = false;\n+\n+\tif (nand->ecc.engine->integration == NAND_ECC_ENGINE_INTEGRATION_PIPELINED)\n+\t\tenable_ecc = true;\n \n \t/* The plane number is passed in MSB just above the column address */\n \tinfo.offset = plane << fls(nand->memorg.pagesize);\n \n+\t/* Write descriptor */\n \tinfo.length = nanddev_page_size(nand) + nanddev_per_page_oobsize(nand);\n-\tinfo.op_tmpl = *spinand->op_templates->update_cache;\n+\tinfo.op_tmpl.data.ecc = enable_ecc;\n \tdesc = devm_spi_mem_dirmap_create(&spinand->spimem->spi->dev,\n \t\t\t\t\t spinand->spimem, &info);\n \tif (IS_ERR(desc))\n@@ -1244,38 +1255,15 @@ static int spinand_create_dirmap(struct spinand_device *spinand,\n \n \tspinand->dirmaps[plane].wdesc = desc;\n \n+\t/* Read descriptor */\n \tinfo.op_tmpl = *spinand->op_templates->read_cache;\n+\tinfo.op_tmpl.data.ecc = enable_ecc;\n \tdesc = spinand_create_rdesc(spinand, &info);\n \tif (IS_ERR(desc))\n \t\treturn PTR_ERR(desc);\n \n \tspinand->dirmaps[plane].rdesc = desc;\n \n-\tif (nand->ecc.engine->integration != NAND_ECC_ENGINE_INTEGRATION_PIPELINED) {\n-\t\tspinand->dirmaps[plane].wdesc_ecc = spinand->dirmaps[plane].wdesc;\n-\t\tspinand->dirmaps[plane].rdesc_ecc = spinand->dirmaps[plane].rdesc;\n-\n-\t\treturn 0;\n-\t}\n-\n-\tinfo.length = nanddev_page_size(nand) + nanddev_per_page_oobsize(nand);\n-\tinfo.op_tmpl = *spinand->op_templates->update_cache;\n-\tinfo.op_tmpl.data.ecc = true;\n-\tdesc = devm_spi_mem_dirmap_create(&spinand->spimem->spi->dev,\n-\t\t\t\t\t spinand->spimem, &info);\n-\tif (IS_ERR(desc))\n-\t\treturn PTR_ERR(desc);\n-\n-\tspinand->dirmaps[plane].wdesc_ecc = desc;\n-\n-\tinfo.op_tmpl = *spinand->op_templates->read_cache;\n-\tinfo.op_tmpl.data.ecc = true;\n-\tdesc = spinand_create_rdesc(spinand, &info);\n-\tif (IS_ERR(desc))\n-\t\treturn PTR_ERR(desc);\n-\n-\tspinand->dirmaps[plane].rdesc_ecc = desc;\n-\n \treturn 0;\n }\n \ndiff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h\nindex e1f19664bb25..896e9b5de0c4 100644\n--- a/include/linux/mtd/spinand.h\n+++ b/include/linux/mtd/spinand.h\n@@ -684,8 +684,6 @@ struct spinand_info {\n struct spinand_dirmap {\n \tstruct spi_mem_dirmap_desc *wdesc;\n \tstruct spi_mem_dirmap_desc *rdesc;\n-\tstruct spi_mem_dirmap_desc *wdesc_ecc;\n-\tstruct spi_mem_dirmap_desc *rdesc_ecc;\n };\n \n /**\n","prefixes":["v3","03/11"]}