{"id":2230305,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230305/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177747214680.4107473.11866114732768812318.stgit@frogsfrogsfrogs/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.1/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<177747214680.4107473.11866114732768812318.stgit@frogsfrogsfrogs>","date":"2026-04-29T14:54:43","name":"[08/19] fuse2fs: turn on iomap for pagecache IO","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"14b8d5743d4a2a133bd75abe20850fa615f1b778","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/1.1/people/77032/?format=json","name":"Darrick J. Wong","email":"djwong@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177747214680.4107473.11866114732768812318.stgit@frogsfrogsfrogs/mbox/","series":[{"id":502087,"url":"http://patchwork.ozlabs.org/api/1.1/series/502087/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=502087","date":"2026-04-29T14:53:09","name":"[01/19] fuse2fs: implement bare minimum iomap for file mapping reporting","version":1,"mbox":"http://patchwork.ozlabs.org/series/502087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230305/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230305/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=p8WQCGvu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=1m55=c4=vger.kernel.org=linux-ext4+bounces-16197-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=p8WQCGvu;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16197-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"p8WQCGvu\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5L2t3Y3xz1yHZ\n\tfor ; Thu, 30 Apr 2026 00:55:50 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g5L2t2klZz4wLR\n\tfor ; Thu, 30 Apr 2026 00:55:50 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g5L2t2P9pz4wM1; Thu, 30 Apr 2026 00:55:50 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g5L2p4vLZz4wLR\n\tfor ; Thu, 30 Apr 2026 00:55:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D4D12301B159\n\tfor ; Wed, 29 Apr 2026 14:54:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 066333254B8;\n\tWed, 29 Apr 2026 14:54:44 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BC63F2727FD;\n\tWed, 29 Apr 2026 14:54:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 97E65C19425;\n\tWed, 29 Apr 2026 14:54:43 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1777474550; cv=pass;\n\tb=swmv2B1m3q2eeZokqCQP4OT6NLrTjs6x/2lS0F5f9I9pPnWytC4nADCsIKm/tO7cqelprzsvaIQB+IMmzvon8R7Zci7XaUhY+vG+OhpIp1PQ9MCcR59TqjC2C2PAP1rtWCLYXrjSJXaeEsTG1YqqZCPTrrGyHjs+GA/Bww9tjaoPTWEESxllvVzPcw5osCkPEIEJ6i+XDCGxfeZ9xFHp1cgI260qn0ferOAZa+Z3jMV986WfI7M2qwcdftn3xRkTOz/+EDhVup5VpQMXvV2N8lttYHBoeuiJR1m0rW820J1+XBjcd7YyiScr4H8xI9JnYTVppDXItrNd+36iuIynGQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777474483; cv=none;\n b=BqLbaer3KWliez4LAh2I8moqSvR9BjWHFPGtaIeJLN+0IU8QVuCf8DJNnufGU4ChA3N6ahnZLeCY3jg08+ZYvqEV0DUF3ul/u8Js4sYow/hpC0n/6W+riR6JnYyG9i5Kub6I30SzrGqtkxttycyQ6nje6UgSuHLxlEkWRo/AMRA="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1777474550; c=relaxed/relaxed;\n\tbh=ariBvjNQnUZgf16Axx8aqvF9xn8uPrsQMKJBvnQr9G0=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=EpxMvbAPDpW5kWl9nQjc14SRRfk4uriPVNTovug/nzWDVW2GGeI3mJ4NwIvG7X9+5uAEqZTuNWsaRuJK04d7LRtc9Vf++WLtWtQb+sZdgwP6iZhVrwdh6a72sS05hvJLIyRawL7148Th44u915TZK/CBriwruR2+Ijoc4psm4u/CqvZa5zVb/a/NhTQ91o+upSW7CMbUMU1VKfvmnKegKkwX9erTuKnOTyIYty+gvAf/53WfIXFciXrrhELuJsIE7cpls4KrkjP0OgdBwKnzd9n2eseUu7n0Y5xRTcSSwvBye6+eqA14ooIsomBAnpzQwC4CqZkNytOY0Y+pBgYBug==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777474483; c=relaxed/simple;\n\tbh=hkNf50VWPsor680ts8cbNBQsJ+GpBIQU0jqMnkD6hCU=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=nMTieaVFkb6IvdxjDKYlwpGeiVXR/0WdpyiUfG9VIHhWSChracD+L1wkAOukTRJoxj20SBtnzzHd2/Y+hZornlrbmYqUTXtIofC65vWzmlXWc+9e5CKWKh4lt8erObeL//JJShfGHYQafC+wTf7310+5wieLXhGFXEwhEXJi0wA="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=p8WQCGvu; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16197-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=p8WQCGvu; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777474483;\n\tbh=hkNf50VWPsor680ts8cbNBQsJ+GpBIQU0jqMnkD6hCU=;\n\th=Date:Subject:From:To:Cc:In-Reply-To:References:From;\n\tb=p8WQCGvuBPirP/0Q3IimzzEKTZPew8BW27PzfBTf7Yb0LjnzIV6WbwC9At7Kql5Hu\n\t hufRu0mKpuPh2eNAhmgUUAcExWlvAefiU2RlOYkAVssdIhOGnfAVnJZYDDZm2MbFmx\n\t MXC3yMPzhLen/Oic+ESyvNx07L3pK6cnkX3A2V+0ZZBvc0yAznC94hG/jCUQrnDdcy\n\t siQwoKgBFigaiz2AGyxPegRe/O+e5HmQDAxBHamld4EDL/lSV5V9zMU+k/uXnYg1q1\n\t TKdMasWUGJxa4IOYTsKQCNf15cTEGm7bXO5W8syBBOxbNtlJq718BV3j/Icbv/X4c3\n\t Yxz6HjfV/57nQ==","Date":"Wed, 29 Apr 2026 07:54:43 -0700","Subject":"[PATCH 08/19] fuse2fs: turn on iomap for pagecache IO","From":"\"Darrick J. Wong\" ","To":"tytso@mit.edu","Cc":"bernd@bsbernd.com, miklos@szeredi.hu, linux-ext4@vger.kernel.org,\n neal@gompa.dev, linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev,\n joannelkoong@gmail.com","Message-ID":"<177747214680.4107473.11866114732768812318.stgit@frogsfrogsfrogs>","In-Reply-To":"<177747214459.4107473.9520724883867588970.stgit@frogsfrogsfrogs>","References":"<177747214459.4107473.9520724883867588970.stgit@frogsfrogsfrogs>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"From: Darrick J. Wong \n\nTurn on iomap for pagecache IO to regular files.\n\nSigned-off-by: \"Darrick J. Wong\" \n---\n fuse4fs/fuse4fs.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++------\n misc/fuse2fs.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++------\n 2 files changed, 108 insertions(+), 14 deletions(-)","diff":"diff --git a/fuse4fs/fuse4fs.c b/fuse4fs/fuse4fs.c\nindex 8b508de5b8cb65..fa82fda99ff687 100644\n--- a/fuse4fs/fuse4fs.c\n+++ b/fuse4fs/fuse4fs.c\n@@ -6438,9 +6438,6 @@ static int fuse4fs_iomap_begin_read(struct fuse4fs *ff, ext2_ino_t ino,\n \t\t\t\t uint64_t count, uint32_t opflags,\n \t\t\t\t struct fuse_file_iomap *read)\n {\n-\tif (!(opflags & FUSE_IOMAP_OP_DIRECT))\n-\t\treturn -ENOSYS;\n-\n \t/* fall back to slow path for inline data reads */\n \tif (inode->i_flags & EXT4_INLINE_DATA_FL)\n \t\treturn -ENOSYS;\n@@ -6531,9 +6528,6 @@ static int fuse4fs_iomap_begin_write(struct fuse4fs *ff, ext2_ino_t ino,\n \toff_t max_size = fuse4fs_max_file_size(ff, inode);\n \tint ret;\n \n-\tif (!(opflags & FUSE_IOMAP_OP_DIRECT))\n-\t\treturn -ENOSYS;\n-\n \tif (pos >= max_size)\n \t\treturn -EFBIG;\n \n@@ -6629,12 +6623,51 @@ static void op_iomap_begin(fuse_req_t req, fuse_ino_t fino, uint64_t dontcare,\n \t\tfuse_reply_iomap_begin(req, &read, NULL);\n }\n \n+static int fuse4fs_iomap_append_setsize(struct fuse4fs *ff, ext2_ino_t ino,\n+\t\t\t\t\tloff_t newsize)\n+{\n+\text2_filsys fs = ff->fs;\n+\tstruct ext2_inode_large inode;\n+\text2_off64_t isize;\n+\terrcode_t err;\n+\n+\tdbg_printf(ff, \"%s: ino=%u newsize=%llu\\n\", __func__, ino,\n+\t\t (unsigned long long)newsize);\n+\n+\terr = fuse4fs_read_inode(fs, ino, &inode);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\tisize = EXT2_I_SIZE(&inode);\n+\tif (newsize <= isize)\n+\t\treturn 0;\n+\n+\tdbg_printf(ff, \"%s: ino=%u oldsize=%llu newsize=%llu\\n\", __func__, ino,\n+\t\t (unsigned long long)isize,\n+\t\t (unsigned long long)newsize);\n+\n+\t/*\n+\t * XXX cheesily update the ondisk size even though we only want to do\n+\t * the incore size until writeback happens\n+\t */\n+\terr = ext2fs_inode_size_set(fs, EXT2_INODE(&inode), newsize);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\terr = fuse4fs_write_inode(fs, ino, &inode);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\treturn 0;\n+}\n+\n static void op_iomap_end(fuse_req_t req, fuse_ino_t fino, uint64_t dontcare,\n \t\t\t off_t pos, uint64_t count, uint32_t opflags,\n \t\t\t ssize_t written, const struct fuse_file_iomap *iomap)\n {\n \tstruct fuse4fs *ff = fuse4fs_get(req);\n \text2_ino_t ino;\n+\tint ret = 0;\n \n \tFUSE4FS_CHECK_CONTEXT(req);\n \tFUSE4FS_CONVERT_FINO(req, &ino, fino);\n@@ -6648,7 +6681,21 @@ static void op_iomap_end(fuse_req_t req, fuse_ino_t fino, uint64_t dontcare,\n \t\t written,\n \t\t iomap->flags);\n \n-\tfuse_reply_err(req, 0);\n+\tfuse4fs_start(ff);\n+\n+\t/* XXX is this really necessary? */\n+\tif ((opflags & FUSE_IOMAP_OP_WRITE) &&\n+\t !(opflags & FUSE_IOMAP_OP_DIRECT) &&\n+\t (iomap->flags & FUSE_IOMAP_F_SIZE_CHANGED) &&\n+\t written > 0) {\n+\t\tret = fuse4fs_iomap_append_setsize(ff, ino, pos + written);\n+\t\tif (ret)\n+\t\t\tgoto out_unlock;\n+\t}\n+\n+out_unlock:\n+\tfuse4fs_finish(ff, ret);\n+\tfuse_reply_err(req, -ret);\n }\n \n /*\ndiff --git a/misc/fuse2fs.c b/misc/fuse2fs.c\nindex 67a5bc4c5cc986..679406323df86f 100644\n--- a/misc/fuse2fs.c\n+++ b/misc/fuse2fs.c\n@@ -5673,9 +5673,6 @@ static int fuse2fs_iomap_begin_read(struct fuse2fs *ff, ext2_ino_t ino,\n \t\t\t\t uint64_t count, uint32_t opflags,\n \t\t\t\t struct fuse_file_iomap *read)\n {\n-\tif (!(opflags & FUSE_IOMAP_OP_DIRECT))\n-\t\treturn -ENOSYS;\n-\n \t/* fall back to slow path for inline data reads */\n \tif (inode->i_flags & EXT4_INLINE_DATA_FL)\n \t\treturn -ENOSYS;\n@@ -5763,9 +5760,6 @@ static int fuse2fs_iomap_begin_write(struct fuse2fs *ff, ext2_ino_t ino,\n \toff_t max_size = fuse2fs_max_file_size(ff, inode);\n \tint ret;\n \n-\tif (!(opflags & FUSE_IOMAP_OP_DIRECT))\n-\t\treturn -ENOSYS;\n-\n \tif (pos >= max_size)\n \t\treturn -EFBIG;\n \n@@ -5860,11 +5854,50 @@ static int op_iomap_begin(const char *path, uint64_t nodeid, uint64_t attr_ino,\n \treturn ret;\n }\n \n+static int fuse2fs_iomap_append_setsize(struct fuse2fs *ff, ext2_ino_t ino,\n+\t\t\t\t\tloff_t newsize)\n+{\n+\text2_filsys fs = ff->fs;\n+\tstruct ext2_inode_large inode;\n+\text2_off64_t isize;\n+\terrcode_t err;\n+\n+\tdbg_printf(ff, \"%s: ino=%u newsize=%llu\\n\", __func__, ino,\n+\t\t (unsigned long long)newsize);\n+\n+\terr = fuse2fs_read_inode(fs, ino, &inode);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\tisize = EXT2_I_SIZE(&inode);\n+\tif (newsize <= isize)\n+\t\treturn 0;\n+\n+\tdbg_printf(ff, \"%s: ino=%u oldsize=%llu newsize=%llu\\n\", __func__, ino,\n+\t\t (unsigned long long)isize,\n+\t\t (unsigned long long)newsize);\n+\n+\t/*\n+\t * XXX cheesily update the ondisk size even though we only want to do\n+\t * the incore size until writeback happens\n+\t */\n+\terr = ext2fs_inode_size_set(fs, EXT2_INODE(&inode), newsize);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\terr = fuse2fs_write_inode(fs, ino, &inode);\n+\tif (err)\n+\t\treturn translate_error(fs, ino, err);\n+\n+\treturn 0;\n+}\n+\n static int op_iomap_end(const char *path, uint64_t nodeid, uint64_t attr_ino,\n \t\t\toff_t pos, uint64_t count, uint32_t opflags,\n \t\t\tssize_t written, const struct fuse_file_iomap *iomap)\n {\n \tstruct fuse2fs *ff = fuse2fs_get();\n+\tint ret = 0;\n \n \tFUSE2FS_CHECK_CONTEXT(ff);\n \n@@ -5879,7 +5912,21 @@ static int op_iomap_end(const char *path, uint64_t nodeid, uint64_t attr_ino,\n \t\t written,\n \t\t iomap->flags);\n \n-\treturn 0;\n+\tfuse2fs_start(ff);\n+\n+\t/* XXX is this really necessary? */\n+\tif ((opflags & FUSE_IOMAP_OP_WRITE) &&\n+\t !(opflags & FUSE_IOMAP_OP_DIRECT) &&\n+\t (iomap->flags & FUSE_IOMAP_F_SIZE_CHANGED) &&\n+\t written > 0) {\n+\t\tret = fuse2fs_iomap_append_setsize(ff, attr_ino, pos + written);\n+\t\tif (ret)\n+\t\t\tgoto out_unlock;\n+\t}\n+\n+out_unlock:\n+\tfuse2fs_finish(ff, ret);\n+\treturn ret;\n }\n \n /*\n","prefixes":["08/19"]}