{"id":2230303,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230303/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177747214644.4107473.15598874995123900313.stgit@frogsfrogsfrogs/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.1/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<177747214644.4107473.15598874995123900313.stgit@frogsfrogsfrogs>","date":"2026-04-29T14:54:11","name":"[06/19] fuse2fs: add extent dump function for debugging","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ff9a6b310db8aedd84b7abf985da7aa634745fa2","submitter":{"id":77032,"url":"http://patchwork.ozlabs.org/api/1.1/people/77032/?format=json","name":"Darrick J. Wong","email":"djwong@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/177747214644.4107473.15598874995123900313.stgit@frogsfrogsfrogs/mbox/","series":[{"id":502087,"url":"http://patchwork.ozlabs.org/api/1.1/series/502087/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=502087","date":"2026-04-29T14:53:09","name":"[01/19] fuse2fs: implement bare minimum iomap for file mapping reporting","version":1,"mbox":"http://patchwork.ozlabs.org/series/502087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230303/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230303/checks/","tags":{},"headers":{"Return-Path":"\n <SRS0=kG/y=C4=vger.kernel.org=linux-ext4+bounces-16195-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Eel9ULEt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=kg/y=c4=vger.kernel.org=linux-ext4+bounces-16195-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Eel9ULEt;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16195-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Eel9ULEt\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5L283vNQz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 00:55:12 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g5L283S6hz4wLR\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 00:55:12 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g5L283NHBz4wLM; Thu, 30 Apr 2026 00:55:12 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g5L250PH3z4wLR\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 30 Apr 2026 00:55:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D801A300341A\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 29 Apr 2026 14:54:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BC42B3382C7;\n\tWed, 29 Apr 2026 14:54:12 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F1DD2FD696;\n\tWed, 29 Apr 2026 14:54:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 03363C19425;\n\tWed, 29 Apr 2026 14:54:11 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1777474512; cv=pass;\n\tb=FV8+tWfeyEczURzPVoE3/ocBgPkTmzp/UbGmhwydih/5fG/dqGKJ7JvcwevXkn1WYB/WcTYnWEMS83ZCANiKaEDb7laeH2wPy3q8UNPfv5xkqmKOJHTulQGqzAEMuQxhjIoBIo64xQMmrxuxx6eZvDX0zPsk0AiTG5K8rIUMD2SUcGPq/F+8zvkaOGcDD5PjZxI/8ofjG6EthfhjYaNi6E6NUDMHIN1I67gk3w0AkTAoEAgijvdwtLEDORc+PbRV5MhSoM7vFHBs6txY62D+VBtojifvHVLffINrBzMSyVx88iwNuus8G3xjg3fMmwoYsCaVzeaBiobkAxWUmGvakQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777474452; cv=none;\n b=Y6rI3xWjjMJiJHa/jHiIRmeOvLQdXb9bKUqdz1jH0f2wzfGY5cR8HqdImHA6aJagrmR9GWj2YbmG7FeKvolh1YUjoWIrjscsom1W1iG5MZNiyO6n46lpUNlLEs9DKP6Dty6MvCX/zYo7gxzFWCdKU6O2ytJBob7LYUOrRsl0JQk="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1777474512; c=relaxed/relaxed;\n\tbh=4xGLx3+IUEeSlFME94IhL8DEvrDy7fEMQtetoRCY5lk=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=k2DNJC30Vg2BN1n61TIgPwGzrTcoiJsJgU5aVmb03Z7zdVEBK/gnLexc7Et7zdwwNFCoSwndzQW4AvuMyUqko1WbHrztUh92BHYE4Yl6F/oHv/b18JXldDGRSrFEie441c4ceU+Ew2UqNuMA2YluV6SLPpYVsipI5akAoTMN4LNynVL6sl8i95+dnK4xFBNVuCqa6pmA88550cdrIJX/vDmiOIsvrN17WC8wm3gcfpA3O+tXnxKE1zTgGqcgwkKN7QV7zTf0jnSKEsC6f3lG5S6W2CLU+TVrjiSLU9uHoliuU6WK1SXQq1umTaTr2f2rU2Nxt9DOMJb3jOhDNlcQFA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777474452; c=relaxed/simple;\n\tbh=WIrGWfD0P1xpeIUrGvIGPdQ9n0mQlI24JaSneegztoc=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=QX1owhrg1aunJ1nXHdppVVMl2G8vNQgn9/tu4A4j3pb43EQwS0NQtdjGDNitPq8KrvwpqLKzFkY+V8fn9OXos1Imt9pUdM2VdrDo+HtxXS2zTZD5YDRuXYbWhi6s6es7lIzU16b1NCCGY7Yy9cdFnXoV6vWiNirPMnyw6rr7B4E="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Eel9ULEt; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16195-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Eel9ULEt; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777474452;\n\tbh=WIrGWfD0P1xpeIUrGvIGPdQ9n0mQlI24JaSneegztoc=;\n\th=Date:Subject:From:To:Cc:In-Reply-To:References:From;\n\tb=Eel9ULEthds8DNb4lV5N2kMqx3vMFEo/jDcP/aNay8ktqOTTKnPe1MXtlNJKiVmoN\n\t tGWL0BiYICIazwOT/drEFHl6OegP2fdJRBtGerBcI3DrCp8u/CHES3sUmadlpOlGJf\n\t oquHXFoyKgv7fe8fLuk6qEbT/H+aq+sEVWjoOMqkR8LvChUpkTAvkvPXraiqqlCnZC\n\t v7pVgzN2I3X5BCncjxOkUeimoUrdpbAuw0yLXnwpkotP+XAI8oLtRN2l1NrRjJhOD4\n\t VjVXWFvdlQEPFbDQ8l0MNQqjM+uHs9hMmvrDay2x6tugDnKbwJRdpklADGHmBno0D7\n\t //fa7+yrhPWrA==","Date":"Wed, 29 Apr 2026 07:54:11 -0700","Subject":"[PATCH 06/19] fuse2fs: add extent dump function for debugging","From":"\"Darrick J. Wong\" <djwong@kernel.org>","To":"tytso@mit.edu","Cc":"bernd@bsbernd.com, miklos@szeredi.hu, linux-ext4@vger.kernel.org,\n neal@gompa.dev, linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev,\n joannelkoong@gmail.com","Message-ID":"<177747214644.4107473.15598874995123900313.stgit@frogsfrogsfrogs>","In-Reply-To":"<177747214459.4107473.9520724883867588970.stgit@frogsfrogsfrogs>","References":"<177747214459.4107473.9520724883867588970.stgit@frogsfrogsfrogs>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"From: Darrick J. Wong <djwong@kernel.org>\n\nAdd a function to dump an inode's extent map for debugging purposes.\nThis helped debug a problem with generic/299 failing on 1k fsblock\nfilesystems:\n\n --- a/tests/generic/299.out\t2025-07-15 14:45:15.030113607 -0700\n +++ b/tests/generic/299.out.bad\t2025-07-16 19:33:50.889344998 -0700\n @@ -3,3 +3,4 @@ QA output created by 299\n  Run fio with random aio-dio pattern\n\n  Start fallocate/truncate loop\n +fio: io_u error on file /opt/direct_aio.0.0: Input/output error: write offset=2602827776, buflen=131072\n\n(The cause of this was misuse of the libext2fs extent code)\n\nSigned-off-by: \"Darrick J. Wong\" <djwong@kernel.org>\n---\n fuse4fs/fuse4fs.c |   70 +++++++++++++++++++++++++++++++++++++++++++++++++++++\n misc/fuse2fs.c    |   70 +++++++++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 140 insertions(+)","diff":"diff --git a/fuse4fs/fuse4fs.c b/fuse4fs/fuse4fs.c\nindex a1d931aed8f393..1489be2104f2b2 100644\n--- a/fuse4fs/fuse4fs.c\n+++ b/fuse4fs/fuse4fs.c\n@@ -917,6 +917,74 @@ static inline int fuse4fs_iomap_enabled(const struct fuse4fs *ff)\n # define fuse4fs_iomap_enabled(...)\t(0)\n #endif\n \n+static inline void fuse4fs_dump_extents(struct fuse4fs *ff, ext2_ino_t ino,\n+\t\t\t\t\tstruct ext2_inode_large *inode,\n+\t\t\t\t\tconst char *why)\n+{\n+\text2_filsys fs = ff->fs;\n+\tunsigned int nr = 0;\n+\tblk64_t blockcount = 0;\n+\tstruct ext2_inode_large xinode;\n+\tstruct ext2fs_extent extent;\n+\text2_extent_handle_t extents;\n+\tint op = EXT2_EXTENT_ROOT;\n+\terrcode_t retval;\n+\n+\tif (!inode) {\n+\t\tinode = &xinode;\n+\n+\t\tretval = fuse4fs_read_inode(fs, ino, inode);\n+\t\tif (retval) {\n+\t\t\tcom_err(__func__, retval, _(\"reading ino %u\"), ino);\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n+\tif (!(inode->i_flags & EXT4_EXTENTS_FL))\n+\t\treturn;\n+\n+\tprintf(\"%s: %s ino=%u isize %llu iblocks %llu\\n\", __func__, why, ino,\n+\t       EXT2_I_SIZE(inode),\n+\t       (ext2fs_get_stat_i_blocks(fs, EXT2_INODE(inode)) * 512) /\n+\t        fs->blocksize);\n+\tfflush(stdout);\n+\n+\tretval = ext2fs_extent_open(fs, ino, &extents);\n+\tif (retval) {\n+\t\tcom_err(__func__, retval, _(\"opening extents of ino \\\"%u\\\"\"),\n+\t\t\tino);\n+\t\treturn;\n+\t}\n+\n+\twhile ((retval = ext2fs_extent_get(extents, op, &extent)) == 0) {\n+\t\top = EXT2_EXTENT_NEXT;\n+\n+\t\tif (extent.e_flags & EXT2_EXTENT_FLAGS_SECOND_VISIT)\n+\t\t\tcontinue;\n+\n+\t\tprintf(\"[%u]: %s ino=%u lblk 0x%llx pblk 0x%llx len 0x%x flags 0x%x\\n\",\n+\t\t       nr++, why, ino, extent.e_lblk, extent.e_pblk,\n+\t\t       extent.e_len, extent.e_flags);\n+\t\tfflush(stdout);\n+\t\tif (extent.e_flags & EXT2_EXTENT_FLAGS_LEAF)\n+\t\t\tblockcount += extent.e_len;\n+\t\telse\n+\t\t\tblockcount++;\n+\t}\n+\tif (retval == EXT2_ET_EXTENT_NO_NEXT)\n+\t\tretval = 0;\n+\tif (retval) {\n+\t\tcom_err(__func__, retval, (\"getting extents of ino %u\"),\n+\t\t\tino);\n+\t}\n+\tif (inode->i_file_acl)\n+\t\tblockcount++;\n+\tprintf(\"%s: %s sum(e_len) %llu\\n\", __func__, why, blockcount);\n+\tfflush(stdout);\n+\n+\text2fs_extent_free(extents);\n+}\n+\n static void get_now(struct timespec *now)\n {\n #ifdef CLOCK_REALTIME\n@@ -6444,6 +6512,8 @@ static void op_iomap_begin(fuse_req_t req, fuse_ino_t fino, uint64_t dontcare,\n \n \t/* Not filling even the first byte will make the kernel unhappy. */\n \tif (read.offset > pos || read.offset + read.length <= pos) {\n+\t\tif (ff->debug)\n+\t\t\tfuse4fs_dump_extents(ff, ino, &inode, \"BAD DATA\");\n \t\tret = translate_error(fs, ino, EXT2_ET_INODE_CORRUPTED);\n \t\tgoto out_unlock;\n \t}\ndiff --git a/misc/fuse2fs.c b/misc/fuse2fs.c\nindex 739867fa41dd91..4b37bcde63d0f2 100644\n--- a/misc/fuse2fs.c\n+++ b/misc/fuse2fs.c\n@@ -729,6 +729,74 @@ static inline int fuse2fs_iomap_enabled(const struct fuse2fs *ff)\n # define fuse2fs_iomap_enabled(...)\t(0)\n #endif\n \n+static inline void fuse2fs_dump_extents(struct fuse2fs *ff, ext2_ino_t ino,\n+\t\t\t\t\tstruct ext2_inode_large *inode,\n+\t\t\t\t\tconst char *why)\n+{\n+\text2_filsys fs = ff->fs;\n+\tunsigned int nr = 0;\n+\tblk64_t blockcount = 0;\n+\tstruct ext2_inode_large xinode;\n+\tstruct ext2fs_extent extent;\n+\text2_extent_handle_t extents;\n+\tint op = EXT2_EXTENT_ROOT;\n+\terrcode_t retval;\n+\n+\tif (!inode) {\n+\t\tinode = &xinode;\n+\n+\t\tretval = fuse2fs_read_inode(fs, ino, inode);\n+\t\tif (retval) {\n+\t\t\tcom_err(__func__, retval, _(\"reading ino %u\"), ino);\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n+\tif (!(inode->i_flags & EXT4_EXTENTS_FL))\n+\t\treturn;\n+\n+\tprintf(\"%s: %s ino=%u isize %llu iblocks %llu\\n\", __func__, why, ino,\n+\t       EXT2_I_SIZE(inode),\n+\t       (ext2fs_get_stat_i_blocks(fs, EXT2_INODE(inode)) * 512) /\n+\t        fs->blocksize);\n+\tfflush(stdout);\n+\n+\tretval = ext2fs_extent_open(fs, ino, &extents);\n+\tif (retval) {\n+\t\tcom_err(__func__, retval, _(\"opening extents of ino \\\"%u\\\"\"),\n+\t\t\tino);\n+\t\treturn;\n+\t}\n+\n+\twhile ((retval = ext2fs_extent_get(extents, op, &extent)) == 0) {\n+\t\top = EXT2_EXTENT_NEXT;\n+\n+\t\tif (extent.e_flags & EXT2_EXTENT_FLAGS_SECOND_VISIT)\n+\t\t\tcontinue;\n+\n+\t\tprintf(\"[%u]: %s ino=%u lblk 0x%llx pblk 0x%llx len 0x%x flags 0x%x\\n\",\n+\t\t       nr++, why, ino, extent.e_lblk, extent.e_pblk,\n+\t\t       extent.e_len, extent.e_flags);\n+\t\tfflush(stdout);\n+\t\tif (extent.e_flags & EXT2_EXTENT_FLAGS_LEAF)\n+\t\t\tblockcount += extent.e_len;\n+\t\telse\n+\t\t\tblockcount++;\n+\t}\n+\tif (retval == EXT2_ET_EXTENT_NO_NEXT)\n+\t\tretval = 0;\n+\tif (retval) {\n+\t\tcom_err(__func__, retval, (\"getting extents of ino %u\"),\n+\t\t\tino);\n+\t}\n+\tif (inode->i_file_acl)\n+\t\tblockcount++;\n+\tprintf(\"%s: %s sum(e_len) %llu\\n\", __func__, why, blockcount);\n+\tfflush(stdout);\n+\n+\text2fs_extent_free(extents);\n+}\n+\n static void get_now(struct timespec *now)\n {\n #ifdef CLOCK_REALTIME\n@@ -5681,6 +5749,8 @@ static int op_iomap_begin(const char *path, uint64_t nodeid, uint64_t attr_ino,\n \n \t/* Not filling even the first byte will make the kernel unhappy. */\n \tif (read->offset > pos || read->offset + read->length <= pos) {\n+\t\tif (ff->debug)\n+\t\t\tfuse2fs_dump_extents(ff, attr_ino, &inode, \"BAD DATA\");\n \t\tret = translate_error(fs, attr_ino, EXT2_ET_INODE_CORRUPTED);\n \t\tgoto out_unlock;\n \t}\n","prefixes":["06/19"]}