{"id":2230300,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230300/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260429145314.79256-1-mdoucha@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429145314.79256-1-mdoucha@suse.cz>","date":"2026-04-29T14:53:11","name":"[v2,1/2] aio_cancel: Fix incorrect strerror() usage","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"527179f037bc1ca70c40a80fe37d063eecf02431","submitter":{"id":77472,"url":"http://patchwork.ozlabs.org/api/1.1/people/77472/?format=json","name":"Martin Doucha","email":"mdoucha@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260429145314.79256-1-mdoucha@suse.cz/mbox/","series":[{"id":502088,"url":"http://patchwork.ozlabs.org/api/1.1/series/502088/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=502088","date":"2026-04-29T14:53:11","name":"[v2,1/2] aio_cancel: Fix incorrect strerror() usage","version":2,"mbox":"http://patchwork.ozlabs.org/series/502088/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230300/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2230300/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=Jeub3bXZ;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=EVZtfbOF;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=BKdSYjZ/;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=TPRFglqz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5L0D0pbdz1xqf\n\tfor ; Thu, 30 Apr 2026 00:53:32 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id D068D3E49D5\n\tfor ; Wed, 29 Apr 2026 16:53:29 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id CD19A3E2538\n for ; Wed, 29 Apr 2026 16:53:25 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 6050220023C\n for ; Wed, 29 Apr 2026 16:53:25 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id B8EF85BD3F\n for ; Wed, 29 Apr 2026 14:53:15 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0E89593B0\n for ; Wed, 29 Apr 2026 14:53:15 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 0RjqKlsb8mlPfwAAD6G6ig\n (envelope-from )\n for ; Wed, 29 Apr 2026 14:53:15 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777474399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=2z4+DhhRHcm8PRMD4HEL+L+6wQf6kO5iIK37iXBOJMg=;\n b=Jeub3bXZBWPV0mbUUfG4BuSkW1u+gDFHRp8rp+s9GwIqf004aA1NjVEBLpPvy2v3wTT75s\n q8Qo7wK8upMzwPtGtPV08UzpMCvJz6BBo82qeneElNpzx/TTdbHztbyknEBR7m4vBb3ozC\n mhzDUeNWpeXh3ozx7PkaQp64BNZ+UT0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777474399;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=2z4+DhhRHcm8PRMD4HEL+L+6wQf6kO5iIK37iXBOJMg=;\n b=EVZtfbOFatj15X+Xqs/k3xPTctS+QGzMgbCaIMDm4vKznkq2msB6JE2Cm3ybb9RVBPipyZ\n QUQT03nX2ywBMwBw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777474395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=2z4+DhhRHcm8PRMD4HEL+L+6wQf6kO5iIK37iXBOJMg=;\n b=BKdSYjZ/tzTBLGqiOjcEEDBC/s/uaU5oY3LMjjy/8qYjU1UsWO0XdbqpWK2RM7xuTGidaA\n KFmYtHqgmkMR/FgrzjHqer2Q1f+4XhhbkYsEof+dBgollqqI4B17JsUfj8Svk3Btwkh3+4\n WDZ+LnoKUm9aZjg8OqpjPnS/T17xbZc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777474395;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=2z4+DhhRHcm8PRMD4HEL+L+6wQf6kO5iIK37iXBOJMg=;\n b=TPRFglqzq2+YS7X+TH/E8c2s3WsP1qmanv2pJTa8rL+kWalyus/fpISzYfsNoKPOCnM9he\n 9lIyBvE/L/CQmiCQ=="],"From":"Martin Doucha ","To":"ltp@lists.linux.it","Date":"Wed, 29 Apr 2026 16:53:11 +0200","Message-ID":"<20260429145314.79256-1-mdoucha@suse.cz>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[];\n RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[];\n MIME_TRACE(0.00)[0:+];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:mid, suse.cz:email,\n imap1.dmz-prg2.suse.org:helo]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v2 1/2] aio_cancel: Fix incorrect strerror() usage","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"Each call of strerror() invalidates the previous return value. Split\nprint calls to avoid calling strerror() twice in the argument list.\n\nAlso remove strerror() calls on aio_cancel() return value because\nthe function does not return errno constants directly.\n\nFixes: 690b37453 (\"aio_cancel_5-1: Rewrite test\")\nFixes: 220f579cd (\"aio_cancel_7-1: Rewrite test\")\nSigned-off-by: Martin Doucha \n---\n\nChanges since v1:\n- Removed strerror() calls on aio_cancel() return value\n- Added Fixes: tags\n\n .../conformance/interfaces/aio_cancel/5-1.c | 9 +++++----\n .../conformance/interfaces/aio_cancel/7-1.c | 9 +++++----\n 2 files changed, 10 insertions(+), 8 deletions(-)","diff":"diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\nindex dd5b0bbfb..0220acd7c 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\n@@ -95,8 +95,8 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t}\n \n \tif (ret != AIO_NOTCANCELED) {\n-\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %s\\n\",\n-\t\t\tstrerror(ret));\n+\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %d\\n\",\n+\t\t\tret);\n \t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\treturn PTS_FAIL;\n \t}\n@@ -131,8 +131,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t\t}\n \n \t\tif (ret != exp_ret) {\n-\t\t\tprintf(TNAME \" Bad task #%d result: %s (expected %s)\\n\",\n-\t\t\t\ti, strerror(ret), strerror(exp_ret));\n+\t\t\tprintf(TNAME \" Bad task #%d result: %s\",\n+\t\t\t\ti, strerror(ret));\n+\t\t\tprintf(\" (expected %s)\\n\", strerror(exp_ret));\n \t\t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\t\treturn PTS_FAIL;\n \t\t}\ndiff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\nindex 36ce8bb12..4bb9d8d09 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\n@@ -89,8 +89,8 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t}\n \n \tif (gret != AIO_NOTCANCELED) {\n-\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %s\\n\",\n-\t\t\tstrerror(gret));\n+\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %d\\n\",\n+\t\t\tgret);\n \t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\treturn PTS_FAIL;\n \t}\n@@ -118,8 +118,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t\t}\n \n \t\tif (ret != exp_ret) {\n-\t\t\tprintf(TNAME \" Bad task #%d result: %s (expected %s)\\n\",\n-\t\t\t\ti, strerror(ret), strerror(exp_ret));\n+\t\t\tprintf(TNAME \" Bad task #%d result: %s\",\n+\t\t\t\ti, strerror(ret));\n+\t\t\tprintf(\" (expected %s)\\n\", strerror(exp_ret));\n \t\t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\t\treturn PTS_FAIL;\n \t\t}\n","prefixes":["v2","1/2"]}