{"id":2230229,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230229/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/4c459d366679d0c83fae4fffa5f6c04e84f6be1d.1777463800.git.metze@samba.org/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<4c459d366679d0c83fae4fffa5f6c04e84f6be1d.1777463800.git.metze@samba.org>","date":"2026-04-29T13:43:35","name":"[1/2] smb: smbdirect: make use of DEFAULT_SYMBOL_NAMESPACE and EXPORT_SYMBOL_GPL","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4494bf86dd77b0df4636a152c60f908e83a4b086","submitter":{"id":8149,"url":"http://patchwork.ozlabs.org/api/1.1/people/8149/?format=json","name":"Stefan Metzmacher","email":"metze@samba.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/4c459d366679d0c83fae4fffa5f6c04e84f6be1d.1777463800.git.metze@samba.org/mbox/","series":[{"id":502065,"url":"http://patchwork.ozlabs.org/api/1.1/series/502065/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502065","date":"2026-04-29T13:43:34","name":"smb: smbdirect: symbol export and header cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/502065/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230229/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230229/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-11278-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (3072-bit key;\n secure) header.d=samba.org header.i=@samba.org header.a=rsa-sha256\n header.s=42 header.b=4FZKKTsq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11278-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=\"4FZKKTsq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=144.76.82.148","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=samba.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Jkr3095z1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 23:56:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E9F8A30EC651\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 13:46:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 90EA337B030;\n\tWed, 29 Apr 2026 13:44:00 +0000 (UTC)","from hr2.samba.org (hr2.samba.org [144.76.82.148])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 605B140243E\n\tfor <linux-cifs@vger.kernel.org>; Wed, 29 Apr 2026 13:43:58 +0000 (UTC)","from [127.0.0.2] (localhost [127.0.0.1])\n\tby hr2.samba.org with esmtpsa\n (TLS1.3:ECDHE_SECP256R1__ECDSA_SECP256R1_SHA256__CHACHA20_POLY1305:256)\n\t(Exim)\n\tid 1wI5Cg-000000050Xb-0hTh;\n\tWed, 29 Apr 2026 13:43:50 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777470240; cv=none;\n b=DG3A8TWz8llVrVntA5QPp0A6gHi5mQ4PsN9PomrFAOwg8f/7uMLjcdjFMjYXESdw96XVXrWbi61mNqlMzepqalE+pZshI55xE//DobC7rWW462/r9virxiMTn4Z8Bgv18rNGNnx6bURJhmAcyDuW3Olomtm2wX8y//9zBYnNAag=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777470240; c=relaxed/simple;\n\tbh=43nHlSffDBj0VZcGJdABQnWLjhJTuvwzUBxOIgp/Zcg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=b8xnD07S1R6JgDwaH+p5wsgy0M6qvbZffRnsKQsClSbb+Uhwp41NUu94yO6d6b65rdFOtzYiX5kf1OS9x0sTKdAYdRxtZnCMv7FprBOZE5MWgukKSkxPuXdiDd+uEwKV8BNCoIyeTYXj+Ggz591utT7sZ0d71yUPPsxO+ypMsl4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=samba.org;\n spf=pass smtp.mailfrom=samba.org;\n dkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org\n header.b=4FZKKTsq; arc=none smtp.client-ip=144.76.82.148","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org;\n\ts=42; h=Message-ID:Date:Cc:To:From;\n\tbh=84dniJZ51MKX+Cn41tpKuh6iwfhWxHS65xtmHI/s+tM=; b=4FZKKTsqMX+knQmChuzYbUWAxz\n\tlAdUUmRkvIxo3yqeECpTYxts62aY1s6Oi5qxH3aDB+fHQkkJXPvxhCvLTLD853g8PEN5NrRroht+m\n\tldtCPu/o7S1lejhvVnYpgbK2F8IE9Q8Do1/cATnddgC7UnmzI4DZFdGy2NJlU5ZuJfUP9c5KLZykg\n\tlzvppR3mS/f0YxLFZHCJQJlPK5wCOaBAKLGNcWMIe30tIdXDMNMYyPF8jzY1DgPgh662V0hl+hYjS\n\tptl0O2wqXpOUCreKDv00ngf42UW7wNwhHTGt+4HL7ml7gRjiUXX7VmiAbc7lYGKd/lZgo9wHkATwA\n\t/5U0G4BkO++yBMA3IPe8AobG6lyAVx0orbsUcp9ysnWla6xQalCtZcgcd8KyqGj9E2ZDdBtp5CRm4\n\t0n80DCM0dQo6Nri6GzmTl1+d3eEwQrVHTQBJiPxj2t/+pfAcrMY8KaGzmf+L4d2pVWjn1qJ305XRR\n\t24kX60qKkAy4/6EIJ0U46QQg;","From":"Stefan Metzmacher <metze@samba.org>","To":"linux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org","Cc":"metze@samba.org,\n\tChristoph Hellwig <hch@infradead.org>,\n\tSteve French <smfrench@gmail.com>,\n\tTom Talpey <tom@talpey.com>,\n\tLong Li <longli@microsoft.com>,\n\tNamjae Jeon <linkinjeon@kernel.org>","Subject":"[PATCH 1/2] smb: smbdirect: make use of DEFAULT_SYMBOL_NAMESPACE and\n EXPORT_SYMBOL_GPL","Date":"Wed, 29 Apr 2026 15:43:35 +0200","Message-ID":"\n <4c459d366679d0c83fae4fffa5f6c04e84f6be1d.1777463800.git.metze@samba.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<cover.1777463800.git.metze@samba.org>","References":"<cover.1777463800.git.metze@samba.org>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"This is a better solution than\nEXPORT_SYMBOL_FOR_MODULES(__sym, \"cifs,ksmbd\") as it makes\nit possible to rebuild smbdirect.ko against a\nrunning kernel and then load the existing cifs.ko and ksmbd.ko\nfrom the running kernel.\n\nSuggested-by: Christoph Hellwig <hch@infradead.org>\nLink: https://lore.kernel.org/linux-cifs/aehrPuY60VMcYGU8@infradead.org/\nCc: Steve French <smfrench@gmail.com>\nCc: Tom Talpey <tom@talpey.com>\nCc: Long Li <longli@microsoft.com>\nCc: Namjae Jeon <linkinjeon@kernel.org>\nCc: Christoph Hellwig <hch@infradead.org>\nCc: linux-cifs@vger.kernel.org\nCc: samba-technical@lists.samba.org\nSigned-off-by: Stefan Metzmacher <metze@samba.org>\n---\n fs/smb/client/smbdirect.c      |  2 ++\n fs/smb/server/transport_rdma.c |  2 ++\n fs/smb/smbdirect/accept.c      |  2 +-\n fs/smb/smbdirect/connect.c     |  4 ++--\n fs/smb/smbdirect/connection.c  | 16 ++++++++--------\n fs/smb/smbdirect/debug.c       |  2 +-\n fs/smb/smbdirect/devices.c     |  2 +-\n fs/smb/smbdirect/internal.h    |  1 +\n fs/smb/smbdirect/listen.c      |  2 +-\n fs/smb/smbdirect/mr.c          |  6 +++---\n fs/smb/smbdirect/public.h      |  2 --\n fs/smb/smbdirect/rw.c          |  2 +-\n fs/smb/smbdirect/socket.c      | 20 ++++++++++----------\n 13 files changed, 33 insertions(+), 30 deletions(-)","diff":"diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex 75f9f91a7ec9..b9826185de18 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -558,3 +558,5 @@ void smbd_debug_proc_show(struct TCP_Server_Info *server, struct seq_file *m)\n \t\t\t\t\t\t    server->rdma_readwrite_threshold,\n \t\t\t\t\t\t    m);\n }\n+\n+MODULE_IMPORT_NS(\"SMBDIRECT\");\ndiff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c\nindex a8242c00096f..346c051e31f5 100644\n--- a/fs/smb/server/transport_rdma.c\n+++ b/fs/smb/server/transport_rdma.c\n@@ -540,3 +540,5 @@ static const struct ksmbd_transport_ops ksmbd_smb_direct_transport_ops = {\n \t.rdma_write\t= smb_direct_rdma_write,\n \t.free_transport = smb_direct_free_transport,\n };\n+\n+MODULE_IMPORT_NS(\"SMBDIRECT\");\ndiff --git a/fs/smb/smbdirect/accept.c b/fs/smb/smbdirect/accept.c\nindex 704b271af3a8..529740005838 100644\n--- a/fs/smb/smbdirect/accept.c\n+++ b/fs/smb/smbdirect/accept.c\n@@ -854,4 +854,4 @@ struct smbdirect_socket *smbdirect_socket_accept(struct smbdirect_socket *lsc,\n \n \treturn nsc;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_accept);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_accept);\ndiff --git a/fs/smb/smbdirect/connect.c b/fs/smb/smbdirect/connect.c\nindex 8addee43a381..cd726b399afe 100644\n--- a/fs/smb/smbdirect/connect.c\n+++ b/fs/smb/smbdirect/connect.c\n@@ -60,7 +60,7 @@ int smbdirect_connect(struct smbdirect_socket *sc, const struct sockaddr *dst)\n \t */\n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connect);\n+EXPORT_SYMBOL_GPL(smbdirect_connect);\n \n static int smbdirect_connect_setup_connection(struct smbdirect_socket *sc)\n {\n@@ -922,4 +922,4 @@ int smbdirect_connect_sync(struct smbdirect_socket *sc,\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connect_sync);\n+EXPORT_SYMBOL_GPL(smbdirect_connect_sync);\ndiff --git a/fs/smb/smbdirect/connection.c b/fs/smb/smbdirect/connection.c\nindex 8f5676158537..8adf58097534 100644\n--- a/fs/smb/smbdirect/connection.c\n+++ b/fs/smb/smbdirect/connection.c\n@@ -706,7 +706,7 @@ bool smbdirect_connection_is_connected(struct smbdirect_socket *sc)\n \t\treturn false;\n \treturn true;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_is_connected);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_is_connected);\n \n int smbdirect_connection_wait_for_connected(struct smbdirect_socket *sc)\n {\n@@ -779,7 +779,7 @@ int smbdirect_connection_wait_for_connected(struct smbdirect_socket *sc)\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_wait_for_connected);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_wait_for_connected);\n \n void smbdirect_connection_idle_timer_work(struct work_struct *work)\n {\n@@ -958,7 +958,7 @@ int smbdirect_connection_send_batch_flush(struct smbdirect_socket *sc,\n \n \treturn ret;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_send_batch_flush);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_send_batch_flush);\n \n struct smbdirect_send_batch *\n smbdirect_init_send_batch_storage(struct smbdirect_send_batch_storage *storage,\n@@ -976,7 +976,7 @@ smbdirect_init_send_batch_storage(struct smbdirect_send_batch_storage *storage,\n \n \treturn batch;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_init_send_batch_storage);\n+EXPORT_SYMBOL_GPL(smbdirect_init_send_batch_storage);\n \n static int smbdirect_connection_wait_for_send_bcredit(struct smbdirect_socket *sc,\n \t\t\t\t\t\t      struct smbdirect_send_batch *batch)\n@@ -1263,7 +1263,7 @@ int smbdirect_connection_send_single_iter(struct smbdirect_socket *sc,\n bcredit_failed:\n \treturn ret;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_send_single_iter);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_send_single_iter);\n \n int smbdirect_connection_send_wait_zero_pending(struct smbdirect_socket *sc)\n {\n@@ -1288,7 +1288,7 @@ int smbdirect_connection_send_wait_zero_pending(struct smbdirect_socket *sc)\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_send_wait_zero_pending);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_send_wait_zero_pending);\n \n int smbdirect_connection_send_iter(struct smbdirect_socket *sc,\n \t\t\t\t   struct iov_iter *iter,\n@@ -1373,7 +1373,7 @@ int smbdirect_connection_send_iter(struct smbdirect_socket *sc,\n \n \treturn total_count;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_send_iter);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_send_iter);\n \n static void smbdirect_connection_send_io_done(struct ib_cq *cq, struct ib_wc *wc)\n {\n@@ -1937,7 +1937,7 @@ int smbdirect_connection_recvmsg(struct smbdirect_socket *sc,\n \n \tgoto again;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_recvmsg);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_recvmsg);\n \n static bool smbdirect_map_sges_single_page(struct smbdirect_map_sges *state,\n \t\t\t\t\t   struct page *page, size_t off, size_t len)\ndiff --git a/fs/smb/smbdirect/debug.c b/fs/smb/smbdirect/debug.c\nindex a66a19d4a463..05ba7c8d165e 100644\n--- a/fs/smb/smbdirect/debug.c\n+++ b/fs/smb/smbdirect/debug.c\n@@ -85,4 +85,4 @@ void smbdirect_connection_legacy_debug_proc_show(struct smbdirect_socket *sc,\n \t\t   atomic_read(&sc->mr_io.ready.count),\n \t\t   atomic_read(&sc->mr_io.used.count));\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_legacy_debug_proc_show);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_legacy_debug_proc_show);\ndiff --git a/fs/smb/smbdirect/devices.c b/fs/smb/smbdirect/devices.c\nindex 44962f221c35..7adacbdfe12e 100644\n--- a/fs/smb/smbdirect/devices.c\n+++ b/fs/smb/smbdirect/devices.c\n@@ -238,7 +238,7 @@ u8 smbdirect_netdev_rdma_capable_node_type(struct net_device *netdev)\n \n \treturn RDMA_NODE_UNSPECIFIED;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_netdev_rdma_capable_node_type);\n+EXPORT_SYMBOL_GPL(smbdirect_netdev_rdma_capable_node_type);\n \n __init int smbdirect_devices_init(void)\n {\ndiff --git a/fs/smb/smbdirect/internal.h b/fs/smb/smbdirect/internal.h\nindex 2d5acf2c21bc..82529b41708b 100644\n--- a/fs/smb/smbdirect/internal.h\n+++ b/fs/smb/smbdirect/internal.h\n@@ -6,6 +6,7 @@\n #ifndef __FS_SMB_COMMON_SMBDIRECT_INTERNAL_H__\n #define __FS_SMB_COMMON_SMBDIRECT_INTERNAL_H__\n \n+#define DEFAULT_SYMBOL_NAMESPACE \"SMBDIRECT\"\n #define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n \n #include \"smbdirect.h\"\ndiff --git a/fs/smb/smbdirect/listen.c b/fs/smb/smbdirect/listen.c\nindex 143a7618d95f..2f78bcaedbf8 100644\n--- a/fs/smb/smbdirect/listen.c\n+++ b/fs/smb/smbdirect/listen.c\n@@ -90,7 +90,7 @@ int smbdirect_socket_listen(struct smbdirect_socket *sc, int backlog)\n \t */\n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_listen);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_listen);\n \n static int smbdirect_new_rdma_event_handler(struct rdma_cm_id *new_id,\n \t\t\t\t\t    struct rdma_cm_event *event)\ndiff --git a/fs/smb/smbdirect/mr.c b/fs/smb/smbdirect/mr.c\nindex 5a428ff1b369..15c6363a2f97 100644\n--- a/fs/smb/smbdirect/mr.c\n+++ b/fs/smb/smbdirect/mr.c\n@@ -383,7 +383,7 @@ smbdirect_connection_register_mr_io(struct smbdirect_socket *sc,\n \t\tmutex_unlock(&mr->mutex);\n \treturn NULL;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_register_mr_io);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_register_mr_io);\n \n void smbdirect_mr_io_fill_buffer_descriptor(struct smbdirect_mr_io *mr,\n \t\t\t\t\t    struct smbdirect_buffer_descriptor_v1 *v1)\n@@ -400,7 +400,7 @@ void smbdirect_mr_io_fill_buffer_descriptor(struct smbdirect_mr_io *mr,\n \t}\n \tmutex_unlock(&mr->mutex);\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_mr_io_fill_buffer_descriptor);\n+EXPORT_SYMBOL_GPL(smbdirect_mr_io_fill_buffer_descriptor);\n \n /*\n  * Deregister a MR after I/O is done\n@@ -493,4 +493,4 @@ void smbdirect_connection_deregister_mr_io(struct smbdirect_mr_io *mr)\n \tif (!kref_put(&mr->kref, smbdirect_mr_io_free_locked))\n \t\tmutex_unlock(&mr->mutex);\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_deregister_mr_io);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_deregister_mr_io);\ndiff --git a/fs/smb/smbdirect/public.h b/fs/smb/smbdirect/public.h\nindex 50088155e7c3..d4fb36e65254 100644\n--- a/fs/smb/smbdirect/public.h\n+++ b/fs/smb/smbdirect/public.h\n@@ -13,8 +13,6 @@ struct smbdirect_socket;\n struct smbdirect_send_batch;\n struct smbdirect_mr_io;\n \n-#define __SMBDIRECT_EXPORT_SYMBOL__(__sym) EXPORT_SYMBOL_FOR_MODULES(__sym, \"cifs,ksmbd\")\n-\n #include <rdma/rw.h>\n \n u8 smbdirect_netdev_rdma_capable_node_type(struct net_device *netdev);\ndiff --git a/fs/smb/smbdirect/rw.c b/fs/smb/smbdirect/rw.c\nindex c2f46b17731e..6fe38042cfb9 100644\n--- a/fs/smb/smbdirect/rw.c\n+++ b/fs/smb/smbdirect/rw.c\n@@ -252,4 +252,4 @@ int smbdirect_connection_rdma_xmit(struct smbdirect_socket *sc,\n \tkfree(msg);\n \tgoto out;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_connection_rdma_xmit);\n+EXPORT_SYMBOL_GPL(smbdirect_connection_rdma_xmit);\ndiff --git a/fs/smb/smbdirect/socket.c b/fs/smb/smbdirect/socket.c\nindex 1b4ab01b745e..39cca7219c4d 100644\n--- a/fs/smb/smbdirect/socket.c\n+++ b/fs/smb/smbdirect/socket.c\n@@ -20,7 +20,7 @@ bool smbdirect_frwr_is_supported(const struct ib_device_attr *attrs)\n \t\treturn false;\n \treturn true;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_frwr_is_supported);\n+EXPORT_SYMBOL_GPL(smbdirect_frwr_is_supported);\n \n static void smbdirect_socket_cleanup_work(struct work_struct *work);\n \n@@ -107,7 +107,7 @@ int smbdirect_socket_create_kern(struct net *net, struct smbdirect_socket **_sc)\n alloc_failed:\n \treturn ret;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_create_kern);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_create_kern);\n \n int smbdirect_socket_init_accepting(struct rdma_cm_id *id, struct smbdirect_socket *sc)\n {\n@@ -148,7 +148,7 @@ int smbdirect_socket_create_accepting(struct rdma_cm_id *id, struct smbdirect_so\n alloc_failed:\n \treturn ret;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_create_accepting);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_create_accepting);\n \n int smbdirect_socket_set_initial_parameters(struct smbdirect_socket *sc,\n \t\t\t\t\t    const struct smbdirect_socket_parameters *sp)\n@@ -189,14 +189,14 @@ int smbdirect_socket_set_initial_parameters(struct smbdirect_socket *sc,\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_set_initial_parameters);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_set_initial_parameters);\n \n const struct smbdirect_socket_parameters *\n smbdirect_socket_get_current_parameters(struct smbdirect_socket *sc)\n {\n \treturn &sc->parameters;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_get_current_parameters);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_get_current_parameters);\n \n int smbdirect_socket_set_kernel_settings(struct smbdirect_socket *sc,\n \t\t\t\t\t enum ib_poll_context poll_ctx,\n@@ -220,7 +220,7 @@ int smbdirect_socket_set_kernel_settings(struct smbdirect_socket *sc,\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_set_kernel_settings);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_set_kernel_settings);\n \n void smbdirect_socket_set_logging(struct smbdirect_socket *sc,\n \t\t\t\t  void *private_ptr,\n@@ -240,7 +240,7 @@ void smbdirect_socket_set_logging(struct smbdirect_socket *sc,\n \tsc->logging.needed = needed;\n \tsc->logging.vaprintf = vaprintf;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_set_logging);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_set_logging);\n \n static void smbdirect_socket_wake_up_all(struct smbdirect_socket *sc)\n {\n@@ -663,13 +663,13 @@ int smbdirect_socket_bind(struct smbdirect_socket *sc, struct sockaddr *addr)\n \n \treturn 0;\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_bind);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_bind);\n \n void smbdirect_socket_shutdown(struct smbdirect_socket *sc)\n {\n \tsmbdirect_socket_schedule_cleanup_lvl(sc, SMBDIRECT_LOG_INFO, -ESHUTDOWN);\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_shutdown);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_shutdown);\n \n static void smbdirect_socket_release_disconnect(struct kref *kref)\n {\n@@ -712,7 +712,7 @@ void smbdirect_socket_release(struct smbdirect_socket *sc)\n \t */\n \tkref_put(&sc->refs.destroy, smbdirect_socket_release_destroy);\n }\n-__SMBDIRECT_EXPORT_SYMBOL__(smbdirect_socket_release);\n+EXPORT_SYMBOL_GPL(smbdirect_socket_release);\n \n int smbdirect_socket_wait_for_credits(struct smbdirect_socket *sc,\n \t\t\t\t      enum smbdirect_socket_status expected_status,\n","prefixes":["1/2"]}