{"id":2230222,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230222/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260429133000.37404-1-tiago.reis@luizalabs.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.1/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260429133000.37404-1-tiago.reis@luizalabs.com>","date":"2026-04-29T13:30:00","name":"[ovs-dev] Fix sha1: Use size_t for buffer lengths to support inputs >4GB The sha1_update() and sha1_bytes() functions previously accepted buffer lengths as uint32_t, which silently truncated larger size_t values passed by callers. This manifested as incor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b8c36e127dd882fe7649e24f890cc2e2d5399565","submitter":{"id":92676,"url":"http://patchwork.ozlabs.org/api/1.1/people/92676/?format=json","name":"Tiago Matos","email":"tiago.reis@luizalabs.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260429133000.37404-1-tiago.reis@luizalabs.com/mbox/","series":[{"id":502060,"url":"http://patchwork.ozlabs.org/api/1.1/series/502060/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=502060","date":"2026-04-29T13:30:00","name":"[ovs-dev] Fix sha1: Use size_t for buffer lengths to support inputs >4GB The sha1_update() and sha1_bytes() functions previously accepted buffer lengths as uint32_t, which silently truncated larger size_t values passed by callers. This manifested as incor","version":1,"mbox":"http://patchwork.ozlabs.org/series/502060/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230222/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2230222/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=luizalabs.com header.i=@luizalabs.com\n header.a=rsa-sha256 header.s=google header.b=F/OLt2WL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key,\n unprotected) header.d=luizalabs.com header.i=@luizalabs.com\n header.a=rsa-sha256 header.s=google header.b=F/OLt2WL","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=luizalabs.com","smtp4.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=luizalabs.com header.i=@luizalabs.com\n header.a=rsa-sha256 header.s=google header.b=F/OLt2WL"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5J8C1LlZz1yHZ\n\tfor ; Wed, 29 Apr 2026 23:30:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id EF22560B49;\n\tWed, 29 Apr 2026 13:30:16 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FIIlu-BrhsGv; Wed, 29 Apr 2026 13:30:16 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 0AB47610A8;\n\tWed, 29 Apr 2026 13:30:16 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D6A11C04FB;\n\tWed, 29 Apr 2026 13:30:15 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id B00CEC04FA\n for ; Wed, 29 Apr 2026 13:30:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 8F9B54071D\n for ; Wed, 29 Apr 2026 13:30:13 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gAL32txquhkD for ;\n Wed, 29 Apr 2026 13:30:12 +0000 (UTC)","from mail-dy1-x1330.google.com (mail-dy1-x1330.google.com\n [IPv6:2607:f8b0:4864:20::1330])\n by smtp4.osuosl.org (Postfix) with ESMTPS id A9AF9406D2\n for ; Wed, 29 Apr 2026 13:30:12 +0000 (UTC)","by mail-dy1-x1330.google.com with SMTP id\n 5a478bee46e88-2c15849aa2cso16810431eec.0\n for ; Wed, 29 Apr 2026 06:30:12 -0700 (PDT)","from state ([2804:10dc:d3c3:6e00:3256:fff:fe0d:5e27])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1bf8e7absm2143924eec.10.2026.04.29.06.30.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 06:30:10 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0AB47610A8","OpenDKIM Filter v2.11.0 smtp4.osuosl.org A9AF9406D2"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1330; helo=mail-dy1-x1330.google.com;\n envelope-from=tiago.reis@luizalabs.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org A9AF9406D2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=luizalabs.com; s=google; t=1777469411; x=1778074211; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Pg9TAUY77JyUP6poYQ7SSYTe+/hByniZKHK0+69q/2s=;\n b=F/OLt2WL5o2vBKZ90VK5OtlZKmB19EAaaoT087vC/BS1/Q1+AifM4/Tk2gBml4PfVB\n usZqUVRRnQ88WzWPoJV3wJP56MzHFSbFTs3FdWoY034gE6ojLdvozai+4l8OUG1DYbM5\n C1CaAg8beB1a3/RoibBp4JLU8yDtcx13Xq24M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777469411; x=1778074211;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Pg9TAUY77JyUP6poYQ7SSYTe+/hByniZKHK0+69q/2s=;\n b=o+kkwynex2A1RMgtGPbBICfAyeANZRxgE93l/vEVmwHKYGO7z7NoTN18HhfwqPCmQz\n fVfhtstCd7sV3LA7zIfKYiGnO4PNyPgzcGYyrAarD5UuCwry5Xm/Pk0A3VWDjXgCuWJH\n zlNKBzwUbBdY06vBp0EmErh2+Whg+91zEdDQRN8UCuE8uThU9nPKX9nBL49BGhnjs68P\n DnPvfZnucvy/lNm6lw+eVsVsxxAhIDaSwTICIxzmJbeE/RVHBCFaZ7dGeX2SCfQY+Ba5\n sirkjHGDzKIW2VlKnjZGyiR/j+qjDnLdMWfXZ2QidwO+4LtCFdfDxOy5r3UANDRLceW6\n t1wA==","X-Gm-Message-State":"AOJu0Yy2OIL+reIPJHcvCsw6xUSHLzklH57lu3fPdiwIEc2EM3KDt1cU\n 3cPHwD8WJuuVIxrliCkEAleurBe/10qdJXBg+2yR6mxq6XJsK+7G3TOFo7TdwKUe1MSKUVH9ZdK\n Hvu15FfY7VNJGC/XufmZN2ZMHjdsIw1f1QRJJL40F4nbG0JRMVAr4DGyCb2HWihM=","X-Gm-Gg":"AeBDievW37MTZ6/aK+zENRthU0fA1CJb5PO+1i2RI98yNGul8nnUAcJRs0HDBWDktRm\n 3hBlY9MkHtUl8bS+9EKDLZRZGA+31tLMHcNTJC1aLx11xW5YWnhFjUrBchyLQHJJbjtbIbcnVo5\n xZpTJlgowssJvvotlmuhZkDP0ZmXE9gffO4NpwbLnJ8Imzt6dsG0ORBWewDY7s2iLZcIATJeErs\n 4r/ftC5p1m06MjbKCIlqUXT6Qnr5p+DugduvgDvPDenGNp4xACghpxwM4qIGtxN6Gz15oCdIOHN\n NwLnVYevRT/S/azQUVs2AnFY38/HbAOuWQvzPSKBP6P8ygCb6UB8tQe0y8e4ZaJQOmx3DTz6Azj\n lr6TTqiqNJe8zoGr/WDxaHacrY40Tn84LHnaosaKGUDyWfqf1hPthURpiLN02fIYNAwqP5DulTp\n 6skODEZ30605xspeLNapSJoaPQyqCDu7pqLAq2xX3DFms66g==","X-Received":"by 2002:a05:7301:2b05:b0:2e6:e916:70ff with SMTP id\n 5a478bee46e88-2ed0a177bbemr3441084eec.28.1777469411332;\n Wed, 29 Apr 2026 06:30:11 -0700 (PDT)","To":"dev@openvswitch.org","Date":"Wed, 29 Apr 2026 10:30:00 -0300","Message-ID":"<20260429133000.37404-1-tiago.reis@luizalabs.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH] Fix sha1: Use size_t for buffer lengths to\n support inputs >4GB The sha1_update() and sha1_bytes() functions previously\n accepted buffer lengths as uint32_t,\n which silently truncated larger size_t values passed by callers. This\n manifested as incorrect SHA1 hashes when compacting an OVSDB database\n larger than 4GB: the truncated length was forwarded to OpenSSL's\n EVP_DigestUpdate(), causing it to hash only the low 32 bits' worth of bytes.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Tiago Matos via dev ","Reply-To":"Tiago Matos ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Change the length parameter of sha1_update() and sha1_bytes() from\nuint32_t to size_t so the full buffer length is preserved on 64-bit\nplatforms.\n\nSigned-off-by: Tiago Matos \n---\n lib/sha1.c | 5 +++--\n lib/sha1.h | 4 ++--\n 2 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/lib/sha1.c b/lib/sha1.c\nindex 871ff55ed..6f7b19e53 100644\n--- a/lib/sha1.c\n+++ b/lib/sha1.c\n@@ -30,6 +30,7 @@\n */\n \n #include \n+#include \n #include \"sha1.h\"\n \n #ifdef HAVE_OPENSSL\n@@ -80,7 +81,7 @@ sha1_init(struct sha1_ctx *sha_info)\n * inputLen: The length of the input buffer.\n */\n void\n-sha1_update(struct sha1_ctx *ctx, const void *buffer_, uint32_t count)\n+sha1_update(struct sha1_ctx *ctx, const void *buffer_, size_t count)\n {\n #ifdef HAVE_OPENSSL\n if (!EVP_DigestUpdate(ctx->ctx, buffer_, count)) {\n@@ -114,7 +115,7 @@ sha1_final(struct sha1_ctx *ctx, uint8_t digest[SHA1_DIGEST_SIZE])\n \n /* Computes the hash of 'n' bytes in 'data' into 'digest'. */\n void\n-sha1_bytes(const void *data, uint32_t n, uint8_t digest[SHA1_DIGEST_SIZE])\n+sha1_bytes(const void *data, size_t n, uint8_t digest[SHA1_DIGEST_SIZE])\n {\n struct sha1_ctx ctx;\n \ndiff --git a/lib/sha1.h b/lib/sha1.h\nindex 710e5751c..e052d7fef 100644\n--- a/lib/sha1.h\n+++ b/lib/sha1.h\n@@ -56,9 +56,9 @@ struct sha1_ctx {\n };\n \n void sha1_init(struct sha1_ctx *);\n-void sha1_update(struct sha1_ctx *, const void *, uint32_t size);\n+void sha1_update(struct sha1_ctx *, const void *, size_t size);\n void sha1_final(struct sha1_ctx *, uint8_t digest[SHA1_DIGEST_SIZE]);\n-void sha1_bytes(const void *, uint32_t size, uint8_t digest[SHA1_DIGEST_SIZE]);\n+void sha1_bytes(const void *, size_t size, uint8_t digest[SHA1_DIGEST_SIZE]);\n \n #define SHA1_FMT \\\n \"%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x\" \\\n","prefixes":["ovs-dev"]}