{"id":2230201,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230201/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260429122617.7324-11-ilpo.jarvinen@linux.intel.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260429122617.7324-11-ilpo.jarvinen@linux.intel.com>","date":"2026-04-29T12:26:16","name":"[10/11] PCI: Lower bound bridge window alignment","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e7192c6229f6722ee93ebabd0b10773e40d715d9","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/1.1/people/83553/?format=json","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260429122617.7324-11-ilpo.jarvinen@linux.intel.com/mbox/","series":[{"id":502050,"url":"http://patchwork.ozlabs.org/api/1.1/series/502050/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502050","date":"2026-04-29T12:26:06","name":"PCI: pci_resource_alignment() improvement + cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/502050/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230201/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230201/checks/","tags":{},"headers":{"Return-Path":"\n <linux-pci+bounces-53395-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=OPZWZ8YJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53395-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"OPZWZ8YJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.12","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Grf1Y90z1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 22:31:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3D682301D303\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 12:28:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2150239D6C6;\n\tWed, 29 Apr 2026 12:28:27 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E5A2739C632;\n\tWed, 29 Apr 2026 12:28:25 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n  by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2026 05:28:25 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.245.212])\n  by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2026 05:28:22 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777465707; cv=none;\n b=t/v5zPR0iYkFPd9+orccDVesZPpRLKIYVuQPlZohEi6azu9CMTKzzbzEb9wn+oyrV8hrgCGVx9YKaPWa3iOyJWAfXL/rhO9FWV/lkL2p3xpx/tYdrpWHFqoqQBnoYHfGlQitZJf0XJHXM642zD2MNd1+MkyCBq3uDwOy6LMHOSg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777465707; c=relaxed/simple;\n\tbh=fqkZl+gRhl4cKQbh+rABk9mPSNA9e1YAdoDCW18qzQY=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=LPBYJS+CjzRI3dA1jfwMHryhICKxxjaFUoJnPsJEBjKnkmlV05oviQzR3ftHwmAeKp5mavl1TBdHbWuvYnHjpuyxO5ZWcnVuxzBg8NBj7KpnrYVm2zOvf2z28XlsvqdkHCnahx9Z/89La3QvGFfgMU2h3UEFQTXhMRO8pNG9q94=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=OPZWZ8YJ; arc=none smtp.client-ip=198.175.65.12","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777465706; x=1809001706;\n  h=from:to:cc:subject:date:message-id:in-reply-to:\n   references:mime-version:content-transfer-encoding;\n  bh=fqkZl+gRhl4cKQbh+rABk9mPSNA9e1YAdoDCW18qzQY=;\n  b=OPZWZ8YJx7wtU7cHmJovX0wIj6YjIBbetkqGnVwiRJBorcYwCUZ5yHh8\n   EwhIaaLhTGS8EtrA2egRhRjW4CEVJXzT43SZ2AChr/Zj1SjuUNFTKXG4s\n   ZB9PaqijoY/6vxL2znraiNCMnhuSteZDwdHdlV709esAu4uBrsMrmk5py\n   YmOaC5s/MXSzrFGXG4amCjQe2qJGK98iabNvqfxlJa5zqjzuezCDdYsoK\n   jiRfCsi6uedVk4JRVDNS6Vr8LJ0BJHysBIHotcRHtDy4tKElcrywwbry4\n   GsqWk5LmT4PBl/uivhp7perzrd+NOyhpHwAxXPG3C+bCrrZznHlVEr20S\n   A==;","X-CSE-ConnectionGUID":["+1dfq9gWQfe61S64OG1OmA==","0b2tYkpVQgm1CLfL2p4dAw=="],"X-CSE-MsgGUID":["ti1ND9IVTnOsuHrkEDVNPw==","uI4xITOIRG2N/6phtyIxUw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"89853538\"","E=Sophos;i=\"6.23,206,1770624000\";\n   d=\"scan'208\";a=\"89853538\"","E=Sophos;i=\"6.23,206,1770624000\";\n   d=\"scan'208\";a=\"264639555\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>","To":"linux-pci@vger.kernel.org,\n\tBjorn Helgaas <bhelgaas@google.com>,\n\tShawn Jin <shawn.jin@asteralabs.com>,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\tlinux-kernel@vger.kernel.org","Cc":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>","Subject":"[PATCH 10/11] PCI: Lower bound bridge window alignment","Date":"Wed, 29 Apr 2026 15:26:16 +0300","Message-Id":"<20260429122617.7324-11-ilpo.jarvinen@linux.intel.com>","X-Mailer":"git-send-email 2.39.5","In-Reply-To":"<20260429122617.7324-1-ilpo.jarvinen@linux.intel.com>","References":"<20260429122617.7324-1-ilpo.jarvinen@linux.intel.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"pci_resource_alignment() does not consider bridge windows special,\nyet their alignment is subject to different requirements from BAR\nalignment.\n\nAdd lower bound to bridge window alignment to help callers out to\nalways have large enough alignment.\n\nSigned-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n---\n drivers/pci/setup-res.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c\nindex 18e8775ea848..c15bce20815d 100644\n--- a/drivers/pci/setup-res.c\n+++ b/drivers/pci/setup-res.c\n@@ -19,7 +19,10 @@\n #include <linux/errno.h>\n #include <linux/ioport.h>\n #include <linux/cache.h>\n+#include <linux/minmax.h>\n #include <linux/slab.h>\n+#include <linux/types.h>\n+\n #include \"pci.h\"\n \n static void pci_std_update_resource(struct pci_dev *dev, int resno)\n@@ -250,12 +253,19 @@ resource_size_t pci_resource_alignment(const struct pci_dev *dev,\n \t\t\t\t       const struct resource *res)\n {\n \tint resno = pci_resource_num(dev, res);\n+\tresource_size_t min_align = 0;\n \n \tif (pci_resource_is_iov(resno))\n \t\treturn pci_sriov_resource_alignment(dev, resno);\n+\n \tif (dev->class >> 8 == PCI_CLASS_BRIDGE_CARDBUS)\n \t\treturn pci_cardbus_resource_alignment(res);\n-\treturn resource_alignment(res);\n+\n+\tif (pci_resource_is_bridge_win(resno) &&\n+\t    (res->flags & (IORESOURCE_IO|IORESOURCE_MEM)))\n+\t\tmin_align = pci_min_window_alignment(dev->bus, res->flags);\n+\n+\treturn max(resource_alignment(res), min_align);\n }\n \n /*\n","prefixes":["10/11"]}