{"id":2230166,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230166/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429121743.1346635-4-stefanb@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429121743.1346635-4-stefanb@linux.ibm.com>","date":"2026-04-29T12:17:40","name":"[v2,3/6] tests: Convert string arrays to byte arrays","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"92265fa02482ce028c23a2ebeaf974009479f975","submitter":{"id":75097,"url":"http://patchwork.ozlabs.org/api/1.1/people/75097/?format=json","name":"Stefan Berger","email":"stefanb@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429121743.1346635-4-stefanb@linux.ibm.com/mbox/","series":[{"id":502046,"url":"http://patchwork.ozlabs.org/api/1.1/series/502046/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502046","date":"2026-04-29T12:17:37","name":"Add test case for TPM over I2C with swtpm","version":2,"mbox":"http://patchwork.ozlabs.org/series/502046/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230166/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230166/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NCgkeoS3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5GZJ6Lv6z1yHZ\n\tfor ; Wed, 29 Apr 2026 22:19:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI3rb-0004GH-1H; Wed, 29 Apr 2026 08:17:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI3rX-0004Ex-Bh\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 08:17:55 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI3rV-0000pu-FR\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 08:17:55 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63T9Jn4E3538290; Wed, 29 Apr 2026 12:17:52 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drm1e0ydv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 29 Apr 2026 12:17:52 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63TC8iNh027713;\n Wed, 29 Apr 2026 12:17:51 GMT","from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8xk66hb-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Wed, 29 Apr 2026 12:17:51 +0000 (GMT)","from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com\n [10.39.53.231])\n by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63TCHo8m4653620\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Wed, 29 Apr 2026 12:17:51 GMT","from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id AC77B58045;\n Wed, 29 Apr 2026 12:17:50 +0000 (GMT)","from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 3C32E58050;\n Wed, 29 Apr 2026 12:17:50 +0000 (GMT)","from mycroft-2.pok.ibm.com (unknown [9.47.158.222])\n by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Wed, 29 Apr 2026 12:17:50 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=JsTIvCSFlcUXPSgx2\n xxGQMJKzlpH+LPV/wPmsQGXzT0=; b=NCgkeoS3WQNRAzzAqQii+5Y+kfM3G0ewq\n EkJYxujdm2LUNergpNqdAr6vz1TaelXUrgiu8ge6+pMWKJ3yWLfY3GD9/P8e9wI9\n PFakxjBR+v5wjR2VFCs7ZkVmWPq6WPBrN9lF7/yCPyy5tmsbIre8g89ChVULylkT\n T6mAJIbxFuy/yPmNauEPf688JXT+8XtIHdZ2tBjmP9RgMZd7SolpuluHz3CHcn//\n oWmUnvJDOiEmuOtMwf2md5m1SPugzbFmsF2n4Mkl8Z3+WRgRgKawWDht+JRbSy2v\n PNZtKZZ5XWNAiTsZ/wSloe5z+flyT1nkOx5zPeuN9Za7sTR52NCZA==","From":"Stefan Berger ","To":"qemu-devel@nongnu.org","Cc":"marcandre.lureau@redhat.com, armenon@redhat.com,\n Stefan Berger ","Subject":"[PATCH v2 3/6] tests: Convert string arrays to byte arrays","Date":"Wed, 29 Apr 2026 12:17:40 +0000","Message-ID":"<20260429121743.1346635-4-stefanb@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429121743.1346635-1-stefanb@linux.ibm.com>","References":"<20260429121743.1346635-1-stefanb@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-ORIG-GUID":"oPIYXqv3RPRYT5v7oTPsvwqo9IBt4LFU","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDEyNSBTYWx0ZWRfX29aHwTo30VVN\n NPlrOD4htaMYsoybYFPT1OQixSFoOibuO3OAaVj/VTFo2sominV6Zy1OsQE02KUAbTmx0q/V1Ch\n k94C9WJOJGAuvMC0Jdjl17pOJUraX4gAv8945NSPHoRWwY7+g5gmjGuc+tU04peiuihHfeSjCRf\n Th7QhwW5o1QkCVsJQ5rA2jzEzREx1dCOboZe83r+1X4O9KOiX/9p7TjxOPYCwmJsPCkWlPsPjf6\n bWYOftSLW53hbzAFqEJ6ko1UTT3+lDRp169my4e4+0do7BwRkC8GrrBo7FdIZOrqeIIHUr1AZxX\n /zJrn0hDlWoSwzRdCBLPf2nfUVYuGlJytxEEqK8TubT+nkKO51TiL3ramdF6jAp2KMDgTzea3hj\n 7Si7aLJG2GkIADLywoBO0hzCN/YoU1pk44gwpjxn/EZvaPZxkYCzChfUi7xUEraAsDiLbMRGJvP\n HWojhciNy436zVdUzVA==","X-Authority-Analysis":"v=2.4 cv=VZLH+lp9 c=1 sm=1 tr=0 ts=69f1f6f0 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=LORrTqdot4XOhRVC2oUA:9","X-Proofpoint-GUID":"oPIYXqv3RPRYT5v7oTPsvwqo9IBt4LFU","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 suspectscore=0 adultscore=0 lowpriorityscore=0 phishscore=0\n spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290125","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=stefanb@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Convert the TPM command and response string arrays to byte arrays.\n\nSigned-off-by: Stefan Berger \n---\n tests/qtest/tpm-tests.c | 30 ++++++++++++++++++---------\n tests/qtest/tpm-util.c | 45 ++++++++++++++++++++++++++---------------\n 2 files changed, 49 insertions(+), 26 deletions(-)","diff":"diff --git a/tests/qtest/tpm-tests.c b/tests/qtest/tpm-tests.c\nindex 197714f8d9..8bd3288f80 100644\n--- a/tests/qtest/tpm-tests.c\n+++ b/tests/qtest/tpm-tests.c\n@@ -59,11 +59,16 @@ void tpm_test_swtpm_test(const char *src_tpm_path, tx_func *tx,\n tpm_util_startup(s, tx);\n tpm_util_pcrextend(s, tx);\n \n- static const unsigned char tpm_pcrread_resp[] =\n- \"\\x80\\x01\\x00\\x00\\x00\\x3e\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x16\\x00\\x00\"\n- \"\\x00\\x01\\x00\\x0b\\x03\\x00\\x04\\x00\\x00\\x00\\x00\\x01\\x00\\x20\\xf6\\x85\"\n- \"\\x98\\xe5\\x86\\x8d\\xe6\\x8b\\x97\\x29\\x99\\x60\\xf2\\x71\\x7d\\x17\\x67\\x89\"\n- \"\\xa4\\x2f\\x9a\\xae\\xa8\\xc7\\xb7\\xaa\\x79\\xa8\\x62\\x56\\xc1\\xde\";\n+ static const unsigned char tpm_pcrread_resp[] = {\n+ 0x80, 0x01, 0x00, 0x00, 0x00, 0x3e, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x16, 0x00, 0x00,\n+ 0x00, 0x01, 0x00, 0x0b, 0x03, 0x00, 0x04, 0x00,\n+ 0x00, 0x00, 0x00, 0x01, 0x00, 0x20, 0xf6, 0x85,\n+ 0x98, 0xe5, 0x86, 0x8d, 0xe6, 0x8b, 0x97, 0x29,\n+ 0x99, 0x60, 0xf2, 0x71, 0x7d, 0x17, 0x67, 0x89,\n+ 0xa4, 0x2f, 0x9a, 0xae, 0xa8, 0xc7, 0xb7, 0xaa,\n+ 0x79, 0xa8, 0x62, 0x56, 0xc1, 0xde\n+ };\n tpm_util_pcrread(s, tx, tpm_pcrread_resp,\n sizeof(tpm_pcrread_resp));\n \n@@ -105,11 +110,16 @@ void tpm_test_swtpm_migration_test(const char *src_tpm_path,\n tpm_util_startup(src_qemu, tx);\n tpm_util_pcrextend(src_qemu, tx);\n \n- static const unsigned char tpm_pcrread_resp[] =\n- \"\\x80\\x01\\x00\\x00\\x00\\x3e\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x16\\x00\\x00\"\n- \"\\x00\\x01\\x00\\x0b\\x03\\x00\\x04\\x00\\x00\\x00\\x00\\x01\\x00\\x20\\xf6\\x85\"\n- \"\\x98\\xe5\\x86\\x8d\\xe6\\x8b\\x97\\x29\\x99\\x60\\xf2\\x71\\x7d\\x17\\x67\\x89\"\n- \"\\xa4\\x2f\\x9a\\xae\\xa8\\xc7\\xb7\\xaa\\x79\\xa8\\x62\\x56\\xc1\\xde\";\n+ static const unsigned char tpm_pcrread_resp[] = {\n+ 0x80, 0x01, 0x00, 0x00, 0x00, 0x3e, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x16, 0x00, 0x00,\n+ 0x00, 0x01, 0x00, 0x0b, 0x03, 0x00, 0x04, 0x00,\n+ 0x00, 0x00, 0x00, 0x01, 0x00, 0x20, 0xf6, 0x85,\n+ 0x98, 0xe5, 0x86, 0x8d, 0xe6, 0x8b, 0x97, 0x29,\n+ 0x99, 0x60, 0xf2, 0x71, 0x7d, 0x17, 0x67, 0x89,\n+ 0xa4, 0x2f, 0x9a, 0xae, 0xa8, 0xc7, 0xb7, 0xaa,\n+ 0x79, 0xa8, 0x62, 0x56, 0xc1, 0xde,\n+ };\n tpm_util_pcrread(src_qemu, tx, tpm_pcrread_resp,\n sizeof(tpm_pcrread_resp));\n \ndiff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c\nindex 2cb2dd4796..63cd5b69db 100644\n--- a/tests/qtest/tpm-util.c\n+++ b/tests/qtest/tpm-util.c\n@@ -54,10 +54,14 @@ void tpm_util_crb_transfer(QTestState *s,\n void tpm_util_startup(QTestState *s, tx_func *tx)\n {\n unsigned char buffer[1024];\n- static const unsigned char tpm_startup[] =\n- \"\\x80\\x01\\x00\\x00\\x00\\x0c\\x00\\x00\\x01\\x44\\x00\\x00\";\n- static const unsigned char tpm_startup_resp[] =\n- \"\\x80\\x01\\x00\\x00\\x00\\x0a\\x00\\x00\\x00\\x00\";\n+ static const unsigned char tpm_startup[] = {\n+ 0x80, 0x01, 0x00, 0x00, 0x00, 0x0c, 0x00, 0x00,\n+ 0x01, 0x44, 0x00, 0x00\n+ };\n+ static const unsigned char tpm_startup_resp[] = {\n+ 0x80, 0x01, 0x00, 0x00, 0x00, 0x0a, 0x00, 0x00,\n+ 0x00, 0x00\n+ };\n \n tx(s, tpm_startup, sizeof(tpm_startup), buffer, sizeof(buffer));\n \n@@ -68,16 +72,23 @@ void tpm_util_startup(QTestState *s, tx_func *tx)\n void tpm_util_pcrextend(QTestState *s, tx_func *tx)\n {\n unsigned char buffer[1024];\n- static const unsigned char tpm_pcrextend[] =\n- \"\\x80\\x02\\x00\\x00\\x00\\x41\\x00\\x00\\x01\\x82\\x00\\x00\\x00\\x0a\\x00\\x00\"\n- \"\\x00\\x09\\x40\\x00\\x00\\x09\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x01\\x00\"\n- \"\\x0b\\x74\\x65\\x73\\x74\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\"\n- \"\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\"\n- \"\\x00\";\n+ static const unsigned char tpm_pcrextend[] = {\n+ 0x80, 0x02, 0x00, 0x00, 0x00, 0x41, 0x00, 0x00,\n+ 0x01, 0x82, 0x00, 0x00, 0x00, 0x0a, 0x00, 0x00,\n+ 0x00, 0x09, 0x40, 0x00, 0x00, 0x09, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00,\n+ 0x0b, 0x74, 0x65, 0x73, 0x74, 0x00, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,\n+ 0x00\n+ };\n \n- static const unsigned char tpm_pcrextend_resp[] =\n- \"\\x80\\x02\\x00\\x00\\x00\\x13\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\"\n- \"\\x01\\x00\\x00\";\n+ static const unsigned char tpm_pcrextend_resp[] = {\n+ 0x80, 0x02, 0x00, 0x00, 0x00, 0x13, 0x00, 0x00,\n+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,\n+ 0x01, 0x00, 0x00\n+ };\n \n tx(s, tpm_pcrextend, sizeof(tpm_pcrextend), buffer, sizeof(buffer));\n \n@@ -89,9 +100,11 @@ void tpm_util_pcrread(QTestState *s, tx_func *tx,\n const unsigned char *exp_resp, size_t exp_resp_size)\n {\n unsigned char buffer[1024];\n- static const unsigned char tpm_pcrread[] =\n- \"\\x80\\x01\\x00\\x00\\x00\\x14\\x00\\x00\\x01\\x7e\\x00\\x00\\x00\\x01\\x00\\x0b\"\n- \"\\x03\\x00\\x04\\x00\";\n+ static const unsigned char tpm_pcrread[] = {\n+ 0x80, 0x01, 0x00, 0x00, 0x00, 0x14, 0x00, 0x00,\n+ 0x01, 0x7e, 0x00, 0x00, 0x00, 0x01, 0x00, 0x0b,\n+ 0x03, 0x00, 0x04, 0x00\n+ };\n \n tx(s, tpm_pcrread, sizeof(tpm_pcrread), buffer, sizeof(buffer));\n \n","prefixes":["v2","3/6"]}