{"id":2230157,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230157/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260429121129.21911-1-mdoucha@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429121129.21911-1-mdoucha@suse.cz>","date":"2026-04-29T12:11:27","name":"icmp_rate_limit01: Fix rate limit change on older kernels","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"aaa9d4fad7a4a97c672e351cc6c3ef66d57e0099","submitter":{"id":77472,"url":"http://patchwork.ozlabs.org/api/1.1/people/77472/?format=json","name":"Martin Doucha","email":"mdoucha@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260429121129.21911-1-mdoucha@suse.cz/mbox/","series":[{"id":502044,"url":"http://patchwork.ozlabs.org/api/1.1/series/502044/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=502044","date":"2026-04-29T12:11:27","name":"icmp_rate_limit01: Fix rate limit change on older kernels","version":1,"mbox":"http://patchwork.ozlabs.org/series/502044/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230157/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2230157/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=BRBHqQ2H;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=8iyHSwMM;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=CxZ0lSuV;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=wQE89eoW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5GPf43fKz1yHX\n\tfor ; Wed, 29 Apr 2026 22:11:50 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2F7A63E2D49\n\tfor ; Wed, 29 Apr 2026 14:11:48 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 1B3453CEE87\n for ; Wed, 29 Apr 2026 14:11:43 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 776D910009FF\n for ; Wed, 29 Apr 2026 14:11:43 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 688E46A88B\n for ; Wed, 29 Apr 2026 12:11:34 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FFD2593B0\n for ; Wed, 29 Apr 2026 12:11:34 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id pz4eF3b18WmdWgAAD6G6ig\n (envelope-from )\n for ; Wed, 29 Apr 2026 12:11:34 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777464698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=hHUcFZteYBs6F9jNOhPOkjNj9eRCuac0yDH9FYbqYvg=;\n b=BRBHqQ2H08uoGhi3LRfEaebi1CnA/3exRcFNNKPEYCxqvaLdna6KYmL0ND4qROO59cq0JL\n bvj4ag7G7l5jQ9D4SczHPMJnhWfDZbL+1q6iN1Aw2HG7/M2ioXfqnJ540HPFZsmQtr0Hb9\n eNW8XMaHSf10GuCO1ICb+jJ+AJ606tI=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777464698;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=hHUcFZteYBs6F9jNOhPOkjNj9eRCuac0yDH9FYbqYvg=;\n b=8iyHSwMMmEi01/rUfpOtRG+DS9PpswMQz/g6/o9EwRlk8zoq4z4e0wtp4ykDqAnwzse/k8\n 23XR1wkw5/JGmVAA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777464694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=hHUcFZteYBs6F9jNOhPOkjNj9eRCuac0yDH9FYbqYvg=;\n b=CxZ0lSuV/0B0Nyg+T2peOo5ILt34m3bnV5xMXsWLI2Tc6hW40EFzfkismpwC1+XrDmr8XS\n 9WFmJULz/4HqLw7xyky9FtBIIKVvxZnCRFgTDSjfE4ttWEI6W9JIRDrdePbzGOokehX7O/\n L0rMNuk3E8EX1QNgev1maeBeZqE0hmk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777464694;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=hHUcFZteYBs6F9jNOhPOkjNj9eRCuac0yDH9FYbqYvg=;\n b=wQE89eoWcGUl8TQZXHncHtSOPo0d6ROlRx9VH0v7k4KS24JHFdJpYHe4XKLkSVDyWZF6tH\n 4H6t8oZpN9yaxLCg=="],"From":"Martin Doucha ","To":"ltp@lists.linux.it","Date":"Wed, 29 Apr 2026 14:11:27 +0200","Message-ID":"<20260429121129.21911-1-mdoucha@suse.cz>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[];\n RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[];\n MIME_TRACE(0.00)[0:+];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:mid,suse.cz:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH] icmp_rate_limit01: Fix rate limit change on older\n kernels","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"The icmp_msgs_burst sysfile was added to non-root namespaces in kernel\nv6.12. Older kernels allow changing the value only from the root\nnamespace. Set the global limit first, then change the test namespace\nlimit as well if needed.\n\nFixes: 3c4c712f1f9b (\"cve: icmp_rate_limit: set icmp_msgs_burst within network namespace\")\nSigned-off-by: Martin Doucha \n---\n testcases/cve/icmp_rate_limit01.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/testcases/cve/icmp_rate_limit01.c b/testcases/cve/icmp_rate_limit01.c\nindex 5193c5dfd..37bc71cb8 100644\n--- a/testcases/cve/icmp_rate_limit01.c\n+++ b/testcases/cve/icmp_rate_limit01.c\n@@ -62,7 +62,12 @@ static void setup(void)\n \t/* Do NOT close this FD, or both interfaces will be destroyed */\n \tchildns = SAFE_OPEN(\"/proc/self/ns/net\", O_RDONLY);\n \n-\tSAFE_FILE_PRINTF(\"/proc/sys/net/ipv4/icmp_msgs_burst\", \"50\");\n+\t/*\n+\t * Set namespace local rate limit if needed. The global limit might\n+\t * be ignored otherwise.\n+\t */\n+\tif (!access(\"/proc/sys/net/ipv4/icmp_msgs_burst\", F_OK))\n+\t\tSAFE_FILE_PRINTF(\"/proc/sys/net/ipv4/icmp_msgs_burst\", \"50\");\n \n \t/* Configure child namespace */\n \tCREATE_VETH_PAIR(\"ltp_veth1\", \"ltp_veth2\");\n@@ -257,6 +262,7 @@ static struct tst_test test = {\n \t},\n \t.save_restore = (const struct tst_path_val[]) {\n \t\t{\"/proc/sys/user/max_user_namespaces\", \"1024\", TST_SR_SKIP},\n+\t\t{\"/proc/sys/net/ipv4/icmp_msgs_burst\", \"50\", TST_SR_TBROK},\n \t\t{}\n \t},\n \t.tags = (const struct tst_tag[]) {\n","prefixes":[]}