{"id":2230154,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230154/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260429114208.941011-2-holger.brunck@hitachienergy.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260429114208.941011-2-holger.brunck@hitachienergy.com>","date":"2026-04-29T11:42:08","name":"[2/2] net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"d7ea50e545d3038a5d5fff65ee5346a9aa1c6919","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/1.1/people/82682/?format=json","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260429114208.941011-2-holger.brunck@hitachienergy.com/mbox/","series":[{"id":502042,"url":"http://patchwork.ozlabs.org/api/1.1/series/502042/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502042","date":"2026-04-29T11:42:08","name":"[1/2] net: wan: fsl_ucc_hdlc: fix uhdlc_memclean","version":1,"mbox":"http://patchwork.ozlabs.org/series/502042/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230154/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2230154/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=nbjJap7m;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kz0kNcUS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20274-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=18.158.144.38","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=nbjJap7m;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kz0kNcUS;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5GDJ5zb9z1yHZ\n\tfor ; Wed, 29 Apr 2026 22:03:43 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g5GDG73ztz2ykf;\n\tWed, 29 Apr 2026 22:03:42 +1000 (AEST)","from out-ip0052.fra.mailhop.org (out-ip0052.fra.mailhop.org\n [18.158.144.38])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g5GDF0C6rz2yVL\n\tfor ; Wed, 29 Apr 2026 22:03:40 +1000 (AEST)","from HPG0000000548.corp.hitachi-powergrids.com (unknown\n [20.62.140.138])\n\tby outbound2.eu.mailhop.org (Halon) with ESMTPSA\n\tid 775d39e3-43c0-11f1-8259-bda8640e0fbb;\n\tWed, 29 Apr 2026 11:42:18 +0000 (UTC)","from gitsiv.hitachienergy.com (unknown [10.54.139.14])\n\tby HPG0000000548.corp.hitachi-powergrids.com (Postfix) with ESMTP id\n B5BD5158F;\n\tWed, 29 Apr 2026 11:42:13 +0000 (UTC)","from chbrn3-p-dev015.keymile.net (chbrn3-p-dev015.keymile.net\n [172.31.41.201])\n\tby gitsiv.hitachienergy.com (Postfix) with ESMTP id 412B6637F985;\n\tWed, 29 Apr 2026 13:42:13 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777464222;\n\tcv=none;\n b=kPSRL72lxl3svgCdBqxa9kBt+QeoDtBq72Yz5NcRtW/2z+2WSnnFOuAuTSVyNX9DkC3PHdLFZYpfeoCQfviKYAx8kNdssN3KFyrdA1xBKt3Njh2Tk6NPbPr4S+YRgBPEPrRQNN6I33Z+h7gZPVTCiI8qeEzZxmWe1SwSYcRuXpqRj0nbdi7EGd4zBq0jEi2lXI6ZHDFUVS2hMSY6knMSTC+HHM29f68GxD3A5hEiw13I6R9gLD4Pts2cuRbwhiUXbRdHMw9X/4VZolcnCFuCDf7v2VCoXWPSCuquoqzLy5b+C/Oh+6CiNqJXtO1DYtCEeETwk5aOB36xKnp0U3aYsQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777464222; c=relaxed/relaxed;\n\tbh=L8KWtdPE2JalTOCUmy3pa9Xkw2o8VCxZ9+OBKyymtC8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gWNlD+BO94KL3hs2wWIP+WmiXykvqLcPPJDHO715sYknIP5bpUZvsqy3F8D1Ug/MM6BVw8On8VOGgUNbP8AIIpw+U+yYBwc5NZWF+XjVIN79VUi38hXkvaO7dhkmc09a/zVJi9xNNpo/WxwiXqd/dd8IBB26+EH1amCK3e9jim9bhdMFRxHetCFtxB2ZJGwAqIvDSC3LpM6M0OiAv2kWuJGJr0NtEI8tGTW237EWXv0nTCFWLvZmxCwOjMD4ZX9QQ26EFrnOkc00i0VJwaddk7NLdv1V8fRBGxTxfGdvp24CX6uctpr3VsA2o+NoVGh86k+ywAFSdPP30skE+Chw4Q==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=nbjJap7m;\n dkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=kz0kNcUS; dkim-atps=neutral;\n spf=pass (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=hitachienergy.com; s=duo-1630306886989-947ac67a;\n\th=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date:\n\t subject:cc:to:from:cfbl-address:cfbl-feedback-id:from;\n\tbh=L8KWtdPE2JalTOCUmy3pa9Xkw2o8VCxZ9+OBKyymtC8=;\n\tb=nbjJap7m4j+Q0FUNBANh6VVe0R4X9CyL6DCL+sPk56ESQkFgkesFRIgye4Ieu7EYfKKxYW75BUrdA\n\t mEmxyP5vukeMYPybFAIN7bWTGw+kXPcfKGRlcAhvcVCRwxL41FyrMPT/6hW7qHfRx7M6kpJIv5lROZ\n\t kq+Rq+MfrZEMiRAs=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=outbound.mailhop.org; s=dkim-high;\n\th=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date:\n\t subject:cc:to:from:cfbl-address:cfbl-feedback-id:from;\n\tbh=L8KWtdPE2JalTOCUmy3pa9Xkw2o8VCxZ9+OBKyymtC8=;\n\tb=kz0kNcUSsI5Tw/+Ld9hqOOdF9Ofo8XOWhFJif8qT4Dlkuzfp+aLKoqNuSQWr+2P5FhoZ6gvB++f32\n\t vxl93SUyHWlWONKGI5tQOcxQWWuO3wXW3wfVQORUz9ix6KKIsIubIMhsSCWcs1LdQ/OSbES+C0t0oL\n\t 9sDT5XjRKUe2gL7cgGuG62cyG5ez1yQhGJ4U+Qk1GZQxeAvlfV4g8MARvXYAZHfdJYIkqCFCldX9eH\n\t 57EXfLAY8AtvBD6wAl9BPw8W5aRHg0wzdpgemfxF6j/hbLFIRJLBJrUm1jMWXL2g0zxRgYoOF8BSy6\n\t TShXpOqYP5hBwnD4QEpl2dLekM93jlw=="],"X-Originating-IP":"20.62.140.138","X-MHO-RoutePath":"aGVkY3NtdHA=","X-MHO-User":"775d39e3-43c0-11f1-8259-bda8640e0fbb","X-Report-Abuse-To":"\n https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information","X-Mail-Handler":"DuoCircle Outbound SMTP","CFBL-Feedback-ID":"775d39e3-43c0-11f1-8259-bda8640e0fbb:5","CFBL-Address":"prvs=057955d709=abuse@outbound.mailhop.org; report=arf","From":"Holger Brunck ","To":"netdev@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org","Cc":"andrew+netdev@lunn.ch,\n\tchleroy@kernel.org,\n\tqiang.zhao@nxp.com,\n\tHolger Brunck ","Subject":"[PATCH 2/2] net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove","Date":"Wed, 29 Apr 2026 13:42:08 +0200","Message-ID":"<20260429114208.941011-2-holger.brunck@hitachienergy.com>","X-Mailer":"git-send-email 2.52.0.120.gb31ab939fe","In-Reply-To":"<20260429114208.941011-1-holger.brunck@hitachienergy.com>","References":"<20260429114208.941011-1-holger.brunck@hitachienergy.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"If the driver is used in a non tdm mode priv->utdm is a NULL pointer.\nTherefore we need to check this pointer first before checking si_regs.\n\nSigned-off-by: Holger Brunck \n---\n drivers/net/wan/fsl_ucc_hdlc.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex 8155e92af14e..15bfb78381d4 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -1250,12 +1250,12 @@ static void ucc_hdlc_remove(struct platform_device *pdev)\n \n \tuhdlc_memclean(priv);\n \n-\tif (priv->utdm->si_regs) {\n+\tif (priv->utdm && priv->utdm->si_regs) {\n \t\tiounmap(priv->utdm->si_regs);\n \t\tpriv->utdm->si_regs = NULL;\n \t}\n \n-\tif (priv->utdm->siram) {\n+\tif (priv->utdm && priv->utdm->siram) {\n \t\tiounmap(priv->utdm->siram);\n \t\tpriv->utdm->siram = NULL;\n \t}\n","prefixes":["2/2"]}