{"id":2230092,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230092/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260429-k1-i2c-ilcr-v6-2-1c7a5a5a8b24@linux.spacemit.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.1/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429-k1-i2c-ilcr-v6-2-1c7a5a5a8b24@linux.spacemit.com>","date":"2026-04-29T07:48:57","name":"[v6,2/2] i2c: spacemit: drop warning when clock-frequency property is absent","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"00ff63cef9f953a79f8d00870ff72096051662d9","submitter":{"id":91240,"url":"http://patchwork.ozlabs.org/api/1.1/people/91240/?format=json","name":"Troy Mitchell","email":"troy.mitchell@linux.spacemit.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260429-k1-i2c-ilcr-v6-2-1c7a5a5a8b24@linux.spacemit.com/mbox/","series":[{"id":502010,"url":"http://patchwork.ozlabs.org/api/1.1/series/502010/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=502010","date":"2026-04-29T07:48:57","name":"i2c: spacemit: improve clock handling and cleanups","version":6,"mbox":"http://patchwork.ozlabs.org/series/502010/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230092/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230092/checks/","tags":{},"headers":{"Return-Path":"\n <linux-i2c+bounces-17198-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.spacemit.com header.i=@linux.spacemit.com\n header.a=rsa-sha256 header.s=mxsw2412 header.b=MhMe4Uf7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17198-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=\"MhMe4Uf7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=54.243.244.52","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com","smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=linux.spacemit.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g58bg1sJzz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 17:50:07 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 85B693004DD3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 07:50:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B38E43A6B9A;\n\tWed, 29 Apr 2026 07:50:02 +0000 (UTC)","from smtpbguseast3.qq.com (smtpbguseast3.qq.com [54.243.244.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 014DB3921C6;\n\tWed, 29 Apr 2026 07:49:59 +0000 (UTC)","from = ( [120.237.158.181])\n\tby bizesmtp.qq.com (ESMTP) with\n\tid ; Wed, 29 Apr 2026 15:49:04 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777449002; cv=none;\n b=S+Ved8uN4wDuiMEnip6JfizqLtXAvUx/0Drg1372aPv7TxtkQp2tYVCtamr8Xn4IaMJU3HJHhyrWFovZNUh1EJqGmeXle5AxPhICzwc68aq9n80ZbIubz0E/FtE2LXA89+ZmKJBTKpj0YnuqzxprJ7WFerB0nZv70QmbgUqbwOM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777449002; c=relaxed/simple;\n\tbh=mCQayAr9RouaadceLxaNioH49sLgj8dEFAMiyWvUNLc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=sA8PRcZh+hd2HajFp+S21T0ayXD2a0XVA/PRrRUAPX9MpGDEXXoEmjfimuq+7xhvDRoOcWYjrrJQbFeKKbAyjd9veJATGJ11bGuyc5FlZBAFzum6W9PsvcoA+Hr6GLZyYlhqOBbd+rXhya+8qXpcvwQP3SFxeoc6dsn1V9etw14=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com;\n spf=none smtp.mailfrom=linux.spacemit.com;\n dkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=MhMe4Uf7;\n arc=none smtp.client-ip=54.243.244.52","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com;\n\ts=mxsw2412; t=1777448952;\n\tbh=/XBLU/2EPMf5LiPhya2jhRX0WZEvv8umzim0o1th8vo=;\n\th=From:Date:Subject:MIME-Version:Message-Id:To;\n\tb=MhMe4Uf7IiKX9v0zyN3tM8f9+7jaUaWsUJeOlgy0fMdHYxucpaqtw7T6iMvHx0RTL\n\t Ujz3UK5PbjQMDMjv4e2bdECMAqlib/z0QGzuOrsZhBX78kD4q8VKGzkk791hbTW9bj\n\t D8IU6VO134Gml0d53I2GWbJp8bS5bKcQmrEDqqfQ=","X-QQ-mid":"zesmtpgz9t1777448946t7992dc9f","X-QQ-Originating-IP":"NIGDpNr5nns6isGhGyKxzyKT90BztXn9N5xiG1xN5EI=","X-QQ-SSF":"0000000000000000000000000000000","X-QQ-GoodBg":"0","X-BIZMAIL-ID":"14935581430065835113","EX-QQ-RecipientCnt":"8","From":"Troy Mitchell <troy.mitchell@linux.spacemit.com>","Date":"Wed, 29 Apr 2026 15:48:57 +0800","Subject":"[PATCH v6 2/2] i2c: spacemit: drop warning when clock-frequency\n property is absent","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260429-k1-i2c-ilcr-v6-2-1c7a5a5a8b24@linux.spacemit.com>","References":"<20260429-k1-i2c-ilcr-v6-0-1c7a5a5a8b24@linux.spacemit.com>","In-Reply-To":"<20260429-k1-i2c-ilcr-v6-0-1c7a5a5a8b24@linux.spacemit.com>","To":"Andi Shyti <andi.shyti@kernel.org>, Alex Elder <elder@riscstar.com>,\n Yixun Lan <dlan@kernel.org>, Yixun Lan <dlan@kernel.org>","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n Troy Mitchell <troy.mitchell@linux.spacemit.com>","X-Mailer":"b4 0.15.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1777448937; l=1770;\n i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id;\n bh=mCQayAr9RouaadceLxaNioH49sLgj8dEFAMiyWvUNLc=;\n b=6XoYLdtoh1REnJ/XnCtZ6jKyFHHng6mH2yjpbp0UYn/RazkzBbdN44yZKhVE2FeyR4yjwF7nl\n /emkxihAbwJAmIItQvo+5FUsweTpM3PjXyvopUvvbfYjrGin1xHSCnt","X-Developer-Key":"i=troy.mitchell@linux.spacemit.com; a=ed25519;\n pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc=","X-QQ-SENDSIZE":"520","Feedback-ID":"zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0","X-QQ-XMAILINFO":"MeriHi1OVszfSpOBSOeiYDAaFgQrWVj3qNROv/xAg8aYIb/pKXdlZShN\n\tNX4AP3Plx+MZx0MHfr30AVBKVeOMOxcfkB8VuGmwBo5FOi2vJ5ifPodPM/e96gE+82sCq/v\n\tV6yQy7lullCr0HSbB2XjXCkkncy9ZQQqVSySoIEo+3bBXuB6IzT7mTZ7zxB5XNaThG08Z4K\n\thr+BRHhGdxWTTUdJ8MhZN9ui79V0F/o8RTQgssQFIcmHyH1ma85jv/PzpZOpeuSOzyUw71y\n\th2zSOs7ftTyRp3VGJTPyf8ZgHAk5nkvrHntO/2f9pTIARBJyjvvz+xd3+gDCRKcFcyKv+f+\n\tacL7Vzl3ACbWa20300jLi1R2SxMHT2KV4Cyn7CKNgpEPzEtvkaw2SixY/ViZ7svLPANAYL/\n\t6RhtEmmBasAbvAnzN12YD9Pg7eppqLdqLz+3mBVmGOwOKFcOtoqcXSqUJosmhafD6Ttwgnm\n\tcaMbSV32bhH4+0iIYlUDZm0HCCYFw2Ln7MigmU2uQVuvlzDWOhcxZ2bxLoxh3BcUD3xLCT4\n\t8Rmgp6Gnsfzxx/bgDiFuhthabQG9z/GD6wiQ1aXRHjfH0/MezF5XwudD+6qUou/kzOB7Olo\n\tO7MRYIrpSiugSAAsiE4zob9JoO18b/yqKORhbplgGNDmRh+EfrZEOanGEOI3gcVTSoys2KV\n\tkRW9hi3IBFCoZtIBgLagKHBjG12ZfkDXSooPuSpFxx6J+dXp+LSuGEtJWfN6mggwHAEHXa6\n\tt1kr1msaTHOO8eBQo94zznNJK10UF3JbOW0B7ArReb4ADnjociR4KA4NYeqx4vv6YtTIgh6\n\tDlNWq1djZh3kRBF1QkaSa75tvl/5hDlksC5HCWMQB5ZXLXte2sR+JR/s7vkNEFDxgHcSG3x\n\tJR716LO0ElioYRJ9/rZI13+xmrDX0EBGr2xg+aCFOalnZG9g4js8zI22ioIS65H4i10MzTt\n\tHy8fcuaU5QbTpwxUHl4iUi0aWpvrd4xAmTyqUFHnxWIjq0cp7KDFy+NF/gbMbYVw8bmjxcL\n\ttuyPuYXnaEtjpjdsWwqhZVVj8LtbHwEf8ekvZzoDfm+v3wOggT322EprzJNFR7SJBN4s7ag\n\tfokI1rQjZQpqUOfa0NDuEqfmpznq4KP7TO3s/Ow611iZ2labTwuw40=","X-QQ-XMRINFO":"Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg==","X-QQ-RECHKSPAM":"0"},"content":"The clock-frequency property is optional according to the DT binding.\nDo not emit a warning when the property is missing and fall back to the\ndefault frequency instead.\n\nSigned-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>\n---\nChangelog in v6:\n- drop Fixes tag per maintainer feedback (this is not a bug fix)\n- change dev_warn to dev_info when clock-frequency is absent (it is optional)\n- Link to v5: https://lore.kernel.org/r/20251226-k1-i2c-ilcr-v5-0-b5807b7dd0e6@linux.spacemit.com\n---\n drivers/i2c/busses/i2c-k1.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c\nindex fad6a20bb43d..8b0a215dfb29 100644\n--- a/drivers/i2c/busses/i2c-k1.c\n+++ b/drivers/i2c/busses/i2c-k1.c\n@@ -823,9 +823,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)\n \tif (!i2c)\n \t\treturn -ENOMEM;\n \n-\tret = of_property_read_u32(of_node, \"clock-frequency\", &i2c->clock_freq);\n-\tif (ret && ret != -EINVAL)\n-\t\tdev_warn(dev, \"failed to read clock-frequency property: %d\\n\", ret);\n+\tof_property_read_u32(of_node, \"clock-frequency\", &i2c->clock_freq);\n \n \t/* For now, this driver doesn't support high-speed. */\n \tif (i2c->clock_freq > SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ &&\n@@ -834,7 +832,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)\n \t} else if (i2c->clock_freq && i2c->clock_freq <= SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ) {\n \t\ti2c->mode = SPACEMIT_MODE_STANDARD;\n \t} else {\n-\t\tdev_warn(i2c->dev, \"invalid clock-frequency, fallback to fast mode\");\n+\t\tdev_info(dev, \"clock-frequency not set or out of range, using fast mode\\n\");\n \t\ti2c->mode = SPACEMIT_MODE_FAST;\n \t\ti2c->clock_freq = SPACEMIT_I2C_MAX_FAST_MODE_FREQ;\n \t}\n","prefixes":["v6","2/2"]}