{"id":2230082,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230082/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260429074356.118420-8-herve.codina@bootlin.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429074356.118420-8-herve.codina@bootlin.com>","date":"2026-04-29T07:43:43","name":"[v2,07/17] ASoC: simple-amplifier: Use 'simple_amp' variable name instead of 'priv'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"67be4c278e1478c9833c85950fe14b7ce4a981ec","submitter":{"id":81983,"url":"http://patchwork.ozlabs.org/api/1.1/people/81983/?format=json","name":"Herve Codina","email":"herve.codina@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260429074356.118420-8-herve.codina@bootlin.com/mbox/","series":[{"id":502009,"url":"http://patchwork.ozlabs.org/api/1.1/series/502009/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502009","date":"2026-04-29T07:43:41","name":"ASoC: Add support for GPIOs driven amplifiers","version":2,"mbox":"http://patchwork.ozlabs.org/series/502009/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230082/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230082/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=OMPRdntW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35764-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"OMPRdntW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.246.85.4","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g58XD30cvz1yHv\n\tfor ; Wed, 29 Apr 2026 17:47:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 92054306B110\n\tfor ; Wed, 29 Apr 2026 07:45:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1A06E3AE718;\n\tWed, 29 Apr 2026 07:44:34 +0000 (UTC)","from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 28E793ACA57;\n\tWed, 29 Apr 2026 07:44:32 +0000 (UTC)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id D11A84E42B68;\n\tWed, 29 Apr 2026 07:44:28 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 9F346601DF;\n\tWed, 29 Apr 2026 07:44:28 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id D7E0C1072989C;\n\tWed, 29 Apr 2026 09:44:25 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777448673; cv=none;\n b=lwY46c0ss0R52ujKfI+iaSo8jexiOkmvKuxS8gsYSrmEq6vcbPGsrlBhr6Qbb8F2sFOalQpQFoSAOLRQkpY32inUw3sTGCaDYU0EGOTKAL6grMIk8Zsm/3sEHAH+4neBAB/4dNQZKl97l86m9qwLVt2tJOP0/KD/0eeF+L+KrBg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777448673; c=relaxed/simple;\n\tbh=ocoaZh1cfN3aM3Ass44A1Z0c1a33deHhsbOrm3iYaRw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=RTBcs/G+2wmsSMUjinZy4uXJFBnGFkcASe8LOYQjw2KsuUjsOjCIRxA+1jEWfWVYoFkA3vRk7OCUT8bKQFre+aHT5Es4MMqXD6ZX13/HKEorA/CwTgNtt1HQCLozZVYWgh33LYbA1LlOpEUDz70QJamUai+fNv03g8+dDXGJT8A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=OMPRdntW; arc=none smtp.client-ip=185.246.85.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777448667; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=ZItBdljHzkyosd2r0ODxJgNw6WPrkERIedKn/xuhEJA=;\n\tb=OMPRdntWiyAyoWbGzCBhPmxo+OOwTGzKBUAHyCLhOfiG4Z9hiZOOmcGfYIv0spjdLyfxl8\n\twBUaQeDTKsQGblyVw46Q9hs2H3xsQtCcGoDxjvh/xJTDWJn6Tx2/H2++eo5pRq096mDqJ6\n\tpPPALyVi6nxjsl+DApW4K5TLbACqLlQUcbbzyH1E0Y+srlTnbuV/sTlsDEAmyodbHFtNna\n\tttLkvVbsETBtME7+1i9Ez7DR899CfNi8tti1I1mRp5Uk3PuAU1Qllzxt0mZFXPQmsvZ7aU\n\tk3Zql/ut6gHhsg3TzLRtnoFAlRXce1nq5Xj4yd6+KpOz/j1crUxqreBdbGzOHA==","From":"Herve Codina ","To":"Herve Codina ,\n\tBartosz Golaszewski ,\n\tLinus Walleij ,\n\tLiam Girdwood ,\n\tMark Brown ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley ,\n\tSaravana Kannan ,\n\tJaroslav Kysela ,\n\tTakashi Iwai ","Cc":"linux-sound@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tChristophe Leroy ,\n\tThomas Petazzoni ","Subject":"[PATCH v2 07/17] ASoC: simple-amplifier: Use 'simple_amp' variable\n name instead of 'priv'","Date":"Wed, 29 Apr 2026 09:43:43 +0200","Message-ID":"<20260429074356.118420-8-herve.codina@bootlin.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260429074356.118420-1-herve.codina@bootlin.com>","References":"<20260429074356.118420-1-herve.codina@bootlin.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3"},"content":"The simple-amplifier driver use 'priv' as variable name for its private\ndata (struct simple_amp).\n\nWith the support for gpio-audio-amp, more functions and data\nstructures will be added.\n\nThose future additions will add more complexity in data manipulation and\nwill make the 'priv' term error prone.\n\nIn order to clearly identify the struct simple_amp private data, use\n'simple_amp' as variable name when this structure is involved.\n\nSigned-off-by: Herve Codina \n---\n sound/soc/codecs/simple-amplifier.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/sound/soc/codecs/simple-amplifier.c b/sound/soc/codecs/simple-amplifier.c\nindex 8f2daec55134..231e84ab4c0e 100644\n--- a/sound/soc/codecs/simple-amplifier.c\n+++ b/sound/soc/codecs/simple-amplifier.c\n@@ -19,7 +19,7 @@ static int simple_amp_power_event(struct snd_soc_dapm_widget *w,\n \t\t\t\t struct snd_kcontrol *control, int event)\n {\n \tstruct snd_soc_component *c = snd_soc_dapm_to_component(w->dapm);\n-\tstruct simple_amp *priv = snd_soc_component_get_drvdata(c);\n+\tstruct simple_amp *simple_amp = snd_soc_component_get_drvdata(c);\n \tint val;\n \n \tswitch (event) {\n@@ -34,7 +34,7 @@ static int simple_amp_power_event(struct snd_soc_dapm_widget *w,\n \t\treturn -EINVAL;\n \t}\n \n-\tgpiod_set_value_cansleep(priv->gpiod_enable, val);\n+\tgpiod_set_value_cansleep(simple_amp->gpiod_enable, val);\n \n \treturn 0;\n }\n@@ -68,17 +68,17 @@ static const struct snd_soc_component_driver simple_amp_component_driver = {\n static int simple_amp_probe(struct platform_device *pdev)\n {\n \tstruct device *dev = &pdev->dev;\n-\tstruct simple_amp *priv;\n+\tstruct simple_amp *simple_amp;\n \n-\tpriv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);\n-\tif (priv == NULL)\n+\tsimple_amp = devm_kzalloc(dev, sizeof(*simple_amp), GFP_KERNEL);\n+\tif (!simple_amp)\n \t\treturn -ENOMEM;\n-\tplatform_set_drvdata(pdev, priv);\n+\tplatform_set_drvdata(pdev, simple_amp);\n \n-\tpriv->gpiod_enable = devm_gpiod_get_optional(dev, \"enable\",\n-\t\t\t\t\t\t GPIOD_OUT_LOW);\n-\tif (IS_ERR(priv->gpiod_enable))\n-\t\treturn dev_err_probe(dev, PTR_ERR(priv->gpiod_enable),\n+\tsimple_amp->gpiod_enable = devm_gpiod_get_optional(dev, \"enable\",\n+\t\t\t\t\t\t\t GPIOD_OUT_LOW);\n+\tif (IS_ERR(simple_amp->gpiod_enable))\n+\t\treturn dev_err_probe(dev, PTR_ERR(simple_amp->gpiod_enable),\n \t\t\t\t \"Failed to get 'enable' gpio\");\n \n \treturn devm_snd_soc_register_component(dev,\n","prefixes":["v2","07/17"]}