{"id":2230071,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230071/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429065127.423949-2-vincent.chen@sifive.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429065127.423949-2-vincent.chen@sifive.com>","date":"2026-04-29T06:51:26","name":"[1/2] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94bade98597a44f5fae06889e175902428ede6f4","submitter":{"id":79516,"url":"http://patchwork.ozlabs.org/api/1.1/people/79516/?format=json","name":"Vincent Chen","email":"vincent.chen@sifive.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429065127.423949-2-vincent.chen@sifive.com/mbox/","series":[{"id":502002,"url":"http://patchwork.ozlabs.org/api/1.1/series/502002/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502002","date":"2026-04-29T06:51:25","name":"ice: fix VF creation when !CONFIG_ICE_SWITCHDEV","version":1,"mbox":"http://patchwork.ozlabs.org/series/502002/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230071/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230071/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gtcTl28f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g57Jc74Dwz1yK5\n\tfor ; Wed, 29 Apr 2026 16:52:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8D1BE420A5;\n\tWed, 29 Apr 2026 06:51:54 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id atd28xo-L3sS; Wed, 29 Apr 2026 06:51:53 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1535E420A1;\n\tWed, 29 Apr 2026 06:51:53 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 3A44123D\n for ; Wed, 29 Apr 2026 06:51:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 2BF79840AB\n for ; Wed, 29 Apr 2026 06:51:52 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id TCOdusFvEJv6 for ;\n Wed, 29 Apr 2026 06:51:51 +0000 (UTC)","from mail-pg1-x529.google.com (mail-pg1-x529.google.com\n [IPv6:2607:f8b0:4864:20::529])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 8ED6183FC7\n for ; Wed, 29 Apr 2026 06:51:51 +0000 (UTC)","by mail-pg1-x529.google.com with SMTP id\n 41be03b00d2f7-c76c60c7502so229317a12.0\n for ; Tue, 28 Apr 2026 23:51:51 -0700 (PDT)","from Vincent-X1Extreme-TW.internal.sifive.com ([136.226.240.187])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b98895afaesm15038105ad.57.2026.04.28.23.51.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 23:51:50 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1535E420A1","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8ED6183FC7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777445513;\n\tbh=HJR0wUneST2OobSctcgeuLs6bttBTQJPSlbTZVLMlC8=;\n\th=To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From:Reply-To:From;\n\tb=gtcTl28fIcs5HAkHkokc7PGxJBhSJbxeqPHZmrKNP+ZgD8TOOFVNErf055CmHHZgz\n\t keAjb1vZeTXL3hN6zxALD/EVgvCUj2OMF3HextKvVD2WToxDhE3ixYdMBvuJI0yBpL\n\t aQXEi2TqF8Ec9/MFUDIsy4xRwLAswXIqwHG5NmWf2bIkPKjRdGx5v39aSt39rK8sMM\n\t QsFWDKK9QK+POH+eUOMgzZu60e6vm3kFGp46qwRYan+S9/b1PVhMy4njTZ+1A9Bhub\n\t iYmWgROpgRdaYp4S/ucscRpGtvgmJWvasa1AXMCyKtIIFChz5A5YDWNgVbnm5SKHAK\n\t vOqTSHKKzaiWQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::529; helo=mail-pg1-x529.google.com;\n envelope-from=vincent.chen@sifive.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8ED6183FC7","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777445511; x=1778050311;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HJR0wUneST2OobSctcgeuLs6bttBTQJPSlbTZVLMlC8=;\n b=BJoaicHfqkCHQmLjF1iI0MN1E9s8m9PY3xmZl/ZwwjaqWr4zLuwtDFu5sUMOsTG1fd\n UAyJ2pe+bY1eZn7NgIZOlN04ABthiua2l/ABew7ibpZQvp4YJb1LxbdDb1rISDgBthZ8\n JbPfEPH8vRsv14UrKiuMxnwg1vAbTxLqYu0scQ+MulY8btPjhcdDIzouLs5uySfCl2Le\n ADwyHNCL1gWUenfAyNniKxqpVEPva5R6LlmAELQJ2WTf7/5Oeo1R85EeaawPB7XAhOVM\n 1V7lNP8qbUf7uz2WPOLf6t7TfETwyT1LEUWPJ2NtnDwv+kOyXlyRE/nBB2zqkSc/NU7d\n aYpA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Zb++VL+9lgU1J/iEJZVizccW8Uyqma9JsqMpvEH3mpJDbFwjGMIjZCZK7Dc7g/IKlDUB8IcPsWLBNFSufjAo=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YyREju2+RkjrMsTfk7c3EgsTdtNqJhN/wPIkyLY1hb5X2m/Pctj\n XA9QyzRR7civXSuVES0EevqI2Fbgbg0UQptP2s7/WDyVpDHjFN5a7qftVQx9WyPs7hQ=","X-Gm-Gg":"AeBDies3lftEHzLsyRIt33EbKol6RGpvsGFAaMhTKlkmjgX7rwhvqXRcPCNB2jdfEfC\n Ig+GS0eKYl6Scb6KE9w4IF0BGclhPlRnkYkQr4r9ti2IdgshdOm/Cm6AJ2aBY3oZZpPJryaMZHW\n sJEHiGAao0xmz3IXqsfdHe0Ig4vkHKdcxn8PsWUGOBOoASJe7Aseie6sNS28Fgxn0taTeSokxgh\n rcwKEmqjsjQBVPHgvq1EYamw+gcekqNnvQwLQTl/busZDdPyjmONHhGjHOW787lK9MNFUt7Chjb\n xCTt2kMwGlUmSM2u3bPDekWKJ51JZK/SO4InRUJL201PlsbOWeYinj4hqrYx6Vx/wTAKk3LaBB5\n 8U60nG7abafatzsm8RY+qwGXk6CM4mhYfaYuASvP7ltB4ZBZrx/yH2CxVT7aZFQEOZG7B8pXPRH\n 7FZwNykDFdUW9sRpvo4pJST9pUOL9fnT3snCatnm8Ub3rO/fycE+X8z0ko/5YyFdk/19hDszebf\n zlVKw==","X-Received":"by 2002:a17:902:f652:b0:2b2:53f5:461f with SMTP id\n d9443c01a7336-2b98825bdb5mr18430485ad.25.1777445510644;\n Tue, 28 Apr 2026 23:51:50 -0700 (PDT)","To":"anthony.l.nguyen@intel.com,\n\tprzemyslaw.kitszel@intel.com","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, vincent.chen@sifive.com","Date":"Wed, 29 Apr 2026 14:51:26 +0800","Message-Id":"<20260429065127.423949-2-vincent.chen@sifive.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260429065127.423949-1-vincent.chen@sifive.com>","References":"<20260429065127.423949-1-vincent.chen@sifive.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sifive.com; s=google; t=1777445511; x=1778050311; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HJR0wUneST2OobSctcgeuLs6bttBTQJPSlbTZVLMlC8=;\n b=INlLIkhD5AMQZvHMwfvmgYDLMZX11OB8DitbAs5lJGxbXhvtn+bk0Uv1wFbZsLtOXY\n DeTql2zLjOrfsaPVEUGuYczEsQu90apstZAFdAdjP8Hn747c26aaAbcoFo/uasRnE6jN\n ip5mLrYSVdfnfi5jck1KybOjFhVkwK0r9ZGK8gu1VGTtGqNMPBnFj4wEJsUMyaTjwF48\n hUCXkJdrMlS6BX+ZITVCKETdUN8wAw1bplG82r8S4NsaA+t1pj9ejcoy1yQonYRlCjQ7\n O5Az23KwAOuUD3bjKFviAlQ5gRKuAkTtoKfWGuaUonc8VtahdOTHUghj2dRA/usSBoHa\n WdBg==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=sifive.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com\n header.a=rsa-sha256 header.s=google header.b=INlLIkhD"],"Subject":"[Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when\n !CONFIG_ICE_SWITCHDEV","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Vincent Chen via Intel-wired-lan ","Reply-To":"Vincent Chen ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Currently ice_eswitch_attach_vf() is called unconditionally in\nice_start_vfs(), which causes VF creation to fail when CONFIG_ICE_SWITCHDEV\nis not defined.\n\nFix this by adding switchdev mode checks at the call sites before\ncalling ice_eswitch_attach_vf(), consistent with how\nice_eswitch_attach_sf() is already handled in ice_devlink_port_new().\nThis is similar to commit aacca7a83b97 (\"ice: allow creating VFs for\n!CONFIG_NET_SWITCHDEV\") which fixed the same issue for the previous\nice_eswitch_configure() API.\n\nSigned-off-by: Vincent Chen \n---\n drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------\n drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++-\n 2 files changed, 10 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c b/drivers/net/ethernet/intel/ice/ice_sriov.c\nindex 843e82fd3bf9..6a0b724e46f9 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n@@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf)\n \t\t\tgoto teardown;\n \t\t}\n \n-\t\tretval = ice_eswitch_attach_vf(pf, vf);\n-\t\tif (retval) {\n-\t\t\tdev_err(ice_pf_to_dev(pf), \"Failed to attach VF %d to eswitch, error %d\",\n-\t\t\t\tvf->vf_id, retval);\n-\t\t\tice_vf_vsi_release(vf);\n-\t\t\tgoto teardown;\n+\t\tif (ice_is_eswitch_mode_switchdev(pf)) {\n+\t\t\tretval = ice_eswitch_attach_vf(pf, vf);\n+\t\t\tif (retval) {\n+\t\t\t\tdev_err(ice_pf_to_dev(pf), \"Failed to attach VF %d to eswitch, error %d\",\n+\t\t\t\t\tvf->vf_id, retval);\n+\t\t\t\tice_vf_vsi_release(vf);\n+\t\t\t\tgoto teardown;\n+\t\t\t}\n \t\t}\n \n \t\tset_bit(ICE_VF_STATE_INIT, vf->vf_states);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\nindex de9e81ccee66..71595410174c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n@@ -807,7 +807,8 @@ void ice_reset_all_vfs(struct ice_pf *pf)\n \t\tice_vf_rebuild_vsi(vf);\n \t\tice_vf_post_vsi_rebuild(vf);\n \n-\t\tice_eswitch_attach_vf(pf, vf);\n+\t\tif (ice_is_eswitch_mode_switchdev(pf))\n+\t\t\tice_eswitch_attach_vf(pf, vf);\n \n \t\tmutex_unlock(&vf->cfg_lock);\n \t}\n","prefixes":["1/2"]}