{"id":2230070,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230070/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429065127.423949-3-vincent.chen@sifive.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429065127.423949-3-vincent.chen@sifive.com>","date":"2026-04-29T06:51:27","name":"[2/2] ice: remove redundant switchdev check in ice_eswitch_attach_vf()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af2d833f8f2dc4e09119d18c015ce0d13ee91e39","submitter":{"id":79516,"url":"http://patchwork.ozlabs.org/api/1.1/people/79516/?format=json","name":"Vincent Chen","email":"vincent.chen@sifive.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429065127.423949-3-vincent.chen@sifive.com/mbox/","series":[{"id":502002,"url":"http://patchwork.ozlabs.org/api/1.1/series/502002/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502002","date":"2026-04-29T06:51:25","name":"ice: fix VF creation when !CONFIG_ICE_SWITCHDEV","version":1,"mbox":"http://patchwork.ozlabs.org/series/502002/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230070/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230070/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=u5YVCSxM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g57Jc380Pz1xqf\n\tfor ; Wed, 29 Apr 2026 16:52:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 846B6840CE;\n\tWed, 29 Apr 2026 06:51:58 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tWnkeRIXAFgF; Wed, 29 Apr 2026 06:51:56 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id A0116840AB;\n\tWed, 29 Apr 2026 06:51:56 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3EF8F1B8\n for ; Wed, 29 Apr 2026 06:51:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 240B7420A2\n for ; Wed, 29 Apr 2026 06:51:55 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tFL7xBwauu3X for ;\n Wed, 29 Apr 2026 06:51:54 +0000 (UTC)","from mail-pl1-x632.google.com (mail-pl1-x632.google.com\n [IPv6:2607:f8b0:4864:20::632])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 804BB420A3\n for ; Wed, 29 Apr 2026 06:51:54 +0000 (UTC)","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2b23fcf90b2so116826795ad.3\n for ; Tue, 28 Apr 2026 23:51:54 -0700 (PDT)","from Vincent-X1Extreme-TW.internal.sifive.com ([136.226.240.187])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b98895afaesm15038105ad.57.2026.04.28.23.51.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 23:51:53 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org A0116840AB","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 804BB420A3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777445516;\n\tbh=jUnzqF1b0jZfPUvpn/ylBvB7W/64BC9cpo6hVx+ffvE=;\n\th=To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From:Reply-To:From;\n\tb=u5YVCSxMR3BAWtE56TuS8ac1BGvgWrSaBzQ4pVkWs10He82Lti0SenfLCQcq2zzjb\n\t y6GStGFyh2BxrZtFk+dRSpPTrEPxPHy4xFHfq5yaCndjXLZL7tI/5oP9sCzd240oTc\n\t zvH1PIs1H0TDa4ighILYpcGf2PIaVFEyvJzRPaBx0pkMgk/08Zzh62C/82+Zv8uAe0\n\t xmcD/Cz5SxcJKxsweWr41LiZINeGVtg4RgA63QKvp844gLiFnbahsSzio9BdEx2N39\n\t tnzyxbjbo2tc8XRDsLwOGSiGdiPe3cLoClhC6oeiqcNU7a/8QQz+4Y3F7KeKOz2mb2\n\t m7dVqx8B4wsCw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::632; helo=mail-pl1-x632.google.com;\n envelope-from=vincent.chen@sifive.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 804BB420A3","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777445514; x=1778050314;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jUnzqF1b0jZfPUvpn/ylBvB7W/64BC9cpo6hVx+ffvE=;\n b=MwRjGYURiTjNpfvjyUpWpa3hNiTueJ4O4cUpFKxum8S8V7vObN8k7XFJXUyFe7f7dC\n 8LJi7hKOwK0zteiYRV5XZZYBUQr4FIhBb6XSvNuncopWaXqNmqB+17+4VzyrlbjeAVmy\n cwvGELMnDwBbd/1uip76uOgDdpWW4+YKoESBtGajnYZx9VtLE3cUJ5NU8PjFQeudOHt6\n EecflDGSTitbV8G+Ra0Pyz7AcrghwyxoyErZnbb8N1cSrxfpKNZAgHkorMAGlZKjT35r\n cu3esp8eF3B46sqyhJmp0NPkuHKOihmivR+gwrGVu4KXY420gm5tWkYLDusnuQE/1S1n\n seNA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Oz7iqMbYLbIQSVpK2SMCX6l4JAKQ5q2cDP2qOyVAW6GCaC/Q1vvXiP4pntrigSpgBDvklonog19xp1GEGpu4=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YxjUeiWuibptSfKldeeJkOKJNSKp7RxaoQBcnxdhVHL/qI/FKHp\n u8ZubTpASoM/EE7zQP1NttIgdBUfuqjeUtDdlgYNCK7lARB1wcnbYEwBLogJmQqdPqk=","X-Gm-Gg":"AeBDieu2evw4nGi7we7to9/oOZG4kv+v9tOjlJajv01AxtyUT5nCW+brzHixi7MekmR\n +5YH9Mjc1xY4qpvBJXjDowVEUGAdrsNN826ETgrlDI2W1BUMEFutWsUnhcTx4WGPjcU0RmIgk5I\n 9UlWGasOYkhAFA4FL3QXXLZoqN0yohFpl16QWr5k47/gTiayA1VZHtaNsqOT/f7dwBmCXRTDPxI\n SPtpTQFNm3D6gE84maMbog8j7l3tsgjRzZLREqeUFZYlE+IMvQJFvaLa5OmkPtqIygoZ38KW9Br\n jysD8SCe0b3yJWTFg70KO3pmRo4npbjKhS+BuNPP8A2df2mbefs287DS5LpucwRKch72mYtNJem\n iQdRT/RxuLGQumJou6XOeRcwkEnN7Sh6qKxf0ab0gcDxiddfqlFISJIbmFaGvwc7/zFYYzpF2tJ\n D592tRWm2XvitZsL/ygf69WOUNA1+Qf8NLW9Ffmalp/1b2fPn4PMWW4f1aPkZgmsuiWFuKWZ+Pr\n cI97afOJDVqzAh4","X-Received":"by 2002:a17:902:cec6:b0:2b4:5a2e:98d9 with SMTP id\n d9443c01a7336-2b97c49a59amr73951545ad.37.1777445513745;\n Tue, 28 Apr 2026 23:51:53 -0700 (PDT)","To":"anthony.l.nguyen@intel.com,\n\tprzemyslaw.kitszel@intel.com","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, vincent.chen@sifive.com","Date":"Wed, 29 Apr 2026 14:51:27 +0800","Message-Id":"<20260429065127.423949-3-vincent.chen@sifive.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260429065127.423949-1-vincent.chen@sifive.com>","References":"<20260429065127.423949-1-vincent.chen@sifive.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sifive.com; s=google; t=1777445514; x=1778050314; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jUnzqF1b0jZfPUvpn/ylBvB7W/64BC9cpo6hVx+ffvE=;\n b=Vr2DsWQ3cc2P2axP61wovl6xngsFngfGXNvyCLKsIaCXyjXmQTaoaL8AaskLIBvfsD\n GDszwqltB7FUiAoy3xl+ol113RbWpMRTHVuVmj79GAkC3Er6LW8MTSat4HYQIBnA0UrZ\n 8WSHzCRt1mcULieTeYBSp78kbMym+WzL/4za8h6n2CPnG7AmFnyQOBrTDKGnaqccOlGa\n Ks/h5MmvTdLLJUsSLKS5ppmjPAFmh4KYKAP5QoTzaI/MuItdrlrMZLmOYexzv+vTp1h9\n uBrcv2k3FAxD28d4F4DxisSIVgHsQobddj12CaUzGHmSMYtZum2letQKvKQNUUrXgv6w\n VLHQ==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=sifive.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256\n header.s=google header.b=Vr2DsWQ3"],"Subject":"[Intel-wired-lan] [PATCH 2/2] ice: remove redundant switchdev check\n in ice_eswitch_attach_vf()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Vincent Chen via Intel-wired-lan ","Reply-To":"Vincent Chen ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"All callers of ice_eswitch_attach_vf() check the switchdev mode before\ncalling the function, the internal switchdev mode check in\nice_eswitch_attach_vf() is redundant. Remove this check to align with\nthe design pattern used for ice_eswitch_attach_sf(), where the caller is\nresponsible for checking switchdev mode before attachment.\n\nSigned-off-by: Vincent Chen \n---\n drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c\nindex 2e4f0969035f..c709decb26d5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_eswitch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n@@ -512,9 +512,6 @@ int ice_eswitch_attach_vf(struct ice_pf *pf, struct ice_vf *vf)\n \tstruct ice_repr *repr;\n \tint err;\n \n-\tif (!ice_is_eswitch_mode_switchdev(pf))\n-\t\treturn 0;\n-\n \trepr = ice_repr_create_vf(vf);\n \tif (IS_ERR(repr))\n \t\treturn PTR_ERR(repr);\n","prefixes":["2/2"]}