{"id":2230058,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230058/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429062004.36582-3-guobin@linux.alibaba.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429062004.36582-3-guobin@linux.alibaba.com>","date":"2026-04-29T06:20:03","name":"[2/3] block/block-backend: delegate blk_co_preadv to blk_co_preadv_part","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4c276834dcd137b3f51a53de7552d500cd86131b","submitter":{"id":91693,"url":"http://patchwork.ozlabs.org/api/1.1/people/91693/?format=json","name":"Bin Guo","email":"guobin@linux.alibaba.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429062004.36582-3-guobin@linux.alibaba.com/mbox/","series":[{"id":501994,"url":"http://patchwork.ozlabs.org/api/1.1/series/501994/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501994","date":"2026-04-29T06:20:01","name":"Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c","version":1,"mbox":"http://patchwork.ozlabs.org/series/501994/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230058/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230058/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=wr0U93eZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g56fv5Xfjz1xqf\n\tfor ; Wed, 29 Apr 2026 16:22:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHyJ6-0004r5-I5; Wed, 29 Apr 2026 02:22:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHyHx-0004Vr-Gw; Wed, 29 Apr 2026 02:20:51 -0400","from out30-118.freemail.mail.aliyun.com ([115.124.30.118])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHyHr-00078I-Uj; Wed, 29 Apr 2026 02:20:47 -0400","from localhost(mailfrom:guobin@linux.alibaba.com\n fp:SMTPD_---0X1wgCg6_1777443622 cluster:ay36) by smtp.aliyun-inc.com;\n Wed, 29 Apr 2026 14:20:28 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linux.alibaba.com; s=default;\n t=1777443629; h=From:To:Subject:Date:Message-ID:MIME-Version;\n bh=MARf+gfsHcq6jSDjRoPtErFT1ue1g868Ee90sY5sqak=;\n b=wr0U93eZxno4saD9w/3jnAR7Nb08wjxxWZjLsGQCsdzxv+9Z8XQi5VJE/OcpCHHfLvOWeHAdbHP1a1lQsV+nTYD5lk1FbSGyBLkWmaI7bOJhuXE03XZVdcEKvvqviB+B2og92h/g4FOIwKkBYHA7jlxKvDSpvqqGwI2prqtwCCo=","X-Alimail-AntiSpam":"AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green;\n DM=||false|;\n DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam011083073210;\n MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=6; SR=0;\n TI=SMTPD_---0X1wgCg6_1777443622;","From":"Bin Guo ","To":"qemu-devel@nongnu.org","Cc":"pbonzini@redhat.com, berrange@redhat.com, kwolf@redhat.com,\n hreitz@redhat.com, qemu-block@nongnu.org","Subject":"[PATCH 2/3] block/block-backend: delegate blk_co_preadv to\n blk_co_preadv_part","Date":"Wed, 29 Apr 2026 14:20:03 +0800","Message-ID":"<20260429062004.36582-3-guobin@linux.alibaba.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260429062004.36582-1-guobin@linux.alibaba.com>","References":"<20260429062004.36582-1-guobin@linux.alibaba.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=115.124.30.118;\n envelope-from=guobin@linux.alibaba.com;\n helo=out30-118.freemail.mail.aliyun.com","X-Spam_score_int":"-174","X-Spam_score":"-17.5","X-Spam_bar":"-----------------","X-Spam_report":"(-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5,\n USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"blk_co_preadv() and blk_co_preadv_part() share identical bodies except\nthat blk_co_preadv() always passes qiov_offset=0. blk_co_pwritev()\nalready uses this pattern and simply calls blk_co_pwritev_part() with\nqiov_offset=0. Apply the same simplification to the read side so that\nboth pairs are consistent and the shared logic lives in a single place.\n\nBefore this change blk_co_preadv() duplicated the\nblk_inc_in_flight / blk_co_do_preadv_part / blk_dec_in_flight\nsequence. After this change it is a one-liner wrapper, matching the\nwrite side.\n\nSigned-off-by: Bin Guo \n---\n block/block-backend.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/block/block-backend.c b/block/block-backend.c\nindex 9944657120..490b149bf8 100644\n--- a/block/block-backend.c\n+++ b/block/block-backend.c\n@@ -1376,14 +1376,8 @@ int coroutine_fn blk_co_preadv(BlockBackend *blk, int64_t offset,\n int64_t bytes, QEMUIOVector *qiov,\n BdrvRequestFlags flags)\n {\n- int ret;\n IO_OR_GS_CODE();\n-\n- blk_inc_in_flight(blk);\n- ret = blk_co_do_preadv_part(blk, offset, bytes, qiov, 0, flags);\n- blk_dec_in_flight(blk);\n-\n- return ret;\n+ return blk_co_preadv_part(blk, offset, bytes, qiov, 0, flags);\n }\n \n int coroutine_fn blk_co_preadv_part(BlockBackend *blk, int64_t offset,\n","prefixes":["2/3"]}