{"id":2230057,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230057/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com>","date":"2026-04-29T06:22:08","name":"fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3482dcb8c887cd1aec053dafb0d5d56c9cd120e5","submitter":{"id":84271,"url":"http://patchwork.ozlabs.org/api/1.1/people/84271/?format=json","name":"Michal Simek","email":"michal.simek@amd.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com/mbox/","series":[{"id":501996,"url":"http://patchwork.ozlabs.org/api/1.1/series/501996/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501996","date":"2026-04-29T06:22:08","name":"fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()","version":1,"mbox":"http://patchwork.ozlabs.org/series/501996/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230057/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230057/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=eS8PEK2e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.b=\"eS8PEK2e\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=fail smtp.mailfrom=michal.simek@amd.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g56fq3vgYz1xqf\n\tfor ; Wed, 29 Apr 2026 16:22:43 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DA16C846C1;\n\tWed, 29 Apr 2026 08:22:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 34EB9846C3; Wed, 29 Apr 2026 08:22:38 +0200 (CEST)","from BL0PR03CU003.outbound.protection.outlook.com\n (mail-eastusazlp170120007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c101::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3F2098460C\n for ; Wed, 29 Apr 2026 08:22:35 +0200 (CEST)","from MW4PR03CA0251.namprd03.prod.outlook.com (2603:10b6:303:b4::16)\n by LV0PR12MB999093.namprd12.prod.outlook.com (2603:10b6:408:32e::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Wed, 29 Apr\n 2026 06:22:25 +0000","from CO1PEPF00012E64.namprd05.prod.outlook.com\n (2603:10b6:303:b4:cafe::90) by MW4PR03CA0251.outlook.office365.com\n (2603:10b6:303:b4::16) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Wed,\n 29 Apr 2026 06:22:25 +0000","from satlexmb08.amd.com (165.204.84.17) by\n CO1PEPF00012E64.mail.protection.outlook.com (10.167.249.73) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9846.18 via Frontend Transport; Wed, 29 Apr 2026 06:22:25 +0000","from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com\n (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 29 Apr\n 2026 01:22:21 -0500","from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com\n (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 28 Apr\n 2026 23:22:21 -0700","from localhost (10.180.168.240) by satlexmb08.amd.com\n (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend\n Transport; Wed, 29 Apr 2026 01:22:20 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=d+HollY1/oRazx7ayhKWH3DRq4pkdQQD6uWu1jKQqnQ9QOFG8eqX8I7H+ka/yAIAWUagfHn+Q4FkQk/l7Qw3L3RTQHCi6FtXPpHUfe+eVKFUPXg8g2fjvPJVfN/UetaE4nzsf8SgfhndoT0VWghLVKRIaJGZCTRiYgZyo6cyPOZLekfQ7vqVO1HtlC+fgclDGxtE4hmhBJk82Tmt2Yiw4XsOnF0lYwIPdrsyhygpNjKEdpMUce4huCe2SZVL0Z6EKvtfrr95pkAiVhe3wItH2axIIAvQ01T4I+dKt7ytkfL5SFVjqrxvvvF6ftmrDvPBTYthhw3h5KZnVR13+OyGLA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AN1onI1EsUiE7aOoVqWKB0r4bIsRKNUk6+dFxjOqVLc=;\n b=r1yIO0NaFmORLb/E48Dfhif7uW/uCCcJYVpss3B3q6CBI0+okpC2dkDWVdJiGLZxRegS9wxDKHduVt38n29UnC9mIXCtQUb1wxq7XOZnSnEcwgIpHg8F0FjVgDm/UnWwIc6CFtDUd9ac5OeJVWTRDOunAkwtEILyaR5QfpP3ZRdBz+6zVn2WPOl+ueYav7krXImgS/u+9rr70T7VLXBuzWYp2PHE38gs5x8mOZWHjfOp3kPEFWC6qMtHxCis2/8MduOBOKT2bZpMUkdkOUmH3XNdx1uoX/sEsKPxO9uzDYoZdQdFT/608azNfSpltKWg8GD6AbJ5gIke3Qiji7Nh1g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=amd.com; dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AN1onI1EsUiE7aOoVqWKB0r4bIsRKNUk6+dFxjOqVLc=;\n b=eS8PEK2ewViGy2vPWFlsdvrvfAky5Ai4bVEJjDZ2vY/kTjnZymscNPyJjeVGJxUTtYqi9WPiQxsB0lLX2cpklD32Z8/Bk6H4sMjIWhRJXXeY3wGHu6Wf8UjaHmTsQZpQRJPD53xKVQtBBmM2whcjM8s5B92zKBvacjhmBiJE8iw=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;","Received-SPF":"Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C","From":"Michal Simek ","To":", ","CC":"Alexander Sverdlin , Casey Connolly\n , Pranav Sanwal , \"Raymond\n Mao\" , Simon Glass , Tom Rini\n ","Subject":"[PATCH] fdt: check fdt_pack() return value in\n fdtdec_apply_bloblist_dtos()","Date":"Wed, 29 Apr 2026 08:22:08 +0200","Message-ID":"\n <3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","X-Developer-Signature":"v=1; a=openpgp-sha256; l=988; i=michal.simek@amd.com;\n h=from:subject:message-id; bh=BAy+ad3Uoop7iayyHMgl6hkB21u1bo18ix3ZTXF3ixA=;\n b=owGbwMvMwCG2mv3fB7+vgl8ZT6slMWR+XDzN3cdS9+UWySmdxycv2i4ZZR0gbXskPWnl/Gv/H\n uizbjsh1lHKwiDGwSArpsgynUnHYc23a0vFlkfmw8xhZQIZwsDFKQATWXWHkeGo54dCLlWvr38r\n RCY7v1130u1LtGLZUYuHy0MndUekf5vGyLBQ5EDRv/xPdrJW/Q3LAmeX872+uDdgI3vxZw+pC9I\n n0jkA","X-Developer-Key":"i=michal.simek@amd.com; a=openpgp;\n fpr=67350C9BF5CCEE9B5364356A377C7F21FE3D1F91","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CO1PEPF00012E64:EE_|LV0PR12MB999093:EE_","X-MS-Office365-Filtering-Correlation-Id":"2af22ad6-8664-4f4c-0090-08dea5b7ae25","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|82310400026|36860700016|1800799024|376014|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n YzdWrb7u/rkwp3Da4sMk032PTkLEKixieeVuvfAZJ2zHD0A1CE2D2SI8zmYPrwfx9TLYEgsZSfwM7YiToQoP/Y/ykG9np6r0jPwosPXOEVigcfEV4t3n8Xe7UYlkGIFToBHZuJZQPpMc4AZXk9lOwER8iDjIExj+fbsty9p2Ht70HLPabNNdpgSRt81bGi7eo++77Z0CBufdTV7/SLavBs76yGvrsimIvu+63mUWfoVwfMFCSU7TLk6oSz2EoiSRin+e5U/b4fnLC4BrllSxslM7QBjYs6/RCys1p5kbU59W5vTvz6QrRaA1OS9xxJSI69Kpcy5IgRZAzCMbVd5pmLxWNhtewpYLwnhGPI4Rjce8pWP2ScbSlZEnczRRq/aKvGSTQGD49D4FDvrnvpDfvFuvuDSRqMmyKgTURFhzFRG4mm8uOMxOzSYzlcrF5oLpSrXL/FWxzHPrDSnW1iESmOrzYDmS4CkG1JXz6U8TNQqMnpz0bHjzm6s9G+HU/u9zVGs9s2N6WFdbxyRh6SKkqUrGOhTKk4cY8Z/6p3zAaf6tVFg9XPDqbZKnkAxT5turmYNMma7Z9/LPqW8tPnTyDHhnE+GLG311t3IGssZHDNpHNLzx0nVsm85KiL7PtmlSZgvHzIeIsItj2/o9QWbjApNxUJubqMUToU52wn5lSEO/FDMhDXjY06edumBZx6af29ZGQBssHT6g7eAZH7X/NirtvCe+mfvJ1FeD9bGN3HCSTPlTP+V5zVO2GKCUVjDFpHL+zcetpACjgrhBmCjq5g==","X-Forefront-Antispam-Report":"CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n hKVDujm8t94sehy1Z87XcFPvbWrFDMj/INsBsl0eQIsUCLRbP/N4X6gfqmW0E4dj2JaT64doZlP6kEQdWW0RJL6FGMWpt3G2z6xVSTCKoauDkv1grlGV6f/G2qTteCDmxDGj0D5qgqYOmNS7Q/aGBFRofr8s6K0Ebex8BAb6sdQPULjMUDJM4Ag7QwEp0o6bSVRg25zSiUQHNycAyeG9U3psZTdOyJ3G/GepfiPYKSnAQprPWVTFA1rBuTHXc6K+4iGfAHhXGi8GI/cqKSRAuFe8cG56VSrMoiSg3MQ7fQgj7oowME8VPMCu11BwNzIOUaB/yuJBZVsvhj9THkWAZ1R6/2pKLyBa21FYbFnJUx8p2AenrDlpl2sA/a6FAWZfT05DkSwcoa66nFdX/pqfUBADtasvCcKG/aZ1JuWYC51UgEwv1iZ8VU5YzZDCSN/v","X-OriginatorOrg":"amd.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"29 Apr 2026 06:22:25.1046 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 2af22ad6-8664-4f4c-0090-08dea5b7ae25","X-MS-Exchange-CrossTenant-Id":"3dd8961f-e488-4e60-8e11-a82d994e183d","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[satlexmb08.amd.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n CO1PEPF00012E64.namprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"LV0PR12MB999093","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The fdt_pack() function can return an error code, but its return value\nwas not being checked. Add proper error handling to propagate any\nfailure.\n\nAlso fix typo in comment: \"Shink\" -> \"Shrink\".\n\nAddresses-Coverity-ID: CID 645839: Error handling issues (CHECKED_RETURN)\nSigned-off-by: Michal Simek \n---\n\n lib/fdtdec.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/fdtdec.c b/lib/fdtdec.c\nindex c6e13b6abefd..2d66860f6ed0 100644\n--- a/lib/fdtdec.c\n+++ b/lib/fdtdec.c\n@@ -1781,8 +1781,11 @@ static int fdtdec_apply_bloblist_dtos(void)\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Shink the blob to the actual FDT size */\n-\tfdt_pack(live_fdt);\n+\t/* Shrink the blob to the actual FDT size */\n+\tret = fdt_pack(live_fdt);\n+\tif (ret)\n+\t\treturn ret;\n+\n \treturn bloblist_resize(BLOBLISTT_CONTROL_FDT, fdt_totalsize(live_fdt));\n }\n \n","prefixes":[]}