{"id":2229983,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229983/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429034849.1686650-1-aaron.ma@canonical.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429034849.1686650-1-aaron.ma@canonical.com>","date":"2026-04-29T03:48:49","name":"[v4] ice: wait for reset completion in ice_resume()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6eba10040eba7f36b908fa73fa0085b9494d529","submitter":{"id":72035,"url":"http://patchwork.ozlabs.org/api/1.1/people/72035/?format=json","name":"Aaron Ma","email":"aaron.ma@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260429034849.1686650-1-aaron.ma@canonical.com/mbox/","series":[{"id":501978,"url":"http://patchwork.ozlabs.org/api/1.1/series/501978/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501978","date":"2026-04-29T03:48:49","name":"[v4] ice: wait for reset completion in ice_resume()","version":4,"mbox":"http://patchwork.ozlabs.org/series/501978/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229983/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229983/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=pNr12g4t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g53Fj0rH7z1yHX\n\tfor ; Wed, 29 Apr 2026 13:49:12 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C45B341F93;\n\tWed, 29 Apr 2026 03:49:10 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id i0oL7wxssEr4; Wed, 29 Apr 2026 03:49:09 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 5D87941F92;\n\tWed, 29 Apr 2026 03:49:09 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 21B3C231\n for ; Wed, 29 Apr 2026 03:49:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 06CFA83F55\n for ; Wed, 29 Apr 2026 03:49:08 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RublNjLav-y0 for ;\n Wed, 29 Apr 2026 03:49:07 +0000 (UTC)","from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 7296E83F52\n for ; Wed, 29 Apr 2026 03:49:05 +0000 (UTC)","from mail-pl1-f200.google.com (mail-pl1-f200.google.com\n [209.85.214.200])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id ED5213F7F8\n for ; Wed, 29 Apr 2026 03:49:02 +0000 (UTC)","by mail-pl1-f200.google.com with SMTP id\n d9443c01a7336-2b242062308so227357085ad.2\n for ; Tue, 28 Apr 2026 20:49:02 -0700 (PDT)","from localhost.localdomain ([103.155.100.7])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b98893f1d1sm6615585ad.48.2026.04.28.20.48.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 20:49:00 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5D87941F92","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7296E83F52"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777434549;\n\tbh=9Poun78EQtztiC583t+elgVeEgGqZI6iTcp9LxQ5+sk=;\n\th=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=pNr12g4tj0AAusZ79w3IPOTsAbpyTvWZIuTrJrT357euynW8ZRFYN6QgR4cFZXxJ3\n\t TZPp2nQkzMaRPlSBW2zasCoM4bMduxrCLN5iXWeNplnTdd5YAdp8lmgwT/AIALocvH\n\t xUwE85bBk1khoc6H9KWCjXgtbqKEau0maItANKgYOENURjb22Cn0kcGUF7LEOP90+q\n\t am69B4TRAF0WriNoQLz1M4CSMfzUi3erNaeUN3Oxw8teVm5iKtasLCsK55MNTJw5/a\n\t i8csU9Py2Mx0TkGqByp46YeQ2XJpxIuO2CDFgsw0EEfU7rM0Nuf4HdUtGwaB+Z5Y7d\n\t WnMfCT5vRRWsw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.122;\n helo=smtp-relay-internal-0.canonical.com;\n envelope-from=aaron.ma@canonical.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7296E83F52","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777434541; x=1778039341;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9Poun78EQtztiC583t+elgVeEgGqZI6iTcp9LxQ5+sk=;\n b=M8N2jrutftbXTsBJpkqbHS2QmFB+owDLRQXA6MED1mC++ZNDK7GpJixXIr4yzIOTrG\n eg9rQmA/ZpLjt4rdjeMVC4xVxjkeJXy80wm0yT6gCLbpaFyTg1hSgV0emEVtmGiickzl\n EXLJ8w8oQW7Ig5tbqlj2yZ+xm5o9XFFB90weGG5njMgtOIiFHhPj50sQrAZscAf0qc/J\n mE1iiYoETbNilHjgD1bxCcGnsisYR+qXFcWM/+S82Ry16tM8D16Aty7QUnecOnjTgTui\n 1ExOJBc+wuZedwhiIwB1ozLXQAaxvMvz3iy7WJwKCifQKVOb0vEO4H0HB/Y+ymynFY5k\n wLNQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+cRzNw5kbVnrr4COEQcsrCJQmNFR0m4xl+UIBV6Ep/tQc+Z2Y0hYJOIpmzQVkWvMoc3Vbx27EDWQLLJ4/7adw=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YzIVT5IzBRnBeGRZUpnLfle8c+F+y725Tq5nWQm2KnA4P9ePBIa\n O2LJf+mP9YIp0gYoEsFRnnVQCzm/A1l7XvWhopeDxjhc8qQPf0djIWg2YqrRl6ilNXXgoF7KtGI\n 7iUJRsQSq/RyqWm7p2oTtxB0YWvin83L/c3BPLtMRj+PBYvrVCIxkCrFj/8msv2JeKpenwjP8Xk\n cKysg4CvkpvtOgoR+BBRgJAw==","X-Gm-Gg":"AeBDievpmPLSZ9t1pW2Ch/7kB6YAqwUy6dwNWP5bYIXQYYIhWKdyjvO7GxctWj+JC3B\n 3nefy8LwnanC+BxQ2aiC0uJU0mhIVA7jUvfX+pPxvIisEvCK31hVRu1uKtfi4gFY2HHnoVb3Gov\n bTEEZgOxVbK5v5wxYkUxOFbVsIQJmZ4kckmPB/v8+93gdpb8v0kojqAbCWxE25GxcoL/d0IFZws\n Zw5/Ct7RQfnTnteE6a1gFph9UI7WN7BBMe5mup/oO1YmtgcTr1xh/2XLRrvPxxuh4awxdvRkHtU\n fANRx0L9/Td6t/JWKukPUEI1yWOcA6wQGSQW8qsO4PoqctGEYWFzztfFvuFczBMt4rrvfFe4Sak\n GE8pBQJOsS+bDM2Hf7gSrbvdYC8pIn9sP106A3IweNwMRTTeeuemHAZayPNrR5gSbx4KqtinR3m\n aZpOo7KjvxnYk3zWldX0sq7VAddxiL","X-Received":["by 2002:a17:902:b7c9:b0:2ae:c529:a13f with SMTP id\n d9443c01a7336-2b97c4373camr40318305ad.14.1777434541567;\n Tue, 28 Apr 2026 20:49:01 -0700 (PDT)","by 2002:a17:902:b7c9:b0:2ae:c529:a13f with SMTP id\n d9443c01a7336-2b97c4373camr40318195ad.14.1777434541160;\n Tue, 28 Apr 2026 20:49:01 -0700 (PDT)"],"To":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org","Cc":"Akeem G Abodunrin ,\n Jesse Brandeburg ,\n intel-wired-lan@lists.osuosl.org, aleksandr.loktionov@intel.com,\n kohei@enjuk.jp, Paul Menzel ","Date":"Wed, 29 Apr 2026 11:48:49 +0800","Message-ID":"<20260429034849.1686650-1-aaron.ma@canonical.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=canonical.com; s=20251003; t=1777434542;\n bh=9Poun78EQtztiC583t+elgVeEgGqZI6iTcp9LxQ5+sk=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=dxokGYNWBfVHMu4VcaLtOE5TgrIb8LulDvUkmSMqLPereGehZOjvuPB40Bn3R5m2+\n JopZXuzvqJJ/jvp4diXLdF5bPvZSfWOiAID3U24FlxG2mJXjSnYNMYtUXHqI5yhllq\n GIWtsdCZDsQad1K1Owm2weyofo77tHfiGjU+YhY8FAf6w7hZoAyrGfXVLo3EmLwslm\n gJMJbMBmJ6ivkV2kmkf8j/HJ9tz6vpShp0r/+VPMlqV88/3gcYzJqHJExjigtWU1r3\n a/HNCwkSp9vga0xce/uZ4+NQBQeDBByVWya913VU6LVNBcWnzFjpCO9/gJYoMlQ+mZ\n WGSz728QKCvwDGg3bNGiT+ybTaHFz2j27zy+A7NtGiNeQtHn92pO/eJmMNjLcSv5Tp\n BOlsEOqVg77IG9Oh3zQaOcUdl7N+P5hykn4PmxMSVDMtHQwpJBrTJk9sQtg0XisSyu\n DepeIEbRjYq7A6gQlIoFyGrqKjbk3m0Fw8eaMThVLNEhJzBh51BoBNAlqpKlotVzdN\n nELuhNo5X0mxv4Mrz9ILKXVzC8oLxB5/nOhyF7byA5F9H+Db1Qe7fBwXgpdPM5q/C1\n EUexKjPcWTSfqllQJxv5HDGCfz3TaifK4oknlJ8copvJ5wzVIoAKupCjqsEZ+hshiW\n klVsXpoZeQdExNNiPZ5gZ880=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=canonical.com","smtp1.osuosl.org;\n dkim=pass (4096-bit key,\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=dxokGYNW"],"Subject":"[Intel-wired-lan] [PATCH v4] ice: wait for reset completion in\n ice_resume()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Ma via Intel-wired-lan ","Reply-To":"Aaron Ma ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ice_resume() schedules an asynchronous PF reset and returns\nimmediately. The reset runs later in ice_service_task(). If\nuserspace tries to bring up the net device before the reset\nfinishes, ice_open() fails with -EBUSY:\n\n ice_resume()\n ice_schedule_reset() # sets ICE_PFR_REQ, returns\n ...\n ice_open()\n ice_is_reset_in_progress() # ICE_PFR_REQ still set, -EBUSY\n ...\n ice_service_task()\n ice_do_reset()\n ice_rebuild() # clears ICE_PFR_REQ, too late\n\nReproduced on E800 series NICs during suspend/resume with irdma\nenabled, where the aux device probe widens the race window.\n\n ice 0000:81:00.0: can't open net device while reset is in progress\n\nAdd a best-effort wait (10s timeout, matching ice_devlink_info_get())\nfor the reset to complete before returning from ice_resume(). In\npractice the reset completes in ~300ms.\n\nFixes: 769c500dcc1e (\"ice: Add advanced power mgmt for WoL\")\nCc: stable@vger.kernel.org\nReviewed-by: Kohei Enju \nReviewed-by: Aleksandr Loktionov \nReviewed-by: Przemek Kitszel \nSigned-off-by: Aaron Ma \n---\nv4: use secs_to_jiffies() instead of 10 * HZ (Przemek Kitszel)\nv3: add error message to commit message for searchability, mention\n timeout in dev_err (Paul Menzel)\nv2: reword comment to clarify best-effort semantics (Kohei Enju)\nv1: https://lore.kernel.org/intel-wired-lan/20260402024220.210466-1-aaron.ma@canonical.com/\n\n drivers/net/ethernet/intel/ice/ice_main.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 5f92377d4dfc2..5fce644dc658e 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5635,6 +5635,16 @@ static int ice_resume(struct device *dev)\n \t/* Restart the service task */\n \tmod_timer(&pf->serv_tmr, round_jiffies(jiffies + pf->serv_tmr_period));\n \n+\t/* Best-effort wait for the scheduled reset to finish so that the\n+\t * device is operational before returning. Without this, userspace\n+\t * (e.g. NetworkManager) may try to open the net device while the\n+\t * asynchronous reset is still in progress, hitting -EBUSY.\n+\t */\n+\tret = ice_wait_for_reset(pf, secs_to_jiffies(10));\n+\tif (ret)\n+\t\tdev_err(dev, \"Wait for reset timed out (10s) during resume: %d\\n\",\n+\t\t\tret);\n+\n \treturn 0;\n }\n \n","prefixes":["v4"]}