{"id":2229976,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229976/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/4bf423bb.AU4AAJbgzlAAAAAAAAAABAMtJJMAAYKKIjQAAAAAAC-ZZgBp8Ww0@mailjet.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<4bf423bb.AU4AAJbgzlAAAAAAAAAABAMtJJMAAYKKIjQAAAAAAC-ZZgBp8Ww0@mailjet.com>","date":"2026-04-29T02:25:25","name":"smb: smbdirect: fix MR registration for coalesced SG lists","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"abe3669ee4c8ceba8593cb380027692159ad7a6e","submitter":{"id":93279,"url":"http://patchwork.ozlabs.org/api/1.1/people/93279/?format=json","name":"Yi Kuo","email":"yi@yikuo.dev"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/4bf423bb.AU4AAJbgzlAAAAAAAAAABAMtJJMAAYKKIjQAAAAAAC-ZZgBp8Ww0@mailjet.com/mbox/","series":[{"id":501973,"url":"http://patchwork.ozlabs.org/api/1.1/series/501973/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501973","date":"2026-04-29T02:25:25","name":"smb: smbdirect: fix MR registration for coalesced SG lists","version":1,"mbox":"http://patchwork.ozlabs.org/series/501973/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229976/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229976/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=yikuo.dev header.i=yi@yikuo.dev header.a=rsa-sha256\n header.s=mailjet header.b=jefRvSJ4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11263-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=yikuo.dev header.i=yi@yikuo.dev header.b=\"jefRvSJ4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.189.236.12","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=yikuo.dev","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=a3119462.bnc3.mailjet.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g51Pm6gKdz1yHv\n\tfor ; Wed, 29 Apr 2026 12:26:04 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 4D40E3012856\n\tfor ; Wed, 29 Apr 2026 02:26:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 04D6237E303;\n\tWed, 29 Apr 2026 02:26:00 +0000 (UTC)","from o12.p25.mailjet.com (o12.p25.mailjet.com [185.189.236.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1810337F743\n\tfor ; Wed, 29 Apr 2026 02:25:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777429559; cv=none;\n b=Y11GiSRhdidtHJIpy5xsbwD/f4Y0F2A6hyE9SKF1djkw+d9ETCGZ+zmsCjFHGv3DKs3gezHhkSuxZpsWTjIYd/gWXuxM0X2XSYldg84S1p9D4UxiZKCp2WXfqJxBIVK3RAHcKInV7FyzM0wsQXg90asdSjDznKzWtEFGTz56l3M=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777429559; c=relaxed/simple;\n\tbh=MnToQbK/FkNAhxh5aQ4vTyxi+EldDESUytf58yodrW8=;\n\th=Message-Id:MIME-Version:From:To:Subject:Date:Cc;\n b=NaMjFGyFWUE9Tg+eEA/eho7fjMcWVpNrz3Ylhi5rxLK8RKnDWgDJFIyZWhp5x8V2HmISES6rhwjGTUekfJMmFrdNEOCKnBZ0jY9ZkJ+mUhoLYwEbz0VkDQyQLPQXYKUio5uJdGYrtvX21DdUmC9fIkrCc3oyZM9aTjFWg7y3pRM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=yikuo.dev;\n spf=pass smtp.mailfrom=a3119462.bnc3.mailjet.com;\n dkim=pass (2048-bit key) header.d=yikuo.dev header.i=yi@yikuo.dev\n header.b=jefRvSJ4; arc=none smtp.client-ip=185.189.236.12","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; q=dns/txt;\n d=yikuo.dev; i=yi@yikuo.dev; s=mailjet; t=1777429556; x=1777436756;\n h=Message-Id: MIME-Version: From: To: Subject: Date:\n List-Unsubscribe: List-Unsubscribe-Post: Cc: Feedback-Id:\n X-CSA-Complaints: X-MJ-Mid: X-MJ-SMTPGUID:\n X-REPORT-ABUSE-TO: Content-Transfer-Encoding: To: From:\n Sender: Subject: Date;\n bh=jgRWHS5LTnADW7gurrSjzDLoK6uUiNKmh4ecbUTbkmg=;\n b=jefRvSJ4C2ISFVIHgqmY8OOjmBYULnk3qkugb3lUbuglcWpcCn1vCI3+9\n W9RJnv1v/1l8RkEaRIC9YILuml/7b9JZs9HPmXnxoI/0UnUhPelvikqSOGJg\n kN3jEUpvGpJI4HnxK8V+j7v28yx8l+GDZ9xkTITAzp1cIo7Ph/ziJXmzJzae\n qaX7ZvnI5uQxF+5xfzZPHvLtO3aGcdJCzX0iD186cEkZxvd8DaisSAyi2Xme\n DrFGAvNdKxA6rqzSYdbN03YdpDdfbNFhsgzZScchSvYRD0iAcKnpxcj6loBn\n /XJW+lD63LCexEpCLaSHJKLbyBVNZlwMTjHpz0UnR9vJw==","Message-Id":"\n <4bf423bb.AU4AAJbgzlAAAAAAAAAABAMtJJMAAYKKIjQAAAAAAC-ZZgBp8Ww0@mailjet.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","From":"Yi Kuo ","To":"smfrench@gmail.com, linkinjeon@kernel.org","Subject":"[PATCH] smb: smbdirect: fix MR registration for coalesced SG lists","Date":"Wed, 29 Apr 2026 10:25:25 +0800","List-Unsubscribe-Post":"List-Unsubscribe=One-Click","Cc":"metze@samba.org, tom@talpey.com, linux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Yi Kuo\n\t","Feedback-Id":"42.3119462.2858555:MJ","X-CSA-Complaints":"csa-complaints@eco.de","X-MJ-Mid":"\n\tAU4AAJbgzlAAAAAAAAAABAMtJJMAAYKKIjQAAAAAAC-ZZgBp8Ww0yCNLysOaRJes78hqlhuD6gArnjs","X-MJ-SMTPGUID":"a321fef6-42c1-4399-acf4-f1adff38652b","X-REPORT-ABUSE-TO":"Message sent by Mailjet please report to\n\tabuse@mailjet.com with a copy of the message","Content-Transfer-Encoding":"quoted-printable"},"content":"ib_dma_map_sg() modifies the provided scatterlist and returns the\nnumber of mapped entries, which can be fewer than the requested\nmr->sgt.nents if the DMA controller coalesces contiguous memory\nsegments. Passing the original, uncoalesced count to ib_map_mr_sg()\ncauses memory registration failures if coalescing actually occurs.\n\nCapture the actual mapped count returned by ib_dma_map_sg() and pass it\nto ib_map_mr_sg() to ensure correct MR registration.\n\nAlso update the ib_dma_map_sg() error logging to drop the error\npointer formatting, since the return value is an integer count\nrather than an error code.\n\nSigned-off-by: Yi Kuo \n---\n fs/smb/smbdirect/mr.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/fs/smb/smbdirect/mr.c b/fs/smb/smbdirect/mr.c\nindex 5228e699cd5d..058dc24bf544 100644\n--- a/fs/smb/smbdirect/mr.c\n+++ b/fs/smb/smbdirect/mr.c\n@@ -269,7 +269,7 @@ smbdirect_connection_register_mr_io(struct smbdirect_socket *sc,\n {\n \tconst struct smbdirect_socket_parameters *sp = &sc->parameters;\n \tstruct smbdirect_mr_io *mr;\n-\tint ret, num_pages;\n+\tint ret, num_pages, num_mapped;\n \tstruct ib_reg_wr *reg_wr;\n \n \tnum_pages = iov_iter_npages(iter, sp->max_frmr_depth + 1);\n@@ -300,19 +300,19 @@ smbdirect_connection_register_mr_io(struct smbdirect_socket *sc,\n \t\tnum_pages, iov_iter_count(iter), sp->max_frmr_depth);\n \tsmbdirect_iter_to_sgt(iter, &mr->sgt, sp->max_frmr_depth);\n \n-\tret = ib_dma_map_sg(sc->ib.dev, mr->sgt.sgl, mr->sgt.nents, mr->dir);\n-\tif (!ret) {\n+\tnum_mapped = ib_dma_map_sg(sc->ib.dev, mr->sgt.sgl, mr->sgt.nents, mr->dir);\n+\tif (!num_mapped) {\n \t\tsmbdirect_log_rdma_mr(sc, SMBDIRECT_LOG_ERR,\n-\t\t\t\"ib_dma_map_sg num_pages=%u dir=%x ret=%d (%1pe)\\n\",\n-\t\t\tnum_pages, mr->dir, ret, SMBDIRECT_DEBUG_ERR_PTR(ret));\n+\t\t\t\"ib_dma_map_sg num_pages=%u dir=%x num_mapped=%d\\n\",\n+\t\t\tnum_pages, mr->dir, num_mapped);\n \t\tgoto dma_map_error;\n \t}\n \n-\tret = ib_map_mr_sg(mr->mr, mr->sgt.sgl, mr->sgt.nents, NULL, PAGE_SIZE);\n-\tif (ret != mr->sgt.nents) {\n+\tret = ib_map_mr_sg(mr->mr, mr->sgt.sgl, num_mapped, NULL, PAGE_SIZE);\n+\tif (ret != num_mapped) {\n \t\tsmbdirect_log_rdma_mr(sc, SMBDIRECT_LOG_ERR,\n-\t\t\t\"ib_map_mr_sg failed ret = %d nents = %u\\n\",\n-\t\t\tret, mr->sgt.nents);\n+\t\t\t\"ib_map_mr_sg failed ret = %d num_mapped = %u\\n\",\n+\t\t\tret, num_mapped);\n \t\tgoto map_mr_error;\n \t}\n \n","prefixes":[]}