{"id":2229961,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229961/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260428234741.1956515-1-dmalcolm@redhat.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260428234741.1956515-1-dmalcolm@redhat.com>","date":"2026-04-28T23:47:41","name":"[pushed:,r17-181] analyzer: add known_function handler for strcasecmp","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9acb41ebf23c5f2d9968ae47b6a6066edccfd4c7","submitter":{"id":24465,"url":"http://patchwork.ozlabs.org/api/1.1/people/24465/?format=json","name":"David Malcolm","email":"dmalcolm@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260428234741.1956515-1-dmalcolm@redhat.com/mbox/","series":[{"id":501964,"url":"http://patchwork.ozlabs.org/api/1.1/series/501964/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501964","date":"2026-04-28T23:47:41","name":"[pushed:,r17-181] analyzer: add known_function handler for strcasecmp","version":1,"mbox":"http://patchwork.ozlabs.org/series/501964/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229961/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229961/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Z+5Qdl7s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Z+5Qdl7s","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4xvt2ZZVz1yHX\n\tfor ; Wed, 29 Apr 2026 09:48:25 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 24D294BBC0B3\n\tfor ; Tue, 28 Apr 2026 23:48:23 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 39D884BB8F58\n for ; Tue, 28 Apr 2026 23:47:56 +0000 (GMT)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-A9TyzT2uMHaczhEe90CDvA-1; Tue,\n 28 Apr 2026 19:47:54 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6FB82195605C; Tue, 28 Apr 2026 23:47:53 +0000 (UTC)","from t14s.localdomain.com (unknown [10.22.65.168])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E4D3419560AB; Tue, 28 Apr 2026 23:47:52 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 24D294BBC0B3","OpenDKIM Filter v2.11.0 sourceware.org 39D884BB8F58"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 39D884BB8F58","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 39D884BB8F58","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777420076; cv=none;\n b=L9GTzuBQKdG+aJp905AtcMbNZfpR7lNHKzW9lnHZZp+IWPGgj1/kSbXki6tz8IWZi9UMGBvVflEoHIONRil6wgXPtL5xwu372hhT4h9BN4I2Ky8hw9cpBcIpijjAxh4RBg8cWvul5BL6XLKW2kOZqIlKC/3TmkJNO0r9n5ze9Ak=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777420076; c=relaxed/simple;\n bh=VkfWNbyr4dqRXqvgLRMMHyjuOcVRPDpycpWm3MdPuGE=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=Ozxx/wfA+NRad5Tr+dAHwYXUbSH+176PGtictOYliVavnj+TTmhVX6oMrvHgpXyNqPqo3M/TLdYbNCqigtzUQyFmQMN5gYC+e2IRvyWi7fGN8Zq4MjFiNBVfWJZ/zCLIP1POZGyo+Wk3mpJVNje8u99aQUU1XIjFG0wo5k41qqA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777420075;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eA1JELpdwhcYvmAi0ItUfBIagOU3Xv8x4g34Kth/RlM=;\n b=Z+5Qdl7sf5CxKHd+8e3/jdEWU8cMcx6Jnyh7SGsc9aSQ+4tgAlUFqtbkwMYerWFXZKkz4k\n oWLBR/Hcui0n2FsLuQT1nhgLpClxI7+rWwzUCaOCdGODDyvRwZt/3LXEPO7sNb5q3+3krD\n s/aqS8vaAiNbEgcVBzriCguVqpTxz4k=","X-MC-Unique":"A9TyzT2uMHaczhEe90CDvA-1","X-Mimecast-MFC-AGG-ID":"A9TyzT2uMHaczhEe90CDvA_1777420073","From":"David Malcolm ","To":"gcc-patches@gcc.gnu.org","Cc":"Virginia Kodsy ","Subject":"[pushed: r17-181] analyzer: add known_function handler for strcasecmp","Date":"Tue, 28 Apr 2026 19:47:41 -0400","Message-ID":"<20260428234741.1956515-1-dmalcolm@redhat.com>","In-Reply-To":"","References":"","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"uPPDus7fuKVJ6OeSTRR3l_cJeuhOpDVZt5mN0jwt6eI_1777420073","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Virginia Kodsy \n\nThis patch adds a known_function handler for strcasecmp to the\nstatic analyzer. It ensures the analyzer checks for null-terminated\nstring arguments and, when a return value is expected (LHS),\nit conjures a symbolic value for the result.\n\ndmalcolm:\nSuccessfully bootstrapped & regrtested on powerpc64le-unknown-linux-gnu\n(albeit without ada,cobol,d, and possibly missing some optional test dependencies)\nPushed to trunk as r17-181-g9f1696dbfe7836.\n\ngcc/analyzer/ChangeLog:\n\t* kf.cc (class kf_strcasecmp): New.\n\t(kf_strcasecmp::impl_call_post): New.\n\t(register_known_functions): Register BUILT_IN_STRCASECMP,\n\t\"strcasecmp\", and \"__builtin_strcasecmp\".\n\ngcc/testsuite/ChangeLog:\n\t* gcc.dg/analyzer/strcasecmp-1.c: New test.\n\nSigned-off-by: Virginia Kodsy \n---\n gcc/analyzer/kf.cc | 43 ++++++++++++++++++++\n gcc/testsuite/gcc.dg/analyzer/strcasecmp-1.c | 43 ++++++++++++++++++++\n 2 files changed, 86 insertions(+)\n create mode 100644 gcc/testsuite/gcc.dg/analyzer/strcasecmp-1.c","diff":"diff --git a/gcc/analyzer/kf.cc b/gcc/analyzer/kf.cc\nindex 5d2af3866a7..d2605e96252 100644\n--- a/gcc/analyzer/kf.cc\n+++ b/gcc/analyzer/kf.cc\n@@ -2848,6 +2848,45 @@ region_model::impl_deallocation_call (const call_details &cd)\n kf.impl_call_post (cd);\n }\n \n+/* Handler for \"strcasecmp\" */\n+\n+class kf_strcasecmp : public builtin_known_function\n+{\n+public:\n+ bool\n+ matches_call_types_p (const call_details &cd) const final override\n+ {\n+ return (cd.num_args () == 2\n+ && cd.arg_is_pointer_p (0)\n+ && cd.arg_is_pointer_p (1));\n+ }\n+ void\n+ impl_call_pre (const call_details &cd) const final override\n+ {\n+ cd.check_for_null_terminated_string_arg (0);\n+ cd.check_for_null_terminated_string_arg (1);\n+ }\n+\n+ enum built_in_function\n+ builtin_code () const final override\n+ {\n+ return BUILT_IN_STRCASECMP;\n+ }\n+\n+ void impl_call_post (const call_details &cd) const final override;\n+};\n+\n+void\n+kf_strcasecmp::impl_call_post (const call_details &cd) const\n+{\n+ if (tree lhs_type = cd.get_lhs_type ())\n+ {\n+ const svalue *result_val\n+\t= cd.get_or_create_conjured_svalue (cd.get_lhs_region ());\n+ cd.maybe_set_lhs (result_val);\n+ }\n+}\n+\n static void\n register_atomic_builtins (known_function_manager &kfm)\n {\n@@ -3037,6 +3076,8 @@ register_known_functions (known_function_manager &kfm,\n \n kfm.add (BUILT_IN_EH_POINTER, std::make_unique ());\n \n+ kfm.add(BUILT_IN_STRCASECMP, std::make_unique());\n+\n register_atomic_builtins (kfm);\n register_sanitizer_builtins (kfm);\n register_varargs_builtins (kfm);\n@@ -3101,6 +3142,8 @@ register_known_functions (known_function_manager &kfm,\n kfm.add (\"__builtin_strlen\", std::make_unique ());\n kfm.add (\"strstr\", std::make_unique ());\n kfm.add (\"__builtin_strstr\", std::make_unique ());\n+ kfm.add(\"strcasecmp\", std::make_unique());\n+ kfm.add(\"__builtin_strcasecmp\", std::make_unique());\n }\n \n /* Known POSIX functions, and some non-standard extensions. */\ndiff --git a/gcc/testsuite/gcc.dg/analyzer/strcasecmp-1.c b/gcc/testsuite/gcc.dg/analyzer/strcasecmp-1.c\nnew file mode 100644\nindex 00000000000..f56bc9df5dd\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/analyzer/strcasecmp-1.c\n@@ -0,0 +1,43 @@\n+/* { dg-additional-options \"-Wno-nonnull\" } */\n+#include \"analyzer-decls.h\"\n+\n+\n+extern int strcasecmp (const char *s1, const char *s2);\n+\n+int\n+test_passthrough (const char *s1, const char *s2)\n+{\n+ return strcasecmp (s1, s2);\n+}\n+\n+void\n+test_literals (void)\n+{\n+ strcasecmp (\"string\", \"STRING\");\n+}\n+\n+void\n+test_unterminated (void)\n+{\n+ char buf[3] = {'a', 'b', 'c' };\n+ strcasecmp (buf, \"abc\"); /* { dg-warning \"stack-based buffer over-read\" } */\n+}\n+\n+void\n+test_unterminated_2 (void)\n+{\n+ char buf[3] = { 'a', 'b', 'c' };\n+ strcasecmp (\"abc\", buf); /* { dg-warning \"stack-based buffer over-read\" } */\n+}\n+\n+void\n+test_null_1 (void)\n+{\n+ strcasecmp (NULL, \"abc\"); /* { dg-warning \"use of NULL where non-null expected\" } */\n+}\n+\n+void\n+test_null_2 (void)\n+{\n+ strcasecmp(\"abc\", NULL); /* { dg-warning \"use of NULL where non-null expected\" } */\n+}\n","prefixes":["pushed:","r17-181"]}