{"id":2229863,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229863/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-56-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-56-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:56","name":"[55/97] wpa_supplicant: Support configuring MAC address on interface creation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"83e3b0893d19d6c1b1fa78963b61c3fa2dfcf32f","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-56-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229863/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229863/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kuTFYp6m;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=bew0hX3l;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s740H9Pz1xrS\n\tfor ; Wed, 29 Apr 2026 06:12:48 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHomx-00000002IXL-0wmQ;\n\tTue, 28 Apr 2026 20:12:11 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHok9-00000002Cfh-1dxu\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:09:23 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:08:39 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:08:38 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=8JJj5o8wPcfkNAQFwQgxNta5k8brDTP1c7CpeaWRVEw=; b=kuTFYp6mzsL4eD\n\t8wn/K6o1EeotAEstVGMUBG37ynxFSI6R6KnFomZW2tewmjLSPTzSy3vHk82JQuDDYtetEswpkPbg7\n\t2pUhy8tk5SbqRyYINd5NMljSJwOJB4wD9DBHtyAI+En/pL9vaPhkBB7BXeiMLd6ee6EGNOIJgaI00\n\ttlNOkoHpHrVp5JQXiecVXTCzEtf+lPfBt73A0n4IkN5m5u6jWouOCwqqqkcvthu02EWUrjTYibwgv\n\tZ443LGyX2Y0ANVsC4CAnZkgC2WGtQ94L5P+Yh4cxHKH5MfT9zU2rK2BahzgM3S4L+LHK0J5FTIJ/X\n\tNpCnauWa3Vg060l80X/g==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406957; x=1808942957;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Fg1wxnYFOYnrOyLujRC9XjT1wQ1AC1oO4pkdlImrhF0=;\n b=bew0hX3lNDZ4WK4uzG6nF+1fnhRrhMFvSfp+54Z/1RmdLPh0jlVu8wwb\n bug/XLDqSNg7QFDi/YKl9SWaWntdEciKZygpF451mAskex9e1Ezm6BmP6\n jYGwdhWmtwwZyNN9bg4ekGcB1L04Sspx4aQ64PKnQf2PrK3jRsg1lE3eh\n X289+EkXdPwugiBiUrtoDJlTlVdky1QgltFbcgFyD75T7zD5xyUN/qhrd\n kg+Gaz41IksptNgxGhbQAbrsA0AlXh7JQ2ks9eeXmiY+xoWGx2G9uq1pX\n otrmbw80XfhuxUxBMXcE7sTQ417zlSlc1bvms1lprMU/m24ZyGfKtClrh\n w==;"],"X-CSE-ConnectionGUID":["ZwoByfclRRCex59LfEyPXA==","6R9QFoWKTcmxYdVtJ7v4Rw=="],"X-CSE-MsgGUID":["NwN8k5J+Sa+mobXFJVoHlg==","sqQUlX97TEyCiDX51tmfaw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519462\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519462\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610553\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tIlan Peer ","Subject":"[PATCH 55/97] wpa_supplicant: Support configuring MAC address on\n interface creation","Date":"Tue, 28 Apr 2026 23:05:56 +0300","Message-ID":"<20260428200639.40243-56-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_130917_635964_379A0537 ","X-CRM114-Status":"GOOD ( 13.74 )","X-Spam-Score":"-4.5 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer Support setting the\n MAC address when a dynamic interface is added, e.g.,\n when creating a NAN Device\n interface etc. Signed-off-by: Ilan Peer ---\n wpa_supplicant/ctrl_iface.c\n | 23 ++++++++++++++++++++--- wpa_supplicant/wpa_cli.c | 8 ++++---- 2 files\n changed, 24 insertions(+), 7 deletions(-)\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Ilan Peer \n\nSupport setting the MAC address when a dynamic interface is added,\ne.g., when creating a NAN Device interface etc.\n\nSigned-off-by: Ilan Peer \n---\n wpa_supplicant/ctrl_iface.c | 23 ++++++++++++++++++++---\n wpa_supplicant/wpa_cli.c | 8 ++++----\n 2 files changed, 24 insertions(+), 7 deletions(-)","diff":"diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c\nindex 1ff295922f..8a96b4f812 100644\n--- a/wpa_supplicant/ctrl_iface.c\n+++ b/wpa_supplicant/ctrl_iface.c\n@@ -14524,12 +14524,12 @@ static int wpa_supplicant_global_iface_add(struct wpa_global *global,\n \tchar *pos, *extra;\n \tstruct wpa_supplicant *wpa_s;\n \tunsigned int create_iface = 0;\n-\tu8 mac_addr[ETH_ALEN];\n+\tu8 mac_addr[ETH_ALEN], *addr_ptr = NULL;\n \tenum wpa_driver_if_type type = WPA_IF_STATION;\n \n \t/*\n \t * TABTABTABTAB\n-\t * TAB[TAB[TAB]]\n+\t * TAB[TAB[TAB][TAB]]\n \t */\n \twpa_printf(MSG_DEBUG, \"CTRL_IFACE GLOBAL INTERFACE_ADD '%s'\", cmd);\n \n@@ -14602,6 +14602,10 @@ static int wpa_supplicant_global_iface_add(struct wpa_global *global,\n \t\t\tif (!pos)\n \t\t\t\tbreak;\n \n+\t\t\textra = os_strchr(pos, '\\t');\n+\t\t\tif (extra)\n+\t\t\t\t*extra++ = '\\0';\n+\n \t\t\tif (os_strcmp(pos, \"sta\") == 0) {\n \t\t\t\ttype = WPA_IF_STATION;\n \t\t\t} else if (os_strcmp(pos, \"ap\") == 0) {\n@@ -14618,6 +14622,19 @@ static int wpa_supplicant_global_iface_add(struct wpa_global *global,\n \t\t\t\t\t pos);\n \t\t\t\treturn -1;\n \t\t\t}\n+\n+\t\t\tpos = extra;\n+\t\t\tif (!pos || !pos[0])\n+\t\t\t\tbreak;\n+\n+\t\t\tif (hwaddr_aton(pos, mac_addr)) {\n+\t\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t\t \"INTERFACE_ADD invalid MAC address: '%s'\",\n+\t\t\t\t\t pos);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\n+\t\t\taddr_ptr = mac_addr;\n \t\t} else {\n \t\t\twpa_printf(MSG_DEBUG,\n \t\t\t\t \"INTERFACE_ADD unsupported extra parameter: '%s'\",\n@@ -14632,7 +14649,7 @@ static int wpa_supplicant_global_iface_add(struct wpa_global *global,\n \t\tif (!global->ifaces)\n \t\t\treturn -1;\n \t\tif (wpa_drv_if_add(global->ifaces, type, iface.ifname,\n-\t\t\t\t NULL, NULL, NULL, mac_addr, NULL) < 0) {\n+\t\t\t\t addr_ptr, NULL, NULL, mac_addr, NULL) < 0) {\n \t\t\twpa_printf(MSG_ERROR,\n \t\t\t\t \"CTRL_IFACE interface creation failed\");\n \t\t\treturn -1;\ndiff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c\nindex 64d6154ee2..9a5d631021 100644\n--- a/wpa_supplicant/wpa_cli.c\n+++ b/wpa_supplicant/wpa_cli.c\n@@ -1887,21 +1887,21 @@ static int wpa_cli_cmd_interface_add(struct wpa_ctrl *ctrl, int argc,\n \t\tprintf(\"Invalid INTERFACE_ADD command: needs at least one \"\n \t\t \"argument (interface name)\\n\"\n \t\t \"All arguments: ifname confname driver ctrl_interface \"\n-\t\t \"driver_param bridge_name [create]\\n\");\n+\t\t \"driver_param bridge_name [create [addr]]\\n\");\n \t\treturn -1;\n \t}\n \n \t/*\n \t * INTERFACE_ADD TABTABTABTAB\n-\t * TAB[TAB[TAB]]\n+\t * TAB[TAB[TAB][TAB]]\n \t */\n \tres = os_snprintf(cmd, sizeof(cmd),\n-\t\t\t \"INTERFACE_ADD %s\\t%s\\t%s\\t%s\\t%s\\t%s\\t%s\\t%s\",\n+\t\t\t \"INTERFACE_ADD %s\\t%s\\t%s\\t%s\\t%s\\t%s\\t%s\\t%s\\t%s\",\n \t\t\t argv[0],\n \t\t\t argc > 1 ? argv[1] : \"\", argc > 2 ? argv[2] : \"\",\n \t\t\t argc > 3 ? argv[3] : \"\", argc > 4 ? argv[4] : \"\",\n \t\t\t argc > 5 ? argv[5] : \"\", argc > 6 ? argv[6] : \"\",\n-\t\t\t argc > 7 ? argv[7] : \"\");\n+\t\t\t argc > 7 ? argv[7] : \"\", argc > 8 ? argv[8] : \"\");\n \tif (os_snprintf_error(sizeof(cmd), res))\n \t\treturn -1;\n \tcmd[sizeof(cmd) - 1] = '\\0';\n","prefixes":["55/97"]}