{"id":2229844,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229844/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-29-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-29-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:29","name":"[28/97] nl80211: Allow deleting group Rx key with specified address","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"98b73e3a5afe42edc2bfee569555541fb648f0e5","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-29-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229844/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229844/checks/","tags":{},"headers":{"Return-Path":"\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=iExp/nX5;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=oTAqltGu;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=PPS8Cbc4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s5G1rMnz1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:11:14 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHola-00000002Ge7-0bDa;\n\tTue, 28 Apr 2026 20:10:46 +0000","from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoja-00000002Dtb-0CZE\n\tfor hostap@bombadil.infradead.org;\n\tTue, 28 Apr 2026 20:08:42 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHojP-00000003ySq-0nxS\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:08:37 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n  by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:58 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n  by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:56 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=0KNPeX/cVzyJEMRSumWxglzq6PMz0OM2xoUwuLV3XFs=; b=iExp/nX52sevdA\n\t5oX4sUztYm8er7amkEB9NFenskeolzihbOT19uCCCSMiMkrwh1xamD7FOIJURq6gAMMskjlMvM3yJ\n\t8LdDbZiGEE+wcrlZrMv6fZvxqBRLisP5xjSfljaPwAYxWimVKhB4Z6eo80kZ54H7KYb4N6lM9nsWq\n\t1Y5qVqQ1/k7Dhc5xnwF1wAH2QaUq72Ce0WMZlsqCGrD5/rwJCfobsugH/ugU4aa6ME47LLprqX3EU\n\tkRBGNF/D3W6s6/gu2NCK3WaTIZIYxuB/oxkbdsn+z8vjjSHaRdMceN/dQqWRwlLmx7KIAL4RWuJ32\n\tpU74Ij9axaELIvOQ0ezg==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version\n\t:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:\n\tContent-Type:Content-ID:Content-Description;\n\tbh=nWShTCTZaMulXhcHCSvDnrmvUI9Ni9hZX0BopWbyvqc=; b=oTAqltGuo6vvKjdK7tEFyUbcan\n\tvhBISSCFVQi1zIONnYl5q51pjPktFM2AWYQto9sI0gPVgZBrB98fWHGsArrnoog6whywOqWHcI6ep\n\t9VfkDlFYeUE/3vG6YwtvDfS3cnLMds92WLHb9XPaAe8JDgXYV1dj6S/5GXVvxJ+wVnuBbC55Hh2Sb\n\tA5TWtfjV8FLXV38ysF57Umax8Bzq+yF1isdGf7/WjPyFfFK/ROa0W+qDbl4GTUhHXtgGDYBWQ3n+Q\n\tsT9ezPCUGyyFABeCW6Ppk8uKdfvN+Z0NWj9Gfpkxjjwx+QV5gMYdHJa65LQBkL4JDUHzT9wrtdz/y\n\tW+UBnZ+g==;","v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777406911; x=1808942911;\n  h=from:to:cc:subject:date:message-id:in-reply-to:\n   references:mime-version:content-transfer-encoding;\n  bh=EXGyvRkHUC7ecFuIFwypiMXA/s79D7zaQDkI3kCp6pw=;\n  b=PPS8Cbc4d7+O5jmtF9dpJxaissnMeG/Hs6XLnLNL4uyfgHa175uVSsQf\n   9hMmxGosan3xEejYufLLWQ+iIFVSi5SPDEz72rAsSIy1TD8AHO2/uvb1k\n   VerN/3wgJTE6E/FMjclLho656WN64CMckCz3/zTdaGAN+8RVnkS0Z/JAQ\n   4Ln6uMfmKCkTfqd28LKf8vfXNVwTfFxQeJVxxJsHOt9RmiVJcndDJWfXG\n   qrXPoy1JuY83KpfL689VRDxjJo/fQSQKXeTPwNyfwqf60gppC8ZADFJuX\n   hm74cVI16C8U/xc70/HawPQqzgIA7oiBMLNwuHrfJTrd+Ane5yjv8NidE\n   A==;"],"X-CSE-ConnectionGUID":["Lks0O1M2RRefMszvGJ/HWw==","QsPM4GPzTH+fJ/UzFz50Gg=="],"X-CSE-MsgGUID":["i6BfR2GcQcKKEPxzRd1t5g==","SfBZKwFxTkGVjmsVATf2KQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519361\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"78519361\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"257610145\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski <andrei.otcheretianski@intel.com>","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern <avraham.stern@intel.com>","Subject":"[PATCH 28/97] nl80211: Allow deleting group Rx key with specified\n address","Date":"Tue, 28 Apr 2026 23:05:29 +0300","Message-ID":"<20260428200639.40243-29-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_210835_190230_EB4DEE32 ","X-CRM114-Status":"UNSURE (   9.55  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.5 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam.  The original\n message has been attached to this so you can view it or label\n similar future email.  If you have any questions, see\n the administrator of that system for details.\n Content preview:  From: Avraham Stern <avraham.stern@intel.com> A group Rx\n key\n    can be added with a specified address (e.g. IGTK of a peer), but cannot be\n    removed. Add support for removing such a key. Signed-off-by: Avraham Stern\n    <avraham.stern@intel.com> --- src/drivers/driver_nl80211.c | 5 +++++ 1\n file\n    changed, 5 insertions(+)\n Content analysis details:   (-2.5 points, 5.0 required)\n  pts rule name              description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,\n                             medium trust\n                             [198.175.65.16 listed in list.dnswl.org]\n  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS               SPF: sender matches SPF record\n -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from\n author's\n                             domain\n -0.1 DKIM_VALID             Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from\n                             envelope-from domain\n  0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n not necessarily valid\n -0.0 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Avraham Stern <avraham.stern@intel.com>\n\nA group Rx key can be added with a specified address (e.g. IGTK of\na peer), but cannot be removed. Add support for removing such a key.\n\nSigned-off-by: Avraham Stern <avraham.stern@intel.com>\n---\n src/drivers/driver_nl80211.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c\nindex d2d0a5cf03..9a2c258c9d 100644\n--- a/src/drivers/driver_nl80211.c\n+++ b/src/drivers/driver_nl80211.c\n@@ -4055,6 +4055,11 @@ static int wpa_driver_nl80211_set_key(struct i802_bss *bss,\n \t\t\tif (nla_put_u32(key_msg, NL80211_KEY_TYPE,\n \t\t\t\t\tNL80211_KEYTYPE_GROUP))\n \t\t\t\tgoto fail;\n+\t\t} else if (alg == WPA_ALG_NONE &&\n+\t\t\t   (key_flag & KEY_FLAG_GROUP_MASK) == KEY_FLAG_GROUP) {\n+\t\t\tif (nla_put_u32(key_msg, NL80211_KEY_TYPE,\n+\t\t\t\t\tNL80211_KEYTYPE_GROUP))\n+\t\t\t\tgoto fail;\n \t\t} else if (!(key_flag & KEY_FLAG_PAIRWISE)) {\n \t\t\twpa_printf(MSG_DEBUG,\n \t\t\t\t   \"   key_flag missing PAIRWISE when setting a pairwise key\");\n","prefixes":["28/97"]}