{"id":2229832,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229832/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-28-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-28-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:28","name":"[27/97] NAN: Process BIGTK KDE from NDP setup messages","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ff0c8e8dfc448eb7cacf9b9bc805cc5052d791eb","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-28-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229832/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229832/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HCYEUN82;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=QnRMLsVi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s436rjVz1xrS\n\tfor ; Wed, 29 Apr 2026 06:10:11 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHokW-00000002FCh-2Mae;\n\tTue, 28 Apr 2026 20:09:40 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoir-00000002CcZ-1f3q\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:08:00 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:57 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:55 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=g4q/SzKarJAhnJ/xCVhmOCmd/JB0VfotGEDCRrBX760=; b=HCYEUN82cFrGQX\n\txPN6xyzX0vpQeTHK9D08AS6iNUHF9PGWcTIHdKzrEbuOn0n91R72cFoAIiMM5slryaBr1qlj7xgfy\n\tHADSqW4hS42xg7d/7nCsZtC26qRBKnDaInZh1aNYZqLu9hnJCgOEPtpN2p9tT0hCBl4g6U7nrbB4E\n\tDWIm/RAeSz9fjezoAyVvHIbAZ8IREGrIU0lRan0VRx++ZqjxjFKWWEaevrGRxVOM+URCqXgeDjo9c\n\tLxup/5kmGapLoDJf2RESyIQb5Q1lO/r2j/H0/a07soZnQmytmiHmrwtzesDeo+y22AM3FvdrtdoCn\n\tS/uaYbe5J7SOdTzHj/Dg==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406878; x=1808942878;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=4uetQXgL9vYPnyi2iMG9GxqESG4l+7IafRCd7ECneAI=;\n b=QnRMLsViG5TGVHrnwb8hO4cHlOIsYTv45MS09yObCwxxGofblX2GhR94\n SnhRDKQmYVKvF0nhdemu2nMK3VDiDwJ5zgIeBsmxVj+gMo5RAajW1bL4R\n m/qD5QrSD1ngrE3TiFSLRJEVosqbqeGBFDZeKDOXv9d+5Uh4H3ab+qaPH\n r8isZFDT1idpJLSMd+Xxgw0+01sy1+ARqsz7Kj0yCRdcexdcxtZnpavxg\n 6ex/fs/55aqQxuEqU18ouurPdy6SOb3YWFOz0C+1YRsNVvz0i3t+DVD8J\n iAyIu31EU7X/M5p2D2xCx41452IIdNWhg3GxyWDVaJ2WWoEcEv2H2TiMB\n A==;"],"X-CSE-ConnectionGUID":["Z61wMa80TrGhy1IX8Zlm5g==","xq9pWHltTwubCy8s4EYy0g=="],"X-CSE-MsgGUID":["xuT3KyrTSgOF+V9X4ym06w==","3LiiT7AjQTmDVpaga+pcmg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519357\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519357\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610136\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern ","Subject":"[PATCH 27/97] NAN: Process BIGTK KDE from NDP setup messages","Date":"Tue, 28 Apr 2026 23:05:28 +0300","Message-ID":"<20260428200639.40243-28-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_130757_588712_BBC3A46D ","X-CRM114-Status":"GOOD ( 11.87 )","X-Spam-Score":"-4.5 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Avraham Stern If the BIGTK\n KDE is included in the key data field of NDP setup M3 and M4 messages,\n parse\n it and install the BIGTK for Rx from this peer. Signed-off-by: Avraham\n Stern\n --- src/nan/nan_i.h | 2 ++ src/nan/nan_sec.c |\n 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+)\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Avraham Stern \n\nIf the BIGTK KDE is included in the key data field of NDP setup\nM3 and M4 messages, parse it and install the BIGTK for Rx from\nthis peer.\n\nSigned-off-by: Avraham Stern \n---\n src/nan/nan_i.h | 2 ++\n src/nan/nan_sec.c | 35 +++++++++++++++++++++++++++++++++++\n 2 files changed, 37 insertions(+)","diff":"diff --git a/src/nan/nan_i.h b/src/nan/nan_i.h\nindex a21e9d3f8e..84e9508fb8 100644\n--- a/src/nan/nan_i.h\n+++ b/src/nan/nan_i.h\n@@ -529,6 +529,7 @@ struct nan_pairing_peer_data {\n * @bootstrap: Bootstrap information of the peer\n * @pairing: Pairing data associated with this peer\n * @igtk_id: IGTK key ID used with this peer. Zero if IGTK is not used.\n+ * @bigtk_id: BIGTK key ID used with this peer. Zero if BIGTK is not used.\n */\n struct nan_peer {\n \tstruct dl_list list;\n@@ -548,6 +549,7 @@ struct nan_peer {\n \tstruct nan_pairing_peer_data pairing;\n \n \tu8 igtk_id;\n+\tu8 bigtk_id;\n };\n \n /**\ndiff --git a/src/nan/nan_sec.c b/src/nan/nan_sec.c\nindex 7220fc7fa3..4875fc14b7 100644\n--- a/src/nan/nan_sec.c\n+++ b/src/nan/nan_sec.c\n@@ -503,6 +503,41 @@ static int nan_sec_rx_key_data(struct nan_data *nan,\n \t\t\t\tigtk_kde->igtk, key_len);\n \t}\n \n+\tif (ie.bigtk && ie.bigtk_len) {\n+\t\tstruct wpa_bigtk_kde *bigtk_kde =\n+\t\t\t(struct wpa_bigtk_kde *)ie.bigtk;\n+\t\tu16 key_idx;\n+\n+\t\tif (ie.bigtk_len != WPA_BIGTK_KDE_PREFIX_LEN + key_len) {\n+\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t \"NAN: SEC: Invalid BIGTK KDE length: %zu (expected %d)\",\n+\t\t\t\t ie.bigtk_len,\n+\t\t\t\t WPA_BIGTK_KDE_PREFIX_LEN + key_len);\n+\t\t\tgoto fail;\n+\t\t}\n+\n+\t\tkey_idx = WPA_GET_LE16(bigtk_kde->keyid);\n+\t\tif (key_idx < 6 || key_idx > 7) {\n+\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t \"NAN: SEC: Invalid BIGTK key index: %u\",\n+\t\t\t\t key_idx);\n+\t\t\tgoto fail;\n+\t\t}\n+\n+\t\tif (nan->cfg->set_group_key(nan->cfg->cb_ctx, alg,\n+\t\t\t\t\t peer->nmi_addr, key_idx,\n+\t\t\t\t\t bigtk_kde->pn, bigtk_kde->bigtk,\n+\t\t\t\t\t key_len, KEY_FLAG_GROUP_RX) < 0) {\n+\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t \"NAN: SEC: Failed to install BIGTK\");\n+\t\t\tgoto fail;\n+\t\t}\n+\n+\t\tpeer->bigtk_id = key_idx;\n+\t\twpa_hexdump_key(MSG_DEBUG, \"NAN: SEC: Received BIGTK\",\n+\t\t\t\tbigtk_kde->bigtk, key_len);\n+\t}\n+\n \tret = 0;\n fail:\n \twpabuf_clear_free(key_data);\n","prefixes":["27/97"]}