{"id":2229827,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229827/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-23-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-23-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:23","name":"[22/97] NAN: Add and implement set_group_key() callback","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1572931e4709e432dac0568069e247439744c76a","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-23-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229827/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229827/checks/","tags":{},"headers":{"Return-Path":"\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PP82CtEV;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=DrOG8Ayk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s3N4N6wz1yJH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:09:36 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHojv-00000002EMD-3md3;\n\tTue, 28 Apr 2026 20:09:03 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoij-00000002CcZ-0VWs\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:50 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n  by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:49 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n  by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:47 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=u0MUFySn67w/QWA0HYuYjqyIHKMqmZoH9fz+J6QJOws=; b=PP82CtEVjza6zs\n\t0wZ01TpqBDoxmsiJcx4+gdOJlrIprjIBAHJpe3uPq/BD685hYrifmXdQ38IIotBFBFbRZt2rLwYMS\n\tgoIj/fiRs4ZNMlteYxPc/DrHsFGuutm31JaeLpHMs1ZzOdnWZNL3QXw3CUnwdSoSad5hCWDX02++R\n\tn07zMkVNRfMMhHDPxccPCckSOMZXn00kaUFHJOEanIdmnM7HBNyIGfo8GR7qYqywAz0sQgj9rNNzC\n\ti8Xm51dnnfW9Wy8MUzbIQLJoALRyDhQobnH1boh/GNOQZaxtX3bvbZ29tQcZwlL68ABpxpggbGGaS\n\tzqYcXbpJDn9kOtOHPHGg==;","v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777406870; x=1808942870;\n  h=from:to:cc:subject:date:message-id:in-reply-to:\n   references:mime-version:content-transfer-encoding;\n  bh=Awpzbe6eh+8vGzIoWaj2b47L5FE5qaGb9g103c30Xsc=;\n  b=DrOG8AykuEyh0kx95O2FJF2H2q2DPsBV4QfUhg9mYhtZeCWnU35YVZJK\n   Z0ddIZwF7evzyi93RXqWbEG5Ud//etMLc5wPXj39qPlRs5pwTkD7BIYfT\n   JfdGdoRBK5gWIv07iatzJKTA7vAYPakLIdAH6edFKpT8ewdVdDibxsUaS\n   l61rHLJcHI3Q0+c+CwO7UgQEfvoopx5qPHO4OjxeLVYVmblWYnIVGhntP\n   RF6T4/QuOWz0YkDD45hPXK6JW477+NCc4QaBKulbas7yM0ZAmep87oKDh\n   JxPlL1X/W2ifuDSFNdG0K3YCHSwVS35FDXFbPYfkGZ+rWFuNaGVzHKnGQ\n   g==;"],"X-CSE-ConnectionGUID":["8biVGQieRLeh6uYEgsYBLA==","nHPVJ6apQBis0LCLTJ1ZjQ=="],"X-CSE-MsgGUID":["ELoQsj6UTcOIhlHq6hAI3g==","7NQMcJcqRu+bCoJGWNrGcg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519338\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"78519338\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"257610084\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski <andrei.otcheretianski@intel.com>","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern <avraham.stern@intel.com>","Subject":"[PATCH 22/97] NAN: Add and implement set_group_key() callback","Date":"Tue, 28 Apr 2026 23:05:23 +0300","Message-ID":"<20260428200639.40243-23-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_130749_444943_F8E29AD3 ","X-CRM114-Status":"GOOD (  11.65  )","X-Spam-Score":"-4.5 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam.  The original\n message has been attached to this so you can view it or label\n similar future email.  If you have any questions, see\n the administrator of that system for details.\n Content preview:  From: Avraham Stern <avraham.stern@intel.com> Add a\n callback\n    for installing a group key. This callback will be used for installing the\n    IGTK/BIGTK. Signed-off-by: Avraham Stern <avraham.stern@intel.com> ---\n src/nan/nan.h\n    | 22 ++++++++++++++++++++++ wpa_supplicant/nan_supplicant.c | 12\n ++++++++++++\n    2 files changed, 34 insertions(+)\n Content analysis details:   (-4.5 points, 5.0 required)\n  pts rule name              description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,\n                             medium trust\n                             [198.175.65.16 listed in list.dnswl.org]\n  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS               SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from\n                             envelope-from domain\n  0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID             Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from\n author's\n                             domain\n -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n                             [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Avraham Stern <avraham.stern@intel.com>\n\nAdd a callback for installing a group key. This callback will be used\nfor installing the IGTK/BIGTK.\n\nSigned-off-by: Avraham Stern <avraham.stern@intel.com>\n---\n src/nan/nan.h                   | 22 ++++++++++++++++++++++\n wpa_supplicant/nan_supplicant.c | 12 ++++++++++++\n 2 files changed, 34 insertions(+)","diff":"diff --git a/src/nan/nan.h b/src/nan/nan.h\nindex 979fb66c14..f4e839aa4d 100644\n--- a/src/nan/nan.h\n+++ b/src/nan/nan.h\n@@ -697,6 +697,28 @@ struct nan_config {\n \tvoid (*pairing_request)(void *ctx, const u8 *peer_nmi, u8 csid,\n \t\t\t\tu8 instance_id,\n \t\t\t\tconst struct wpa_ie_data *rsn_data);\n+\n+\t/**\n+\t * set_group_key - Install a group key\n+\t *\n+\t * @ctx: Callback context from cb_ctx\n+\t * @alg: Encryption algorithm (WPA_ALG_* )\n+\t * @addr: Address of the peer STA for Rx group keys, ff:ff:ff:ff:ff:ff\n+\t *\tfor Tx keys; when clearing keys, %NULL is used to\n+\t *\tindicate that both the broadcast-only and default key of the\n+\t *\tspecified key index is to be cleared\n+\t * @key_idx: Key index\n+\t * @seq: Packet number, the next packet number to be\n+\t *\tused for in replay protection; %NULL if not set\n+\t * @key: Key buffer\n+\t * @key_len: Length of the key buffer in octets\n+\t * @key_flags: bitwise OR of KEY_FLAG_*\n+\t * Returns: 0 on success, -1 on failure\n+\t */\n+\tint (*set_group_key)(void *ctx, enum wpa_alg alg, const u8 *addr,\n+\t\t\t     int key_idx, const u8 *seq,\n+\t\t\t     const u8 *key, size_t key_len,\n+\t\t\t     enum key_flag key_flags);\n };\n \n struct nan_data * nan_init(const struct nan_config *cfg);\ndiff --git a/wpa_supplicant/nan_supplicant.c b/wpa_supplicant/nan_supplicant.c\nindex b53670174c..5e612dd73c 100644\n--- a/wpa_supplicant/nan_supplicant.c\n+++ b/wpa_supplicant/nan_supplicant.c\n@@ -916,6 +916,17 @@ static int wpas_nan_pasn_auth_status_cb(void *ctx, const u8 *peer_addr,\n \treturn 0;\n }\n \n+static int wpas_nan_set_group_key_cb(void *ctx, enum wpa_alg alg,\n+\t\t\t\t     const u8 *addr, int key_idx, const u8 *seq,\n+\t\t\t\t     const u8 *key, size_t key_len,\n+\t\t\t\t     enum key_flag key_flags)\n+{\n+\tstruct wpa_supplicant *wpa_s = ctx;\n+\n+\treturn wpa_drv_set_key(wpa_s, -1, alg, addr, key_idx, 0,\n+\t\t\t       seq, RSN_PN_LEN, key, key_len, key_flags);\n+}\n+\n \n static int wpas_nan_update_pairing_credentials_cb(void *ctx, const u8 *nik,\n \t\t\t\t\t\t  size_t nik_len,\n@@ -1129,6 +1140,7 @@ int wpas_nan_init(struct wpa_supplicant *wpa_s)\n \t\tnan.get_chans = wpas_nan_get_chans_cb;\n \t\tnan.is_valid_publish_id = wpas_nan_is_valid_publish_id_cb;\n \t\tnan.set_peer_schedule = wpas_nan_set_peer_schedule_cb;\n+\t\tnan.set_group_key = wpas_nan_set_group_key_cb;\n \n \t\twpa_printf(MSG_DEBUG, \"NAN: Bootstrap support enabled\");\n \t\tnan.bootstrap_request = wpas_nan_bootstrap_request_cb;\n","prefixes":["22/97"]}