{"id":2229822,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229822/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-20-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-20-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:20","name":"[19/97] NAN: Support configuration and notification of IPv6 local identifier","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2012892698718e6b9bd6b2a6b4d3e0075d7b28dc","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-20-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229822/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229822/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ktx7u96u;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=JynYFr4n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s2p2W0Vz1yJH\n\tfor ; Wed, 29 Apr 2026 06:09:06 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHojU-00000002DnJ-2CcH;\n\tTue, 28 Apr 2026 20:08:36 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoie-00000002Cfh-1b6J\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:45 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:45 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:42 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=lVkXUvQEX9gAZ9dWrbqOrH9Gaz82DJTqEWdW7MqUH0E=; b=ktx7u96uQdz75K\n\tP8BCwswE5DVXPL+qzceA8vIIyK3s6abWIVIZUCh7S6U9oysnPd0UJofXGXs1/7Znw9j/iTenowpUV\n\tyckstcZjV7wkUUw2u2gdwne6psn2+6exvhc6uiD5UEj8WVxC5ibBhH2g7QCAzdZNNhxOp7mtzJHcb\n\tMWfwC2KZNudIpv2OLjNxpZhorsNgVdN8QI5kYMJ0GfwrJSzmYR0gmuFYPeKLvftODdloHSGR+8DeE\n\tcGfbs2YGIDxBvY3oo94OEECI1cdFWrXHbB3zsUQsQevsbwmnSrKTfESWmUaSItOWx5bL+ItzW3vkM\n\tQJ4INDKMNYkX9Y098LJg==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406865; x=1808942865;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=z6xcuX1eWC427FlmYSWsNOhAOEuimWKLPFmbVxceZ0E=;\n b=JynYFr4nhJRVr+aCoo9B6j/w7PLblA3BaVQmop/km9H0HbW5wiPpOvSk\n W0E5sMZM0huDPR3tIQ53qqMoc/AYE95rwHuDE0ZFHzcYUkBlIGrLSiRwf\n GrhabfiiiGcTrvCVmonCtLP78ulSLk7aGs5XSt3Kxw+b04R/F7btc7XPv\n 1giojbxYVBBzof9sQyfxYOniQzczeYa8nzoLtizgsqwMwEjncnCoNZxus\n +3iOF6zg3ynUTSMFgnbTz56RT7zCA//52GxgYALlwzwlyNjkSO5Kw+Y//\n 4CIvh/abalvcjDX9D7prlPXo7qec+CPj6+6DMweYYkizw5MHe20i47F36\n A==;"],"X-CSE-ConnectionGUID":["dODdvZXmTO6MlQrSDZNFGg==","YVr+twwbRlm6elTdaBB/pA=="],"X-CSE-MsgGUID":["RCwS+CE7Si23MpAmnjEd1g==","8lrus5QwS4ueMEFd8tTxgg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519328\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519328\"","E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610053\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tIlan Peer ","Subject":"[PATCH 19/97] NAN: Support configuration and notification of IPv6\n local identifier","Date":"Tue, 28 Apr 2026 23:05:20 +0300","Message-ID":"<20260428200639.40243-20-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_130744_577620_D7BBD15A ","X-CRM114-Status":"GOOD ( 12.83 )","X-Spam-Score":"-4.5 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer Add support for\n configuring\n NAN IPv6 local identifier in the NDP request/response and indicating the\n peer IPv6 local identifier in NDP connected notification. Finally, indicate\n support for NDPE in the device capabilities attribute.\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Ilan Peer \n\nAdd support for configuring NAN IPv6 local identifier in the NDP\nrequest/response and indicating the peer IPv6 local identifier\nin NDP connected notification.\n\nFinally, indicate support for NDPE in the device capabilities\nattribute.\n\nSigned-off-by: Ilan Peer \n---\n wpa_supplicant/nan_supplicant.c | 35 ++++++++++++++++++++++++++++++---\n wpa_supplicant/notify.c | 26 +++++++++++++++++++-----\n wpa_supplicant/notify.h | 3 ++-\n 3 files changed, 55 insertions(+), 9 deletions(-)","diff":"diff --git a/wpa_supplicant/nan_supplicant.c b/wpa_supplicant/nan_supplicant.c\nindex a1fff99aba..b53670174c 100644\n--- a/wpa_supplicant/nan_supplicant.c\n+++ b/wpa_supplicant/nan_supplicant.c\n@@ -628,7 +628,8 @@ static int wpas_nan_ndp_connected_cb(void *ctx,\n \twpas_notify_nan_ndp_connected(wpa_s, params->ndp_id.peer_nmi,\n \t\t\t\t params->ndp_id.id,\n \t\t\t\t params->local_ndi, params->peer_ndi,\n-\t\t\t\t params->ssi, params->ssi_len);\n+\t\t\t\t params->ssi, params->ssi_len,\n+\t\t\t\t params->interface_id);\n \n return 0;\n }\n@@ -1157,6 +1158,7 @@ int wpas_nan_init(struct wpa_supplicant *wpa_s)\n \tnan.dev_capa.channel_switch_time =\n \t\twpa_s->nan_capa.max_channel_switch_time;\n \tnan.dev_capa.capa = wpa_s->nan_capa.dev_capa;\n+\tnan.dev_capa.capa |= NAN_DEV_CAPA_NDPE_ATTR_SUPP;\n \n \tnan.supported_bootstrap_methods = DEFAULT_NAN_SUPP_PBM;\n \tnan.auto_accept_bootstrap_methods = DEFAULT_NAN_AUTO_ACCEPT_PBM;\n@@ -2213,7 +2215,7 @@ static int wpas_nan_fill_nd_pmk(struct wpa_supplicant *wpa_s,\n \n /* Command format NAN_NDP_REQUEST handle= ndi= peer_nmi=\n peer_id= ssi= qos=\n- [csid = |pmk=>] */\n+ [csid = |pmk=>] [interface_id=]*/\n int wpas_nan_ndp_request(struct wpa_supplicant *wpa_s, char *cmd)\n {\n \tstruct nan_ndp_params ndp;\n@@ -2313,6 +2315,18 @@ int wpas_nan_ndp_request(struct wpa_supplicant *wpa_s, char *cmd)\n \t\t\tpwd = pos;\n \t\t} else if (os_strcmp(token, \"pmk\") == 0) {\n \t\t\tpmk = pos;\n+\t\t} else if (os_strcmp(token, \"interface_id\") == 0) {\n+\t\t\tndp.interface_id = os_malloc(NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN);\n+\t\t\tif (!ndp.interface_id)\n+\t\t\t\tgoto fail;\n+\n+\t\t\tif (hexstr2bin(pos, ndp.interface_id,\n+\t\t\t\t NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN) < 0) {\n+\t\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t\t \"NAN: Invalid interface_id hex data: %s\",\n+\t\t\t\t\t pos);\n+\t\t\t\tgoto fail;\n+\t\t\t}\n \t\t} else {\n \t\t\twpa_printf(MSG_INFO, \"NAN: Unknown parameter: %s\",\n \t\t\t\t token);\n@@ -2368,6 +2382,7 @@ int wpas_nan_ndp_request(struct wpa_supplicant *wpa_s, char *cmd)\n fail:\n \twpabuf_free(ndp.sched.elems);\n \twpabuf_free(ssi_buf);\n+\tos_free(ndp.interface_id);\n \n \treturn ret;\n }\n@@ -2377,7 +2392,7 @@ fail:\n [reason_code=]\n [ndi= handle= init_ndi=\n ndp_id= [ssi=] [qos=]\n- [csid= |pmk=]] */\n+ [csid= |pmk=]] [interface_id=] */\n int wpas_nan_ndp_response(struct wpa_supplicant *wpa_s, char *cmd)\n {\n \tstruct nan_ndp_params ndp;\n@@ -2490,6 +2505,18 @@ int wpas_nan_ndp_response(struct wpa_supplicant *wpa_s, char *cmd)\n \t\t\tpwd = pos;\n \t\t} else if (os_strcmp(token, \"pmk\") == 0) {\n \t\t\tpmk = pos;\n+\t\t} else if (os_strcmp(token, \"interface_id\") == 0) {\n+\t\t\tndp.interface_id = os_malloc(NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN);\n+\t\t\tif (!ndp.interface_id)\n+\t\t\t\tgoto fail;\n+\n+\t\t\tif (hexstr2bin(pos, ndp.interface_id,\n+\t\t\t\t NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN) < 0) {\n+\t\t\t\twpa_printf(MSG_DEBUG,\n+\t\t\t\t\t \"NAN: Invalid interface_id hex data: %s\",\n+\t\t\t\t\t pos);\n+\t\t\t\tgoto fail;\n+\t\t\t}\n \t\t} else {\n \t\t\twpa_printf(MSG_DEBUG, \"NAN: Unknown parameter: %s\",\n \t\t\t\t token);\n@@ -2572,6 +2599,8 @@ int wpas_nan_ndp_response(struct wpa_supplicant *wpa_s, char *cmd)\n fail:\n \twpabuf_free(ndp.sched.elems);\n \twpabuf_free(ssi_buf);\n+\tos_free(ndp.interface_id);\n+\n \treturn ret;\n }\n \ndiff --git a/wpa_supplicant/notify.c b/wpa_supplicant/notify.c\nindex 2881fddab2..ec2c68ea11 100644\n--- a/wpa_supplicant/notify.c\n+++ b/wpa_supplicant/notify.c\n@@ -1409,9 +1409,10 @@ void wpas_notify_nan_ndp_connected(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *peer_nmi, u32 ndp_id,\n \t\t\t\t const u8 *local_ndi,\n \t\t\t\t const u8 *peer_ndi,\n-\t\t\t\t const u8 *ssi, size_t ssi_len)\n+\t\t\t\t const u8 *ssi, size_t ssi_len,\n+\t\t\t\t const u8 *interface_id)\n {\n-\tchar *ssi_hex = NULL;\n+\tchar *ssi_hex = NULL, *interface_id_hex = NULL;\n \n \tif (ssi) {\n \t\tssi_hex = os_zalloc(2 * ssi_len + 1);\n@@ -1421,13 +1422,28 @@ void wpas_notify_nan_ndp_connected(struct wpa_supplicant *wpa_s,\n \t\twpa_snprintf_hex(ssi_hex, 2 * ssi_len + 1, ssi, ssi_len);\n \t}\n \n+\tif (interface_id) {\n+\t\tinterface_id_hex =\n+\t\t\tos_zalloc(2 * NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN + 1);\n+\t\tif (!interface_id_hex)\n+\t\t\treturn;\n+\n+\t\twpa_snprintf_hex(interface_id_hex,\n+\t\t\t\t 2 * NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN + 1,\n+\t\t\t\t interface_id,\n+\t\t\t\t NAN_NDPE_TLV_IPV6_LINK_LOCAL_LEN);\n+\t}\n+\n \twpa_msg_global(wpa_s, MSG_INFO, NAN_NDP_CONNECTED \"peer=\" MACSTR\n \t\t \" ndp_id=%u local_ndi=\" MACSTR\n-\t\t \" peer_ndi=\" MACSTR \" ssi=%s\",\n-\t\t MAC2STR(peer_nmi), ndp_id, MAC2STR(local_ndi),\n-\t\t MAC2STR(peer_ndi), ssi_hex ? ssi_hex : \"\");\n+\t\t \" peer_ndi=\" MACSTR \" ssi=%s interface_id=%s\",\n+\t\t MAC2STR(peer_nmi), ndp_id,\n+\t\t MAC2STR(local_ndi), MAC2STR(peer_ndi),\n+\t\t ssi_hex ? ssi_hex : \"\",\n+\t\t interface_id ? interface_id_hex : \"\");\n \n \tos_free(ssi_hex);\n+\tos_free(interface_id_hex);\n }\n \n \ndiff --git a/wpa_supplicant/notify.h b/wpa_supplicant/notify.h\nindex 3c2feece9e..f6d3654e17 100644\n--- a/wpa_supplicant/notify.h\n+++ b/wpa_supplicant/notify.h\n@@ -238,7 +238,8 @@ void wpas_notify_nan_ndp_counter_request(struct wpa_supplicant *wpa_s,\n void wpas_notify_nan_ndp_connected(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *peer_nmi, u32 ndp_id,\n \t\t\t\t const u8 *local_ndi, const u8 *peer_ndi,\n-\t\t\t\t const u8 *ssi, size_t ssi_len);\n+\t\t\t\t const u8 *ssi, size_t ssi_len,\n+\t\t\t\t const u8 *interface_id);\n void wpas_notify_nan_ndp_disconnected(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *peer_nmi, u32 ndp_id,\n \t\t\t\t const u8 *local_ndi, const u8 *peer_ndi,\n","prefixes":["19/97"]}