{"id":2229801,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229801/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-5-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.1/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428200639.40243-5-andrei.otcheretianski@intel.com>","date":"2026-04-28T20:05:05","name":"[04/97] NAN: Fix A3 in multicast solicited replies","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"91ae45e1651cd6124ef79f7c2943b842c26670b1","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.1/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-5-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501927,"url":"http://patchwork.ozlabs.org/api/1.1/series/501927/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501927","date":"2026-04-28T20:05:05","name":"NAN: Group keys support, schedule update and more","version":1,"mbox":"http://patchwork.ozlabs.org/series/501927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229801/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229801/checks/","tags":{},"headers":{"Return-Path":"\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=rWcBUzd0;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Quazee5B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s1W4pvnz1yJH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:07:55 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoiI-00000002CG1-45kR;\n\tTue, 28 Apr 2026 20:07:22 +0000","from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoiH-00000002CE6-0QGW\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:22 +0000","from fmviesa001.fm.intel.com ([10.60.135.141])\n  by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:21 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n  by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:19 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Rj+UEwxMeLV1qTls3y5+tGWk5L35Ra4WaXAB0Er76/g=; b=rWcBUzd09llRug\n\tcbfp2NgAoggNqGbPnsb08VxdKdQfRQ9D0tme03RGhKYzzFNt3Or3R/w9rPiF8/mKyQHfp6q490JqF\n\tMw4Ywy454nPFCQ6b4hJYK31ybd0c6apiOECknasdpmp0UtJhD842bX21nBFOUVoPmKtLOhMg/rmk1\n\tysWxe8YswbI5ti/RXfO2ZteVMQEn+SQhlTuR/z+kd84RRaFZBON1ZIp2cjWkyh10z6DHq2xYp+NR9\n\tCf7mBzl34twEH4iBLdVCPWHPzahYXZBZvVm0UgMYDqUMWtFAq2MlPyLu+9/hXFJij6GUY8OVmeKUW\n\tydhadP/koAkdBkpgUcYQ==;","v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777406842; x=1808942842;\n  h=from:to:cc:subject:date:message-id:in-reply-to:\n   references:mime-version:content-transfer-encoding;\n  bh=cxT40ne1w6UlSgd67Dl1e0puIPMBHsphkb76k2+SVDw=;\n  b=Quazee5BYLx2Vvb9sLG9VtbNMOcG1zYPfa9vtWaiNsvvpi0yby+/1vqw\n   XgR9q5L1jD0gC7lt2dArAzse9TCpaKufMPvTw3IL9iao6bOppCkPNH2UF\n   m/kGuL/+YcgzHgttROea0E52emRdq4s1iQjowPE1nd/RO0ORk1zdpU4Jf\n   EeOMYBKFIKErzr3I/xzb7dGnWK1oRMQV573wSkfgOAgYsaL+pJn6BcStm\n   PmUHEcwiS91X05eWjuzblh43YAlwvQtd8N2CW4RJCIFjWssi1tuYtuBiy\n   ErEsws3DAq91gCy6vtOrf4ACZ44aTDPAiuleS87P0VWFEcnOwdAbcxk9p\n   A==;"],"X-CSE-ConnectionGUID":["hto+VstjRM20kXofEG3lDQ==","umDk2xsVRCu3+qo11GG+kg=="],"X-CSE-MsgGUID":["oYkA7V62T+OAso5x1d8WPg==","QhLQ82OaQQi/U0zF3dAlHw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78519263\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"78519263\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"257609920\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski <andrei.otcheretianski@intel.com>","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAndrei Otcheretianski <andrei.otcheretianski@intel.com>","Subject":"[PATCH 04/97] NAN: Fix A3 in multicast solicited replies","Date":"Tue, 28 Apr 2026 23:05:05 +0300","Message-ID":"<20260428200639.40243-5-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","References":"<20260428200639.40243-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_130721_199521_6B806D78 ","X-CRM114-Status":"UNSURE (   9.57  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.5 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam.  The original\n message has been attached to this so you can view it or label\n similar future email.  If you have any questions, see\n the administrator of that system for details.\n Content preview:  For sync services,\n cluster ID should be used. Fix it. Signed-off-by:\n    Andrei Otcheretianski <andrei.otcheretianski@intel.com> ---\n src/common/nan_de.c\n    | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)\n Content analysis details:   (-4.5 points, 5.0 required)\n  pts rule name              description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,\n                             medium trust\n                             [198.175.65.16 listed in list.dnswl.org]\n  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS               SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from\n                             envelope-from domain\n  0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID             Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from\n author's\n                             domain\n -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n                             [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH         DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"For sync services, cluster ID should be used. Fix it.\n\nSigned-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>\n---\n src/common/nan_de.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/common/nan_de.c b/src/common/nan_de.c\nindex 201eb8474c..154c7c0a00 100644\n--- a/src/common/nan_de.c\n+++ b/src/common/nan_de.c\n@@ -1592,7 +1592,9 @@ static bool nan_de_rx_subscribe(struct nan_de *de, struct nan_de_service *srv,\n \telse\n \t\tnetwork_id = nan_network_id;\n \n-\tif (srv->publish.solicited_multicast || !a3)\n+\tif (srv->sync && de->cluster_id_set)\n+\t\ta3 = de->cluster_id;\n+\telse if (srv->publish.solicited_multicast || !a3)\n \t\ta3 = network_id;\n \telse if (srv->is_p2p)\n \t\ta3 = de->nmi;\n","prefixes":["04/97"]}