{"id":2229768,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229768/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-4-sprasad@microsoft.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428160804.281745-4-sprasad@microsoft.com>","date":"2026-04-28T16:07:49","name":"[v3,04/19] cifs: define variable sized buffer for querydir responses","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aaaf955d39d88076fd07aaf7c310fa5f054b7da1","submitter":{"id":79368,"url":"http://patchwork.ozlabs.org/api/1.1/people/79368/?format=json","name":"Shyam Prasad N","email":"nspmangalore@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-4-sprasad@microsoft.com/mbox/","series":[{"id":501896,"url":"http://patchwork.ozlabs.org/api/1.1/series/501896/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501896","date":"2026-04-28T16:07:57","name":"[v3,01/19] cifs: change_conf needs to be called for session setup","version":3,"mbox":"http://patchwork.ozlabs.org/series/501896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229768/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229768/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=eCX1iSm/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11241-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"eCX1iSm/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.179","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4nXb1XVSz1xvV\n\tfor ; Wed, 29 Apr 2026 03:31:10 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 4E9FE34690DA\n\tfor ; Tue, 28 Apr 2026 16:14:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 402F244CAD3;\n\tTue, 28 Apr 2026 16:08:25 +0000 (UTC)","from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE99F44BCB6\n\tfor ; Tue, 28 Apr 2026 16:08:23 +0000 (UTC)","by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-2ad4d639db3so57673455ad.0\n for ;\n Tue, 28 Apr 2026 09:08:23 -0700 (PDT)","from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b97ac7894csm30864465ad.50.2026.04.28.09.08.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 09:08:22 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777392505; cv=none;\n b=uQhzxxh74BRZowIILzVdXWnmeK+2lLG454WpmYPuXwuM+Cz9LPYVIj0/WPzQD6uBTVdksT+BB8uob6fb/UMKa3gYuV4E2fpRX0Wd55Uxu935HEZbS9LrDqlwv+qv0hcb8U3eYU69yJqWMqIFpNLQmrXEUROj4hek6keoUxW4z2g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777392505; c=relaxed/simple;\n\tbh=7fs/qpQj7CViKJpl1xKhLVHakBiwsBbgCOkyBzjRtuo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Mjb97F8UTuD8LwZWHb1fsKVE7eBb37En3iL7GdvFkXIeoGlGr/kg2Dg+PvuSTURsVYC5+SFr7Ez/ZrZVDNclO7kGeaH7YgUMGv0Cvh4+Zmkatngw38SIYYrzf+DQZMohvss3U36RQmFyHs5J8aqIShQpIlPy8CrMjwzHoRL5ylg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=eCX1iSm/; arc=none smtp.client-ip=209.85.214.179","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777392503; x=1777997303;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4CeNnh5BjM1nRomeWQoA26EkMPBAyik+6iryoO/A02Y=;\n b=eCX1iSm/pNtiEfgE/MKPgZzTZnDcB3VNGGmF/WbS5VynoPcoWs+AK4DR3QvJAPiBhP\n Y0tDlZkNLpzCqHjzxThoDdiEhN6tBZHUmaaq0+Y5gDTra0f0YwNJAWRtP5CUbkRthVkl\n FlKg5NCkoHZYVacHf11whpJlN7JPYDQzhA4QzbWumaIAM7JybmgtQZE3v0RKst0qb1Eh\n +rKizQD61nx3uH8trBior4tDC10xn1JP2vi/teSc0G4t3GcOwEKXCPu+I1wBOU0z2bXS\n +dvEQMa5cHAHuBtZxseeuaQZc9Fph64CC+1EaVyX5d7hJV7+1m9fKiJR95INp/5oQbYj\n tJjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777392503; x=1777997303;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4CeNnh5BjM1nRomeWQoA26EkMPBAyik+6iryoO/A02Y=;\n b=sRrzGMYv9z6UyzgFAybFg5zS7zKJ4jUy2k+0B9hWwM8VZ7hitAQuloxnmthiPtgpOg\n EATaC6HtIl0ZwNrgelX5gLivw9qVy/ajSij8HgOuIPWb2YGVeKPPReNG7EWD4GS2kLQ8\n AuiL2doWEfNi2+3IKqvRwaVSdb/jEW6Hx84bGSIwfMl2cvT1ZxZa6P3Wl2clVebyFXgI\n 9wda/03JyRZ4m3MGOYcRjqdq0FFZPWkMmpj0D0ByxiQQ+dh/X6UdEi0kPiwftOWDSggE\n 0apzdvODpEOCbgciHzBg772ZuI1LUID6KDbjrTwgIrgYYltUng+tZPWaIPkYSBFrc84Q\n Y0ew==","X-Gm-Message-State":"AOJu0YyKkJC1x2/HsemwWDiQhiNGu4FH/6zQse+6WPVrN2Dt/6XDDQA9\n\tKb/ydK4jvyr1C4R/4n5u/CQfkF3lEmd5VPdip1CWC3zkfiqzm1GbU57ktLqTc53S","X-Gm-Gg":"AeBDieu4vdvt4A6VDDa0UvsHBzjDD78s4DX0mVhpCfIoAWAlpiyAbrM8dbmJXkq4AHC\n\t+8M2FL9S0KQX4o9z5QpcOmvHUVkS0DuBrt8mvEMB54d9zBzwaMbHs0Cf03qnkIgSG16BQH3mB5j\n\t1UkNOGiP63KRheMWUvAFBbONMga7/6OL4HKWVvzJ5N38mKzokeeCJ8zAQRk/8qg0LqcZN/XZZAW\n\tqmd2PaqxkZWuog8s0fkUwwd2OJowGz8jQhlOOQWbrRCwa/1fDqtfalRDL7EPgTdxtBcMgJ7hFbx\n\t00QSHZnRnc7hl7IrK7gaDk+Q8a1gNUXrO40z+IRT6OxK4rcXGgKmisK9zQ+K24moATXaBZhqFXA\n\tLhiCXkMEcFSFY56f1kSancq23im7pbuKu3kORKhvBKdf0YSyfHE7KWQHmer/ic7/B1FD4wWlJLN\n\teEyCi2chomtKSbIUK4wrrvQeUPK9cx8MVtvNUEb3KeeP947q49IN0FM6jhEZCGs9cO","X-Received":"by 2002:a17:902:c412:b0:2b0:5cb4:d89d with SMTP id\n d9443c01a7336-2b97c499589mr39140425ad.29.1777392502782;\n Tue, 28 Apr 2026 09:08:22 -0700 (PDT)","From":"nspmangalore@gmail.com","X-Google-Original-From":"sprasad@microsoft.com","To":"linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de","Cc":"Shyam Prasad N ","Subject":"[PATCH v3 04/19] cifs: define variable sized buffer for querydir\n responses","Date":"Tue, 28 Apr 2026 21:37:49 +0530","Message-ID":"<20260428160804.281745-4-sprasad@microsoft.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260428160804.281745-1-sprasad@microsoft.com>","References":"<20260428160804.281745-1-sprasad@microsoft.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Shyam Prasad N \n\nQueryDirectory responses today are stored in one of two fixed\nsized buffers: smallbuf (448 bytes) or bigbuf (16KB). These are\nborrowed from server struct and are not sufficient for large-sized\nquery dir operations.\n\nWith this change we will now define a new buffer type specifically\nfor cifs_search_info to hold variable sized responses. These will\nbe allocated by kmalloc and freed by kfree.\n\nSigned-off-by: Shyam Prasad N \n---\n fs/smb/client/cifsglob.h | 2 ++\n fs/smb/client/file.c | 2 ++\n fs/smb/client/readdir.c | 2 ++\n fs/smb/client/smb2pdu.c | 14 +++++++++++---\n 4 files changed, 17 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h\nindex 709e96e077916..8d089ba08e3e5 100644\n--- a/fs/smb/client/cifsglob.h\n+++ b/fs/smb/client/cifsglob.h\n@@ -1394,6 +1394,7 @@ struct cifs_search_info {\n \tbool emptyDir:1;\n \tbool unicode:1;\n \tbool smallBuf:1; /* so we know which buf_release function to call */\n+\tbool is_dynamic_buf:1; /* dynamically allocated buffer - can be variable size */\n };\n \n #define ACL_NO_MODE\t((umode_t)(-1))\n@@ -1907,6 +1908,7 @@ enum cifs_find_flags {\n #define CIFS_NO_BUFFER 0 /* Response buffer not returned */\n #define CIFS_SMALL_BUFFER 1\n #define CIFS_LARGE_BUFFER 2\n+#define CIFS_DYNAMIC_BUFFER 3 /* Dynamically allocated buffer */\n #define CIFS_IOVEC 4 /* array of response buffers */\n \n /* Type of Request to SendReceive2 */\ndiff --git a/fs/smb/client/file.c b/fs/smb/client/file.c\nindex a69e05f86d7e2..6a1419d59ed5a 100644\n--- a/fs/smb/client/file.c\n+++ b/fs/smb/client/file.c\n@@ -1546,6 +1546,8 @@ int cifs_closedir(struct inode *inode, struct file *file)\n \t\tcfile->srch_inf.ntwrk_buf_start = NULL;\n \t\tif (cfile->srch_inf.smallBuf)\n \t\t\tcifs_small_buf_release(buf);\n+\t\telse if (cfile->srch_inf.is_dynamic_buf)\n+\t\t\tkfree(buf);\n \t\telse\n \t\t\tcifs_buf_release(buf);\n \t}\ndiff --git a/fs/smb/client/readdir.c b/fs/smb/client/readdir.c\nindex be22bbc4a65a0..b50efd9b9e1d2 100644\n--- a/fs/smb/client/readdir.c\n+++ b/fs/smb/client/readdir.c\n@@ -732,6 +732,8 @@ find_cifs_entry(const unsigned int xid, struct cifs_tcon *tcon, loff_t pos,\n \t\t\tif (cfile->srch_inf.smallBuf)\n \t\t\t\tcifs_small_buf_release(cfile->srch_inf.\n \t\t\t\t\t\tntwrk_buf_start);\n+\t\t\telse if (cfile->srch_inf.is_dynamic_buf)\n+\t\t\t\tkfree(cfile->srch_inf.ntwrk_buf_start);\n \t\t\telse\n \t\t\t\tcifs_buf_release(cfile->srch_inf.\n \t\t\t\t\t\tntwrk_buf_start);\ndiff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c\nindex 5188218c25be4..49dca84b169e6 100644\n--- a/fs/smb/client/smb2pdu.c\n+++ b/fs/smb/client/smb2pdu.c\n@@ -5625,6 +5625,8 @@ smb2_parse_query_directory(struct cifs_tcon *tcon,\n \tif (srch_inf->ntwrk_buf_start) {\n \t\tif (srch_inf->smallBuf)\n \t\t\tcifs_small_buf_release(srch_inf->ntwrk_buf_start);\n+\t\telse if (srch_inf->is_dynamic_buf)\n+\t\t\tkfree(srch_inf->ntwrk_buf_start);\n \t\telse\n \t\t\tcifs_buf_release(srch_inf->ntwrk_buf_start);\n \t}\n@@ -5644,12 +5646,18 @@ smb2_parse_query_directory(struct cifs_tcon *tcon,\n \tcifs_dbg(FYI, \"num entries %d last_index %lld srch start %p srch end %p\\n\",\n \t\t srch_inf->entries_in_buffer, srch_inf->index_of_last_entry,\n \t\t srch_inf->srch_entries_start, srch_inf->last_entry);\n-\tif (resp_buftype == CIFS_LARGE_BUFFER)\n+\tif (resp_buftype == CIFS_LARGE_BUFFER) {\n \t\tsrch_inf->smallBuf = false;\n-\telse if (resp_buftype == CIFS_SMALL_BUFFER)\n+\t\tsrch_inf->is_dynamic_buf = false;\n+\t} else if (resp_buftype == CIFS_SMALL_BUFFER) {\n \t\tsrch_inf->smallBuf = true;\n-\telse\n+\t\tsrch_inf->is_dynamic_buf = false;\n+\t} else if (resp_buftype == CIFS_DYNAMIC_BUFFER) {\n+\t\tsrch_inf->smallBuf = false;\n+\t\tsrch_inf->is_dynamic_buf = true;\n+\t} else {\n \t\tcifs_tcon_dbg(VFS, \"Invalid search buffer type\\n\");\n+\t}\n \n \treturn 0;\n }\n","prefixes":["v3","04/19"]}