{"id":2229727,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229727/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428163702.3224323-1-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428163702.3224323-1-thuth@redhat.com>","date":"2026-04-28T16:37:02","name":"hw/vfio: Drop superfluous inclusion of hw-error.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3473626dfdbb2b1be6e3ffaa5947b6db2fd75f0c","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/1.1/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428163702.3224323-1-thuth@redhat.com/mbox/","series":[{"id":501901,"url":"http://patchwork.ozlabs.org/api/1.1/series/501901/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501901","date":"2026-04-28T16:37:02","name":"hw/vfio: Drop superfluous inclusion of hw-error.h","version":1,"mbox":"http://patchwork.ozlabs.org/series/501901/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229727/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229727/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YGLt/Grz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4mMd08N1z1xrS\n\tfor ; Wed, 29 Apr 2026 02:38:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHlR3-0004xx-36; Tue, 28 Apr 2026 12:37:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHlR0-0004xI-P4\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:37:18 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHlQx-0002NQ-7J\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:37:16 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-P8OMpp1lOviOWtNdeS59gA-1; Tue,\n 28 Apr 2026 12:37:10 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6893F195609E; Tue, 28 Apr 2026 16:37:08 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.44.32.74])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 59B22300756E; Tue, 28 Apr 2026 16:37:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777394233;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=Kj25SlUsmmALKk+qbpeQMijTUk7XTBdfa7B7QV3dyMk=;\n b=YGLt/GrztQzoYG3r8XO4ZAF7sXMOAV8Fp12oyqFq2Ijj/vcmbW1NMGkFddb4MtKY6sSdG/\n RdUZWD3EuBJp2s/WCPbnmD/EhkBvVFgP4T9a43YkeHs3LxrYVSjYMOWtjCDdFZoMMiqTiP\n x2UC1DFnVQ7Sj01nSesOPhatQEKy+DU=","X-MC-Unique":"P8OMpp1lOviOWtNdeS59gA-1","X-Mimecast-MFC-AGG-ID":"P8OMpp1lOviOWtNdeS59gA_1777394228","From":"Thomas Huth ","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org","Cc":"Alex Williamson , Tomita Moeko ,\n qemu-trivial@nongnu.org","Subject":"[PATCH] hw/vfio: Drop superfluous inclusion of hw-error.h","Date":"Tue, 28 Apr 2026 18:37:02 +0200","Message-ID":"<20260428163702.3224323-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Thomas Huth \n\nNone of these files use the hw_error() function, so there is no\nneed to include hw-error.h here.\n\nSigned-off-by: Thomas Huth \n---\n hw/vfio/device.c | 1 -\n hw/vfio/helpers.c | 1 -\n hw/vfio/igd.c | 1 -\n hw/vfio/kvm-helpers.c | 1 -\n 4 files changed, 4 deletions(-)","diff":"diff --git a/hw/vfio/device.c b/hw/vfio/device.c\nindex 3ffd69a579b..ccf14743e95 100644\n--- a/hw/vfio/device.c\n+++ b/hw/vfio/device.c\n@@ -24,7 +24,6 @@\n #include \"hw/vfio/vfio-device.h\"\n #include \"hw/vfio/pci.h\"\n #include \"hw/core/iommu.h\"\n-#include \"hw/core/hw-error.h\"\n #include \"trace.h\"\n #include \"qapi/error.h\"\n #include \"qemu/error-report.h\"\ndiff --git a/hw/vfio/helpers.c b/hw/vfio/helpers.c\nindex 65c6dba0428..c719864b92f 100644\n--- a/hw/vfio/helpers.c\n+++ b/hw/vfio/helpers.c\n@@ -24,7 +24,6 @@\n \n #include \"exec/cpu-common.h\"\n #include \"hw/vfio/vfio-device.h\"\n-#include \"hw/core/hw-error.h\"\n #include \"qapi/error.h\"\n #include \"vfio-helpers.h\"\n \ndiff --git a/hw/vfio/igd.c b/hw/vfio/igd.c\nindex 6aacf27284f..e091f21b6a3 100644\n--- a/hw/vfio/igd.c\n+++ b/hw/vfio/igd.c\n@@ -16,7 +16,6 @@\n #include \"qapi/error.h\"\n #include \"qapi/qmp/qerror.h\"\n #include \"hw/core/boards.h\"\n-#include \"hw/core/hw-error.h\"\n #include \"hw/nvram/fw_cfg.h\"\n #include \"pci.h\"\n #include \"pci-quirks.h\"\ndiff --git a/hw/vfio/kvm-helpers.c b/hw/vfio/kvm-helpers.c\nindex d71c9590aaa..5e73dddc418 100644\n--- a/hw/vfio/kvm-helpers.c\n+++ b/hw/vfio/kvm-helpers.c\n@@ -25,7 +25,6 @@\n #include \"system/kvm.h\"\n #include \"exec/cpu-common.h\"\n #include \"hw/vfio/vfio-device.h\"\n-#include \"hw/core/hw-error.h\"\n #include \"qapi/error.h\"\n #include \"vfio-helpers.h\"\n \n","prefixes":[]}