{"id":2229720,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229720/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-13-sprasad@microsoft.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428160804.281745-13-sprasad@microsoft.com>","date":"2026-04-28T16:07:58","name":"[v3,13/19] cifs: option to disable time-based eviction of cache","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2d4d3d001b83b63086d10ee79705072b89b8f278","submitter":{"id":79368,"url":"http://patchwork.ozlabs.org/api/1.1/people/79368/?format=json","name":"Shyam Prasad N","email":"nspmangalore@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-13-sprasad@microsoft.com/mbox/","series":[{"id":501896,"url":"http://patchwork.ozlabs.org/api/1.1/series/501896/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501896","date":"2026-04-28T16:07:57","name":"[v3,01/19] cifs: change_conf needs to be called for session setup","version":3,"mbox":"http://patchwork.ozlabs.org/series/501896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229720/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229720/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-11250-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FJVNGH3I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11250-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"FJVNGH3I\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.174","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4m8F6XzQz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 02:28:29 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 2480B30CFD80\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 16:14:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DD13244CAF8;\n\tTue, 28 Apr 2026 16:08:33 +0000 (UTC)","from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEFD44D01E\n\tfor <linux-cifs@vger.kernel.org>; Tue, 28 Apr 2026 16:08:32 +0000 (UTC)","by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-2ab077e3f32so50630235ad.3\n        for <linux-cifs@vger.kernel.org>;\n Tue, 28 Apr 2026 09:08:32 -0700 (PDT)","from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n        by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b97ac7894csm30864465ad.50.2026.04.28.09.08.30\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Tue, 28 Apr 2026 09:08:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777392513; cv=none;\n b=KHFtGgdBwWz1CmBnb9rwcyGiY0w96GigaBJ5c9RNe8j3OpT0QBe+WMTDNnvEtLaOSoyyhpVxNwSuA70r2AM3Rul2e2M22pivVNTCCxgmdWiu30pe0abxqZ2CGsQC1xEkPqRTYNNDYfsvluBsZLwpDipXlIOrTOozJJNb1m3kD2M=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777392513; c=relaxed/simple;\n\tbh=9v6XO9ylEL8LwjPW3xmhI3J94s+qIyMUgsSxkjgdOXk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=EH3E1O6syMGeWhW5QtDp5HbklWaxSui23RbeluRqfR3RMci9jLC0aKEUZItdvEnbcMrC3RTRP2x3NtfqxTAaN+Ib4l+QOb5eHrQDLNVwdZxZ5+jWTI4AzBiCtMxwJjDuPo7ftxFoENdEYwVSoBTk627iWNSrgR6Vg+cxpWh+u8I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=FJVNGH3I; arc=none smtp.client-ip=209.85.214.174","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777392511; x=1777997311;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=go18YIiEwWbQ57FroEFcnRyZ9WBWa63cQdoyTHIy0po=;\n        b=FJVNGH3IVcXfoO3S+EyBzA9XfUsDGetQ2NvmcMEcJqxHV1HS3orJ8ecA/XMgnxRzHt\n         1/RHkZBVU/cnOj95AuICKz1krgcE2IBQ9eSPPSRx2PBuIlBgLuymeGjrWXVUTdOKJIwK\n         ChALv3PCczcnRmSb/54csTVKM7W+VQ3V9LStTiOp/wwjSSJNXtRw+AVvU8tpSA3Ex+uQ\n         NQxNC6AdxhN8z950ai2pYiIzscNh2csyQivbeSmHJ0LnCx7qsuChs0ORakVHgWc71h2K\n         a7a+P1oUknHLZu3QYilLy7gBGzIhMW6YdqqQ5IxB7BAO8hTaSW4qPvMAbnC754Iaguxo\n         Ctnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777392511; x=1777997311;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=go18YIiEwWbQ57FroEFcnRyZ9WBWa63cQdoyTHIy0po=;\n        b=UgKSYbj31jnDKowYANds6y2Yb+W0HPU2iCSESK4Kbceeg2/GOrWeNsdI9O/zHm1KDK\n         NdnlwOepfS54ogzt1vhlEHcYmhOE/jsRiK3rcEGpoouhhPQyvjMovhD316FCL8OVI0o2\n         ZwXfcpv80+eRdPUcBKj6uX3xbksVi6TqfL+6JKd1WJwdLXvwqZ+TclWo1iTVS3lUP2x+\n         d9HQzdgZRQEynu8i8Lc8uwfzq+CYQwznQjdSlLy7hMjjnV4/MB0tbQ1IsvS5CjpxH1PX\n         A5KwpKk5OQy40/Jm1WWLog69xSv8v6s9Q9taw5hwCJP9aTQf3CY1pMTFkSxQVbqt9j7b\n         yFZA==","X-Gm-Message-State":"AOJu0YzikvEgLYyIcv2YCezsXuzgDKowZPaMBIU+o4IarHl6S9SPB/In\n\tJBUDkmCl7oFGbL6veA2EH2PVFZHH4vN/BVKNQ5QuTVCNkjjkLzlNlEWjB/ZG1tEEuTQ=","X-Gm-Gg":"AeBDieuAZMBdZ2SNgrSYprCuCzDenmRsTeGU0en1b2cKjcw/tc/CorypJVtfIAPSkDJ\n\tkl7LRrA/opco77xZW9vvSgwgL5hihusIGY96ob0sN4RpiuNjMFQRWkjRaEtSuDrAUzjVk76GxLD\n\tg7YNNQnhz8XLJPz58IIoTydq9/82XVJf/3DtIRR0pUaVPI+Fsa41H4lni6Si2h2U0XuR2bGxNt5\n\tWt9BeWEjWPTnKmJXMpu5VOgEIRS8OrQy6ULFO8/fMd6HH5+La3S48FzNdFkMg66P6B56pOOPwJQ\n\tj7ps7ZRgTWKbKQmsewX6JFQz1CL46twWoq4HibKlMHYzKohWSv6JcPSX35IIgf4St8o0b34LE+A\n\tclsGCPjucUDtl2EYEK8sS0w5KSS3cHvPPkXFu6640JWm2pxu1hCPwkc/dwo0lyn/cdNFxoDK8OU\n\tWA2CcpRTDaFn9yLb/b7y1t6biQNg6n6f4f6ZV5i5irDIEgbh8Jw3o4l+bkEjcT6ehsh7MEDpbS1\n\tmM=","X-Received":"by 2002:a17:902:f54a:b0:2b0:6885:f1d4 with SMTP id\n d9443c01a7336-2b97c4f3b2fmr34294335ad.39.1777392511250;\n        Tue, 28 Apr 2026 09:08:31 -0700 (PDT)","From":"nspmangalore@gmail.com","X-Google-Original-From":"sprasad@microsoft.com","To":"linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de","Cc":"Shyam Prasad N <sprasad@microsoft.com>","Subject":"[PATCH v3 13/19] cifs: option to disable time-based eviction of cache","Date":"Tue, 28 Apr 2026 21:37:58 +0530","Message-ID":"<20260428160804.281745-13-sprasad@microsoft.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260428160804.281745-1-sprasad@microsoft.com>","References":"<20260428160804.281745-1-sprasad@microsoft.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Shyam Prasad N <sprasad@microsoft.com>\n\nToday there is no way to disable time-based eviction of dir cache.\ndir_cache_timeout = 0 meant immediate free up of dir cache on next\nlaundromat scan. We already have nohandlecache to disable dir cache.\n\nThis changes the meaning of dir_cache_timeout = 0 to mean unlimited\ntimeout. Shrinker-based eviction is still possible.\n\nSigned-off-by: Shyam Prasad N <sprasad@microsoft.com>\n---\n fs/smb/client/cifsfs.c  | 2 +-\n fs/smb/client/connect.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c\nindex ee5de358e27f8..79a6a4c297ee3 100644\n--- a/fs/smb/client/cifsfs.c\n+++ b/fs/smb/client/cifsfs.c\n@@ -121,7 +121,7 @@ MODULE_PARM_DESC(cifs_max_pending, \"Simultaneous requests to server for \"\n unsigned int dir_cache_timeout = 30;\n module_param(dir_cache_timeout, uint, 0644);\n MODULE_PARM_DESC(dir_cache_timeout, \"Number of seconds to cache directory contents for which we have a lease. Default: 30 \"\n-\t\t\t\t \"Range: 1 to 65000 seconds, 0 to disable caching dir contents\");\n+\t\t\t\t \"Range: 0 to 65000 seconds. 0 disables timeout-based cleanup (cached dirs persist until explicitly invalidated).\");\n /* Module-wide total cached dirents (in bytes) across all tcons */\n atomic64_t cifs_dircache_bytes_used = ATOMIC64_INIT(0);\n static struct shrinker *cifs_dircache_shrinker;\ndiff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c\nindex 69b38f0ccf2b2..849c16c538353 100644\n--- a/fs/smb/client/connect.c\n+++ b/fs/smb/client/connect.c\n@@ -2698,7 +2698,7 @@ cifs_get_tcon(struct cifs_ses *ses, struct smb3_fs_context *ctx)\n \n \tif (ses->server->dialect >= SMB20_PROT_ID &&\n \t    (ses->server->capabilities & SMB2_GLOBAL_CAP_DIRECTORY_LEASING))\n-\t\tnohandlecache = ctx->nohandlecache || !dir_cache_timeout;\n+\t\tnohandlecache = ctx->nohandlecache;\n \telse\n \t\tnohandlecache = true;\n \ttcon = tcon_info_alloc(!nohandlecache, netfs_trace_tcon_ref_new);\n","prefixes":["v3","13/19"]}