{"id":2229710,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229710/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-3-sprasad@microsoft.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428160804.281745-3-sprasad@microsoft.com>","date":"2026-04-28T16:07:48","name":"[v3,03/19] cifs: invalidate cfid on unlink/rename/rmdir","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a31a1adfd5ea52a0e35c676d0258a1ef4219a247","submitter":{"id":79368,"url":"http://patchwork.ozlabs.org/api/1.1/people/79368/?format=json","name":"Shyam Prasad N","email":"nspmangalore@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428160804.281745-3-sprasad@microsoft.com/mbox/","series":[{"id":501896,"url":"http://patchwork.ozlabs.org/api/1.1/series/501896/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501896","date":"2026-04-28T16:07:57","name":"[v3,01/19] cifs: change_conf needs to be called for session setup","version":3,"mbox":"http://patchwork.ozlabs.org/series/501896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229710/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229710/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HO+b/Yk5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11240-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"HO+b/Yk5\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.170","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4m1f5gfTz1xrS\n\tfor ; Wed, 29 Apr 2026 02:22:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 6596F3044A81\n\tfor ; Tue, 28 Apr 2026 16:14:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7ED12441022;\n\tTue, 28 Apr 2026 16:08:24 +0000 (UTC)","from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3622544A723\n\tfor ; Tue, 28 Apr 2026 16:08:23 +0000 (UTC)","by mail-pl1-f170.google.com with SMTP id\n d9443c01a7336-2adff872068so57099475ad.1\n for ;\n Tue, 28 Apr 2026 09:08:23 -0700 (PDT)","from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b97ac7894csm30864465ad.50.2026.04.28.09.08.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 09:08:21 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777392504; cv=none;\n b=pniLETDQ7IqqzGGBDaZPACVHpSRElS2VnJ7K6gIWy0JV7Eu0rMjv4+G3vSWDM8ePk/nwTWqYmSZEd6IuPqpOUfOrPVvUdGL15Zzezmn4UmSH5NNXC51t0H79JMuBTBK+jB/Z3YX2DZRop/1hKWbiO4je+Aa/fufbHMgZrpacOeU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777392504; c=relaxed/simple;\n\tbh=wQe+RhB85yi02jo020KLvcVHTJCqLGplUXNCsaMyMYA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=c2RljTe2KLtjVcJQ/W3+I4pTTXY1U1lfD3LLMIjH/AFqHd73T0N5KtTuTH4PJ9VFE789FDs5JP4hHxHS9w+8bSvMxYovv/CX4ckIYngBsHlhjuKK3PJ7NVwgoKK6oX38jmfs/l0rvhi48nv/e+WLnFA4I+viyRcMjpRO36s9e9U=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=HO+b/Yk5; arc=none smtp.client-ip=209.85.214.170","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777392502; x=1777997302;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vJ/ecoS+iyPaqh9vg50r98KJRrVZjWdsD/kOJ7GPw5M=;\n b=HO+b/Yk5aq44ofsL3sAvJPd+/S2jh74VxZDvh1uA+Jcf/WQA5SrEI8jkjlymSUiOAf\n 6+uL2hVbSsm3g3hfWG+XyZlSkPWSjzxYkYbkyUX8l9lSQAoKz3umTucUe+M+svL3Qf4P\n eH6BUNDOHnVjFL1hT5Su0gM2FCcqkb9ZzkL8sVdkxyJBeMJ5esPnqRk17WWbVtEIRnBP\n WkRRKApVRHGr1IHGvfl/DwsBtPtMivuN3yyBdmEDrOhhxtH6k3IXr+dcvAJID+yXdVH4\n YKtdHNG9CMDdQiiLerfGDKjqAVJE6Kg/KoIgO/U3kcAxCHWOh+1eb7c2L74JGc+C9hJb\n WPcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777392502; x=1777997302;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vJ/ecoS+iyPaqh9vg50r98KJRrVZjWdsD/kOJ7GPw5M=;\n b=JW//OIQ6fTTXJpkjPRHhvOgoFE0siBcQjTHxjFwo4hQbVyV4OWf45t/FuduAfsuAVA\n 9woUwMgX3HKyEqLcYjo3lga91/n8nneRhLIZ3lTOz7qDlcJt6DPms6vFwNJ6OGZJ58a3\n Ny8PwbJsyYWL3ktzsyyPGBEA3+hYR4K8n/ep/8GQQ+mal/qnALcPYOEAXQWpN/TLeB9z\n bFfCbklMl1OL1FTSGYd6qHUGrf7IXaFGvgmYKfTI8xwAnmcq1mPOtbRgiy80+xITY7ZR\n dLAx9fDXTp7q0k+j/QB6CyGOl0q0xivzru3SXxr1tHWx8yTzM9A1up1eHFDCWsKFskAG\n dVKQ==","X-Gm-Message-State":"AOJu0YzLbPcYvCvNjuQ+LP/DyBnaVdbZ3/1SzvKgyQZgPxRnN+qLpeQQ\n\tlcxjN970sdbnHYm8obT9VeHnY2gMZehfk7Wv1jvK66LiUAdacp1j5hlVdQhvJiAG","X-Gm-Gg":"AeBDievEqveoGRUdzrsionF1FnyWr281C5jaZnNCI+KtVOArsFZU9nZJVtbzJsIKY5M\n\tCWWBb/N8KTNVEktD3cDQ8X1wUaEBxmhiJjEgj3WyZllP5aMr3mYmp5SNSyRxKp0lzScnzdd94kY\n\t/lQ5u/5lHjSyg6AzwJufmeFBkvzOF5lSVrNwgZfZcRzoKD0+5CmzP1sPtrK6e4ey5SQviqKooM8\n\tRPaxoEjArNpDjbVr0I3Qx06uufBYDAeS2UFfyBMDskvCYDhRz4SQKWwHY4O8fF0M3uFIhcIDist\n\tYozxBWUSQHkw565RF7gAQnfBn09K6eYHiImfW4uD4XoMUTksLvQbYg/S+Y2htPDoY6eq3HSvb6/\n\tjsGFDZ8RWHa85xgrtqU2sD0eMo1NiUBdIu0KOBvfeIoSy8NCIgRBfHX8PmfE5WJ5VvbxPPIToG3\n\t9OziF682j7VXDV2IB7365jw1detGv5IQdXhOJziQdDDzg7IfPNBHx80WX8saBZjDBH","X-Received":"by 2002:a17:902:8f94:b0:2b0:6d33:e7c0 with SMTP id\n d9443c01a7336-2b97c3cbae9mr26324095ad.1.1777392502017;\n Tue, 28 Apr 2026 09:08:22 -0700 (PDT)","From":"nspmangalore@gmail.com","X-Google-Original-From":"sprasad@microsoft.com","To":"linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de","Cc":"Shyam Prasad N ,\n\tstable@vger.kernel.org","Subject":"[PATCH v3 03/19] cifs: invalidate cfid on unlink/rename/rmdir","Date":"Tue, 28 Apr 2026 21:37:48 +0530","Message-ID":"<20260428160804.281745-3-sprasad@microsoft.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260428160804.281745-1-sprasad@microsoft.com>","References":"<20260428160804.281745-1-sprasad@microsoft.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Shyam Prasad N \n\nToday we do not invalidate the cached_dirent or the entire\nparent cfid when a dentry in a dir has been removed/moved.\n\nThis change invalidates the parent cfid so that we don't serve\ndirectory contents from the cache.\n\nCc: \nSigned-off-by: Shyam Prasad N \n---\n fs/smb/client/inode.c | 40 ++++++++++++++++++++++++++++++++++++++--\n 1 file changed, 38 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c\nindex 888f9e35f14b8..e077df844c819 100644\n--- a/fs/smb/client/inode.c\n+++ b/fs/smb/client/inode.c\n@@ -28,6 +28,23 @@\n #include \"cached_dir.h\"\n #include \"reparse.h\"\n \n+static void cifs_invalidate_cached_dir(struct cifs_tcon *tcon,\n+\t\t\t\t struct dentry *parent)\n+{\n+\tstruct cached_fid *parent_cfid = NULL;\n+\n+\tif (!tcon || !parent)\n+\t\treturn;\n+\n+\tif (!open_cached_dir_by_dentry(tcon, parent, &parent_cfid)) {\n+\t\tmutex_lock(&parent_cfid->dirents.de_mutex);\n+\t\tparent_cfid->dirents.is_valid = false;\n+\t\tparent_cfid->dirents.is_failed = true;\n+\t\tmutex_unlock(&parent_cfid->dirents.de_mutex);\n+\t\tclose_cached_dir(parent_cfid);\n+\t}\n+}\n+\n /*\n * Set parameters for the netfs library\n */\n@@ -322,7 +339,7 @@ cifs_unix_basic_to_fattr(struct cifs_fattr *fattr, FILE_UNIX_BASIC_INFO *info,\n \t\t\t\tfattr->cf_uid = uid;\n \t\t}\n \t}\n-\t\n+\n \tfattr->cf_gid = cifs_sb->ctx->linux_gid;\n \tif (!(sbflags & CIFS_MOUNT_OVERR_GID)) {\n \t\tu64 id = le64_to_cpu(info->Gid);\n@@ -2067,6 +2084,9 @@ static int __cifs_unlink(struct inode *dir, struct dentry *dentry, bool sillyren\n \t\tcifs_set_file_info(inode, attrs, xid, full_path, origattr);\n \n out_reval:\n+\tif (!rc && dentry->d_parent)\n+\t\tcifs_invalidate_cached_dir(tcon, dentry->d_parent);\n+\n \tif (inode) {\n \t\tcifs_inode = CIFS_I(inode);\n \t\tcifs_inode->time = 0;\t/* will force revalidate to get info\n@@ -2378,7 +2398,6 @@ int cifs_rmdir(struct inode *inode, struct dentry *direntry)\n \t}\n \n \trc = server->ops->rmdir(xid, tcon, full_path, cifs_sb);\n-\tcifs_put_tlink(tlink);\n \n \tcifsInode = CIFS_I(d_inode(direntry));\n \n@@ -2388,6 +2407,8 @@ int cifs_rmdir(struct inode *inode, struct dentry *direntry)\n \t\ti_size_write(d_inode(direntry), 0);\n \t\tclear_nlink(d_inode(direntry));\n \t\tspin_unlock(&d_inode(direntry)->i_lock);\n+\t\tif (direntry->d_parent)\n+\t\t\tcifs_invalidate_cached_dir(tcon, direntry->d_parent);\n \t}\n \n \t/* force revalidate to go get info when needed */\n@@ -2402,6 +2423,7 @@ int cifs_rmdir(struct inode *inode, struct dentry *direntry)\n \n \tinode_set_ctime_current(d_inode(direntry));\n \tinode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));\n+\tcifs_put_tlink(tlink);\n \n rmdir_exit:\n \tfree_dentry_path(page);\n@@ -2501,6 +2523,8 @@ cifs_rename2(struct mnt_idmap *idmap, struct inode *source_dir,\n \tstruct cifs_sb_info *cifs_sb;\n \tstruct tcon_link *tlink;\n \tstruct cifs_tcon *tcon;\n+\tstruct dentry *source_parent;\n+\tstruct dentry *target_parent;\n \tbool rehash = false;\n \tunsigned int xid;\n \tint rc, tmprc;\n@@ -2532,6 +2556,8 @@ cifs_rename2(struct mnt_idmap *idmap, struct inode *source_dir,\n \tif (IS_ERR(tlink))\n \t\treturn PTR_ERR(tlink);\n \ttcon = tlink_tcon(tlink);\n+\tsource_parent = source_dentry->d_parent ? dget(source_dentry->d_parent) : NULL;\n+\ttarget_parent = target_dentry->d_parent ? dget(target_dentry->d_parent) : NULL;\n \tserver = tcon->ses->server;\n \n \tpage1 = alloc_dentry_path();\n@@ -2668,11 +2694,21 @@ cifs_rename2(struct mnt_idmap *idmap, struct inode *source_dir,\n \t}\n \n \t/* force revalidate to go get info when needed */\n+\tif (!rc) {\n+\t\tcifs_invalidate_cached_dir(tcon, source_parent);\n+\t\tif (target_parent != source_parent)\n+\t\t\tcifs_invalidate_cached_dir(tcon, target_parent);\n+\t}\n+\n \tCIFS_I(source_dir)->time = CIFS_I(target_dir)->time = 0;\n \n cifs_rename_exit:\n \tif (rehash)\n \t\td_rehash(target_dentry);\n+\tif (target_parent)\n+\t\tdput(target_parent);\n+\tif (source_parent)\n+\t\tdput(source_parent);\n \tkfree(info_buf_source);\n \tfree_dentry_path(page2);\n \tfree_dentry_path(page1);\n","prefixes":["v3","03/19"]}