{"id":2229697,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229697/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428155759.226368-6-henrique.carvalho@suse.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428155759.226368-6-henrique.carvalho@suse.com>","date":"2026-04-28T15:57:59","name":"[v2,10/11] smb: server: track TCP and QUIC listener state independently","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"21f5843bb4b7816006cf33446126df5db926e79f","submitter":{"id":89563,"url":"http://patchwork.ozlabs.org/api/1.1/people/89563/?format=json","name":"Henrique Carvalho","email":"henrique.carvalho@suse.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428155759.226368-6-henrique.carvalho@suse.com/mbox/","series":[{"id":501886,"url":"http://patchwork.ozlabs.org/api/1.1/series/501886/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501886","date":"2026-04-28T15:55:41","name":"smb: implement SMB over QUIC","version":2,"mbox":"http://patchwork.ozlabs.org/series/501886/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229697/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229697/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=MgpbytK9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11236-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=\"MgpbytK9\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.45","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4ll54Pz0z1xrS\n\tfor ; Wed, 29 Apr 2026 02:10:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id CB1303068F4F\n\tfor ; Tue, 28 Apr 2026 16:01:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 13DCB29D291;\n\tTue, 28 Apr 2026 15:58:36 +0000 (UTC)","from mail-wm1-f45.google.com (mail-wm1-f45.google.com\n [209.85.128.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E273D6CD8\n\tfor ; Tue, 28 Apr 2026 15:58:34 +0000 (UTC)","by mail-wm1-f45.google.com with SMTP id\n 5b1f17b1804b1-4891c0620bcso80134005e9.1\n for ;\n Tue, 28 Apr 2026 08:58:34 -0700 (PDT)","from precision ([2a01:4b00:c007:bb00:be9d:a3c4:18b1:4a25])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7b560a84sm3409255e9.4.2026.04.28.08.58.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 08:58:31 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777391916; cv=none;\n b=Nn/5p6P8X4j2yBxwrM9S1o9EakNVGUbzwmwM40ABCDiLXK6eBz6OiHtVbGGNLvKQqaTIfzz51ltokuvnHTvIaQRazTI9Ty51iFb8ud+KycN+m+ny/BX80Yuh0BOHFTAaxR+CbhGFisKJje+nsvmcEcdujfL/wHoLnExZTbwFTuo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777391916; c=relaxed/simple;\n\tbh=KPDUAM/B7dwjOMD8wuZQR8c8CPU0KWccASaAffXaxAc=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=H6lGSb6fNKld6pAhkFFvJi2MI+8+TZpS8BYy2nelgWKxt2Xiej6MHxSc3VkxKPiEN7EVjf2y5s7idTgZMqYupZ2fsL4Ex5P/7GdKC+YKs8A0yfkfeAEvn9z4z0jPi09INUsYo6vaRFx+6Sjkk4zBVbLIBWaXnJnxZA8VaXri7+0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com;\n spf=pass smtp.mailfrom=suse.com;\n dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=MgpbytK9; arc=none smtp.client-ip=209.85.128.45","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1777391913; x=1777996713;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7Ld0FBcSpGP2eiiSXkF6apkU8lf6UUEovJRC91J2+Aw=;\n b=MgpbytK9nPMK5H4eN6vT09Nx317hJYQGTm/9OfXmDSN88hfy+J6H9Jg3CN1GFdqfFw\n HZ1po3zOYSaQGP8ryKxTCPlLjtqD6TyXgJGEwUAnpaQdZNzlh67PKdXHpiEaxR8cS2pL\n FfQYi6M5rdfY/qxkxl5ePtzejfKY4bed9lzje8bUozQ11kRBRGyDOIOqLAg9nbqbd5tA\n lqJ0iDutRZEWVlzSujJx0/wKKTwlJuIQgsFl0oFPRPlv7EQoC+2m/ecnQUDH8vUzvz65\n JT6P6NH92l9PPhShdbrrFWmEKIAEwrlVq9k7XsFv1G+3jC3bsJs+cC0vRSBnlwduItyJ\n WdlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777391913; x=1777996713;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7Ld0FBcSpGP2eiiSXkF6apkU8lf6UUEovJRC91J2+Aw=;\n b=TSPAGtaXlZDF2uKtN6UK1W0w4mZiyVm2oVIJjaGVURl/p4HLp4GP7nxQqEolmXqm2+\n dVE2Ayu1bfZ4jNJMD4QYyoO0j8/2o3Fiy7XP2n1pHygPuNALrIwqUdBRG+BSgEWHq6km\n 3hw3uHGFnmboUt6nAWviiaQ18rSt9vazaJBIAsB3Q9TDdE+nzr6DOxBfFQLNOH84GMig\n KADv3y2Mf9X/eN8rYCgd+GB8C4ilrTq6cTPc3KqGu7uIzx1K2eT747K86bbLlLXTXvl6\n dLFed8TkB1ji3Um1U+EPZa4gv7qyMNylsgfcb/ngj+CA3gIJAQ6/cuPLpDELJWSmU9L8\n Im2A==","X-Gm-Message-State":"AOJu0YwSTY/7dnqv6eOAmbTEfvnVls4j3+o1j4fsno2d4YJ8LAde9CHw\n\twm/K2NpMxmcR61w4CCk1OjCxbPmUWplGfevE9ZjlZu5b4rD/U/5ZMRt40M62xsNSBvO4sUG5BGZ\n\tjg42/iVKZ0Q==","X-Gm-Gg":"AeBDiet+J/N950jCrisXGn1oA161lWReMMuhVAsqkHR/6aXhSHGBHyCSIP7utWq6e47\n\txJKDQJDTUbRxjFVwZ9XLtEQrMomyzXMCLL2gddNZD/7K8F5UyGqPIvHwxsAmBxcw8t9CnyuCrid\n\tcg9CBa27tPQz3VLUrD5kYLj+7usDDXzgODto4Y3jNge4AYSZne39kvY0uT4ZTCwvvo46bo6BuB/\n\tb6qGv1860EZY1lB8zruAAeXHIFqoFPWu7Vhq4mJUHfBoPn/n/eBS1Q2MX92y54IT9GFqhdgGXyE\n\twoP0Cb468rRfXOQweVH7zIt5tZAGlsMkIv7C00n7sClO1FIZTe+Evot8VqpvXONaUIiwFIi/3cm\n\tWdvhKNam6lW1xBVAg7nmh3QIgSla9ftV0mblb9btW3d4f/mNiuVjMVwbBUmnAVlr/FFLrjgU2xM\n\tbCBrctMPi9axeN1SBYS6Xn3YG05YbNqLu+SkQS2Ck67bGH","X-Received":"by 2002:a05:600c:3d90:b0:488:b239:77ec with SMTP id\n 5b1f17b1804b1-48a77b1781cmr62293975e9.17.1777391912061;\n Tue, 28 Apr 2026 08:58:32 -0700 (PDT)","From":"Henrique Carvalho ","To":"linux-cifs@vger.kernel.org","Cc":"linkinjeon@kernel.org,\n\tsfrench@samba.org,\n\tmetze@samba.org,\n\tsenozhatsky@chromium.org,\n\ttom@talpey.com,\n\tematsumiya@suse.de,\n\tHenrique Carvalho ","Subject":"[PATCH v2 10/11] smb: server: track TCP and QUIC listener state\n independently","Date":"Tue, 28 Apr 2026 12:57:59 -0300","Message-ID":"<20260428155759.226368-6-henrique.carvalho@suse.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428155759.226368-1-henrique.carvalho@suse.com>","References":"<20260428155759.226368-1-henrique.carvalho@suse.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"An interface can host both TCP and QUIC listeners, so a single\nconfigured/down state is no longer precise enough once QUIC support is\nadded (e.g. a TCP listener may already be up when QUIC setup fails).\n\nTurn iface->state into a transport bitmask and track TCP and QUIC\nlistener bring-up independently. This lets NETDEV_UP retry only the\nmissing transport and lets NETDEV_DOWN tear down only the listeners that\nwere actually started.\n\nSigned-off-by: Henrique Carvalho \n---\n fs/smb/server/interface.c | 61 ++++++++++++++++++++++------------\n fs/smb/server/interface.h | 6 ++--\n fs/smb/server/transport_quic.c | 2 +-\n fs/smb/server/transport_tcp.c | 2 +-\n 4 files changed, 45 insertions(+), 26 deletions(-)","diff":"diff --git a/fs/smb/server/interface.c b/fs/smb/server/interface.c\nindex 25b8e7f44059..272c4aaad347 100644\n--- a/fs/smb/server/interface.c\n+++ b/fs/smb/server/interface.c\n@@ -17,6 +17,11 @@\n static LIST_HEAD(iface_list);\n static int bind_additional_ifaces;\n \n+static inline bool ksmbd_iface_transport_up(const struct interface *iface)\n+{\n+\treturn iface->state != 0;\n+}\n+\n static struct interface *alloc_iface(char *ifname)\n {\n \tstruct interface *iface;\n@@ -31,7 +36,7 @@ static struct interface *alloc_iface(char *ifname)\n \t}\n \n \tiface->name = ifname;\n-\tiface->state = IFACE_STATE_DOWN;\n+\tiface->state = 0;\n \tlist_add(&iface->entry, &iface_list);\n \treturn iface;\n }\n@@ -80,20 +85,30 @@ static int ksmbd_netdev_event(struct notifier_block *nb, unsigned long event,\n \t\t\treturn NOTIFY_OK;\n \n \t\tiface = ksmbd_find_netdev_name_iface_list(netdev->name);\n-\t\tif (iface && iface->state == IFACE_STATE_DOWN) {\n+\t\tif (iface) {\n \t\t\tksmbd_debug(CONN, \"netdev-up event: netdev(%s) is going up\\n\",\n \t\t\t\t\tiface->name);\n \n \t\t\tif (!iface->net)\n \t\t\t\tiface->net = get_net(dev_net(netdev));\n \n-\t\t\tret = ksmbd_tcp_create_socket(iface);\n-\t\t\tif (ret)\n-\t\t\t\tbreak;\n-\n-\t\t\tret = ksmbd_quic_create_socket(iface);\n-\t\t\tif (ret)\n-\t\t\t\tbreak;\n+\t\t\tif (!(iface->state & IFACE_STATE_TCP_UP)) {\n+\t\t\t\tret = ksmbd_tcp_create_socket(iface);\n+\t\t\t\tif (ret && !ksmbd_iface_transport_up(iface)) {\n+\t\t\t\t\tput_net(iface->net);\n+\t\t\t\t\tiface->net = NULL;\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t}\n+\n+\t\t\tif (!(iface->state & IFACE_STATE_QUIC_UP)) {\n+\t\t\t\tret = ksmbd_quic_create_socket(iface);\n+\t\t\t\tif (ret && !ksmbd_iface_transport_up(iface)) {\n+\t\t\t\t\tput_net(iface->net);\n+\t\t\t\t\tiface->net = NULL;\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t}\n \t\t}\n \t\tif (!iface && bind_additional_ifaces) {\n \t\t\tiface = alloc_iface(kstrdup(netdev->name, KSMBD_DEFAULT_GFP));\n@@ -106,44 +121,49 @@ static int ksmbd_netdev_event(struct notifier_block *nb, unsigned long event,\n \t\t\tiface->net = get_net(dev_net(netdev));\n \n \t\t\tret = ksmbd_tcp_create_socket(iface);\n-\t\t\tif (ret)\n+\t\t\tif (ret && !ksmbd_iface_transport_up(iface)) {\n+\t\t\t\tput_net(iface->net);\n+\t\t\t\tiface->net = NULL;\n \t\t\t\tbreak;\n+\t\t\t}\n \n \t\t\tret = ksmbd_quic_create_socket(iface);\n-\t\t\tif (ret)\n+\t\t\tif (ret && !ksmbd_iface_transport_up(iface)) {\n+\t\t\t\tput_net(iface->net);\n+\t\t\t\tiface->net = NULL;\n \t\t\t\tbreak;\n+\t\t\t}\n \t\t}\n \t\tbreak;\n \tcase NETDEV_DOWN:\n \t\tiface = ksmbd_find_netdev_name_iface_list(netdev->name);\n-\t\tif (iface && iface->state == IFACE_STATE_CONFIGURED) {\n+\t\tif (iface && ksmbd_iface_transport_up(iface)) {\n \t\t\tksmbd_debug(CONN, \"netdev-down event: netdev(%s) is going down\\n\",\n \t\t\t\t\tiface->name);\n \n-\t\t\tif (iface->ksmbd_tcp_socket)\n+\t\t\tif (iface->state & IFACE_STATE_TCP_UP)\n \t\t\t\tkernel_sock_shutdown(iface->ksmbd_tcp_socket, SHUT_RDWR);\n-\t\t\tif (iface->ksmbd_quic_socket)\n+\t\t\tif (iface->state & IFACE_STATE_QUIC_UP)\n \t\t\t\tkernel_sock_shutdown(iface->ksmbd_quic_socket, SHUT_RDWR);\n \n-\t\t\tif (iface->ksmbd_tcp_kthread)\n+\t\t\tif (iface->state & IFACE_STATE_TCP_UP)\n \t\t\t\tksmbd_interface_stop_kthread(iface->ksmbd_tcp_kthread);\n-\t\t\tif (iface->ksmbd_quic_kthread)\n+\t\t\tif (iface->state & IFACE_STATE_QUIC_UP)\n \t\t\t\tksmbd_interface_stop_kthread(iface->ksmbd_quic_kthread);\n \n-\t\t\tif (iface->ksmbd_tcp_socket)\n+\t\t\tif (iface->state & IFACE_STATE_TCP_UP)\n \t\t\t\tsock_release(iface->ksmbd_tcp_socket);\n-\t\t\tif (iface->ksmbd_quic_socket)\n+\t\t\tif (iface->state & IFACE_STATE_QUIC_UP)\n \t\t\t\tsock_release(iface->ksmbd_quic_socket);\n \n \t\t\tiface->ksmbd_tcp_kthread = NULL;\n \t\t\tiface->ksmbd_quic_kthread = NULL;\n \t\t\tiface->ksmbd_tcp_socket = NULL;\n \t\t\tiface->ksmbd_quic_socket = NULL;\n+\t\t\tiface->state = 0;\n \n \t\t\tput_net(iface->net);\n \t\t\tiface->net = NULL;\n-\n-\t\t\tiface->state = IFACE_STATE_DOWN;\n \t\t\tbreak;\n \t\t}\n \t\tbreak;\n@@ -213,4 +233,3 @@ int ksmbd_set_interfaces(char *ifc_list, int ifc_list_sz)\n \n \treturn 0;\n }\n-\ndiff --git a/fs/smb/server/interface.h b/fs/smb/server/interface.h\nindex 94ffb73fd635..d99b1f3c8bc0 100644\n--- a/fs/smb/server/interface.h\n+++ b/fs/smb/server/interface.h\n@@ -10,8 +10,8 @@\n \n #include \n \n-#define IFACE_STATE_DOWN\t\tBIT(0)\n-#define IFACE_STATE_CONFIGURED\t\tBIT(1)\n+#define IFACE_STATE_TCP_UP\t\tBIT(0)\n+#define IFACE_STATE_QUIC_UP\t\tBIT(1)\n \n struct interface {\n \tstruct task_struct\t*ksmbd_tcp_kthread;\n@@ -20,7 +20,7 @@ struct interface {\n \tstruct socket\t\t*ksmbd_quic_socket;\n \tstruct list_head\tentry;\n \tchar\t\t\t*name;\n-\tint\t\t\tstate;\n+\tunsigned int\t\tstate;\n \tstruct net\t\t*net;\n };\n \ndiff --git a/fs/smb/server/transport_quic.c b/fs/smb/server/transport_quic.c\nindex 84067225c1d3..da089b655e6c 100644\n--- a/fs/smb/server/transport_quic.c\n+++ b/fs/smb/server/transport_quic.c\n@@ -314,7 +314,7 @@ int ksmbd_quic_create_socket(struct interface *iface)\n \n \tiface->ksmbd_quic_socket = ksmbd_socket;\n \tiface->ksmbd_quic_kthread = kthread;\n-\tiface->state = IFACE_STATE_CONFIGURED;\n+\tiface->state |= IFACE_STATE_QUIC_UP;\n #endif /* CONFIG_IP_QUIC */\n \treturn 0;\n }\ndiff --git a/fs/smb/server/transport_tcp.c b/fs/smb/server/transport_tcp.c\nindex 1496f0336af6..81bf6996a6f7 100644\n--- a/fs/smb/server/transport_tcp.c\n+++ b/fs/smb/server/transport_tcp.c\n@@ -208,7 +208,7 @@ int ksmbd_tcp_create_socket(struct interface *iface)\n \t}\n \n \tiface->ksmbd_tcp_kthread = kthread;\n-\tiface->state = IFACE_STATE_CONFIGURED;\n+\tiface->state |= IFACE_STATE_TCP_UP;\n \n \treturn 0;\n \n","prefixes":["v2","10/11"]}