{"id":2229660,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229660/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260428151926.3798626-6-i.maximets@ovn.org/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.1/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260428151926.3798626-6-i.maximets@ovn.org>","date":"2026-04-28T15:19:10","name":"[ovs-dev,5/6] dpif-netdev: Remove 'private' from internal header names.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1a4eaa217095a28d922433a7f3f15ce48249fde5","submitter":{"id":76798,"url":"http://patchwork.ozlabs.org/api/1.1/people/76798/?format=json","name":"Ilya Maximets","email":"i.maximets@ovn.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260428151926.3798626-6-i.maximets@ovn.org/mbox/","series":[{"id":501877,"url":"http://patchwork.ozlabs.org/api/1.1/series/501877/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=501877","date":"2026-04-28T15:19:05","name":"dpif-netdev: Remove deprecated AVX512-based optimizations.","version":1,"mbox":"http://patchwork.ozlabs.org/series/501877/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229660/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2229660/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n dmarc=none (p=none dis=none) header.from=ovn.org"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4kdR2SGpz1yHv\n\tfor ; Wed, 29 Apr 2026 01:20:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CFA2761075;\n\tTue, 28 Apr 2026 15:20:08 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Rb5Mo476it5O; Tue, 28 Apr 2026 15:20:07 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id D28386105D;\n\tTue, 28 Apr 2026 15:20:03 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id B92EDC04FB;\n\tTue, 28 Apr 2026 15:20:03 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1B465C0592\n for ; Tue, 28 Apr 2026 15:20:02 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id DE31260FE0\n for ; Tue, 28 Apr 2026 15:19:49 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2ZpdL3Xqtg26 for ;\n Tue, 28 Apr 2026 15:19:48 +0000 (UTC)","from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n [209.85.221.65])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 6CDFF60EAA\n for ; Tue, 28 Apr 2026 15:19:48 +0000 (UTC)","by mail-wr1-f65.google.com with SMTP id\n ffacd0b85a97d-43cf8d550bdso9773508f8f.0\n for ; Tue, 28 Apr 2026 08:19:48 -0700 (PDT)","from im-t490s.redhat.com (89-24-34-32.nat.epc.tmcz.cz.\n [89.24.34.32])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4463fa89038sm7080967f8f.26.2026.04.28.08.19.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 08:19:45 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org D28386105D","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6CDFF60EAA"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.65;\n helo=mail-wr1-f65.google.com; envelope-from=i.maximets.ovn@gmail.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6CDFF60EAA","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777389586; x=1777994386;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zFjon2vkGTQ8ZjcdEGBmwWSb04yYRr0rW7DGopw2JqE=;\n b=LD6LEvAyq/KbrvgjUigp4aFzx1W9EkXs7ozjZSVP2nUNpTwv5A9oWEPdtGBWfvSjJ/\n rljSAj14Lbv4gf+cBElFG9ZBYIwErPSDZChq9LSI2VcZUJIuDMURoT4m3N7QJHzdYPl3\n fBhnAFyW0IuwVh2PfShuBdXu8wmkRYPQWmeBT8nKcSqKshNTk+EagBit9fsvgafr5p/J\n EDsFM4cc8Woshcw/iVQPuQqX3zVPvB53jmGjwPLJWT/Pnv325r6FsuCKpT7PglnVT3L4\n idLwWPDG3LTiM3dwgBoWx51Bfwc8xPiQjPPPemjOjwfDgbVyJ8TSHPfcXk+dGpvx86+i\n n6NQ==","X-Gm-Message-State":"AOJu0YwdYpyjhOT2+EOnvTD0xiq3YnSZNGstCcijnCbEtuZL/6lbZeRP\n D7+LllorjgYlDcrxRSYf5T7zb8p1Pf46FS6x4wcNo+pz5zcPi9/itfMAMxt8wteSbvo=","X-Gm-Gg":"AeBDietAxyvkUkEyVegEUrR9nZ9RHTC8jvGgTsGMhWh9FWdY8mOT90GK6mdspQWZOTn\n xCYYocUSDQfxI8+w4h+CKJAQuTymXt2VtJYNnNiq8t8STzyUVzul311AVUSJR6r+uiMxXgy6HyM\n 1QmFDBNr+jNKFPU3G27xsUFydGaYYoKSazZ0nKxziLV0kKVU/5C/b0AMaKVxaU0g8eDifACGVoj\n SgXdFys5P3B56yMtSrlnN9I0mxy57Ewk8+vU0WRdyPoG/FJUNqgMU5Lfatez8rk9jsdk2sy7dgq\n reAm+QNAhDOR1zTQqOqnACnRraDrMpa8KGUGSsRZLUdOaXgxi8icnacVE776LWsso1bDL4KuDPK\n 7vtHskeuoVDbWtQQ5GKFHDJiBJOxnhjdTA+Wyd8rDAJr+UPMmjZY66sUsoqwNOixpzaqkziZDSh\n JKB4hRd/Rw/zH9RQQA2JVZFlh78n5hkHGl1hTiOTHjqus79LjT6Ou+xbMW5JT/fkmHcjlSP89Iz\n foKVA==","X-Received":"by 2002:a05:6000:2007:b0:43d:50c:6f33 with SMTP id\n ffacd0b85a97d-446494ea060mr6326178f8f.26.1777389586253;\n Tue, 28 Apr 2026 08:19:46 -0700 (PDT)","From":"Ilya Maximets ","To":"ovs-dev@openvswitch.org","Cc":"Ilya Maximets ","Date":"Tue, 28 Apr 2026 17:19:10 +0200","Message-ID":"<20260428151926.3798626-6-i.maximets@ovn.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428151926.3798626-1-i.maximets@ovn.org>","References":"<20260428151926.3798626-1-i.maximets@ovn.org>","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH 5/6] dpif-netdev: Remove 'private' from internal\n header names.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Since dpif-netdev-private.h was removed, the naming scheme doesn't\nmake a lot of sense anymore. The 'private' part of the names should\nbe dropped.\n\nSigned-off-by: Ilya Maximets \n---\n lib/automake.mk | 12 ++++++------\n lib/{dpif-netdev-private-dfc.c => dpif-netdev-dfc.c} | 2 +-\n lib/{dpif-netdev-private-dfc.h => dpif-netdev-dfc.h} | 10 +++++-----\n ...if-netdev-private-dpcls.c => dpif-netdev-dpcls.c} | 2 +-\n ...if-netdev-private-dpcls.h => dpif-netdev-dpcls.h} | 6 +++---\n ...dpif-netdev-private-flow.h => dpif-netdev-flow.h} | 6 +++---\n ...-netdev-private-thread.h => dpif-netdev-thread.h} | 8 ++++----\n lib/dpif-netdev.c | 8 ++++----\n 8 files changed, 27 insertions(+), 27 deletions(-)\n rename lib/{dpif-netdev-private-dfc.c => dpif-netdev-dfc.c} (98%)\n rename lib/{dpif-netdev-private-dfc.h => dpif-netdev-dfc.h} (97%)\n rename lib/{dpif-netdev-private-dpcls.c => dpif-netdev-dpcls.c} (99%)\n rename lib/{dpif-netdev-private-dpcls.h => dpif-netdev-dpcls.h} (97%)\n rename lib/{dpif-netdev-private-flow.h => dpif-netdev-flow.h} (97%)\n rename lib/{dpif-netdev-private-thread.h => dpif-netdev-thread.h} (98%)","diff":"diff --git a/lib/automake.mk b/lib/automake.mk\nindex bf1aba0ed..adeffa10b 100644\n--- a/lib/automake.mk\n+++ b/lib/automake.mk\n@@ -89,14 +89,14 @@ lib_libopenvswitch_la_SOURCES = \\\n \tlib/dp-packet-gso.c \\\n \tlib/dp-packet-gso.h \\\n \tlib/dpdk.h \\\n+\tlib/dpif-netdev-dfc.c \\\n+\tlib/dpif-netdev-dfc.h \\\n+\tlib/dpif-netdev-dpcls.c \\\n+\tlib/dpif-netdev-dpcls.h \\\n+\tlib/dpif-netdev-flow.h \\\n \tlib/dpif-netdev-perf.c \\\n \tlib/dpif-netdev-perf.h \\\n-\tlib/dpif-netdev-private-dfc.c \\\n-\tlib/dpif-netdev-private-dfc.h \\\n-\tlib/dpif-netdev-private-dpcls.c \\\n-\tlib/dpif-netdev-private-dpcls.h \\\n-\tlib/dpif-netdev-private-flow.h \\\n-\tlib/dpif-netdev-private-thread.h \\\n+\tlib/dpif-netdev-thread.h \\\n \tlib/dpif-netdev.c \\\n \tlib/dpif-netdev.h \\\n \tlib/dpif-offload.c \\\ndiff --git a/lib/dpif-netdev-private-dfc.c b/lib/dpif-netdev-dfc.c\nsimilarity index 98%\nrename from lib/dpif-netdev-private-dfc.c\nrename to lib/dpif-netdev-dfc.c\nindex 1d53fafff..ccf311738 100644\n--- a/lib/dpif-netdev-private-dfc.c\n+++ b/lib/dpif-netdev-dfc.c\n@@ -18,7 +18,7 @@\n \n #include \n \n-#include \"dpif-netdev-private-dfc.h\"\n+#include \"dpif-netdev-dfc.h\"\n \n static void\n emc_clear_entry(struct emc_entry *ce)\ndiff --git a/lib/dpif-netdev-private-dfc.h b/lib/dpif-netdev-dfc.h\nsimilarity index 97%\nrename from lib/dpif-netdev-private-dfc.h\nrename to lib/dpif-netdev-dfc.h\nindex 3dfc91f0f..42ad291ed 100644\n--- a/lib/dpif-netdev-private-dfc.h\n+++ b/lib/dpif-netdev-dfc.h\n@@ -15,12 +15,12 @@\n * limitations under the License.\n */\n \n-#ifndef DPIF_NETDEV_PRIVATE_DFC_H\n-#define DPIF_NETDEV_PRIVATE_DFC_H 1\n+#ifndef DPIF_NETDEV_DFC_H\n+#define DPIF_NETDEV_DFC_H 1\n \n #include \"dpif.h\"\n-#include \"dpif-netdev-private-dpcls.h\"\n-#include \"dpif-netdev-private-flow.h\"\n+#include \"dpif-netdev-dpcls.h\"\n+#include \"dpif-netdev-flow.h\"\n \n #include \n #include \n@@ -187,4 +187,4 @@ smc_lookup_single(struct dp_netdev_pmd_thread *pmd,\n }\n #endif\n \n-#endif /* dpif-netdev-private-dfc.h */\n+#endif /* dpif-netdev-dfc.h */\ndiff --git a/lib/dpif-netdev-private-dpcls.c b/lib/dpif-netdev-dpcls.c\nsimilarity index 99%\nrename from lib/dpif-netdev-private-dpcls.c\nrename to lib/dpif-netdev-dpcls.c\nindex 31e1a357e..f1f6b0864 100644\n--- a/lib/dpif-netdev-private-dpcls.c\n+++ b/lib/dpif-netdev-dpcls.c\n@@ -17,7 +17,7 @@\n \n #include \n #include \"dpif-netdev.h\"\n-#include \"dpif-netdev-private-dpcls.h\"\n+#include \"dpif-netdev-dpcls.h\"\n \n #include \"bitmap.h\"\n #include \"cmap.h\"\ndiff --git a/lib/dpif-netdev-private-dpcls.h b/lib/dpif-netdev-dpcls.h\nsimilarity index 97%\nrename from lib/dpif-netdev-private-dpcls.h\nrename to lib/dpif-netdev-dpcls.h\nindex 7949134bb..4679d2122 100644\n--- a/lib/dpif-netdev-private-dpcls.h\n+++ b/lib/dpif-netdev-dpcls.h\n@@ -15,8 +15,8 @@\n * limitations under the License.\n */\n \n-#ifndef DPIF_NETDEV_PRIVATE_DPCLS_H\n-#define DPIF_NETDEV_PRIVATE_DPCLS_H 1\n+#ifndef DPIF_NETDEV_DPCLS_H\n+#define DPIF_NETDEV_DPCLS_H 1\n \n #include \"dpif.h\"\n \n@@ -138,4 +138,4 @@ dpcls_lookup(struct dpcls *cls, const struct netdev_flow_key *keys[],\n }\n #endif\n \n-#endif /* dpif-netdev-private-dpcls.h */\n+#endif /* dpif-netdev-dpcls.h */\ndiff --git a/lib/dpif-netdev-private-flow.h b/lib/dpif-netdev-flow.h\nsimilarity index 97%\nrename from lib/dpif-netdev-private-flow.h\nrename to lib/dpif-netdev-flow.h\nindex f05382626..c70931a0f 100644\n--- a/lib/dpif-netdev-private-flow.h\n+++ b/lib/dpif-netdev-flow.h\n@@ -15,8 +15,8 @@\n * limitations under the License.\n */\n \n-#ifndef DPIF_NETDEV_PRIVATE_FLOW_H\n-#define DPIF_NETDEV_PRIVATE_FLOW_H 1\n+#ifndef DPIF_NETDEV_FLOW_H\n+#define DPIF_NETDEV_FLOW_H 1\n \n #include \n #include \n@@ -156,4 +156,4 @@ struct dp_netdev_actions {\n }\n #endif\n \n-#endif /* dpif-netdev-private-flow.h */\n+#endif /* dpif-netdev-flow.h */\ndiff --git a/lib/dpif-netdev-private-thread.h b/lib/dpif-netdev-thread.h\nsimilarity index 98%\nrename from lib/dpif-netdev-private-thread.h\nrename to lib/dpif-netdev-thread.h\nindex 2ee855ca4..43adc7fef 100644\n--- a/lib/dpif-netdev-private-thread.h\n+++ b/lib/dpif-netdev-thread.h\n@@ -15,8 +15,8 @@\n * limitations under the License.\n */\n \n-#ifndef DPIF_NETDEV_PRIVATE_THREAD_H\n-#define DPIF_NETDEV_PRIVATE_THREAD_H 1\n+#ifndef DPIF_NETDEV_THREAD_H\n+#define DPIF_NETDEV_THREAD_H 1\n \n #include \n #include \n@@ -24,7 +24,7 @@\n #include \"ccmap.h\"\n #include \"cmap.h\"\n \n-#include \"dpif-netdev-private-dfc.h\"\n+#include \"dpif-netdev-dfc.h\"\n #include \"dpif-netdev-perf.h\"\n #include \"openvswitch/thread.h\"\n \n@@ -219,4 +219,4 @@ struct dp_netdev_pmd_thread {\n }\n #endif\n \n-#endif /* dpif-netdev-private-thread.h */\n+#endif /* dpif-netdev-thread.h */\ndiff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex d02344637..01a0447fc 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -42,11 +42,11 @@\n #include \"csum.h\"\n #include \"dp-packet.h\"\n #include \"dpif.h\"\n+#include \"dpif-netdev-dfc.h\"\n+#include \"dpif-netdev-dpcls.h\"\n+#include \"dpif-netdev-flow.h\"\n #include \"dpif-netdev-perf.h\"\n-#include \"dpif-netdev-private-dfc.h\"\n-#include \"dpif-netdev-private-dpcls.h\"\n-#include \"dpif-netdev-private-flow.h\"\n-#include \"dpif-netdev-private-thread.h\"\n+#include \"dpif-netdev-thread.h\"\n #include \"dpif-offload.h\"\n #include \"dpif-provider.h\"\n #include \"dummy.h\"\n","prefixes":["ovs-dev","5/6"]}