{"id":2229646,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229646/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-16-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428150726.1659814-16-marcandre.lureau@redhat.com>","date":"2026-04-28T15:07:25","name":"[PULL,v2,15/15] ui/gtk: Turn clipboard flag into runtime option","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d384ff176fb15f45be190eaa3c9b752b23e2dcde","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-16-marcandre.lureau@redhat.com/mbox/","series":[{"id":501872,"url":"http://patchwork.ozlabs.org/api/1.1/series/501872/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501872","date":"2026-04-28T15:07:10","name":"[PULL,v2,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","version":2,"mbox":"http://patchwork.ozlabs.org/series/501872/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229646/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229646/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UbopDAgj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4kP769hdz1xrS\n\tfor ; Wed, 29 Apr 2026 01:09:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHk3x-0004as-Eg; Tue, 28 Apr 2026 11:09:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHk3i-0004Jk-RO\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:09:11 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHk3g-0000uB-Kg\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:09:10 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-rLy0ZmtiNmahxuBY95-sLw-1; Tue,\n 28 Apr 2026 11:09:06 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B998F1800245; Tue, 28 Apr 2026 15:09:04 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 80ECE180047F; Tue, 28 Apr 2026 15:09:03 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777388947;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ZX+m/6bPPeLovcy5LSomlbMNC6WXFdgx77ohqNBz5/M=;\n b=UbopDAgjsrL8HtTSGfKVZHsNp3I5JmhJHr5NYVxV+l6D+WMPfmv2op2rt/7Ln4QPU44YSE\n Z0jOx2KFZ4DFt7wOPNy9+2bUa9Uc48i1GPS1AUd5hwqWnjjR67J4HikEHdia+xJcFNMTpC\n zhY2QPr5KU44p1E2wd1tEILMkNVd0EI=","X-MC-Unique":"rLy0ZmtiNmahxuBY95-sLw-1","X-Mimecast-MFC-AGG-ID":"rLy0ZmtiNmahxuBY95-sLw_1777388944","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"stefanha@gmail.com,\n =?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ,\n Paolo Bonzini ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Pierrick Bouvier ,\n Eric Blake , Markus Armbruster ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ","Subject":"[PULL v2 15/15] ui/gtk: Turn clipboard flag into runtime option","Date":"Tue, 28 Apr 2026 19:07:25 +0400","Message-ID":"<20260428150726.1659814-16-marcandre.lureau@redhat.com>","In-Reply-To":"<20260428150726.1659814-1-marcandre.lureau@redhat.com>","References":"<20260428150726.1659814-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Jindřich Makovička \n\n- Compile the GTK clipboard support unconditionally\n\n- Introduce GTK clipboard option, defaulting to off\n\nSigned-off-by: Jindrich Makovicka \nReviewed-by: Marc-André Lureau \nReviewed-by: Daniel P. Berrangé \nMessage-ID: <20260427-gtk-clipboard-v5-2-6968feb31a5d@gmail.com>\n---\n meson.build | 4 ----\n qapi/ui.json | 6 +++++-\n ui/gtk.c | 8 +++++---\n meson_options.txt | 7 -------\n qemu-options.hx | 9 ++++++---\n scripts/meson-buildoptions.sh | 3 ---\n ui/meson.build | 4 +---\n 7 files changed, 17 insertions(+), 24 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 7d25b1ec7ef..4176d020c21 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1932,7 +1932,6 @@ endif\n gtk = not_found\n gtkx11 = not_found\n vte = not_found\n-have_gtk_clipboard = get_option('gtk_clipboard').enabled()\n \n if get_option('gtk') \\\n .disable_auto_if(not have_system) \\\n@@ -1954,8 +1953,6 @@ if get_option('gtk') \\\n method: 'pkg-config',\n required: get_option('vte'))\n endif\n- elif have_gtk_clipboard\n- error('GTK clipboard requested, but GTK not found')\n endif\n endif\n \n@@ -2475,7 +2472,6 @@ if glusterfs.found()\n endif\n config_host_data.set('CONFIG_GTK', gtk.found())\n config_host_data.set('CONFIG_VTE', vte.found())\n-config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)\n config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))\n config_host_data.set('CONFIG_LIBATTR', have_old_libattr)\n config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())\ndiff --git a/qapi/ui.json b/qapi/ui.json\nindex e3da77632a8..b2c42a7f578 100644\n--- a/qapi/ui.json\n+++ b/qapi/ui.json\n@@ -1319,6 +1319,9 @@\n #\n # GTK display options.\n #\n+# @clipboard: Enable host-guest clipboard sharing. Defaults to \"off\".\n+# (Since 11.1)\n+#\n # @grab-on-hover: Grab keyboard input on mouse hover.\n #\n # @zoom-to-fit: Zoom guest display to fit into the host window. When\n@@ -1344,7 +1347,8 @@\n # Since: 2.12\n ##\n { 'struct' : 'DisplayGTK',\n- 'data' : { '*grab-on-hover' : 'bool',\n+ 'data' : { '*clipboard' : 'bool',\n+ '*grab-on-hover' : 'bool',\n '*zoom-to-fit' : 'bool',\n '*show-tabs' : 'bool',\n '*show-menubar' : 'bool',\ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex 8fd39c90c29..ec95f0f294a 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -2601,9 +2601,11 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)\n opts->u.gtk.show_tabs) {\n gtk_menu_item_activate(GTK_MENU_ITEM(s->show_tabs_item));\n }\n-#ifdef CONFIG_GTK_CLIPBOARD\n- gd_clipboard_init(s);\n-#endif /* CONFIG_GTK_CLIPBOARD */\n+\n+ if (opts->u.gtk.has_clipboard &&\n+ opts->u.gtk.clipboard) {\n+ gd_clipboard_init(s);\n+ }\n \n /* GTK's event polling must happen on the main thread. */\n qemu_main = NULL;\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 31d5916cfce..286461129bd 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -262,13 +262,6 @@ option('vnc_sasl', type : 'feature', value : 'auto',\n description: 'SASL authentication for VNC server')\n option('vte', type : 'feature', value : 'auto',\n description: 'vte support for the gtk UI')\n-\n-# GTK Clipboard implementation is disabled by default, since it may cause hangs\n-# of the guest VCPUs. See gitlab issue 1150:\n-# https://gitlab.com/qemu-project/qemu/-/issues/1150\n-\n-option('gtk_clipboard', type: 'feature', value : 'disabled',\n- description: 'clipboard support for the gtk UI (EXPERIMENTAL, MAY HANG)')\n option('xkbcommon', type : 'feature', value : 'auto',\n description: 'xkbcommon support')\n option('zstd', type : 'feature', value : 'auto',\ndiff --git a/qemu-options.hx b/qemu-options.hx\nindex 21972f83268..e780bc2ac06 100644\n--- a/qemu-options.hx\n+++ b/qemu-options.hx\n@@ -2209,9 +2209,9 @@ DEF(\"display\", HAS_ARG, QEMU_OPTION_display,\n \" [,window-close=on|off]\\n\"\n #endif\n #if defined(CONFIG_GTK)\n- \"-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\\n\"\n- \" [,show-tabs=on|off][,show-cursor=on|off][,window-close=on|off]\\n\"\n- \" [,show-menubar=on|off][,zoom-to-fit=on|off]\\n\"\n+ \"-display gtk[,clipboard=on|off][,full-screen=on|off][,gl=on|off]\\n\"\n+ \" [,grab-on-hover=on|off][,show-tabs=on|off][,show-cursor=on|off]\\n\"\n+ \" [,window-close=on|off][,show-menubar=on|off][,zoom-to-fit=on|off]\\n\"\n #endif\n #if defined(CONFIG_VNC)\n \"-display vnc=[,]\\n\"\n@@ -2295,6 +2295,9 @@ SRST\n drop-down menus and other UI elements to configure and control\n the VM during runtime. Valid parameters are:\n \n+ ``clipboard=on|off`` : Enable host-guest clipboard sharing,\n+ defaults to \"off\"\n+\n ``full-screen=on|off`` : Start in fullscreen mode\n \n ``gl=on|off`` : Use OpenGL for displaying\ndiff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh\nindex ca5b113119a..80de8c4af42 100644\n--- a/scripts/meson-buildoptions.sh\n+++ b/scripts/meson-buildoptions.sh\n@@ -124,7 +124,6 @@ meson_options_help() {\n printf \"%s\\n\" ' glusterfs Glusterfs block device driver'\n printf \"%s\\n\" ' gnutls GNUTLS cryptography support'\n printf \"%s\\n\" ' gtk GTK+ user interface'\n- printf \"%s\\n\" ' gtk-clipboard clipboard support for the gtk UI (EXPERIMENTAL, MAY HANG)'\n printf \"%s\\n\" ' guest-agent Build QEMU Guest Agent'\n printf \"%s\\n\" ' guest-agent-msi Build MSI package for the QEMU Guest Agent'\n printf \"%s\\n\" ' hv-balloon hv-balloon driver (requires Glib 2.68+ GTree API)'\n@@ -336,8 +335,6 @@ _meson_option_parse() {\n --disable-gnutls) printf \"%s\" -Dgnutls=disabled ;;\n --enable-gtk) printf \"%s\" -Dgtk=enabled ;;\n --disable-gtk) printf \"%s\" -Dgtk=disabled ;;\n- --enable-gtk-clipboard) printf \"%s\" -Dgtk_clipboard=enabled ;;\n- --disable-gtk-clipboard) printf \"%s\" -Dgtk_clipboard=disabled ;;\n --enable-guest-agent) printf \"%s\" -Dguest_agent=enabled ;;\n --disable-guest-agent) printf \"%s\" -Dguest_agent=disabled ;;\n --enable-guest-agent-msi) printf \"%s\" -Dguest_agent_msi=enabled ;;\ndiff --git a/ui/meson.build b/ui/meson.build\nindex 3d15ff96287..ceaf110683d 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -112,9 +112,7 @@ if gtk.found()\n \n gtk_ss = ss.source_set()\n gtk_ss.add(gtk, vte, pixman, files('gtk.c'))\n- if have_gtk_clipboard\n- gtk_ss.add(files('gtk-clipboard.c'))\n- endif\n+ gtk_ss.add(files('gtk-clipboard.c'))\n gtk_ss.add(when: x11, if_true: files('x_keymap.c'))\n gtk_ss.add(when: opengl, if_true: files('gtk-gl-area.c'))\n gtk_ss.add(when: [x11, opengl], if_true: files('gtk-egl.c'))\n","prefixes":["PULL","v2","15/15"]}