{"id":2229642,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-15-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428150726.1659814-15-marcandre.lureau@redhat.com>","date":"2026-04-28T15:07:24","name":"[PULL,v2,14/15] ui/gtk: Use non-blocking clipboard retrieval","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f5bd2d8ab10bc94dbc705b1ee6942ca6bef9804","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-15-marcandre.lureau@redhat.com/mbox/","series":[{"id":501872,"url":"http://patchwork.ozlabs.org/api/1.1/series/501872/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501872","date":"2026-04-28T15:07:10","name":"[PULL,v2,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","version":2,"mbox":"http://patchwork.ozlabs.org/series/501872/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229642/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229642/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=CG4DnHty;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4kNr42zMz1xrS\n\tfor ; Wed, 29 Apr 2026 01:09:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHk3k-0004Kg-4U; Tue, 28 Apr 2026 11:09:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHk3d-0004HI-VZ\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:09:06 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHk3c-0000tB-E0\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:09:05 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-fKf36PWmMsSuwaH5eQ7NsA-1; Tue,\n 28 Apr 2026 11:08:59 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id CA84D18001CD; Tue, 28 Apr 2026 15:08:58 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 129A2180045E; Tue, 28 Apr 2026 15:08:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777388943;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Gy3gvmjpI8EblaKmP37cy8WZAr58VmLwq/dbUZN2fU8=;\n b=CG4DnHtycXpae9kdXOgQaD+ZvJoodypjg0q8DRuFB6oBP60lD0bYGedReXid9GQKyKUem9\n xpqNGGfizAat3czOgbP7c/dn/JRMVEwqCYasBpXIzBBGgj96PMuEuvuem3oH4HKqIy/6x5\n yRlhkd+h4yPiluL7+bOgAmDWenaaTck=","X-MC-Unique":"fKf36PWmMsSuwaH5eQ7NsA-1","X-Mimecast-MFC-AGG-ID":"fKf36PWmMsSuwaH5eQ7NsA_1777388938","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"stefanha@gmail.com,\n =?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= , =?utf-8?q?Ma?=\n\t=?utf-8?q?rc-Andr=C3=A9_Lureau?= ","Subject":"[PULL v2 14/15] ui/gtk: Use non-blocking clipboard retrieval","Date":"Tue, 28 Apr 2026 19:07:24 +0400","Message-ID":"<20260428150726.1659814-15-marcandre.lureau@redhat.com>","In-Reply-To":"<20260428150726.1659814-1-marcandre.lureau@redhat.com>","References":"<20260428150726.1659814-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Jindřich Makovička \n\nSigned-off-by: Jindrich Makovicka \nReviewed-by: Marc-André Lureau \nMessage-ID: <20260427-gtk-clipboard-v5-1-6968feb31a5d@gmail.com>\n---\n ui/gtk-clipboard.c | 53 ++++++++++++++++++++++++++++++++++------------\n 1 file changed, 40 insertions(+), 13 deletions(-)","diff":"diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c\nindex 65d89ec601d..463ed4e905b 100644\n--- a/ui/gtk-clipboard.c\n+++ b/ui/gtk-clipboard.c\n@@ -136,26 +136,55 @@ static void gd_clipboard_notify(Notifier *notifier, void *data)\n }\n }\n \n+static void\n+gd_clipboard_request_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (text) {\n+ qemu_clipboard_set_data(info->owner, info, QEMU_CLIPBOARD_TYPE_TEXT,\n+ strlen(text), text, true);\n+ }\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_clipboard_request(QemuClipboardInfo *info,\n QemuClipboardType type)\n {\n GtkDisplayState *gd = container_of(info->owner, GtkDisplayState, cbpeer);\n- char *text;\n \n switch (type) {\n case QEMU_CLIPBOARD_TYPE_TEXT:\n- text = gtk_clipboard_wait_for_text(gd->gtkcb[info->selection]);\n- if (text) {\n- qemu_clipboard_set_data(&gd->cbpeer, info, type,\n- strlen(text), text, true);\n- g_free(text);\n- }\n+ qemu_clipboard_info_ref(info);\n+ gtk_clipboard_request_text(gd->gtkcb[info->selection],\n+ gd_clipboard_request_text_received_callback,\n+ info);\n break;\n default:\n break;\n }\n }\n \n+static void gd_clipboard_owner_change_targets_received_callback(\n+ GtkClipboard *clipboard,\n+ GdkAtom *targets,\n+ gint n_targets,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (n_targets) {\n+ if (gtk_targets_include_text(targets, n_targets)) {\n+ info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n+ }\n+ }\n+\n+ qemu_clipboard_update(info);\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_owner_change(GtkClipboard *clipboard,\n GdkEvent *event,\n gpointer data)\n@@ -173,12 +202,10 @@ static void gd_owner_change(GtkClipboard *clipboard,\n switch (event->owner_change.reason) {\n case GDK_OWNER_CHANGE_NEW_OWNER:\n info = qemu_clipboard_info_new(&gd->cbpeer, s);\n- if (gtk_clipboard_wait_is_text_available(clipboard)) {\n- info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n- }\n-\n- qemu_clipboard_update(info);\n- qemu_clipboard_info_unref(info);\n+ gtk_clipboard_request_targets(\n+ clipboard,\n+ gd_clipboard_owner_change_targets_received_callback,\n+ info);\n break;\n default:\n qemu_clipboard_peer_release(&gd->cbpeer, s);\n","prefixes":["PULL","v2","14/15"]}