{"id":2229577,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229577/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428131756.922303-5-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428131756.922303-5-dhowells@redhat.com>","date":"2026-04-28T13:17:34","name":"[v5,04/24] netfs: Fix netfs_read_to_pagecache() to pause on subreq failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6f207c538bc253712f495f6bba6cab419b40f8ad","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428131756.922303-5-dhowells@redhat.com/mbox/","series":[{"id":501852,"url":"http://patchwork.ozlabs.org/api/1.1/series/501852/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501852","date":"2026-04-28T13:17:35","name":"netfs: Miscellaneous fixes","version":5,"mbox":"http://patchwork.ozlabs.org/series/501852/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229577/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229577/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dD31MZ79;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11195-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"dD31MZ79\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hRh31Mgz1yHv\n\tfor ; Tue, 28 Apr 2026 23:41:36 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9870930E2CA0\n\tfor ; Tue, 28 Apr 2026 13:26:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0EA5D47277B;\n\tTue, 28 Apr 2026 13:19:10 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EBD4472785\n\tfor ; Tue, 28 Apr 2026 13:19:08 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-7zCkveG9NRmxk-gbMKgZjA-1; Tue,\n 28 Apr 2026 09:19:02 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id CAA8B186B1A4;\n\tTue, 28 Apr 2026 13:18:21 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1A22719560AB;\n\tTue, 28 Apr 2026 13:18:18 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777382349; cv=none;\n b=BzvblYJ2Xhu2JYdal0nTVuDmwySuaV/Z3gAbH6l0YbY/9ft9SfXE+i4/pEncsKrXGnXvu4zV7nBLHpk+HnKicKg9XwvqnxjzmsFUaCtmXro6pjW+gpt+cxg/la1nYfMQNTVh3gBsmlZzsd9b5f9y9bLbTCsl7G8Dnf29zT3Wj30=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777382349; c=relaxed/simple;\n\tbh=xt/VtEfH0gIsDmidCvLtu7xSES7YK7i6BHGIB3e+zRY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=IuHXozJOj75I2D0orPo4ccbQetyfLhnsF+6JaDcykBcNUWRxsjVztfFdBcWvybVoeB32DThb372UbTMw/A37QVjTDydNpselZy2BHk3U7FsY7/hX+NOkwK7Za4fgVWKzyaLBi0huMRCP/nDiKvsRHGCBCrIU649cEGcPGqJb6PU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=dD31MZ79; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777382347;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=NNTWy1b19ZoNmt6S5T/uvk5jPsS1NSlNmD1y6ywnbBw=;\n\tb=dD31MZ79OBFtd9APhkQQtsSKwDcBRSnudwLiBxI5e+qIIGnb65vg6HmIlCaRdH21gICiiy\n\tD0Dtu+CLDUITIxn182JHbk//LQrcLyFC6D00mwZYuFeBT9ABju1EVv0i0z/GFQMt+BZVWr\n\t/E+kQUHC1+5/n+ceD0y8PbK8GqyeGkE=","X-MC-Unique":"7zCkveG9NRmxk-gbMKgZjA-1","X-Mimecast-MFC-AGG-ID":"7zCkveG9NRmxk-gbMKgZjA_1777382338","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v5 04/24] netfs: Fix netfs_read_to_pagecache() to pause on\n subreq failure","Date":"Tue, 28 Apr 2026 14:17:34 +0100","Message-ID":"<20260428131756.922303-5-dhowells@redhat.com>","In-Reply-To":"<20260428131756.922303-1-dhowells@redhat.com>","References":"<20260428131756.922303-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"Fix netfs_read_to_pagecache() so that it pauses the generation of new\nsubrequests if an already-issued subrequest fails.\n\nFixes: ee4cdf7ba857 (\"netfs: Speed up buffered reading\")\nCloses: https://sashiko.dev/#/patchset/20260425125426.3855807-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex 7ec11893552d..228d058bf1a2 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -299,6 +299,11 @@ static void netfs_read_to_pagecache(struct netfs_io_request *rreq,\n \t\t}\n \n \t\tnetfs_issue_read(rreq, subreq);\n+\n+\t\tif (test_bit(NETFS_RREQ_PAUSE, &rreq->flags))\n+\t\t\tnetfs_wait_for_paused_read(rreq);\n+\t\tif (test_bit(NETFS_RREQ_FAILED, &rreq->flags))\n+\t\t\tbreak;\n \t\tcond_resched();\n \t} while (size > 0);\n \n","prefixes":["v5","04/24"]}