{"id":2229568,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229568/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260428103645.50617-1-Gautam.Menghani@ibm.com/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","date":"2026-04-28T10:36:44","name":"[v2] hw/intc/xics: Add a check for an invalid server id","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9675dc295cf3dd4dce94877fde07253a8f34f23b","submitter":{"id":93249,"url":"http://patchwork.ozlabs.org/api/1.1/people/93249/?format=json","name":"Gautam Menghani","email":"Gautam.Menghani@ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260428103645.50617-1-Gautam.Menghani@ibm.com/mbox/","series":[{"id":501854,"url":"http://patchwork.ozlabs.org/api/1.1/series/501854/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=501854","date":"2026-04-28T10:36:44","name":"[v2] hw/intc/xics: Add a check for an invalid server id","version":2,"mbox":"http://patchwork.ozlabs.org/series/501854/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229568/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229568/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=WT6d33Xg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hKn3pPLz1xrS\n\tfor ; Tue, 28 Apr 2026 23:36:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHibf-0005dH-Ht; Tue, 28 Apr 2026 09:36:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHfoN-0003hE-Na; Tue, 28 Apr 2026 06:37:03 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHfoL-0008KB-To; Tue, 28 Apr 2026 06:37:03 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63S8Y6G2036865; Tue, 28 Apr 2026 10:36:58 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drm1duw9a-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 28 Apr 2026 10:36:58 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63SANvJ5001198;\n Tue, 28 Apr 2026 10:36:57 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dsamy917p-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 28 Apr 2026 10:36:57 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63SAareX60621098\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 28 Apr 2026 10:36:53 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 8F6692004B;\n Tue, 28 Apr 2026 10:36:53 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id D712220040;\n Tue, 28 Apr 2026 10:36:51 +0000 (GMT)","from localhost.localdomain (unknown [9.43.36.19])\n by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 28 Apr 2026 10:36:51 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=Fmr4fsjDCSje8LaRXFevkKK/e5kpy7KbCEwat6mo5\n wg=; b=WT6d33Xg1CjkMnPYjgKqeINiniulyzxCJVQ7rhyyW03sB7fnG7ksRJ2TN\n m84GYQLI7D1sJGNHcuKlsuHLWrct8J+hA1XqLJ0RwOCwFfiU5IwLCikH3SxILPCc\n WpW+cgfpBU/hLmPx/o8nCQNc6nSHzidFwiD7umA+72hIRapu/0GamfA68KoVpbUw\n xoQvJnSalu3va487ZhqYf5Yl24DUjueyuz2WIB0E6xs5uNKds7rpStQ3utpv6ZJf\n 63fWb/X8mhvZLiZL8UUYlbEeS9QoV6CP6lM7lHlQm/Ifv0sa7m836ym2Cr/F0k5Q\n JHk/bnQuAqTGKsjUTP7uR7E7CkYfw==","From":"Gautam Menghani ","To":"npiggin@gmail.com, harshpb@linux.ibm.com, adityag@linux.ibm.com","Cc":"kiki , qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n Zexiang Zhang , Gautam Menghani ","Subject":"[PATCH v2] hw/intc/xics: Add a check for an invalid server id","Date":"Tue, 28 Apr 2026 16:06:44 +0530","Message-ID":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"niRNXtms5A0aSykIOvL3piamIEvrHa-I","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI4MDA5MSBTYWx0ZWRfXya1fBzqhH+Z0\n JdHCadIdHXuPao0K31kzLe5R17Wou/7mCyKPqyZjDlysAg2Sl09EarhV8BO6Kf+u6OkSM7SPF0a\n dkQ4WAGvB4QaLULFLZKiEOoa+M878gU8TIt4X6wta24nmbU3dQ9tG47uAFDrl9nLXdaJyM+jOZF\n HpVMRXS1gPNV+8iIEl4sXieezYh25z0NByTwXSUCZMQfQNtupZGar4PlrnyGWxwbzVgg1gtCHe1\n FVs2ELbD+lYAF8OyXakHn3RCkQnTGbUdiM5L0RuSVXhwIniQ9fzgEpef07t6mrVmYV2lWoVzd/v\n eGoanjFGiZ8HSlQ94E3oGm3QHf6KfZFV2RxhnUQJlptpvjO4kunNqK93BJe1EoM52Ci/CxYfqeo\n Bf+sOimb49JunIVBC2kh9MfmKX924okg8NehCh+JIbwX2E+67HaRoeaYqFLC5vDFnyfFNAEthva\n 85zEpcJ0p8rGuzKZQLA==","X-Authority-Analysis":"v=2.4 cv=VZLH+lp9 c=1 sm=1 tr=0 ts=69f08dca cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8\n a=gDGxtpEj6ED9AaWiFCkA:9","X-Proofpoint-GUID":"UrssTfQayPXaH2P0i-Va2YOmuDEpzajl","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_02,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1011 suspectscore=0 adultscore=0 lowpriorityscore=0 phishscore=0\n spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280091","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=Gautam.Menghani@ibm.com; helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-Mailman-Approved-At":"Tue, 28 Apr 2026 09:36:04 -0400","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: kiki \n\nA malformed IVE value can result in an invalid server field being\npassed to icp_irq(). The function assumes the server id is valid and\nmay access invalid state otherwise, potentially leading to a crash.\n\nFix this by validating the server id before using it and ignoring\ninvalid values.\n\nReported-by: Zexiang Zhang \nSigned-off-by: Zexiang Zhang \nSigned-off-by: Gautam Menghani \n---\nv2:\n1. Fix build error and subject line\n\n hw/intc/xics.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/hw/intc/xics.c b/hw/intc/xics.c\nindex c0a252d051..e32984e9fc 100644\n--- a/hw/intc/xics.c\n+++ b/hw/intc/xics.c\n@@ -26,6 +26,7 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/log.h\"\n #include \"qapi/error.h\"\n #include \"trace.h\"\n #include \"qemu/timer.h\"\n@@ -222,6 +223,13 @@ void icp_irq(ICSState *ics, int server, int nr, uint8_t priority)\n \n trace_xics_icp_irq(server, nr, priority);\n \n+ if (!icp) {\n+ qemu_log_mask(LOG_GUEST_ERROR, \"XICS: invalid server %d for IRQ 0x%x\\n\",\n+ server, nr);\n+ ics_reject(ics, nr);\n+ return;\n+ }\n+\n if ((priority >= CPPR(icp))\n || (XISR(icp) && (icp->pending_priority <= priority))) {\n ics_reject(ics, nr);\n","prefixes":["v2"]}