{"id":2229564,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229564/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260428133233.28050-1-mdoucha@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428133233.28050-1-mdoucha@suse.cz>","date":"2026-04-28T13:32:11","name":"[1/2] aio_cancel: Fix incorrect strerror() usage","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"9d7f2d1f05ddeeb53c4ce402897cfdfba1ac9f90","submitter":{"id":77472,"url":"http://patchwork.ozlabs.org/api/1.1/people/77472/?format=json","name":"Martin Doucha","email":"mdoucha@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260428133233.28050-1-mdoucha@suse.cz/mbox/","series":[{"id":501851,"url":"http://patchwork.ozlabs.org/api/1.1/series/501851/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=501851","date":"2026-04-28T13:32:12","name":"[1/2] aio_cancel: Fix incorrect strerror() usage","version":1,"mbox":"http://patchwork.ozlabs.org/series/501851/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229564/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2229564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=0RuuPPzm;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=eZcqXTY0;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=0RuuPPzm;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=eZcqXTY0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0RuuPPzm;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eZcqXTY0"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hFq6zKbz1yHv\n\tfor ; Tue, 28 Apr 2026 23:33:03 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 027523E49F6\n\tfor ; Tue, 28 Apr 2026 15:33:02 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 297433DEFF3\n for ; Tue, 28 Apr 2026 15:32:40 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id AEE5814004EE\n for ; Tue, 28 Apr 2026 15:32:39 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 7C2F15BCFE\n for ; Tue, 28 Apr 2026 13:32:38 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6A852593B0\n for ; Tue, 28 Apr 2026 13:32:38 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id TxjOGfa28GlLbwAAD6G6ig\n (envelope-from )\n for ; Tue, 28 Apr 2026 13:32:38 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777383158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=z5wQ2/r1uRm2fKOp9YwEbUVk059hmYE3cd1uOckcQuU=;\n b=0RuuPPzmysOJAcx46vY5Bo9knHXQNlYLeKhAwgGENrdxKjagJWKfgyoA9Sfo9duvVb6smZ\n irL+h5ZOjuNDheUHxG5cWvRHsLeEw5XuRGauJP2GmecrWsJpDgrVUzath3j/MvJxL+pGpU\n 93h+eanSNVe2ejD5vM/LBn1OxWCNh44=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777383158;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=z5wQ2/r1uRm2fKOp9YwEbUVk059hmYE3cd1uOckcQuU=;\n b=eZcqXTY0OKF3Of3ZrgbJaGASvZAbZXp48zPY9ovAyt9mJ86pyDPyzcqoiG3jg6IyEKRDEs\n JGzNQ+9w5vYLduCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777383158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=z5wQ2/r1uRm2fKOp9YwEbUVk059hmYE3cd1uOckcQuU=;\n b=0RuuPPzmysOJAcx46vY5Bo9knHXQNlYLeKhAwgGENrdxKjagJWKfgyoA9Sfo9duvVb6smZ\n irL+h5ZOjuNDheUHxG5cWvRHsLeEw5XuRGauJP2GmecrWsJpDgrVUzath3j/MvJxL+pGpU\n 93h+eanSNVe2ejD5vM/LBn1OxWCNh44=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777383158;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=z5wQ2/r1uRm2fKOp9YwEbUVk059hmYE3cd1uOckcQuU=;\n b=eZcqXTY0OKF3Of3ZrgbJaGASvZAbZXp48zPY9ovAyt9mJ86pyDPyzcqoiG3jg6IyEKRDEs\n JGzNQ+9w5vYLduCw=="],"From":"Martin Doucha ","To":"ltp@lists.linux.it","Date":"Tue, 28 Apr 2026 15:32:11 +0200","Message-ID":"<20260428133233.28050-1-mdoucha@suse.cz>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_NONE(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,\n imap1.dmz-prg2.suse.org:rdns, suse.cz:dkim, suse.cz:mid, suse.cz:email]","X-Rspamd-Queue-Id":"7C2F15BCFE","X-Spam-Score":"-3.01","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH 1/2] aio_cancel: Fix incorrect strerror() usage","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"Each call of strerror() invalidates the previous return value. Split\nprint calls to avoid calling strerror() twice in the argument list.\n\nSigned-off-by: Martin Doucha \n---\n .../conformance/interfaces/aio_cancel/5-1.c | 5 +++--\n .../conformance/interfaces/aio_cancel/7-1.c | 5 +++--\n 2 files changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\nindex dd5b0bbfb..04306417e 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/5-1.c\n@@ -131,8 +131,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t\t}\n \n \t\tif (ret != exp_ret) {\n-\t\t\tprintf(TNAME \" Bad task #%d result: %s (expected %s)\\n\",\n-\t\t\t\ti, strerror(ret), strerror(exp_ret));\n+\t\t\tprintf(TNAME \" Bad task #%d result: %s\",\n+\t\t\t\ti, strerror(ret));\n+\t\t\tprintf(\" (expected %s)\\n\", strerror(exp_ret));\n \t\t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\t\treturn PTS_FAIL;\n \t\t}\ndiff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\nindex 36ce8bb12..0fdc1bef8 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/7-1.c\n@@ -118,8 +118,9 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n \t\t}\n \n \t\tif (ret != exp_ret) {\n-\t\t\tprintf(TNAME \" Bad task #%d result: %s (expected %s)\\n\",\n-\t\t\t\ti, strerror(ret), strerror(exp_ret));\n+\t\t\tprintf(TNAME \" Bad task #%d result: %s\",\n+\t\t\t\ti, strerror(ret));\n+\t\t\tprintf(\" (expected %s)\\n\", strerror(exp_ret));\n \t\t\tcleanup_aio(fds, aiocb, BUF_NB);\n \t\t\treturn PTS_FAIL;\n \t\t}\n","prefixes":["1/2"]}