{"id":2229563,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229563/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260428133233.28050-2-mdoucha@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428133233.28050-2-mdoucha@suse.cz>","date":"2026-04-28T13:32:12","name":"[2/2] aio_cancel_6-1: Rewrite test","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"9eb6d8b3cfc4d665d60c76ecea18b79f866ea9f8","submitter":{"id":77472,"url":"http://patchwork.ozlabs.org/api/1.1/people/77472/?format=json","name":"Martin Doucha","email":"mdoucha@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260428133233.28050-2-mdoucha@suse.cz/mbox/","series":[{"id":501851,"url":"http://patchwork.ozlabs.org/api/1.1/series/501851/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=501851","date":"2026-04-28T13:32:12","name":"[1/2] aio_cancel: Fix incorrect strerror() usage","version":1,"mbox":"http://patchwork.ozlabs.org/series/501851/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229563/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2229563/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=T0K9Wf9W;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=W97B16zh;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=T0K9Wf9W;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=W97B16zh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hFV01psz1yHv\n\tfor ; Tue, 28 Apr 2026 23:32:45 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 999D33E2539\n\tfor ; Tue, 28 Apr 2026 15:32:43 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id EB5153DEFF3\n for ; Tue, 28 Apr 2026 15:32:39 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 4D58A600B80\n for ; Tue, 28 Apr 2026 15:32:39 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 957EC6A85C\n for ; Tue, 28 Apr 2026 13:32:38 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A7FB593B1\n for ; Tue, 28 Apr 2026 13:32:38 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 0IuzHfa28GlLbwAAD6G6ig\n (envelope-from )\n for ; Tue, 28 Apr 2026 13:32:38 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777383158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1QbX2oSnUixJTRBTzreGKl/X+2OC4cRnfeRXLGIl9Ng=;\n b=T0K9Wf9WYwNRLMOmlWAObTX3XLZqcpn52GCIdB3t5uPY5b0nDGWEi4JB9eCORy3JXEUTTb\n Ykx4vTBlAuhlWM6F4KUi14zLXuVuMuxz7dT92+gmTf8mrFMfqG+mVDX52d7bd1jBSUjoCm\n YXLMb2WxWBNaY+7aVTY9gwjxvmXBVhM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777383158;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1QbX2oSnUixJTRBTzreGKl/X+2OC4cRnfeRXLGIl9Ng=;\n b=W97B16zhnx6Hn6KbaZL2AQ+57gxEzapZUvdqTNZ+d+rnfMCcl3r0iYShYZj7+f8l5Qlq3G\n uC3h3HB7QKwyvCCg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777383158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1QbX2oSnUixJTRBTzreGKl/X+2OC4cRnfeRXLGIl9Ng=;\n b=T0K9Wf9WYwNRLMOmlWAObTX3XLZqcpn52GCIdB3t5uPY5b0nDGWEi4JB9eCORy3JXEUTTb\n Ykx4vTBlAuhlWM6F4KUi14zLXuVuMuxz7dT92+gmTf8mrFMfqG+mVDX52d7bd1jBSUjoCm\n YXLMb2WxWBNaY+7aVTY9gwjxvmXBVhM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777383158;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1QbX2oSnUixJTRBTzreGKl/X+2OC4cRnfeRXLGIl9Ng=;\n b=W97B16zhnx6Hn6KbaZL2AQ+57gxEzapZUvdqTNZ+d+rnfMCcl3r0iYShYZj7+f8l5Qlq3G\n uC3h3HB7QKwyvCCg=="],"From":"Martin Doucha ","To":"ltp@lists.linux.it","Date":"Tue, 28 Apr 2026 15:32:12 +0200","Message-ID":"<20260428133233.28050-2-mdoucha@suse.cz>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428133233.28050-1-mdoucha@suse.cz>","References":"<20260428133233.28050-1-mdoucha@suse.cz>","MIME-Version":"1.0","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.995];\n MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1];\n ARC_NA(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n RCVD_TLS_ALL(0.00)[]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH 2/2] aio_cancel_6-1: Rewrite test","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"The test schedules multiple async writes into a file and then hopes that\nat least one will block long enough that aio_cancel() will cancel it.\nUse a socket pair instead of a file to force async writes to block\nindefinitely, then cancel one of the blocked writes. This fixes a race\ncondition where aio_cancel() could be called after the target write\nhas already finished. Also improve result checks to verify that\nnon-canceled writes are still pending.\n\nSigned-off-by: Martin Doucha \n---\n .../conformance/interfaces/aio_cancel/6-1.c | 135 +++++++-----------\n 1 file changed, 48 insertions(+), 87 deletions(-)","diff":"diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/6-1.c\nindex 2e3d64742..0282677a8 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/6-1.c\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/6-1.c\n@@ -1,5 +1,6 @@\n /*\n * Copyright (c) 2004, Bull SA. All rights reserved.\n+ * Copyright (c) 2026 SUSE LLC\n * Created by: Laurent.Vivier@bull.net\n * This file is licensed under the GPL license. For the full content\n * of this license, see the COPYING file at the top level of this\n@@ -14,128 +15,88 @@\n *\n * method:\n *\n- *\tqueue a lot of aio_write() to a given fildes.\n- *\ttry to cancel the last one submited\n- *\tif aio_error() is ECANCELED and aio_cancel() is AIO_CANCELED\n- *\ttest is passed\n- *\tif aio_error() is ECANCELED and aio_cancel() is NOT AIO_CANCELED\n- *\ttest is failed\n- *\tif there is no aio_error() with ECANCELED and\n- *\taio_cancel() is AIO_CANCELED\n- *\ttest is failed\n- *\totherwise test is unresolved\n+ *\tqueue multiple aio_write()s to a given socket\n+ *\ttry to cancel a task which hasn't been started yet\n+ *\tif aio_cancel() return value is not AIO_CANCELED, the test failed\n+ *\tfor blocked tasks, aio_error() must be:\n+ *\t- ECANCELED if aio_cancel() was called on it\n+ *\t- EINPROGRESS otherwise\n+ *\tif all aio_error() values match, the test passed, otherwise it failed\n *\n */\n \n-#include \n-#include \n #include \n-#include \n-#include \n-#include \n-#include \n-#include \n-#include \n \n #include \"posixtest.h\"\n-#include \"tempfile.h\"\n+#include \"aio_test.h\"\n \n #define TNAME \"aio_cancel/6-1.c\"\n \n-#define BUF_NB\t\t128\n-#define BUF_SIZE\t1024\n+#define WRITE_COUNT\t8\n+#define MAX_COMPLETE\t3\n+#define CANCELED_TASK\t5\n+\n+static int fds[2];\n+static struct aiocb aiocb[WRITE_COUNT];\n \n int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)\n {\n-\tchar tmpfname[PATH_MAX];\n-\tint fd;\n-\tstruct aiocb *aiocb[BUF_NB];\n \tint i;\n-\tint in_progress;\n \tint gret;\n \n \tif (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L)\n \t\treturn PTS_UNSUPPORTED;\n \n-\tPTS_GET_TMP_FILENAME(tmpfname, \"pts_aio_cancel_6_1\");\n-\tunlink(tmpfname);\n-\tfd = open(tmpfname, O_CREAT | O_RDWR | O_EXCL, S_IRUSR | S_IWUSR);\n-\tif (fd == -1) {\n-\t\tprintf(TNAME \" Error at open(): %s\\n\", strerror(errno));\n+\tif (setup_aio(TNAME, fds, aiocb, WRITE_COUNT))\n \t\treturn PTS_UNRESOLVED;\n-\t}\n-\n-\tunlink(tmpfname);\n \n \t/* create AIO req */\n-\n-\tfor (i = 0; i < BUF_NB; i++) {\n-\t\taiocb[i] = calloc(1, sizeof(struct aiocb));\n-\t\tif (aiocb[i] == NULL) {\n-\t\t\tprintf(TNAME \" Error at malloc(): %s\\n\",\n-\t\t\t strerror(errno));\n-\t\t\treturn PTS_UNRESOLVED;\n-\t\t}\n-\t\taiocb[i]->aio_fildes = fd;\n-\t\taiocb[i]->aio_buf = malloc(BUF_SIZE);\n-\t\tif (aiocb[i]->aio_buf == NULL) {\n-\t\t\tprintf(TNAME \" Error at malloc(): %s\\n\",\n-\t\t\t strerror(errno));\n-\t\t\treturn PTS_UNRESOLVED;\n-\t\t}\n-\t\taiocb[i]->aio_nbytes = BUF_SIZE;\n-\t\taiocb[i]->aio_offset = 0;\n-\t\taiocb[i]->aio_sigevent.sigev_notify = SIGEV_NONE;\n-\n-\t\tif (aio_write(aiocb[i]) == -1) {\n+\tfor (i = 0; i < WRITE_COUNT; i++) {\n+\t\tif (aio_write(&aiocb[i]) == -1) {\n \t\t\tprintf(TNAME \" loop %d: Error at aio_write(): %s\\n\",\n-\t\t\t i, strerror(errno));\n+\t\t\t\ti, strerror(errno));\n+\t\t\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n \t\t\treturn PTS_FAIL;\n \t\t}\n \t}\n \n \t/* try to cancel the last one queued */\n-\n-\tgret = aio_cancel(fd, aiocb[i - 1]);\n+\tgret = aio_cancel(fds[0], &aiocb[CANCELED_TASK]);\n \n \tif (gret == -1) {\n \t\tprintf(TNAME \" Error at aio_cancel(): %s\\n\", strerror(errno));\n+\t\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n \t\treturn PTS_FAIL;\n \t}\n \n-\tclose(fd);\n-\n-\tdo {\n-\t\tin_progress = 0;\n-\t\tfor (i = 0; i < BUF_NB; i++) {\n-\t\t\tint ret;\n-\n-\t\t\tret = (aio_error(aiocb[i]));\n-\n-\t\t\tif (ret == -1) {\n-\t\t\t\tprintf(TNAME \" Error at aio_error(): %s\\n\",\n-\t\t\t\t strerror(errno));\n-\t\t\t\treturn PTS_FAIL;\n-\t\t\t} else if (ret == EINPROGRESS)\n-\t\t\t\tin_progress = 1;\n-\t\t\telse if (ret == ECANCELED) {\n-\t\t\t\tif (gret == AIO_CANCELED) {\n-\t\t\t\t\tprintf(\"Test PASSED\\n\");\n-\t\t\t\t\treturn PTS_PASS;\n-\t\t\t\t}\n-\n-\t\t\t\tprintf(TNAME\n-\t\t\t\t \" aio_cancel() is not AIO_CANCELED\\n\");\n-\t\t\t\treturn PTS_FAIL;\n-\t\t\t}\n+\tif (gret != AIO_CANCELED) {\n+\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %s\\n\",\n+\t\t\tstrerror(gret));\n+\t\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n+\t\treturn PTS_FAIL;\n+\t}\n+\n+\tfor (i = MAX_COMPLETE; i < WRITE_COUNT; i++) {\n+\t\tint exp_ret = (i == CANCELED_TASK) ? ECANCELED : EINPROGRESS;\n+\t\tint ret = aio_error(&aiocb[i]);\n+\n+\t\tif (ret == -1) {\n+\t\t\tprintf(TNAME \" Error at aio_error(): %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n+\t\t\treturn PTS_FAIL;\n \t\t}\n-\t} while (in_progress);\n \n-\tif (gret == AIO_CANCELED) {\n-\t\tprintf(TNAME\n-\t\t \" aio_cancel() is AIO_CANCELED without ECANCELED\\n\");\n-\t\treturn PTS_FAIL;\n+\t\tif (ret != exp_ret) {\n+\t\t\tprintf(TNAME \" Bad task #%d result %s\",\n+\t\t\t\ti, strerror(ret));\n+\t\t\tprintf(\" (expected: %s)\\n\", strerror(exp_ret));\n+\t\t\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n+\t\t\treturn PTS_FAIL;\n+\t\t}\n \t}\n \n-\treturn PTS_UNRESOLVED;\n+\tcleanup_aio(fds, aiocb, WRITE_COUNT);\n+\tprintf(\"Test PASSED\\n\");\n+\treturn PTS_PASS;\n }\n","prefixes":["2/2"]}