{"id":2229544,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229544/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428130718.1325177-7-stefanb@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428130718.1325177-7-stefanb@linux.ibm.com>","date":"2026-04-28T13:07:18","name":"[6/6] tests: Add a TPM TIS I2C swtpm test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4f360589945390403c6f3b15ec9baba7a00ac120","submitter":{"id":75097,"url":"http://patchwork.ozlabs.org/api/1.1/people/75097/?format=json","name":"Stefan Berger","email":"stefanb@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428130718.1325177-7-stefanb@linux.ibm.com/mbox/","series":[{"id":501847,"url":"http://patchwork.ozlabs.org/api/1.1/series/501847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501847","date":"2026-04-28T13:07:15","name":"Add test case for TPM over I2C with swtpm","version":1,"mbox":"http://patchwork.ozlabs.org/series/501847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229544/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229544/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kYdHMdO0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4gjj06YHz1xvV\n\tfor ; Tue, 28 Apr 2026 23:08:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHiAJ-0006XS-DA; Tue, 28 Apr 2026 09:07:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHiA6-0006UE-DS\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 09:07:41 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHiA3-0001KT-33\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 09:07:38 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63S6peHh2581734; Tue, 28 Apr 2026 13:07:31 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn8vccdc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 28 Apr 2026 13:07:31 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63SCw54N010467;\n Tue, 28 Apr 2026 13:07:30 GMT","from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ds7xq9wfp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 28 Apr 2026 13:07:30 +0000 (GMT)","from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com\n [10.241.53.103])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63SD7T1n30147304\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 28 Apr 2026 13:07:30 GMT","from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id C6E105805A;\n Tue, 28 Apr 2026 13:07:29 +0000 (GMT)","from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 7870D58052;\n Tue, 28 Apr 2026 13:07:29 +0000 (GMT)","from mycroft-2.pok.ibm.com (unknown [9.47.158.222])\n by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 28 Apr 2026 13:07:29 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=7NnKmXHbZdy2Zm7kz\n s4Yg9dgU0n6mNdcDNttJIzCMw0=; b=kYdHMdO0gbHNp2u4IPbWojo7r5BHWiarz\n QufyJ5IXWyWkNQxPAYiSXXQ7jDY7KO2KetKY6nOozeF8+jIKScBCSvhlElO6AL+T\n 4+LOZSzlp/nBRIEiM1CGMgbw0vuXfnLIgLtxyjMNayd0K10qyR+Dy8YHb76n5rFm\n C1bVIBmSiodUNHO+cKtqaps5+IDMQuvFsJfpAScRm8Og0OIvW91F/u8Rwltc82X8\n BeSg3azEY91tCLJV7FPnG9C7GY82zu0cj7j9TknagXT/WKOJ25RCjRyaJ8E3NOL8\n A7eV8VYYvFe29pjJKjNVwn32coS2j01WC7+vMMk0doS0AaBFqFt4Q==","From":"Stefan Berger ","To":"qemu-devel@nongnu.org","Cc":"marcandre.lureau@redhat.com, armenon@redhat.com,\n Stefan Berger ","Subject":"[PATCH 6/6] tests: Add a TPM TIS I2C swtpm test","Date":"Tue, 28 Apr 2026 13:07:18 +0000","Message-ID":"<20260428130718.1325177-7-stefanb@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260428130718.1325177-1-stefanb@linux.ibm.com>","References":"<20260428130718.1325177-1-stefanb@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=CIIamxrD c=1 sm=1 tr=0 ts=69f0b113 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=NJ5oAHpCSCO7Ays0SvMA:9","X-Proofpoint-ORIG-GUID":"S-R-HLWpzziaw13GZwZ-oHiYLUblNMNJ","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI4MDExOCBTYWx0ZWRfX0QeM7ci4Z6CO\n y4agmFwn3imckuxZL5otY1HkvcV9UEA6ncRGcfm06/E7BdyRdSsSUln4gYPH7AjuqgvyR9PQM05\n YulJwdTkAPgoOoHXb4+FMIzgoeJg6DBjj0Tk8joGXIZrk+0gwoAhth4FSZgP/MhluUkWck3AWSr\n COlvOs9O+TucU5xAFXE5ZIxnaM1aJXNPu2f1DXCH/xDOrQMT+s8Hxw1UWa+nmS180iLvLIJNum3\n TgrdsoFufTzXm0CAznlhK7BtScnZPpznEJgRshxOe+/Y2uyMcpAcnl1xy72nmuKfDHNomcGW3Gh\n JosLoHUN+qiadgP6mQ30gHnaAaxf6pbkcqg4NpchWabS4oZogIlTlvqa+sly2wFWN5xxV8LAya9\n J/dsgRtRZOcMqjtKL7jfWaZuULmewCwT0HsHd6M88MaUdppT0Z0Q6i+fcjRk0gCjBnfHimiAneb\n 2pfPL6Zl/nI7GGb/9yg==","X-Proofpoint-GUID":"S-R-HLWpzziaw13GZwZ-oHiYLUblNMNJ","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_04,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0\n impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604280118","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=stefanb@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add a test case testing the TPM TIS over I2C with swtpm.\n\nSigned-off-by: Stefan Berger \n---\n tests/qtest/meson.build | 5 +-\n tests/qtest/tpm-tis-i2c-swtpm-test.c | 86 ++++++++++++++++++++++++++++\n tests/qtest/tpm-tis-i2c-util.c | 38 ++++++++++++\n tests/qtest/tpm-tis-i2c-util.h | 4 ++\n 4 files changed, 131 insertions(+), 2 deletions(-)\n create mode 100644 tests/qtest/tpm-tis-i2c-swtpm-test.c","diff":"diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\nindex 823be192e7..1a94f20f7f 100644\n--- a/tests/qtest/meson.build\n+++ b/tests/qtest/meson.build\n@@ -241,7 +241,7 @@ qtests_arm = \\\n (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed : []) + \\\n (config_all_devices.has_key('CONFIG_NPCM7XX') ? qtests_npcm7xx : []) + \\\n (config_all_devices.has_key('CONFIG_GENERIC_LOADER') ? ['hexloader-test'] : []) + \\\n- (config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test'] : []) + \\\n+ (config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test', 'tpm-tis-i2c-swtpm-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_VEXPRESS') ? ['test-arm-mptimer'] : []) + \\\n (config_all_devices.has_key('CONFIG_MICROBIT') ? ['microbit-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_STM32L4X5_SOC') ? qtests_stm32l4x5 : []) + \\\n@@ -260,7 +260,7 @@ qtests_aarch64 = \\\n (config_all_devices.has_key('CONFIG_XLNX_VERSAL') ? ['xlnx-canfd-test', 'xlnx-versal-trng-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_RASPI') ? ['bcm2835-dma-test', 'bcm2835-i2c-test'] : []) + \\\n (config_all_accel.has_key('CONFIG_TCG') and \\\n- config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test'] : []) + \\\n+ config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test', 'tpm-tis-i2c-swtpm-test'] : []) + \\\n (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed64 : []) + \\\n (config_all_devices.has_key('CONFIG_NPCM8XX') ? qtests_npcm8xx : []) + \\\n (config_all_devices.has_key('CONFIG_IOMMU_TESTDEV') and\n@@ -398,6 +398,7 @@ qtests = {\n 'tpm-tis-swtpm-test': [io, tpmemu_files, 'tpm-tis-util.c'],\n 'tpm-tis-test': [io, tpmemu_files, 'tpm-tis-util.c'],\n 'tpm-tis-i2c-test': [io, tpmemu_files, 'tpm-tis-i2c-util.c', 'qtest_aspeed.c'],\n+ 'tpm-tis-i2c-swtpm-test': [io, tpmemu_files, 'tpm-tis-i2c-util.c', 'qtest_aspeed.c'],\n 'tpm-tis-device-swtpm-test': [io, tpmemu_files, 'tpm-tis-util.c'],\n 'tpm-tis-device-test': [io, tpmemu_files, 'tpm-tis-util.c'],\n 'virtio-net-failover': test_migration_files,\ndiff --git a/tests/qtest/tpm-tis-i2c-swtpm-test.c b/tests/qtest/tpm-tis-i2c-swtpm-test.c\nnew file mode 100644\nindex 0000000000..54a84251f8\n--- /dev/null\n+++ b/tests/qtest/tpm-tis-i2c-swtpm-test.c\n@@ -0,0 +1,86 @@\n+/*\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ *\n+ * QTest testcase for TPM TIS over I2C talking to external swtpm\n+ *\n+ * Copyright (c) 2018, 2026 IBM Corporation\n+ * with parts borrowed from migration-test.c that is:\n+ * Copyright (c) 2016-2018 Red Hat, Inc. and/or its affiliates\n+ *\n+ * Authors:\n+ * Stefan Berger \n+ *\n+ */\n+\n+#include \"qemu/osdep.h\"\n+\n+#include \"libqtest.h\"\n+#include \"qemu/module.h\"\n+#include \"tpm-tests.h\"\n+#include \"tpm-tis-i2c-util.h\"\n+#include \"qtest_aspeed.h\"\n+\n+typedef struct TestState {\n+ char *src_tpm_path;\n+ char *dst_tpm_path;\n+ char *uri;\n+ const char *machine_options;\n+ char *ifmodel;\n+} TestState;\n+\n+static void tpm_tis_i2c_swtpm_test(const void *data)\n+{\n+ const TestState *ts = data;\n+\n+ aspeed_i2c_restart();\n+\n+ tpm_test_swtpm_test(ts->src_tpm_path, tpm_tis_i2c_transfer,\n+ ts->ifmodel, ts->machine_options);\n+}\n+\n+static void tpm_tis_swtpm_migration_test(const void *data)\n+{\n+ const TestState *ts = data;\n+\n+ aspeed_i2c_restart();\n+\n+ tpm_test_swtpm_migration_test(ts->src_tpm_path, ts->dst_tpm_path,\n+ ts->uri, tpm_tis_i2c_transfer,\n+ ts->ifmodel, ts->machine_options);\n+}\n+\n+\n+int main(int argc, char **argv)\n+{\n+ int ret;\n+ TestState ts;\n+\n+ ts.src_tpm_path = g_dir_make_tmp(\"qemu-tpm-tis-i2c-swtpm-test.XXXXXX\",\n+ NULL);\n+ ts.dst_tpm_path = g_dir_make_tmp(\"qemu-tpm-tis-i2c-swtpm-test.XXXXXX\",\n+ NULL);\n+ ts.uri = g_strdup_printf(\"unix:%s/migsocket\", ts.src_tpm_path);\n+ ts.machine_options = \"-machine rainier-bmc -accel tcg\";\n+ ts.ifmodel = g_strdup_printf(\n+ \"tpm-tis-i2c,bus=aspeed.i2c.bus.%d,address=0x%x\",\n+ I2C_DEV_BUS_NUM, I2C_SLAVE_ADDR);\n+\n+ module_call_init(MODULE_INIT_QOM);\n+ g_test_init(&argc, &argv, NULL);\n+\n+ aspeed_bus_addr = ast2600_i2c_calc_bus_addr(I2C_DEV_BUS_NUM);\n+\n+ qtest_add_data_func(\"/tpm/tis-i2c-swtpm/test\", &ts, tpm_tis_i2c_swtpm_test);\n+ qtest_add_data_func(\"/tpm/tis-i2c-swtpm-migration/test\", &ts,\n+ tpm_tis_swtpm_migration_test);\n+ ret = g_test_run();\n+\n+ tpm_util_rmdir(ts.dst_tpm_path);\n+ g_free(ts.dst_tpm_path);\n+ tpm_util_rmdir(ts.src_tpm_path);\n+ g_free(ts.src_tpm_path);\n+ g_free(ts.uri);\n+ g_free(ts.ifmodel);\n+\n+ return ret;\n+}\ndiff --git a/tests/qtest/tpm-tis-i2c-util.c b/tests/qtest/tpm-tis-i2c-util.c\nindex 6e724a4a47..c73420ec5b 100644\n--- a/tests/qtest/tpm-tis-i2c-util.c\n+++ b/tests/qtest/tpm-tis-i2c-util.c\n@@ -15,6 +15,7 @@\n #include \"libqtest-single.h\"\n #include \"qtest_aspeed.h\"\n #include \"tpm-tis-i2c-util.h\"\n+#include \"tpm-emu.h\"\n \n uint32_t aspeed_bus_addr;\n \n@@ -62,3 +63,40 @@ void tpm_tis_i2c_writel(QTestState *s, uint8_t locty, uint8_t reg, uint32_t v)\n }\n aspeed_i2c_writel(s, aspeed_bus_addr, I2C_SLAVE_ADDR, reg, v);\n }\n+\n+void tpm_tis_i2c_transfer(QTestState *s,\n+ const unsigned char *req, size_t req_size,\n+ unsigned char *rsp, size_t rsp_size)\n+{\n+ uint32_t sts;\n+ size_t i;\n+\n+ /* request use of locality 0 */\n+ tpm_tis_i2c_writeb(s, 0, TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_REQUEST_USE);\n+\n+ tpm_tis_i2c_writel(s, 0, TPM_I2C_REG_STS, TPM_TIS_STS_COMMAND_READY);\n+\n+ /* transmit command */\n+ for (i = 0; i < req_size; i++) {\n+ tpm_tis_i2c_writeb(s, 0, TPM_I2C_REG_DATA_FIFO, req[i]);\n+ }\n+\n+ /* start processing */\n+ tpm_tis_i2c_writeb(s, 0, TPM_I2C_REG_STS, TPM_TIS_STS_TPM_GO);\n+\n+ uint64_t end_time = g_get_monotonic_time() + 50 * G_TIME_SPAN_SECOND;\n+ do {\n+ sts = tpm_tis_i2c_readl(s, 0, TPM_I2C_REG_STS);\n+ if ((sts & TPM_TIS_STS_DATA_AVAILABLE) != 0) {\n+ break;\n+ }\n+ } while (g_get_monotonic_time() < end_time);\n+\n+ /* read response */\n+ for (i = 0; i < rsp_size; i++) {\n+ rsp[i] = tpm_tis_i2c_readb(s, 0, TPM_I2C_REG_DATA_FIFO);\n+ }\n+ /* relinquish use of locality 0 */\n+ tpm_tis_i2c_writeb(s, 0,\n+ TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_ACTIVE_LOCALITY);\n+}\ndiff --git a/tests/qtest/tpm-tis-i2c-util.h b/tests/qtest/tpm-tis-i2c-util.h\nindex 3289545f61..499bf4964a 100644\n--- a/tests/qtest/tpm-tis-i2c-util.h\n+++ b/tests/qtest/tpm-tis-i2c-util.h\n@@ -27,4 +27,8 @@ uint32_t tpm_tis_i2c_readl(QTestState *s, uint8_t locty, uint8_t reg);\n void tpm_tis_i2c_writeb(QTestState *s, uint8_t locty, uint8_t reg, uint8_t v);\n void tpm_tis_i2c_writel(QTestState *s, uint8_t locty, uint8_t reg, uint32_t v);\n \n+void tpm_tis_i2c_transfer(QTestState *s,\n+ const unsigned char *req, size_t req_size,\n+ unsigned char *rsp, size_t rsp_size);\n+\n #endif /* TESTS_TPM_TIS_I2C_UTIL_H */\n","prefixes":["6/6"]}