{"id":2229520,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229520/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260428113439.9783-1-m32285159@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428113439.9783-1-m32285159@gmail.com>","date":"2026-04-28T11:34:39","name":"[v3] gpio: sim: Replace sprintf() with sysfs_emit()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f0b63fbd7da95f4c6190f406e240c1c48543936d","submitter":{"id":93193,"url":"http://patchwork.ozlabs.org/api/1.1/people/93193/?format=json","name":"Maxwell Doose","email":"m32285159@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260428113439.9783-1-m32285159@gmail.com/mbox/","series":[{"id":501831,"url":"http://patchwork.ozlabs.org/api/1.1/series/501831/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501831","date":"2026-04-28T11:34:39","name":"[v3] gpio: sim: Replace sprintf() with sysfs_emit()","version":3,"mbox":"http://patchwork.ozlabs.org/series/501831/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229520/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229520/checks/","tags":{},"headers":{"Return-Path":"\n <linux-gpio+bounces-35696-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SPL4z6k7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35696-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"SPL4z6k7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.160.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4dpB4wc3z1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 21:42:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 01DEF3053BF7\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 11:35:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B78553F20FB;\n\tTue, 28 Apr 2026 11:34:44 +0000 (UTC)","from mail-oa1-f50.google.com (mail-oa1-f50.google.com\n [209.85.160.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E96863EB7F0\n\tfor <linux-gpio@vger.kernel.org>; Tue, 28 Apr 2026 11:34:42 +0000 (UTC)","by mail-oa1-f50.google.com with SMTP id\n 586e51a60fabf-415b23dd6e5so3956232fac.3\n        for <linux-gpio@vger.kernel.org>;\n Tue, 28 Apr 2026 04:34:42 -0700 (PDT)","from linuxescape.lan (23-88-128-2.fttp.usinternet.com.\n [23.88.128.2])\n        by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-433efb816e4sm1697344fac.1.2026.04.28.04.34.40\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Tue, 28 Apr 2026 04:34:40 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777376084; cv=none;\n b=lvXiL/RBLP/DYZSx19UI67d9X1wSmobIw43KBLBJuQiGZGk3JCyq1RSRjWgrJhuaHpLlA7cOe47Du2gmh0UI/zQQBnsE+sadBC/r0g/vONb+0TYmXrYGQBkuW+Skw8qJNxXgQkAocSCAJfY/70gmbo4VGYhAODAYKdTeP3wGZE0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777376084; c=relaxed/simple;\n\tbh=HfA2jm2PlyzEpeCPUBoKS49ADYLzApf6IHW140CSIEU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=nUPa0XfyOQVTwFPkCm4eupo74w7CcPlD6z/FdcdwG3UxbMGMQdTn5S8F6MADQnw1WRBc95FdxE2Y4pWo2JcIXE3XP6EOgXtz6Y5dWV/1tlXVIUSf1czpgxk+QSXIIvUwmcA2uj47Z8XE5KsirMCT6lkcUD6lErSxVoSf0MSbqLQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=SPL4z6k7; arc=none smtp.client-ip=209.85.160.50","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777376082; x=1777980882;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=snUsLloMWiOv2ToYV4UGwd0LNmqsP/o20Ldn23wlG1A=;\n        b=SPL4z6k7zIqz2UyzrVS9PpObtfB/JHD4xsXt7Sm7/ND7bvi50M4TluEx0EOathnGjx\n         2trvdBw/mUJdyShaAxZO1wBdlJIkmkxq7mX4fpnKTf6dlg7fUOxE9sWZN6Y2l+iKf0i0\n         NBa5HjBx9DFzMN6M5OVOdxxv7+SMkHhXOL4AKB7p5+2cCBFaTBYImmOWwzMqPTitCO9W\n         PxjrlKUPDIrLbHMSZzOBYryX3GGW44qJk4mCdAiZ2ztqEPlF7XlEt9bbekS1p3RJF+de\n         Q91wZz6rTgsmngrJS3rflTXC1zvip8ZEjRy415u8N912Ir3+ZThit0jhe1aqg3h41Cfx\n         IOjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777376082; x=1777980882;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=snUsLloMWiOv2ToYV4UGwd0LNmqsP/o20Ldn23wlG1A=;\n        b=iExaR+KDW6u2Odp66JZnCYi8GeWNsad31zaxQ0n6EGN071aHAwaENneZaxZSlB9Pbk\n         0k7VYEoKSxNROHGq38vSCd2HZk1yDFBV/opUJlNkr/ie8mYMSEnwnJz0FyUsVWfbozXc\n         /R+AOUTS0YFMWk75+8ycHGvJWjGuBbLJAsBDVr3C10OYHHq3moxceQdTjHqhdJr3uy+i\n         aGcJQM7q4qC+AyGWwmjfeO1QWGGBSZ+fCLLYV+uRn/f43JyKUPHuzPbzpUm9suzyeeJ0\n         r2AHjOE64JNN+hPwdJrRzfEFS9CxFWpX/jPlfmxa1KMIyJ0VYzSEBVjirFVWLy/aGJrs\n         OZEA==","X-Gm-Message-State":"AOJu0YzpCOVxJlvbw4qZ165YKeQesGjp6sggX5BbE8pb4SqAtsp3kuPC\n\tesZXxnGZPVd/gFKp2z+P8PyRtxWOijkq5HQZqcgfA/OlOSpbUNJhshwgiMtbxA==","X-Gm-Gg":"AeBDieuxh6DG31RaUzcLXk956VtChzhVNMp2rK9sEd6+ZxE6iy+YLIRQE572Sgc11ZP\n\tW+LIaTDnwL6fK1F+b4WOXDDaVaEMdd7WQ0IIIstBnU/FjwJOQWVMTsOazD2gG3QyHOz0RXNtvUm\n\t/tqV3KLcwcZCUE0xlanW5oII/bQ67WDQ55tCoezU7Mhf1vlkeMcAvXzzAxlNPdUBl/aOS0YzeoT\n\tBoAAFI87uuXlH4VUbRSu6/nIl+ws/CGTskS7sxsbWA5VqmNtCO3Z8mcNzrUtcsDdJCzIrsX9YZY\n\tTyhrxk/r0n23E0whpvB9wprN79JWD5vJ+tPivYZrtiV6LHROLKnMQCgzcdscZm/R4QG9sfSeviL\n\tW0z3qIQ2ovKylJZmdHuyu3UaINnKPdJsxLEQ7Q0XpJaAgo1rqdZ8hNHEZzRNV6MgpA0PB5rqWyZ\n\tbF9dXsjs0LeJV+GpEpRwUqJ71pRoKgrtyjKbLC1+YdNf2+CdQ9zA2Ln9ybeFFKUTAsa9T/","X-Received":"by 2002:a05:6871:551:b0:41c:fdd7:5b4d with SMTP id\n 586e51a60fabf-433f3a85dddmr1188578fac.19.1777376081661;\n        Tue, 28 Apr 2026 04:34:41 -0700 (PDT)","From":"Maxwell Doose <m32285159@gmail.com>","To":"linusw@kernel.org,\n\tbrgl@kernel.org","Cc":"linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v3] gpio: sim: Replace sprintf() with sysfs_emit()","Date":"Tue, 28 Apr 2026 06:34:39 -0500","Message-ID":"<20260428113439.9783-1-m32285159@gmail.com>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Replace sprintf() function calls with sysfs_emit() in the configfs show\ncallbacks. This will help harden the driver and will bring the driver\nup-to-date with more modern functions.\n\nSuggested-by: Bartosz Golaszewski <brgl@kernel.org>\nSigned-off-by: Maxwell Doose <m32285159@gmail.com>\n---\n v2:\n - Rebase commit onto tag 7.1-rc1.\n - No functional changes from v1.\n v3:\n - Add missing sysfs_emit(), caught by Bartosz Golaszewski.\n\n drivers/gpio/gpio-sim.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)","diff":"diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c\nindex e19701c2ed67..b1f31861f40d 100644\n--- a/drivers/gpio/gpio-sim.c\n+++ b/drivers/gpio/gpio-sim.c\n@@ -695,9 +695,9 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,\n \n \tpdev = dev->pdev;\n \tif (pdev)\n-\t\treturn sprintf(page, \"%s\\n\", dev_name(&pdev->dev));\n+\t\treturn sysfs_emit(page, \"%s\\n\", dev_name(&pdev->dev));\n \n-\treturn sprintf(page, \"gpio-sim.%d\\n\", dev->id);\n+\treturn sysfs_emit(page, \"gpio-sim.%d\\n\", dev->id);\n }\n \n CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name);\n@@ -711,7 +711,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page)\n \tscoped_guard(mutex, &dev->lock)\n \t\tlive = gpio_sim_device_is_live(dev);\n \n-\treturn sprintf(page, \"%c\\n\", live ? '1' : '0');\n+\treturn sysfs_emit(page, \"%c\\n\", live ? '1' : '0');\n }\n \n static unsigned int gpio_sim_get_line_names_size(struct gpio_sim_bank *bank)\n@@ -1056,7 +1056,7 @@ static int gpio_sim_emit_chip_name(struct device *dev, void *data)\n \t\treturn 0;\n \n \tif (device_match_fwnode(dev, ctx->swnode))\n-\t\treturn sprintf(ctx->page, \"%s\\n\", dev_name(dev));\n+\t\treturn sysfs_emit(ctx->page, \"%s\\n\", dev_name(dev));\n \n \treturn 0;\n }\n@@ -1074,7 +1074,7 @@ static ssize_t gpio_sim_bank_config_chip_name_show(struct config_item *item,\n \t\treturn device_for_each_child(&dev->pdev->dev, &ctx,\n \t\t\t\t\t     gpio_sim_emit_chip_name);\n \n-\treturn sprintf(page, \"none\\n\");\n+\treturn sysfs_emit(page, \"none\\n\");\n }\n \n CONFIGFS_ATTR_RO(gpio_sim_bank_config_, chip_name);\n@@ -1087,7 +1087,7 @@ gpio_sim_bank_config_label_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", bank->label ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", bank->label ?: \"\");\n }\n \n static ssize_t gpio_sim_bank_config_label_store(struct config_item *item,\n@@ -1122,7 +1122,7 @@ gpio_sim_bank_config_num_lines_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%u\\n\", bank->num_lines);\n+\treturn sysfs_emit(page, \"%u\\n\", bank->num_lines);\n }\n \n static ssize_t\n@@ -1168,7 +1168,7 @@ gpio_sim_line_config_name_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", line->name ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", line->name ?: \"\");\n }\n \n static ssize_t gpio_sim_line_config_name_store(struct config_item *item,\n@@ -1203,7 +1203,7 @@ gpio_sim_line_config_valid_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%c\\n\", line->valid ? '1' : '0');\n+\treturn sysfs_emit(page, \"%c\\n\", line->valid ? '1' : '0');\n }\n \n static ssize_t gpio_sim_line_config_valid_store(struct config_item *item,\n@@ -1241,7 +1241,7 @@ static ssize_t gpio_sim_hog_config_name_show(struct config_item *item,\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", hog->name ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", hog->name ?: \"\");\n }\n \n static ssize_t gpio_sim_hog_config_name_store(struct config_item *item,\n@@ -1295,7 +1295,7 @@ static ssize_t gpio_sim_hog_config_direction_show(struct config_item *item,\n \t\treturn -EINVAL;\n \t}\n \n-\treturn sprintf(page, \"%s\\n\", repr);\n+\treturn sysfs_emit(page, \"%s\\n\", repr);\n }\n \n static ssize_t\n@@ -1335,7 +1335,7 @@ static ssize_t gpio_sim_hog_config_active_low_show(struct config_item *item,\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%c\\n\", hog->active_low ? '1' : '0');\n+\treturn sysfs_emit(page, \"%c\\n\", hog->active_low ? '1' : '0');\n }\n \n static ssize_t\n","prefixes":["v3"]}