{"id":2229506,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229506/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260428102052.53637-1-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260428102052.53637-1-pablo@netfilter.org>","date":"2026-04-28T10:20:52","name":"[net] neighbour: neigh_xmit needs to release skb on -EAFNOSUPPORT","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"a216a709e1e1265c282087c187ed43011a2e678d","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260428102052.53637-1-pablo@netfilter.org/mbox/","series":[{"id":501821,"url":"http://patchwork.ozlabs.org/api/1.1/series/501821/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501821","date":"2026-04-28T10:20:52","name":"[net] neighbour: neigh_xmit needs to release skb on -EAFNOSUPPORT","version":1,"mbox":"http://patchwork.ozlabs.org/series/501821/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229506/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229506/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=rrvyHmeM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12248-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"rrvyHmeM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4cG86BSzz1yHX\n\tfor ; Tue, 28 Apr 2026 20:33:04 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D61A6300F28D\n\tfor ; Tue, 28 Apr 2026 10:21:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0542C3E6392;\n\tTue, 28 Apr 2026 10:21:03 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 600293DA5BD;\n\tTue, 28 Apr 2026 10:21:00 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id E41FC60180;\n\tTue, 28 Apr 2026 12:20:58 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777371662; cv=none;\n b=q6aXABmFZ6W18xSTnRSS0UetcoUkhuV8aPJTPAnYxB7ajhJiz8bOdSP8IoX4AM7aZ6JdIj0pktHKgNQMwA4jz21eQfoi2cib0ls5FwAncvHfEv+ENqz3dUMn7HrPnKzOri3Cpl+Kk8o5+k6YXejRx4r96IUoh0T1y8LxfIcr4Yw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777371662; c=relaxed/simple;\n\tbh=EJdmfCjiMU1AlDmWQswL59SE9LDp3E5uZUB+a60eTP8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=hAYm3pYeSUOXOKl5vVyIpvYDpQRNHR/9GOK8oisc+NATHGL73cO5dnTyr5gR6db2mYrUCbiLCZZvIj2T/HAuGvZ6mOD4+1ii8yXoLTz4i6ENxvADz0/VFQdzuI1dRjQ27mh3e0Yxjrt4QxCZ5UZMUtleciUmpsxa9y4cCKD7uYI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=rrvyHmeM; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1777371659;\n\tbh=Dd1whcvuSm/GI09QOtK5dQFfyV7EZd2UMIuTg6xDe0E=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=rrvyHmeM8d2oXeu+1g5QYb6mPAaglguf81Tiktkwbgx+yQkJvhna2HyfTFPgDFfeV\n\t AFm+f/NBbnQ0RZpAk/09Jx2B71U6o+zsWj6iHwzxi5XM9UGUqf9g0PwZZJpKexh12K\n\t EWj18DS2wlX95ZHRsUh4DiLdBaN7pSPIlrH8HFEfDmhIJnmo6SBfEM4Iij52rs77qR\n\t RG7sMU0lDUlt3e9BaJ3t0oryqtMvHcVFu2l0r1zztLvAt6WDvdm3PVs6xIc8/c2POI\n\t at2YnyFP9M/bfIby5aFIpEs/zHM2GL2EeZ3Lp3EdT0pIoDeNamaTVgng1zBDXzqF8h\n\t vxiIG2VDUOK7Q==","From":"Pablo Neira Ayuso ","To":"netdev@vger.kernel.org","Cc":"netfilter-devel@vger.kernel.org,\n\tedumazet@google.com,\n\tdavem@davemloft.net,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\thorms@kernel.org","Subject":"[PATCH net] neighbour: neigh_xmit needs to release skb on\n -EAFNOSUPPORT","Date":"Tue, 28 Apr 2026 12:20:52 +0200","Message-ID":"<20260428102052.53637-1-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Sashiko reports:\n\n\"... if the target neighbor table is NULL (for example, for\nNEIGH_ND_TABLE when IPv6 is disabled), the code takes the out_unlock\npath and bypasses the out_kfree_skb cleanup\"\n\nFix this skb memleak by releasing the skb in case of -EAFNOSUPPORT.\n\nFixes: f8f2eb9de69a (\"neighbour: add RCU protection to neigh_tables[]\")\nSigned-off-by: Pablo Neira Ayuso \n---\n net/core/neighbour.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/net/core/neighbour.c b/net/core/neighbour.c\nindex 9e12524b67fa..2191668b79e3 100644\n--- a/net/core/neighbour.c\n+++ b/net/core/neighbour.c\n@@ -3210,8 +3210,10 @@ int neigh_xmit(int index, struct net_device *dev,\n \n \t\trcu_read_lock();\n \t\ttbl = rcu_dereference(neigh_tables[index]);\n-\t\tif (!tbl)\n-\t\t\tgoto out_unlock;\n+\t\tif (!tbl) {\n+\t\t\trcu_read_unlock();\n+\t\t\tgoto out_kfree_skb;\n+\t\t}\n \t\tif (index == NEIGH_ARP_TABLE) {\n \t\t\tu32 key = *((u32 *)addr);\n \n@@ -3227,7 +3229,6 @@ int neigh_xmit(int index, struct net_device *dev,\n \t\t\tgoto out_kfree_skb;\n \t\t}\n \t\terr = READ_ONCE(neigh->output)(neigh, skb);\n-out_unlock:\n \t\trcu_read_unlock();\n \t}\n \telse if (index == NEIGH_LINK_TABLE) {\n","prefixes":["net"]}