{"id":2229461,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229461/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-2-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428093339.2087081-2-peter.maydell@linaro.org>","date":"2026-04-28T09:33:36","name":"[1/4] hw/riscv: iommu-trap: remove .impl.unaligned = true","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc793724a7ce82e4aaf3b3017dfac2cd5c8e38f8","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-2-peter.maydell@linaro.org/mbox/","series":[{"id":501806,"url":"http://patchwork.ozlabs.org/api/1.1/series/501806/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501806","date":"2026-04-28T09:33:37","name":"MemoryRegionOps .impl cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/501806/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229461/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229461/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=aeDDAU6S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Zyt0lfYz1yJQ\n\tfor ; Tue, 28 Apr 2026 19:34:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHepA-0003OD-Jg; Tue, 28 Apr 2026 05:33:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHep8-0003MB-NC\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:46 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHep6-0007QK-Vb\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:46 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-4896c22fcbaso83459735e9.0\n for ; Tue, 28 Apr 2026 02:33:44 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a774d7a1fsm19665595e9.4.2026.04.28.02.33.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 02:33:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777368823; x=1777973623; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2cvYLVcnk1qS3FA5lQP8W94koZO4vK3ygKeMeP+mRXU=;\n b=aeDDAU6SBs+NtD1I1J1pLZa0oKuSE4dJ/CGwLIpUWSNQhsPiGZb7l4hKGvvrCAgFr1\n HFGk0elPnj0+MTJ+8VJ7sTjlyBK1XI5btiNOjPQjNS//PKAR7kB42gTKNjmtxKzvY8iK\n DlbTqFr04jsDO4YJW6RI9KT8QNq/QMM+OPQ5FFXSxR8lf11b7n766ltbV0UdlN2LKtwN\n RZJZ+Iso8BSwER/Dsn/eqeunOPgNOWcrnrxKw9tV7EkPrVJ0Lt/x9cyQ6L33c8HH/BtS\n sdXw7w29JaYzrBNjmHxl3l0QUabpqEr6rJhLLR3wjQnAhNg+MipCEX0omptU6kad0e73\n 9Omg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777368823; x=1777973623;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=2cvYLVcnk1qS3FA5lQP8W94koZO4vK3ygKeMeP+mRXU=;\n b=DbuNheGwvBM6QsfrRGPtwBm3lR2s//dbI35HxMC0EKkXkA6E+hQyHrZuRUu/3itm9W\n Pl2PhUuFgPtnPJ+CeZfSX5nHvLcnR/2UiK3TI3Vd4EzN602JsnFzvEJJ8AnEsfdiTajh\n UJGsOXjWO2F+OzUQAousowzL18V9wuA9Krr1jFJBnjrfU6XtskAyk2ih63NAbjDNSm2R\n 4RHYcBUrvaAZIJpBWJtAnX9jfwUVJs3iaWp9mTG6RBdyj9MClKfmhZfz6Xg2inFfxoA+\n 15igL1q/zFihkrWxOzG6++Brcw5BsXv/MqmlqmND34u3mND3bvLI8bWQ6ePXc6DR2bNA\n 8hig==","X-Gm-Message-State":"AOJu0YztW9D5SXtSlnkGYIEF6n+bh1KM2WhJV7JwRF5Ay+dFTIMq5yU7\n 4RHqiOKl/iLiQqoGhTxF/n8Bikhqcl5AZBYHO+kk7Iyzp3JrzW4knWvJDNOHrrUgSlaGLWl6mHr\n tGuyp","X-Gm-Gg":"AeBDieurofJXdCllGOEOTTHLWYQI3+Fo62eEo/lRLOhwo0sgDIFjL20tvwmDSydQi8o\n mEJI4OL2yygzYuNI01tPX60Y4UV6YDdcqM2J6ivdt/qFmEi2AF/NmwKQILEf7Y7aplyFOZYEaMz\n 1BWoDJn//cDuhe+dOrj8mxC5ju/iVkrFSw30FoacStV+Mr/jMCj94035S5Vu9hnSMfB+slU7sfO\n QNpH31F7Fjg+5Q7zrNWUsPGorhyFyLcG5uvu8DqzYF3DwF6aajQo4Qm9lvVu+BX13bvbrEaRlHh\n XGura112IfHUVOVeY0R+b3MOUscIck3WD0G3ypV0LsV2B4ypxIuGbNPhc7sL45YSM2rRtKdnAfO\n jdWkK5Mg+FAWnA3GDMt+eDFBMLnKZi3myj/iy2AV0zG36GfmzvqPgtZW4awNPtNxnICgtFRrYlz\n GDf8KLriW1hoqS8Z0WS0lH55z9iQChkPjOqy8C6c14WbB8fgVKgQNg9HyggsuE/HF78vm2Xu8AB\n Vfsqi0MvZE/M3fyiA4euM3Ua2hgUuIkqtM8mZ968A==","X-Received":"by 2002:a05:600c:3386:b0:488:a977:8de with SMTP id\n 5b1f17b1804b1-48a77e64f29mr18307465e9.16.1777368823314;\n Tue, 28 Apr 2026 02:33:43 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Tyrone Ting ,\n Hao Wu , Max Filippov ,\n Paolo Bonzini , Peter Xu ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-riscv@nongnu.org, qemu-arm@nongnu.org","Subject":"[PATCH 1/4] hw/riscv: iommu-trap: remove .impl.unaligned = true","Date":"Tue, 28 Apr 2026 10:33:36 +0100","Message-ID":"<20260428093339.2087081-2-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260428093339.2087081-1-peter.maydell@linaro.org>","References":"<20260428093339.2087081-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: CJ Chen \n\nThe riscv_iommu_trap_ops MemoryRegionOps specifies that\nunaligned accesses are not valid for this device but that\nit does implement them. This doesn't make much sense, and\nwe want to add an assertion that registered MRs don't specify\nthis invalid combination of settings.\n\nDrop .impl.unaligned = true, with no behaviour change.\n\nSigned-off-by: CJ Chen \nAcked-by: Tomoyuki Hirose \nReported-by: Tomoyuki Hirose \nReviewed-by: Daniel Henrique Barboza \n[PMM: reworded commit message]\nReviewed-by: Peter Maydell \nSigned-off-by: Peter Maydell \n---\n hw/riscv/riscv-iommu.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c\nindex c3c9ed6469..f0de264a10 100644\n--- a/hw/riscv/riscv-iommu.c\n+++ b/hw/riscv/riscv-iommu.c\n@@ -2433,7 +2433,6 @@ static const MemoryRegionOps riscv_iommu_trap_ops = {\n .impl = {\n .min_access_size = 4,\n .max_access_size = 8,\n- .unaligned = true,\n },\n .valid = {\n .min_access_size = 4,\n","prefixes":["1/4"]}