{"id":2229434,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229434/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260428085312.1808358-1-ye.li@nxp.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260428085312.1808358-1-ye.li@nxp.com>","date":"2026-04-28T08:53:12","name":"i2c: imx_lpi2c: Fix MSR status check issue in STOP","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8120079266cdfd23ffe21fdc7bc595e9e0970c33","submitter":{"id":68036,"url":"http://patchwork.ozlabs.org/api/1.1/people/68036/?format=json","name":"Ye Li","email":"ye.li@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260428085312.1808358-1-ye.li@nxp.com/mbox/","series":[{"id":501798,"url":"http://patchwork.ozlabs.org/api/1.1/series/501798/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501798","date":"2026-04-28T08:53:12","name":"i2c: imx_lpi2c: Fix MSR status check issue in STOP","version":1,"mbox":"http://patchwork.ozlabs.org/series/501798/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229434/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229434/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=DklHkO8B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=nxp.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.b=\"DklHkO8B\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=nxp.com","phobos.denx.de; spf=pass smtp.mailfrom=ye.li@nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Z0d1yPqz1yHv\n\tfor ; Tue, 28 Apr 2026 18:51:13 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 90E63845D8;\n\tTue, 28 Apr 2026 10:51:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 58BF08460B; Tue, 28 Apr 2026 10:51:10 +0200 (CEST)","from AM0PR83CU005.outbound.protection.outlook.com\n (mail-westeuropeazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 672FA8432A\n for ; Tue, 28 Apr 2026 10:51:08 +0200 (CEST)","from AM0PR04MB12051.eurprd04.prod.outlook.com\n (2603:10a6:20b:743::24) by VI0PR04MB11048.eurprd04.prod.outlook.com\n (2603:10a6:800:25d::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr\n 2026 08:51:06 +0000","from AM0PR04MB12051.eurprd04.prod.outlook.com\n ([fe80::5839:856:e138:4029]) by AM0PR04MB12051.eurprd04.prod.outlook.com\n ([fe80::5839:856:e138:4029%6]) with mapi id 15.20.9846.025; Tue, 28 Apr 2026\n 08:51:06 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=cSGeevsjjQniA8/pKIGAfD5UU6lGSv9KpytM/04XMadBiqlKLZIyYEjuwXEkDhBbMcDi5CsKVRaClv6fwqS0Gy8h+1Ap1YT2+NiX7eqx+2vxsXwm8J0yn1kBii1TGosGI9gS67sn3XDUDu+A72XjbkVNrL1DSneq5kGBUc9zjB9KtQ6EArNMZ6MZQTrytYjP4MFGYh0BcfRIGmRuu6PyIVleadmbg51jl2kOhVZoB0MRimDnlcjMM0zBng8Tsf08m/nA3ILov0D4x2mleQAqY3eNmXjMPBjkbf5Ehe/SUtyBqnHOm/ff58re2bWx29sSh7Ogp2ezEPoLLWZWyVB1Rg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AKm3cR9HfQjPO4YpAHiE5mJzd2ZhxzP9ChUmZIJfUEU=;\n b=ZUuRAGqrkrJp6NAk7FKmt5TFx5zP0WTccoJnftgsW4qoHsaTYSDQcz8xSLNikIhkstF1Plkxz6uadclsHBhoDEsysgzCXzSb+tbbe91zRWJVC/Sij7p7ehyNDDQIQvRmJT4ihwPk/trz0icr0zN/cCUxCcj1CxMQjTY9v0K9Rrezoshgw/xWdtEckPSwTn2ulEeynZcUAuSKF30DlajLkrU41s3YXlqKYde8Ri3URpWV9aOdbtKESi6PMpoIhuwE4f0A2Qbp1FOGavHtzFBGdy6SN1Yr+9/Gm4axRRi1jVZh+AKekUJJyzydMSZHyK4tTTDYPI1sqj6p4vnm0eSnxg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AKm3cR9HfQjPO4YpAHiE5mJzd2ZhxzP9ChUmZIJfUEU=;\n b=DklHkO8BCWf6Gp2TM1kQMmmOaNLo8/U92hEfCBmonE3BqntldCux2kAdGW8CM+pyPFcDMeUE43eMqxIPvoC8yQLWSnjhuUvNiV89D7IW05BzcyjEOuQ37WQvMGxS+rMfN9MHkZRtAHHRh+6SI6fUwGnGzxcelRwiDbU62G55SQ1IlHO3AzIHEncIrOWGY9ylLNN0fUO2X28ydxzpQ2L6/ndsabJum6xCYPaEALVvJAPbdon8BBSmEAxVn8aHPejagdZqYdkRdjFTypC+4YotHeZa96UOWY+H51xPhjpf70ZbIbmooBrB3/Q/fyVIKaD0c6vMAmYDZbyeD/ML28dZEw==","From":"Ye Li ","To":"hs@nabladev.com, festevam@gmail.com, u-boot@lists.denx.de,\n peng.fan@nxp.com","Cc":"uboot-imx@nxp.com","Subject":"[PATCH] i2c: imx_lpi2c: Fix MSR status check issue in STOP","Date":"Tue, 28 Apr 2026 16:53:12 +0800","Message-Id":"<20260428085312.1808358-1-ye.li@nxp.com>","X-Mailer":"git-send-email 2.37.1","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"MA5PR01CA0220.INDPRD01.PROD.OUTLOOK.COM\n (2603:1096:a01:1f3::16) To AM0PR04MB12051.eurprd04.prod.outlook.com\n (2603:10a6:20b:743::24)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM0PR04MB12051:EE_|VI0PR04MB11048:EE_","X-MS-Office365-Filtering-Correlation-Id":"ddf20f8b-06fa-4daf-1184-08dea50348eb","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|42112799006|19092799006|376014|52116014|56012099003|18002099003|38350700014;","X-Microsoft-Antispam-Message-Info":"\n ClV07P+VHhrNlLTAhjFYoTGdGN9lF9OOm2+NRpHXUXoOCxWZQ3JwE3vLn3TUJHKvZFLPKhqcTrPKCSjG8va3OHc7OrZ3LTq57oknVnuhGBYrl2fd191fYGrT1sQXLdha8tJJgo3eh1bcOTJ2qYJnhjsFJ2cl4BAjCa8DXv6hlQCw77HeBw9RUzakBOv8YdhzMvLIcKoEqG789dJognlVfvi1obc1zb1GQxuTiCxPLvwMcvm1He+dz/DmZ2aXoiRwuc5or4rOMsp9dykqXARKdhOVh4euagAXt9shZCuK7mwMVuLcBs/AlZ7Di2EY9/jWk5HZH42Cwk2DPxTfeufJprJGMzYV3nni5lAcxEkP81IfDXXXNTQlC/e2nKD0SVyYHUY4GsZvWgvHY5QDowZ+97U61pxj5BLYErpyzyKx9J7CGSjk9o0Ckvh218ruXxr7Qu1t3cETFeOuevs2GIKVsvjbAYhqGnO9M8aM+z/6apEmZm2CO984GUILBIKxNHvcvWsBw3RwlTyorl6P4q0stYdGkMPO0fpp4TOafgnKiqUiS/Xps/+FlTXclBVsfS3PMSIFVecE5YNu1MZg3b0Oeda/4in8s+4sldxz7s4ON17+Ui9nIakTHhf3HRjFpWPkCbR3ye/Tzk9nFwmTEe1KZP07kK6RGLgRLisE4Qz3gKbt1C0LZQxaixs1wtOY5wRsEm76l3QYi2amhDLf4jkeTNNnZr39/hSULhePtH7nEWKdxl2vGXcCoogspCiTDHz1c8N1E9Usg/ChtblmrEp3wCnV0pg1cGZSyL40Wo+jjOw=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB12051.eurprd04.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(42112799006)(19092799006)(376014)(52116014)(56012099003)(18002099003)(38350700014);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n 2j1XXQphD94QZSwwBu9NtPHzqleUBYFmpJtowR8Mlwz4Bq4tVqzcoRzA6ZBrb/fvE/Ay0isOAJa2Qol2oo0+ivIDZb/v0oTb0BEuKuZ/bY6CW6dmtH05GByMZImyUMtYxbAzpZshKBz+bxBtm+TFzfD4rFcEgJYbZSZQuPHD+ME7KLcj4a96pJyPqTAiHWYodZ1FetnEXfxZKNl1pi8cB97AEcHuIZhFMNuoljw4qeC81meaO5SHlajb76nlGc5S20b1tYeNwXNtzVvE76gH3SjDswV+eCBHT04TODIFjHvc+WX2OA2l9SggmoLerIGL5rbFVwmwzKByk6Oyee6YQK02pFK10dYiIhfQT64c8KAEwh2TznndZiu+RhTGwSB7UsnJskRD4sYgRTgyya/s/7tZvzNE9jXbp3RA26L68hBMMRig4vRC+05NJlDCXigjNfJooybS5HG3+0TBZaaswS847CG/18qjVOyUChDUldTRtmAYS/LYPeb6PNIg/QjHDGKr1sJyPSYpMHaf+sG9tfqiwOGTBwsdFpNY4HxhcLGOuEREHYNcvHqvEP/xC74/QWKRKHyNL8RUg80jst9LUIBU/dCPZ4kkkXWOJuKXugCWrN+K8Nvsr8GKIHTKbtxIHos5frbxs+4AfF5vOX+EGW0c3lOqko1PhuUXNZqvv9lIUdC/Xqmq0qw9eL7IrniU2Jh6rS5+2Cr3bxwxNn4OH+IGfnvMaAu4+MTm/vkuG1b394elDD6jVDDqL66WwBtS7BFhZIbB5/2+BJ8MbUL3mhFMw7wAD8WPG6QKKSu3w/mKp8Yv0ododJ28wmx947JHmsIjk2pHhuvi9JbPAdAoH/8hFGe6ztMARgVM1zIDtGgJj5lP1g0Azg4VueYWwyfNg8zARKAczGZlRnFN5ZBt4E2cuNUA0IAclVfq4rP0csilYYiO1Me8JpVNQAaYz4rivuaub6WLbaZWHka4t6phqULoeaj8ehl73vY+TxqBqR6R4lwYQYXVvfAUuqd3XNiKdxBi6GugZvkek5c8+jlin06HhdGJR8tZcml0fA2Pm/c+SuOVjXpXybyHNQCEszX03nbC0YkNOinfFveuHVKg8VTexMRscGdy0ptm+63lJsiiill+E8zTtKRZrqp+9GY7Ti0fP1JNoF28pTYUjnxWudUVkE3lmejbMw3fIAVW/6XXnh+Z0jIi5HIgyBlVoJ3BTabY4EoWqnWyu8aNyOxI4L9FbpypSVNm5fotx+J9iM2K8aiwPLSFx2f2kMcaHouEpL5wiNQuFnQtvxLqqjPg3I2kGViglOp4H1ioeQijLaMgTVYfAuch6HVzwqPN9qR5koBnaOe5QjDUDLvRjVzR2CuBX7YBvCOPMpqxDroVQyFl1RU3lWnmHS9Qlr1p88nhKdyC+h9N0UhE7nr3op1MEs23kkn4JBwZbBi3XxypZ88xPOsyUrSuY0jfHMsYcgZ0Z0xZTN8g0FrU1pyHuawyeibPbhjshyhx9Kehhiz502VF9phKZF1q40NAyjXMzXhzNjZhc6DEZVkwY72KAziJ3ZCfdlkjFeUavl3/bEwGtJJ1IrUB7feDxZY4ADpZltWf0Fv1g23City5LBUqB7y8Vwfgvr87yt2SNEL8l6sNpJO+iZAtB24Ljg7cePxsH9JM6EEuZ4YZQczYddvpYgmL+9V6lBlVKAjzX30do7MCeZIV3soy0Sl+qBguk+UdQzEp","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n ddf20f8b-06fa-4daf-1184-08dea50348eb","X-MS-Exchange-CrossTenant-AuthSource":"AM0PR04MB12051.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"28 Apr 2026 08:51:06.1733 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n EOZ686lhc71DmYn3qunPA2l+rQ2djUKR5i2Y/FVaaPoPoOklrJj8y7ikss8gSaS+","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI0PR04MB11048","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"In bus_i2c_stop, the MSR SDF is checked in a loop after stop command\nis sent. Meanwhile, some error status in MSR is also checked by\nimx_lpci2c_check_clear_error. But the imx_lpci2c_check_clear_error\nwill clear the MSR.\n\nIt causes problem in below situation:\nIn current loop, SDF does not set, but error status is found by\nimx_lpci2c_check_clear_error (for example, NDF), then NDF will be cleared\nand result has NDF error. However, because SDF does not set in this loop,\nit goes not next loop. When SDF is set in next loop,\nimx_lpci2c_check_clear_error is re-executed, but as the MSR is cleared,\nthe result is 0. Then the stop return 0. But it should return NDF error.\n\nSigned-off-by: Ye Li \n---\n drivers/i2c/imx_lpi2c.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/i2c/imx_lpi2c.c b/drivers/i2c/imx_lpi2c.c\nindex a309fd6f07c..e2b4fd334ec 100644\n--- a/drivers/i2c/imx_lpi2c.c\n+++ b/drivers/i2c/imx_lpi2c.c\n@@ -239,7 +239,6 @@ static int bus_i2c_stop(struct udevice *bus)\n \tstart_time = get_timer(0);\n \twhile (1) {\n \t\tstatus = readl(®s->msr);\n-\t\tresult = imx_lpci2c_check_clear_error(regs);\n \t\t/* stop detect flag */\n \t\tif (status & LPI2C_MSR_SDF_MASK) {\n \t\t\t/* clear stop flag */\n@@ -250,10 +249,13 @@ static int bus_i2c_stop(struct udevice *bus)\n \n \t\tif (get_timer(start_time) > LPI2C_NACK_TOUT_MS) {\n \t\t\tdebug(\"stop timeout\\n\");\n+\t\t\tresult = imx_lpci2c_check_clear_error(regs);\n \t\t\treturn -ETIMEDOUT;\n \t\t}\n \t}\n \n+\tresult = imx_lpci2c_check_clear_error(regs);\n+\n \treturn result;\n }\n \n","prefixes":[]}