{"id":2229427,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229427/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260428083332.768693-14-aalbersh@kernel.org/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.1/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260428083332.768693-14-aalbersh@kernel.org>","date":"2026-04-28T08:33:19","name":"[v9,13/22] xfs: disable direct read path for fs-verity files","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7341b7348870d68f905cfa604e2324bc63991579","submitter":{"id":92821,"url":"http://patchwork.ozlabs.org/api/1.1/people/92821/?format=json","name":"Andrey Albershteyn","email":"aalbersh@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260428083332.768693-14-aalbersh@kernel.org/mbox/","series":[{"id":501796,"url":"http://patchwork.ozlabs.org/api/1.1/series/501796/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=501796","date":"2026-04-28T08:33:09","name":"[v9,01/22] fsverity: report validation errors through fserror to fsnotify","version":9,"mbox":"http://patchwork.ozlabs.org/series/501796/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229427/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229427/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=YMwK2SQ6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=sybg=c3=vger.kernel.org=linux-ext4+bounces-16159-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=YMwK2SQ6;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16159-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"YMwK2SQ6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YvL57RFz1yHX\n\tfor ; Tue, 28 Apr 2026 18:46:38 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g4YvL4gskz4wLj\n\tfor ; Tue, 28 Apr 2026 18:46:38 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g4YvL4bjtz4wLT; Tue, 28 Apr 2026 18:46:38 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g4YvH26WQz4wLj\n\tfor ; Tue, 28 Apr 2026 18:46:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 164A030A8EC1\n\tfor ; Tue, 28 Apr 2026 08:35:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 817523D6CDF;\n\tTue, 28 Apr 2026 08:34:34 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DAD03D4117;\n\tTue, 28 Apr 2026 08:34:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 698DBC2BCB9;\n\tTue, 28 Apr 2026 08:34:31 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1777365998; cv=pass;\n\tb=H0xgkehNPVD7d/p8Zlloya71oWFKFkxoBimEFVbI8SaZsSDXAMrkltygdQwO7MnHtIjZ7IbcSLhZp+L6XSn3Q41u2WNGAYmLmbQS4SWYkTfm4hyubWwPDpCeK95wSV4ftiMQ8lxZB8E6pgUTpwOCacS+jAnQU12GcF2q0Q7VIt9ztc06aNjrxfhKBFRw1UlLFxcRiy7WOlFtNI0UhEeHf8neHG1NNOaddgkCLTUTybwuDGQladOD9Q+AOFJErWpRmdzWHceExSLZlspPBfP9Y4YbDbH7NITxGgA0JWwOD/pbvkoBP+F+V/RuOcYSCHyrP3+tyZHUo/FEj7sYq7O5ww==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777365274; cv=none;\n b=fj7vFdlrIEkGvVl9zwuB2t6M1aP2P0mHHBzQ/DJrm2Dm7fDndNNY9Kzr0RFzP/UhRwwaKjoywhAZp+7iJjw81daAp8rMvk2yBhaR5PGp8tDjsySCjtugiyLpQOpHdCrfSBEPgeGPpZq32Jm5P41hOUrcKGe+cE/NYFsKtQhGowk="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1777365998; c=relaxed/relaxed;\n\tbh=L7lbVMXOwHHcAevnI59LdKxFWewGKSw08vt9Mtg3z1Q=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=A5twITchHrLqFMqyhK9ePMGIemqdbkytXpkmzkdIaH94cA+IDVEUbIP4GjEHcWivaOrER7vt31RgviIc5bvhCGVSMruIEMw3j1S2la8Hf2SpbHa9d3oZlaPpyTlmiy6Hm9CFfoPtcg1A2HLc+XsElJCYmg+bhTBedd2mDOxQovTETae2n1F91qpfkGU8/cxsFhZJ2Z1VraWMQSwEH2aDqmYTkmg3T+eo1djk6JFDWE1cDkPpjTLF4AipHzIjai9dsrCLCUJAbrG10GgxvhtV4JPSSI0UQzysfIne01d0ubzc8s1pjYtuxKikgpcV8Fh8tBCNNCrTaBcK+91W4Ts8/Q==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777365274; c=relaxed/simple;\n\tbh=l2TuE4Dq3W00QnGqh26ac7WtX/eqBCa3lcQ4ZM8TF1E=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=bQz739AF6Cmgjzbk6L0Tu7gzWv7S4iCyCS2bpCH+5xw3dFCionsyDYMgMQfZLeo5Doxm43SqLfqgqomArTkexc37BEM8u8FhdFvBuaykUGCJx3k6daHK8zHpbJuwGAJWN5CGb7LRSbZnFt9GR2dg9YRJY1l3b0p/HELzxIbZCkc="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=YMwK2SQ6; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16159-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=YMwK2SQ6; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777365273;\n\tbh=l2TuE4Dq3W00QnGqh26ac7WtX/eqBCa3lcQ4ZM8TF1E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YMwK2SQ6PuOpeyfRJw58qAZtdcj0ld0MHefAaomuol/byqLyagL8z2OnXDvQ88nAe\n\t VgRYaBrpWNw1GDwBgpJwJbzz5QlIvIOrqAQ/sImd1mHsAgk746ujTCQXHlQjobP+vx\n\t SsOQ0JJbSqzH4c8wvITLmHPprh8vM1hkgcB5xq3xiWP+w0+nW0xBCtrHNAkKWMYzq/\n\t gw5oVMGNE0A0oDI3340xvs7oK+Tm4CFF/nXxbKYLxiXEmxy8W/rd7LUfGxguEiY3Dk\n\t GH5DA2auZZ1xuXTWyzvLOeKNPYCGHxmijpda4QWfmRKPrzcwgD93RSLUFbmq6+zFiP\n\t D7KVqTgTWS6Ug==","From":"Andrey Albershteyn ","To":"linux-xfs@vger.kernel.org,\n\tfsverity@lists.linux.dev,\n\tlinux-fsdevel@vger.kernel.org,\n\tebiggers@kernel.org","Cc":"Andrey Albershteyn ,\n\thch@lst.de,\n\tlinux-ext4@vger.kernel.org,\n\tlinux-f2fs-devel@lists.sourceforge.net,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-unionfs@vger.kernel.org,\n\tdjwong@kernel.org","Subject":"[PATCH v9 13/22] xfs: disable direct read path for fs-verity files","Date":"Tue, 28 Apr 2026 10:33:19 +0200","Message-ID":"<20260428083332.768693-14-aalbersh@kernel.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260428083332.768693-1-aalbersh@kernel.org>","References":"<20260428083332.768693-1-aalbersh@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"The direct path is not supported on verity files. Attempts to use direct\nI/O path on such files should fall back to buffered I/O path.\n\nSigned-off-by: Darrick J. Wong \nReviewed-by: Christoph Hellwig \nSigned-off-by: Andrey Albershteyn \n---\n fs/xfs/xfs_file.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c\nindex a980ac5196a8..6fa9835f9531 100644\n--- a/fs/xfs/xfs_file.c\n+++ b/fs/xfs/xfs_file.c\n@@ -282,7 +282,8 @@ xfs_file_dax_read(\n \tstruct kiocb\t\t*iocb,\n \tstruct iov_iter\t\t*to)\n {\n-\tstruct xfs_inode\t*ip = XFS_I(iocb->ki_filp->f_mapping->host);\n+\tstruct inode\t\t*inode = iocb->ki_filp->f_mapping->host;\n+\tstruct xfs_inode\t*ip = XFS_I(inode);\n \tssize_t\t\t\tret = 0;\n \n \ttrace_xfs_file_dax_read(iocb, to);\n@@ -333,6 +334,14 @@ xfs_file_read_iter(\n \tif (xfs_is_shutdown(mp))\n \t\treturn -EIO;\n \n+\t/*\n+\t * In case fs-verity is enabled, we also fallback to the buffered read\n+\t * from the direct read path. Therefore, IOCB_DIRECT is set and need to\n+\t * be cleared (see generic_file_read_iter())\n+\t */\n+\tif (fsverity_active(inode))\n+\t\tiocb->ki_flags &= ~IOCB_DIRECT;\n+\n \tif (IS_DAX(inode))\n \t\tret = xfs_file_dax_read(iocb, to);\n \telse if (iocb->ki_flags & IOCB_DIRECT)\n","prefixes":["v9","13/22"]}