{"id":2229410,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229410/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428082654.44364-11-larysa.zaremba@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428082654.44364-11-larysa.zaremba@intel.com>","date":"2026-04-28T08:26:44","name":"[iwl-next,v7,10/14] idpf: print a debug message and bail in case of non-event ctlq message","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9a3b96d5bebe5c0dee95eed078f94b0a8949b0b3","submitter":{"id":84900,"url":"http://patchwork.ozlabs.org/api/1.1/people/84900/?format=json","name":"Larysa Zaremba","email":"larysa.zaremba@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428082654.44364-11-larysa.zaremba@intel.com/mbox/","series":[{"id":501793,"url":"http://patchwork.ozlabs.org/api/1.1/series/501793/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501793","date":"2026-04-28T08:26:34","name":"Introduce iXD driver","version":7,"mbox":"http://patchwork.ozlabs.org/series/501793/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229410/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229410/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=1357s7rr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YTK6Y23z1xvV\n\tfor ; Tue, 28 Apr 2026 18:27:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E9FB183709;\n\tTue, 28 Apr 2026 08:27:29 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pPRpyT7qESno; Tue, 28 Apr 2026 08:27:29 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3D86B83716;\n\tTue, 28 Apr 2026 08:27:29 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 555911B8\n for ; Tue, 28 Apr 2026 08:27:27 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 3753240655\n for ; Tue, 28 Apr 2026 08:27:27 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id stxZbIWvqXWm for ;\n Tue, 28 Apr 2026 08:27:26 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 821A740649\n for ; Tue, 28 Apr 2026 08:27:26 +0000 (UTC)","from orviesa006.jf.intel.com ([10.64.159.146])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 01:27:20 -0700","from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa006.jf.intel.com with ESMTP; 28 Apr 2026 01:27:15 -0700","from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id D3F5B27BA8;\n Tue, 28 Apr 2026 09:27:13 +0100 (IST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3D86B83716","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 821A740649"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777364849;\n\tbh=MayREWHHBl8r9r+rMBWqPbPaKJr/wz0J1+A+JKAjdgY=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=1357s7rrx+Z4wIczDjAQFW1W4FX5zxvdrIuA6RuEcfH5X3fpDE/F3XnAZeLEIIw3M\n\t g8urZ1yo4T1+P0iEdU6PBW1kt5kSW99w/Uo0WdnXdIxDHyiRuLmI3XmvfrCy51p3nx\n\t 8CtEQjsm5a0AOD3D0rxLY/fD7wVkP9cbQLyP1M+yN9wuhR+jVkUnLkB6CuiiELdyG2\n\t jFxUziKQ8fh9tnZpLyLJRy0/UuKnnM8at0NuOq+aSBZbHE+VrCgpacPuIN9rrii8jL\n\t 9DsHpnSSFqbvSlUKWVkUeQM/i2Iy+l/lJ50ls9v5FM0sTOHvM3aPQBG3MWsOQ6Igcf\n\t +89exXbQ/l70w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.15;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 821A740649","X-CSE-ConnectionGUID":["r0NN+fIsSOO/3OBlxVDh2g==","RF4MzHqjS/a7a2l6EWMAUA=="],"X-CSE-MsgGUID":["QpcyiVSgSIiEWSDro8nuNQ==","L+y2WcZjSWuinPu0obyytA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"78376962\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"78376962\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"232881579\""],"X-ExtLoop1":"1","From":"Larysa Zaremba ","To":"intel-wired-lan@lists.osuosl.org, Tony Nguyen ","Cc":"aleksander.lobakin@intel.com, sridhar.samudrala@intel.com,\n Michal Swiatkowski ,\n Larysa Zaremba ,\n \"Fijalkowski, Maciej\" ,\n Emil Tantilov ,\n Madhu Chittim , Josh Hay ,\n \"Keller, Jacob E\" ,\n jayaprakash.shanmugam@intel.com, Jiri Pirko ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , Simon Horman ,\n Jonathan Corbet ,\n Richard Cochran ,\n Przemek Kitszel ,\n Andrew Lunn , netdev@vger.kernel.org,\n linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n Aleksandr Loktionov ,\n Samuel Salin ","Date":"Tue, 28 Apr 2026 10:26:44 +0200","Message-ID":"<20260428082654.44364-11-larysa.zaremba@intel.com>","X-Mailer":"git-send-email 2.47.0","In-Reply-To":"<20260428082654.44364-1-larysa.zaremba@intel.com>","References":"<20260428082654.44364-1-larysa.zaremba@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777364846; x=1808900846;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=BMAgwXQrkx/VBAHYwKEPrZ5iHHknFulXIvTL1397V/w=;\n b=BAxidgaJr58N0YxxkxLSa2VPOfW9RVHKEKPZAIzUY7F+lqfoHOSq75yp\n +p+ZrRF2l932DNYQVG+DaMNW0EqPMRhV08l0fcwzbVKC4sT7M9/brigI0\n tQVUnJVJtPZt1O/AccQ6EVcGLjdjo6dpSsjSrm4S+k0dlq5n4xcrscvFj\n lSX9X5NvRbT3UTpOOAI0KaIndo9+m176GQ9qyzxEpDZC5NguIxuxxqk83\n F3qO2kMQNMjUwU/Q8GtyiHRO+S8X+GfGE8KaNxEshmdDga4qNn9gCuW+e\n SFJaVNLwrihf5jgrUsHF9W8J4vfJpmYrJAuOaha39M4u1jo5y4mjeo+D5\n A==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=BAxidgaJ"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v7 10/14] idpf: print a debug\n message and bail in case of non-event ctlq message","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Unlike previous internal idpf ctlq implementation, idpf calls the default\nmessage handler for all received messages that do not have a matching xn\ntransaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error\nmessages printing garbage, because the parsing expected a valid event\nmessage, but got e.g. a delayed response for a timed-out transaction.\n\nThe information about timed-out transactions and otherwise unhandleable\nmessages can still be valuable for developers, so print the information\nwith dynamic debug and exit the function, so the following functions can\nparse valid events in peace.\n\nReviewed-by: Aleksandr Loktionov \nReviewed-by: Michal Kubiak \nSigned-off-by: Larysa Zaremba \nTested-by: Samuel Salin \nSigned-off-by: Tony Nguyen \n---\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex 8936c2a67ce0..7c3dd89b61d6 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx,\n \tu32 event;\n \n \tadapter = container_of(ctx, struct idpf_adapter, ctlq_ctx);\n+\tif (ctlq_msg->chnl_opcode != VIRTCHNL2_OP_EVENT) {\n+\t\tdev_dbg(&adapter->pdev->dev,\n+\t\t\t\"Unhandled message with opcode %u from CP\\n\",\n+\t\t\tctlq_msg->chnl_opcode);\n+\t\tgoto free_rx_buf;\n+\t}\n+\n \tif (payload_size < sizeof(*v2e)) {\n \t\tdev_err_ratelimited(&adapter->pdev->dev, \"Failed to receive valid payload for event msg (op %d len %d)\\n\",\n \t\t\t\t ctlq_msg->chnl_opcode,\n","prefixes":["iwl-next","v7","10/14"]}