{"id":2229409,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229409/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428082654.44364-7-larysa.zaremba@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428082654.44364-7-larysa.zaremba@intel.com>","date":"2026-04-28T08:26:40","name":"[iwl-next,v7,06/14] idpf: remove 'vport_params_reqd' field","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b92f3639d1a0985e611fc0bc9c74bbfd358390a6","submitter":{"id":84900,"url":"http://patchwork.ozlabs.org/api/1.1/people/84900/?format=json","name":"Larysa Zaremba","email":"larysa.zaremba@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428082654.44364-7-larysa.zaremba@intel.com/mbox/","series":[{"id":501793,"url":"http://patchwork.ozlabs.org/api/1.1/series/501793/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501793","date":"2026-04-28T08:26:34","name":"Introduce iXD driver","version":7,"mbox":"http://patchwork.ozlabs.org/series/501793/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229409/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229409/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=RL9XTurw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YTJ2VvSz1xvV\n\tfor ; Tue, 28 Apr 2026 18:27:32 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EC08C411A7;\n\tTue, 28 Apr 2026 08:27:29 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jdF1fITlho5q; Tue, 28 Apr 2026 08:27:28 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C624841199;\n\tTue, 28 Apr 2026 08:27:27 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 6AC6823D\n for ; Tue, 28 Apr 2026 08:27:26 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 29A9A40649\n for ; Tue, 28 Apr 2026 08:27:25 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ToCvLa1--JOG for ;\n Tue, 28 Apr 2026 08:27:24 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 1F94B40654\n for ; Tue, 28 Apr 2026 08:27:24 +0000 (UTC)","from orviesa006.jf.intel.com ([10.64.159.146])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 01:27:14 -0700","from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa006.jf.intel.com with ESMTP; 28 Apr 2026 01:27:08 -0700","from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 2373627BA4;\n Tue, 28 Apr 2026 09:27:06 +0100 (IST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org C624841199","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1F94B40654"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777364847;\n\tbh=SQ58SFtxHbHLSGFkZsCV/kJHtJPLhH4NOr1j6kS2snQ=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=RL9XTurwTQ+BH17yekCemboSdFHvtspyg2f0gilF9JRXLFyIOJZrghQ6CW95qepWg\n\t oAci/hN37oh1Uxi2kbdteW6mX59xAhXI2E3wsfBlLKekxbS6+YaCY7mL1KwWnab18i\n\t dnZNqmUK9eibExsz1T6DOGvQR0pxZBU0KV7SLxmxnLqHvM57rc5AoOZ/RBgUh3buvp\n\t Qmser61UnIRYRAFtbnHMsPovaE8YcCycoDi3EVxOvvn9k7y5uIiK0gkxKswOFkF+WQ\n\t TCkv2qvk2+3mOr/SxHTNcXruDLeIz+8mQqckMafMMj0N/PcTVsST8Xvb2mFuEdYoSs\n\t 5nyeaNjqKXiQA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.15;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 1F94B40654","X-CSE-ConnectionGUID":["hPv/J4phQLKg0uWzk0ePTA==","c45u6mTFTT2u2DkGb0DKEw=="],"X-CSE-MsgGUID":["kqCap6kbS1yegMGdeZriCQ==","VeQUkUZvSEeqADMrrgb2Ng=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"78376917\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"78376917\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"232881540\""],"X-ExtLoop1":"1","From":"Larysa Zaremba ","To":"intel-wired-lan@lists.osuosl.org, Tony Nguyen ","Cc":"aleksander.lobakin@intel.com, sridhar.samudrala@intel.com,\n Michal Swiatkowski ,\n Larysa Zaremba ,\n \"Fijalkowski, Maciej\" ,\n Emil Tantilov ,\n Madhu Chittim , Josh Hay ,\n \"Keller, Jacob E\" ,\n jayaprakash.shanmugam@intel.com, Jiri Pirko ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , Simon Horman ,\n Jonathan Corbet ,\n Richard Cochran ,\n Przemek Kitszel ,\n Andrew Lunn , netdev@vger.kernel.org,\n linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n Samuel Salin ","Date":"Tue, 28 Apr 2026 10:26:40 +0200","Message-ID":"<20260428082654.44364-7-larysa.zaremba@intel.com>","X-Mailer":"git-send-email 2.47.0","In-Reply-To":"<20260428082654.44364-1-larysa.zaremba@intel.com>","References":"<20260428082654.44364-1-larysa.zaremba@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777364844; x=1808900844;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=XW1m6bqvmUfNo+0hIg95OqPPzr6vStEVuTXEgVC2c8o=;\n b=AYAAHZfGi5iKmjTZRob3rNUa6ME390i5vyQFZjJvWJUNO0tdRDvUp9GD\n sb0CB0o8yGjsQQsUNTxqqzfloc/Hzk8T9dhglmPqBfn4tSqdTYUi59P9O\n AT3Kkg7jrwzUt+CsOktl5pbCo8R/nyd6DUZR4cLJzn/lX7Ox/X+bspIop\n DmWaMKK4MrMbtC9/XxmNHLlda31QR6PSFpxGftAaIYlY66nnHmogaFD+N\n cfngiLd7KuquLwdSrKO93ZD8f/vQMpQ7Rki49/UlerxtbNouuvog6t4TG\n eIEYQzoGdaDF5SZ8HbMXOg4h8DqQ5UuUNqan474P/CvwnuklXo2sO308s\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=AYAAHZfG"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v7 06/14] idpf: remove\n 'vport_params_reqd' field","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Pavan Kumar Linga \n\nWhile sending a create vport message to the device control plane, a create\nvport virtchnl message is prepared with all the required info to initialize\nthe vport. This info is stored in the adapter struct but never used\nthereafter. So, remove the said field.\n\nSigned-off-by: Pavan Kumar Linga \nReviewed-by: Maciej Fijalkowski \nReviewed-by: Madhu Chittim \nSigned-off-by: Larysa Zaremba \nTested-by: Samuel Salin \nSigned-off-by: Tony Nguyen \n---\n drivers/net/ethernet/intel/idpf/idpf.h | 2 --\n drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 --\n .../net/ethernet/intel/idpf/idpf_virtchnl.c | 30 +++++++------------\n 3 files changed, 10 insertions(+), 24 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h\nindex 3a3dc9892d16..0d08f51be7e3 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf.h\n+++ b/drivers/net/ethernet/intel/idpf/idpf.h\n@@ -638,7 +638,6 @@ struct idpf_vc_xn_manager;\n * @avail_queues: Device given queue limits\n * @vports: Array to store vports created by the driver\n * @netdevs: Associated Vport netdevs\n- * @vport_params_reqd: Vport params requested\n * @vport_params_recvd: Vport params received\n * @vport_ids: Array of device given vport identifiers\n * @singleq_pt_lkup: Lookup table for singleq RX ptypes\n@@ -697,7 +696,6 @@ struct idpf_adapter {\n \tstruct idpf_avail_queue_info avail_queues;\n \tstruct idpf_vport **vports;\n \tstruct net_device **netdevs;\n-\tstruct virtchnl2_create_vport **vport_params_reqd;\n \tstruct virtchnl2_create_vport **vport_params_recvd;\n \tu32 *vport_ids;\n \ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c\nindex cf966fe6c759..d88ca59edf97 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c\n@@ -1109,8 +1109,6 @@ static void idpf_vport_rel(struct idpf_vport *vport)\n \n \tkfree(adapter->vport_params_recvd[idx]);\n \tadapter->vport_params_recvd[idx] = NULL;\n-\tkfree(adapter->vport_params_reqd[idx]);\n-\tadapter->vport_params_reqd[idx] = NULL;\n \n \tkfree(vport);\n \tadapter->num_alloc_vports--;\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex be66f9b2e101..d4546d62cca9 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -1557,14 +1557,10 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \tssize_t reply_sz;\n \n \tbuf_size = sizeof(struct virtchnl2_create_vport);\n-\tif (!adapter->vport_params_reqd[idx]) {\n-\t\tadapter->vport_params_reqd[idx] = kzalloc(buf_size,\n-\t\t\t\t\t\t\t GFP_KERNEL);\n-\t\tif (!adapter->vport_params_reqd[idx])\n-\t\t\treturn -ENOMEM;\n-\t}\n+\tvport_msg = kzalloc(buf_size, GFP_KERNEL);\n+\tif (!vport_msg)\n+\t\treturn -ENOMEM;\n \n-\tvport_msg = adapter->vport_params_reqd[idx];\n \tvport_msg->vport_type = cpu_to_le16(VIRTCHNL2_VPORT_TYPE_DEFAULT);\n \tvport_msg->vport_index = cpu_to_le16(idx);\n \n@@ -1581,8 +1577,7 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \terr = idpf_vport_calc_total_qs(adapter, idx, vport_msg, max_q);\n \tif (err) {\n \t\tdev_err(&adapter->pdev->dev, \"Enough queues are not available\");\n-\n-\t\treturn err;\n+\t\tgoto rel_buf;\n \t}\n \n \tif (!adapter->vport_params_recvd[idx]) {\n@@ -1590,7 +1585,7 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \t\t\t\t\t\t\t GFP_KERNEL);\n \t\tif (!adapter->vport_params_recvd[idx]) {\n \t\t\terr = -ENOMEM;\n-\t\t\tgoto free_vport_params;\n+\t\t\tgoto rel_buf;\n \t\t}\n \t}\n \n@@ -1606,13 +1601,15 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \t\tgoto free_vport_params;\n \t}\n \n+\tkfree(vport_msg);\n+\n \treturn 0;\n \n free_vport_params:\n \tkfree(adapter->vport_params_recvd[idx]);\n \tadapter->vport_params_recvd[idx] = NULL;\n-\tkfree(adapter->vport_params_reqd[idx]);\n-\tadapter->vport_params_reqd[idx] = NULL;\n+rel_buf:\n+\tkfree(vport_msg);\n \n \treturn err;\n }\n@@ -3418,8 +3415,6 @@ static void idpf_vport_params_buf_rel(struct idpf_adapter *adapter)\n {\n \tkfree(adapter->vport_params_recvd);\n \tadapter->vport_params_recvd = NULL;\n-\tkfree(adapter->vport_params_reqd);\n-\tadapter->vport_params_reqd = NULL;\n \tkfree(adapter->vport_ids);\n \tadapter->vport_ids = NULL;\n }\n@@ -3434,15 +3429,10 @@ static int idpf_vport_params_buf_alloc(struct idpf_adapter *adapter)\n {\n \tu16 num_max_vports = idpf_get_max_vports(adapter);\n \n-\tadapter->vport_params_reqd = kzalloc_objs(*adapter->vport_params_reqd,\n-\t\t\t\t\t\t num_max_vports);\n-\tif (!adapter->vport_params_reqd)\n-\t\treturn -ENOMEM;\n-\n \tadapter->vport_params_recvd = kzalloc_objs(*adapter->vport_params_recvd,\n \t\t\t\t\t\t num_max_vports);\n \tif (!adapter->vport_params_recvd)\n-\t\tgoto err_mem;\n+\t\treturn -ENOMEM;\n \n \tadapter->vport_ids = kcalloc(num_max_vports, sizeof(u32), GFP_KERNEL);\n \tif (!adapter->vport_ids)\n","prefixes":["iwl-next","v7","06/14"]}