{"id":2229399,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229399/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428081733.1615755-1-aaron.ma@canonical.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428081733.1615755-1-aaron.ma@canonical.com>","date":"2026-04-28T08:17:33","name":"[v3] ice: wait for reset completion in ice_resume()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"44d8e77eeb7ac0f1e57ce475615bad619d8d7674","submitter":{"id":72035,"url":"http://patchwork.ozlabs.org/api/1.1/people/72035/?format=json","name":"Aaron Ma","email":"aaron.ma@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428081733.1615755-1-aaron.ma@canonical.com/mbox/","series":[{"id":501791,"url":"http://patchwork.ozlabs.org/api/1.1/series/501791/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501791","date":"2026-04-28T08:17:33","name":"[v3] ice: wait for reset completion in ice_resume()","version":3,"mbox":"http://patchwork.ozlabs.org/series/501791/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229399/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229399/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=vEsZk0qS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YKH0WSdz1yHv\n\tfor ; Tue, 28 Apr 2026 18:20:35 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BE5DD83613;\n\tTue, 28 Apr 2026 08:20:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dhvhtwpoQCWh; Tue, 28 Apr 2026 08:20:31 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 75C71835EF;\n\tTue, 28 Apr 2026 08:20:31 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id B3FAE1B8\n for ; Tue, 28 Apr 2026 08:20:29 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id A5B8B41025\n for ; Tue, 28 Apr 2026 08:20:29 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bbDmwQRHHXaM for ;\n Tue, 28 Apr 2026 08:20:28 +0000 (UTC)","from smtp-relay-internal-1.canonical.com\n (smtp-relay-internal-1.canonical.com [185.125.188.123])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1CCCD4101F\n for ; Tue, 28 Apr 2026 08:20:27 +0000 (UTC)","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id ECC733F601\n for ; Tue, 28 Apr 2026 08:20:24 +0000 (UTC)","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2b24611696eso76260065ad.3\n for ; Tue, 28 Apr 2026 01:20:24 -0700 (PDT)","from localhost.localdomain ([103.155.100.1])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b97aca8328sm17881525ad.77.2026.04.28.01.20.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 01:20:22 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 75C71835EF","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1CCCD4101F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777364431;\n\tbh=FjJThp4I5WkrMZHH23Stv5s45vttZoJtLgvhqAh471A=;\n\th=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=vEsZk0qSVXdX7llKemXYpPebHFAfmLGToX4DYoU4QS86QN6JcdsMgBhmN5xw3NPPz\n\t GDQDE/NxdbIe3kPVc6nkQX8DiBGphZ9axEcotMql0UZCIUloegWO4X3df7b0QY1hKa\n\t 3nGxEWlWCsUwQzVVnY2G51Fr03lHc5enXm+rXb7EG6J1q0ODC3yIDjseMQwNWXaf5v\n\t PpblO7wFb7lDK1cZOYCiQlFJv/GX6oPeXtT9Zo8+FgP38EMKoZBgsGwVxXMwgqKiVV\n\t jz3n/AUJoPMke2W8RseBGGBSmlgQLKAoFgE4bsUeDOh9XH+q0453e2qmKsN4lHoOu3\n\t zgZMGWsP2t4GA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.123;\n helo=smtp-relay-internal-1.canonical.com;\n envelope-from=aaron.ma@canonical.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1CCCD4101F","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777364423; x=1777969223;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FjJThp4I5WkrMZHH23Stv5s45vttZoJtLgvhqAh471A=;\n b=QWvec0JOlntDCEs9uNKUqMzlLTv/AAOvOHXsj73X7HV8GeUyFuvvtceSPuljZSF+7N\n NmPt2SgtKPhNpE0D44P89wCjI71bAKo912sxjkydIUL4mqzIS0GbdsJw9Cny4ttWfDBP\n 64C1ullN5Myry9+HnYZjORYXQHqaFQVi/3q6nMjmqErYrYy3sCOcQSRUCea80yoU3aEf\n 5KGgGOACX4Mlix/mJSMPk7ZGVzz/rIxOS4v15Duf/pl7zB00NIwN2vVtR70pIhfHLy6r\n kZZDJFhumSlC0yJPbbwwnv81CK+5JUH9nM3DnJh2v68TJbmSwnQc2RH/lhD4McY8N6BR\n os1w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9gs8Vi9yhRarOdR+r1SMMaXJZ4W5dq7x16RtuqugKKBER3LS4gF8FVsuHzPmTUUczu5vlm5aD8BCB1zDdjMs4=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YxSZ6ELmUZmLy1rCQt389/qPiQSQ/oJNjsadaeRcDH0f9PjP1Iz\n lG/QkrjsOASXb4wPIu1KShCXxHaKT2AQDo1wc+qzwT1IGedlORLUZpY1fD9vq8MnK57VAzzgHgW\n 0qITq7khhUV8NtZse6e6kZ2NORJfkJF67fGHerAECcgwWbgpk+RL2AH7w/X/jwUdN59U/86GhgT\n 33Njf6yS02Gw8=","X-Gm-Gg":"AeBDievuQOnxqlNL5ObbIa1hvwQaKcULrySJevEKdDu5KQ3/lVasKq70Ufm4HMyUYm3\n LvcXG+3plRujcHDojd95s+apJiN1GZlJaHLDFoeokO2MOrABkK77bLuanQbDk3MkeL3/ugOIXvP\n 3GgeV6gHaQJrFM6+WhJ7gLF3kxgsv2Oa7Ma/KhNjHG7XUl2IEuAm0s4BnBLo8fqbG8BCcZqSNjK\n E48vvZpeBjh51D1PEmBUBJYwb6UmFAt65A6HZEXtFfEuy1HPod8UBSOU5tTLUb+53rounQ/Fw/2\n xy7fYD2LYWvspPZXqUHAP3GyvPs3q+W9MJNDzvfQuG+tWfPEYgiYv+/qptYPTRfJmIWfKjatNSm\n lMMCaXR/zzblJOEU4JODZZ9epDTT8eZk0QPkZFibc4wO/7OxIygWjXEF/CrQHkAHrL3n0MOCHjq\n cKEjEBZXHkZW53Cz3159KyxwshyBUJ","X-Received":["by 2002:a17:902:b689:b0:2ae:450c:951e with SMTP id\n d9443c01a7336-2b97c435bc1mr13505375ad.17.1777364423377;\n Tue, 28 Apr 2026 01:20:23 -0700 (PDT)","by 2002:a17:902:b689:b0:2ae:450c:951e with SMTP id\n d9443c01a7336-2b97c435bc1mr13504915ad.17.1777364422830;\n Tue, 28 Apr 2026 01:20:22 -0700 (PDT)"],"To":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org","Cc":"Akeem G Abodunrin ,\n Jesse Brandeburg ,\n intel-wired-lan@lists.osuosl.org, aleksandr.loktionov@intel.com,\n kohei@enjuk.jp, Paul Menzel ","Date":"Tue, 28 Apr 2026 16:17:33 +0800","Message-ID":"<20260428081733.1615755-1-aaron.ma@canonical.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=canonical.com; s=20251003; t=1777364424;\n bh=FjJThp4I5WkrMZHH23Stv5s45vttZoJtLgvhqAh471A=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=jJMD9yumR5zEv0jkcLgxZSvMXOnHBOX+drLp44ak0Q6UVrOklQkqU8TMKxdZ5VaLK\n UkfzpS0wQXy0vNuQCGaZBDFlOOBojBHP9ddBv8hXjj+0v7odwPoSjn1Qa2T4L5vE0G\n RDu1ObhTqUfWx5erDkpgtBxsK7fnnmG9HMdpk9VD53yFLhPQPeHlJ8yHjgCPqUrQ2q\n 1ZX6GzVSTn60vZyN3lXLrih6XmHy/yT16fJueNWYHp0TamqWHAG4y4C24hVvzn9dKP\n A/RcfT/19lQDUrtM6NjU0CMkgWh79CIrxjtN0L5FYMQA0A/9xClOr9WJtip3xLGkAY\n q6u/EKSWzjpxGj/+CsLdPsE/cg6oXxPANhNlvb7aO+wRgiL88wN6vJEqjAJPhO5t5U\n bBTrwaUgpl+VQOa13YYjWKpRqyjoSZSUtCQapVzE5/gAISKLrzLWbzklcCBS4FREcE\n LTEZx1TQY7QEciBjG5sRk6Y8sP+DG7dvGTBBTXBvQVqmTjhgDAVCL/0XVXWosOLyza\n gn8JNV8yvUH83CGosu4iwfVn4rxpl4GmoO1tYgvLvvO0n7d1JneHjX1/y/M0/vkL5G\n LLAw06ynofY8NA8y3sOw5R6XYHz3J3fBZ2mp5qB8HxrbHBupbwV9NvYFQAaS+Va6YQ\n w9S/sM6veChkpZEqw4ZBM/4o=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=canonical.com","smtp4.osuosl.org;\n dkim=pass (4096-bit key,\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=jJMD9yum"],"Subject":"[Intel-wired-lan] [PATCH v3] ice: wait for reset completion in\n ice_resume()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Ma via Intel-wired-lan ","Reply-To":"Aaron Ma ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ice_resume() schedules an asynchronous PF reset and returns\nimmediately. The reset runs later in ice_service_task(). If\nuserspace tries to bring up the net device before the reset\nfinishes, ice_open() fails with -EBUSY:\n\n ice_resume()\n ice_schedule_reset() # sets ICE_PFR_REQ, returns\n ...\n ice_open()\n ice_is_reset_in_progress() # ICE_PFR_REQ still set, -EBUSY\n ...\n ice_service_task()\n ice_do_reset()\n ice_rebuild() # clears ICE_PFR_REQ, too late\n\nReproduced on E800 series NICs during suspend/resume with irdma\nenabled, where the aux device probe widens the race window.\n\n ice 0000:81:00.0: can't open net device while reset is in progress\n\nAdd a best-effort wait (10s timeout) for the reset to complete\nbefore returning from ice_resume().\n\nFixes: 769c500dcc1e (\"ice: Add advanced power mgmt for WoL\")\nCc: stable@vger.kernel.org\nReviewed-by: Kohei Enju \nReviewed-by: Aleksandr Loktionov \nReviewed-by: Przemek Kitszel \nSigned-off-by: Aaron Ma \n---\nv3: add error message to commit message for searchability, mention\n timeout in dev_err (Paul Menzel)\nv2: reword comment to clarify best-effort semantics (Kohei Enju)\nv1: https://lore.kernel.org/intel-wired-lan/20260402024220.210466-1-aaron.ma@canonical.com/\n\n drivers/net/ethernet/intel/ice/ice_main.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 5f92377d4dfc2..260cbd0d9ad90 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5635,6 +5635,16 @@ static int ice_resume(struct device *dev)\n \t/* Restart the service task */\n \tmod_timer(&pf->serv_tmr, round_jiffies(jiffies + pf->serv_tmr_period));\n \n+\t/* Best-effort wait for the scheduled reset to finish so that the\n+\t * device is operational before returning. Without this, userspace\n+\t * (e.g. NetworkManager) may try to open the net device while the\n+\t * asynchronous reset is still in progress, hitting -EBUSY.\n+\t */\n+\tret = ice_wait_for_reset(pf, 10 * HZ);\n+\tif (ret)\n+\t\tdev_err(dev, \"Wait for reset timed out (10s) during resume: %d\\n\",\n+\t\t\tret);\n+\n \treturn 0;\n }\n \n","prefixes":["v3"]}